summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2019-11-20Remove comphelper::OUStringLiteralListStephan Bergmann1-12/+15
...that had been introduced with 51eb969cb77f8b54681033f4959b15ce32116b56 "Replace comphelper::ServiceInfoHelper::addToSequence" and obsoleted by <https://gerrit.libreoffice.org/#/c/83291/> "loplugin:redundantfcast: Don't warn about cast from braced-init-list" Change-Id: Ic5bb63cf4f528285587f46437a27bafbb05a07ac Reviewed-on: https://gerrit.libreoffice.org/83315 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-20loplugin:unusedmethodsNoel Grandin3-34/+0
Change-Id: Id5f7a9c34d1d159dd0f930a4ce66871bdd3796c1 Reviewed-on: https://gerrit.libreoffice.org/83305 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-20svx: add rendering for semi-transparent shape textMiklos Vajna3-1/+129
The color's alpha is normally lost when we roundtrip SvxColorItem's tools Color via TextSimplePortionPrimitive2D's basegfx::BColor. One way would be to add an extra transparency member to the primitive, like BackgroundColorPrimitive2D does that. However, a much easier way is to go via UnifiedTransparencePrimitive2D, that way we handle transparency in drawinglayer::impBufferDevice::paint(), rather than platform-specific code like CairoTextRender::DrawTextLayout() in the Linux case. Change-Id: Ie7aebe77ad9ac776dd27fc50538a5045200c8010 Reviewed-on: https://gerrit.libreoffice.org/83307 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-20PendingOverflowCheck in TextChain is unusedNoel Grandin2-18/+0
Change-Id: I575865d79fc279ec017b6af461003f77e9c6073c Reviewed-on: https://gerrit.libreoffice.org/83258 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-20loplugin:unusedmethodsNoel Grandin5-18/+0
Remove a filtering step in the python script that was hiding some results Change-Id: Id94268f150902405ab197c077f18aaedf98845fc Reviewed-on: https://gerrit.libreoffice.org/83256 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-20expand out some macrosNoel Grandin1-7/+75
Change-Id: I5a2f6068ae80b9491af7f633564dd49358b0d3d1 Reviewed-on: https://gerrit.libreoffice.org/83257 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-19LinkWarnDialog "ask" checkbox should be aligned with contentCaolán McNamara1-1/+1
there is a special argument to MessageDialogController to acheive that Change-Id: I0990cdc1f07479c23184e9b70914e611708dbd96 Reviewed-on: https://gerrit.libreoffice.org/83177 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18rhbz#1773525 wrong elements removed from saved entries when limit hitCaolán McNamara1-7/+7
Change-Id: Iaf8a012ffe927cbf38789e97b469d899e7cbf87b Reviewed-on: https://gerrit.libreoffice.org/83094 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18rhbz#1773525 reducing the amount of saved search/replace entries didn't workCaolán McNamara1-3/+6
Change-Id: I1512ef507130718859271079e603a95cf2105c58 Reviewed-on: https://gerrit.libreoffice.org/83088 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18cid#1421150 Useless callCaolán McNamara1-0/+1
add annotation Change-Id: I6f5eabf945f81cfb54ca3afb51231600ac30d9d2 Reviewed-on: https://gerrit.libreoffice.org/83065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18convert AccessibilityFlowTo to scoped enumNoel Grandin1-4/+4
and drop the unused FORSPELLCHECKFLOWTO Change-Id: I128e84d386c10d001aa63f93b4b6dcb7238a1242 Reviewed-on: https://gerrit.libreoffice.org/83060 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-18use FasterParser for SvxXMLXTableImport::loadNoel Grandin1-6/+2
the SvXMLImport superclass of XMLVersionListImport already constructs a parser, so we can just use that one Change-Id: I28402467f63e166a2c5ffc3bf0c851de81ba2108 Reviewed-on: https://gerrit.libreoffice.org/83061 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-18cid#1430094 Arguments in wrong orderCaolán McNamara1-0/+1
add an annotation here Change-Id: If28f6494e80df0ea38036196ed152e9dee29339f Reviewed-on: https://gerrit.libreoffice.org/83027 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-18loplugin:singlevalfieldsNoel Grandin1-17/+3
Change-Id: I0bb32ad7351f0e4cfbdc872ed0e81b8157ecc4cb Reviewed-on: https://gerrit.libreoffice.org/83056 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-17ofz#12553 Timeout, cut out slow uninteresting path for fuzzingCaolán McNamara1-0/+3
Change-Id: Iaaf940e48a54e9578c747e57f2f328c36e4a119b Reviewed-on: https://gerrit.libreoffice.org/83002 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-17Extend loplugin:external to warn about enumsStephan Bergmann7-0/+27
To mitigate the dangers of silently breaking ADL when moving enums into unnamed namespaces (see the commit message of 206b5b2661be37efdff3c6aedb6f248c4636be79 "New loplugin:external"), note all functions that are affected. (The plan is to extend loplugin:external further to also warn about classes and class templates, and the code to identify affected functions already takes that into account, so some parts of that code are not actually relevant for enums.) But it appears that none of the functions that are actually affected by the changes in this commit relied on being found through ADL, so no adaptions were necessary for them. (clang::DeclContext::collectAllContexts is non-const, which recursively means that External's Visit... functions must take non-const Decl*. Which required compilerplugins/clang/sharedvisitor/analyzer.cxx to be generalized to support such Visit... functions with non-const Decl* parameters.) Change-Id: Ia215291402bf850d43defdab3cff4db5b270d1bd Reviewed-on: https://gerrit.libreoffice.org/83001 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-16Replace comphelper::ServiceInfoHelper::addToSequenceMike Kaganski1-24/+25
Change-Id: I325e16fdf9bbbc6f2ba2d06c417da5eeb0d48023 Reviewed-on: https://gerrit.libreoffice.org/82975 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-16Simplify sequences initializationMike Kaganski1-194/+60
Change-Id: Ib8ca198762317b49d35e51d2d31e1cac7ca53921 Reviewed-on: https://gerrit.libreoffice.org/82971 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-15Log exceptionStephan Bergmann1-0/+2
Change-Id: Icde4e8a6598eb2d4aca7b67d96876bf0ecf017ab Reviewed-on: https://gerrit.libreoffice.org/82753 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-15tdf#128737 svx: fix off-by-one in SdrObjList::sort()Michael Stahl1-3/+19
Increment if the previous one was a text-box, not the current one. Also add some consistency checks while at it. (regression from a8b1699ca9c7e8c43eff79467451fd1fcb4fde9b or its follow-ups) Change-Id: Iab79e884f4f9cfa358630681495848f4f894506b Reviewed-on: https://gerrit.libreoffice.org/82724 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14tdf#128104 Input Engine events are delivered via CommandCaolán McNamara1-0/+6
so editengine needs to get those events too. Change-Id: I528065ef804f0a2dfa98e49034c86e9483bade2d Reviewed-on: https://gerrit.libreoffice.org/82718 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-14New loplugin:consttoboolStephan Bergmann1-1/+1
...to: "Find implicit conversions from non-'bool' constants (e.g., 'sal_False') to 'bool'". Due to how FALSE is defined as just #define FALSE (0) (i.e., a literal of type 'int') but TRUE is defined as #define TRUE (!FALSE) (i.e., an implicit conversion from 'int' to 'bool') in GLib (see the comment in ConstToBool::VisitImplicitCastExpr), we get more warnings about uses of 'TRUE' than of 'FALSE'. For example, in libreofficekit/source/gtk/lokdocview.cxx there is a warning about the 'TRUE' in g_main_context_iteration(nullptr, TRUE); but not about the 'FALSE' in g_main_context_iteration(nullptr, FALSE); (where the parameter of 'g_main_context_iteration' is of type 'gboolean'). Lets live with that asymmetry for now... (Besides the issues addressed directly in this commit, it also found the two bogus asserts at 7e09d08807b5ba2fd8b9831557752a415bdad562 "Fix useless assert(true) (which would never fire)" and 122a0be8ae480473bd1d7f35e197a2529f4621e3 "Fix useless assert(true) (which would never fire)", plus 5f0d6df7f57ae281fe161e61c7f25d67453fddd2 "Use two-argument form of static_assert".) Change-Id: Id77322de9f94b85a7b65608a03e0e9865d14467b Reviewed-on: https://gerrit.libreoffice.org/82667 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-14jsdialogs: send .uno:FillShadowTransparency updatesSzymon Kłos1-0/+14
Change-Id: Id74a0cf697faf796f68f5c350941e354494a6e3b Reviewed-on: https://gerrit.libreoffice.org/82607 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 5adc79f54507bb7d191589a0895e491c95e63fe7) Reviewed-on: https://gerrit.libreoffice.org/82614 Tested-by: Jenkins
2019-11-13jsdialogs: send .uno:FillTransparence updatesSzymon Kłos1-0/+14
Change-Id: I9951429d00c1c50d6ef3b1a703b266be6d72de9a Reviewed-on: https://gerrit.libreoffice.org/82586 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 06592c3c818f41b73ed0d8fa677cf7475c7cae5a) Reviewed-on: https://gerrit.libreoffice.org/82602 Tested-by: Jenkins
2019-11-13jsdialogs: send .uno:LineTransparence updatesSzymon Kłos1-0/+14
Change-Id: Ib6a2f5fd85e3e8c2cc8eb96c4b75f2357b669388 Reviewed-on: https://gerrit.libreoffice.org/82585 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-13external: update pdfium to 3963Miklos Vajna1-2/+2
Also simplify visibility.patch.1. Change-Id: I8b4ed78b314a1a1f7d31467f782877f056429cc2 Reviewed-on: https://gerrit.libreoffice.org/82548 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-12use std::move when popping stuff off stacksNoel Grandin1-6/+6
Change-Id: I6ba0ee8afee1a9579045643cd0118cf19599d5b9 Reviewed-on: https://gerrit.libreoffice.org/82497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-12tdf#128651 SdrObjCustomShape::NbcSetSnapRect needs logic rectRegina Henschel1-2/+12
SdrObjCustomShape::NbcSetSnapRect needs a logic rect in its parameter. A general change to snap rect as input in NbcSetSnapRect is not possible, if the transformation has to be kept. Therefore callers need to be adapted. This is done her for SdrUndoAttrObj. The error was that for a transformed custom shape with text, undo and redo had generated a wrong size of the shape. A least the following actions were affected: extrusion on/off, shadow on/off, and changes in line or fill properties. The unit test uses extrusion on. Change-Id: I8b6990d3d57d25f15f18e8690fc49dbe5e2a2728 Reviewed-on: https://gerrit.libreoffice.org/82367 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-11-12SvxOverlineItem probably should be SvxTextLineItem hereCaolán McNamara1-1/+1
Change-Id: I6d8a40f38a827c1f7644d3c9d6a3cad4481b5e7c Reviewed-on: https://gerrit.libreoffice.org/82456 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-11jsdialogs: send .uno:LineWidth updatesSzymon Kłos1-0/+13
Change-Id: I83856625d17910e5b9165c7a2ddae8b219650c8c Reviewed-on: https://gerrit.libreoffice.org/82455 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-11jsdialogs: send .uno:FillColor & XLineColor status updatesSzymon Kłos1-0/+42
Reviewed-on: https://gerrit.libreoffice.org/82307 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit c28ea22c5198c1162fc5a535d35b407762b8a865) Change-Id: I665ca45293fb3e98a7940e24c1f14a5963b8d073 Reviewed-on: https://gerrit.libreoffice.org/82309 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-09Add some info to the IllegalArgumentException in SvxShapeMuhammet Kara1-1/+6
Change-Id: I31253a0410299ec2f7fbeb8bb981bdc97c66906c Reviewed-on: https://gerrit.libreoffice.org/82351 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-08tdf#128413 SetSnapRect of custom shapes expects logic rectRegina Henschel3-2/+32
SdrObjCustomShape has its own version of SetSnapRect. This expects a logic rectangle in its input parameter. That was not considered in method SetVerticalWriting(). The result was, that for rotated or sheared shapes, which has text, setting tb-rl writing mode changed size and position. Change-Id: Idefd75cf25fd9ff4b9088ee494c65d5e6c5d12c8 Reviewed-on: https://gerrit.libreoffice.org/82233 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-11-08jsdialog: consume .uno:LineWidth double valueSzymon Kłos1-1/+1
Change-Id: Iaf09dd11ae4fd6b3d9ebeabac790f0cfe73fec17 Reviewed-on: https://gerrit.libreoffice.org/82226 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82234 Tested-by: Jenkins
2019-11-08tdf#42949 Fix IWYU warning in include/svx/svdotable.hxxGabor Kelemen2-0/+3
The boost/property_tree/json_parser.hpp added in commit 0285492a45e9cc19c26e14dcdf297bcc491da4d2 is somewhat expensive. Replacing it with forward declaration header - similar to commit fb1b461208e7a2760fa1c018db08606a9b3e435d shaves off about 80Mb of includebloat Change-Id: I5055834b691718eec2a5ebbfc4f1cffbdea96aae Reviewed-on: https://gerrit.libreoffice.org/81972 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-07lok: disable text spacing for now.Michael Meeks2-1/+12
Change-Id: I87229ab2bc1b72987d43ce685a03627111951ce3 Reviewed-on: https://gerrit.libreoffice.org/82178 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-06loplugin:unusedvariablecheck tweak to find more stuffNoel Grandin5-10/+2
but leave the tweak commented out, since it generates false positives Change-Id: Iaf3f92414d2618f8780561f98765e33e282afe0c Reviewed-on: https://gerrit.libreoffice.org/82121 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06loplugin:indentation find broken if statementsNoel Grandin1-1/+1
so I don't read the "then" block as being a sequential statements Change-Id: Ib2004acd3518bd4ebd2246f02a26c2c0a8bbab4c Reviewed-on: https://gerrit.libreoffice.org/82069 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-05jsdialogs: .uno:ChartBackColor with string argumentSzymon Kłos1-1/+1
Change-Id: I2f28a0ba957548b020eacf3d630dccef6ebbf5ed Reviewed-on: https://gerrit.libreoffice.org/82057 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-05jsdialogs: .uno:Color with string argumentSzymon Kłos1-1/+1
Change-Id: Ifdc95ff8c6a71340de3ed66cf58bc937e3730810 Reviewed-on: https://gerrit.libreoffice.org/82038 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-04tdf#121963 apply GridOffset in isPrimitiveVisibleArmin Le Grand1-1/+25
Need to take evtl. GridOffset into account for Controls in ViewObjectContactOfUnoControl::isPrimitiveVisible to get same coordinates inside adjustControlGeometry_throw Change-Id: Id6f0d1c7a4de4ee5908b50ee1a2217a0b078ecf5 Reviewed-on: https://gerrit.libreoffice.org/82031 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2019-11-03make some classes module-privateNoel Grandin1-3/+3
improve the script, but it still generates some false positives Change-Id: If8ee1cba8c04ac0be11f73220149e6de15f24f44 Reviewed-on: https://gerrit.libreoffice.org/81929 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-03loplugin:stringaddNoel Grandin8-33/+30
tweak the plugin to be more permissive, then validate by hand afterwards Change-Id: I40c5c911fe6ff7e45baaca372abf7dac211d9654 Reviewed-on: https://gerrit.libreoffice.org/81942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-02New loplugin:conditionalstringStephan Bergmann1-1/+1
Change-Id: I2eab990c15f845b44a3b598571aca361dadf9ff3 Reviewed-on: https://gerrit.libreoffice.org/81946 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-01tdf#126966: Use larger buttons for the colours in the sidebar on iOS - 2Marco Cecchetti1-2/+14
Attempt to merge this with Noel's re-work of the color picker. Change-Id: I9687546889bc20ef95a50aeafbc6f40e939d57a9 Reviewed-on: https://gerrit.libreoffice.org/81755 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/81900 Tested-by: Jenkins
2019-11-01crashtesting: out of bounds on importing tdf90224-2.odtCaolán McNamara1-1/+1
Change-Id: I5697cefd0859f007023fcd356d69db0e2176d67f Reviewed-on: https://gerrit.libreoffice.org/81850 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-11-01Bin code that has been commented-out for ten years.Tor Lillqvist1-6/+0
Change-Id: I315e22ce296418799b6f51618cb6276c461b537b Reviewed-on: https://gerrit.libreoffice.org/81873 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-11-01crashtesting: fix creating increments array in tdf106848-1.odtKatarina Behrens1-15/+11
else duplicate indexes happen and sort algorithm falls flat on its face Change-Id: I2b79e8df0f0a8e68117029630c0e026b8c202b02 Reviewed-on: https://gerrit.libreoffice.org/81775 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2019-10-31setting has-default true on an element in a GtkPopover is fatalCaolán McNamara1-6/+8
in gtk 3.24.12 at least. in ColorWindow explicitly track which button is the 'default' one for the two modes instead of using get/use-default and then just grab_focus instead of setting has-default for these popover cases Change-Id: Ia226f847f666d2356c6ea4e8c47f5db8e2535410 Reviewed-on: https://gerrit.libreoffice.org/81834 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31jsdialogs: .uno:XFillColor with string argumentSzymon Kłos1-1/+1
Change-Id: I7f078fc66cecacccd4473495f96e4e2dbfd89d14 Reviewed-on: https://gerrit.libreoffice.org/81832 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 14:02:01 +0000