summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2019-07-31tdf#126605: Do not end TextEdit when changing an attributeXisco Fauli1-2/+0
otherwise, pTextEditOutlinerView becomes nullptr in svx/source/svdraw/svdedxv.cxx:2184 Regression from e6c7a018a0cfee395ce2886d41c908a2447ef5cc Change-Id: I9d0645f637dc92b50d01682d119c0db60238e921 Reviewed-on: https://gerrit.libreoffice.org/76711 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-07-15tdf#120495 Providing self adapting height to the Area section of SidebarSumit Chauhan1-0/+18
This problem comes when we switch between different fill tabs in area sidebar and this patch solves the issue. Change-Id: I09936e600214394d26a27d26d47be3ef9942b65f Reviewed-on: https://gerrit.libreoffice.org/67577 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 347afce3a997291313fd88843ba248ccbbcb3990) Reviewed-on: https://gerrit.libreoffice.org/75483 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-07-03tdf#126180: EndTextEdit on all views before delete/cut slideXisco Fauli4-21/+40
This also reworks the fixes tdf#125824 and tdf#111522 to use EndTextEdit instead of blocking the undoing Change-Id: I73c2289a9d950465f020f684e9e736148380f5c5 Reviewed-on: https://gerrit.libreoffice.org/74989 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit e6c7a018a0cfee395ce2886d41c908a2447ef5cc) Reviewed-on: https://gerrit.libreoffice.org/75027 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-07-01tdf#125824 svx: fix crash with view1 and view2 doing texteditXisco Fauli1-1/+1
Similar to 3a874f1c80c37e8b35666e1d73161ff762eb7e4c Change-Id: I51bffa4d33e82bb90b8a42787f55c12746bcd8c2 Reviewed-on: https://gerrit.libreoffice.org/74931 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 091f573728e7951d5dc4ef138117499b7480885f) Reviewed-on: https://gerrit.libreoffice.org/74948 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-28tdf#126137: Do not dereference non-existing ObjectXisco Fauli1-1/+1
Regression from dfefe448c41921f2f1e54d3f69b8b9e89031d055 Use same logic as in c28ec6d9fbb21b363102faac0171de2754ea5d75 Change-Id: Ia489eb61873d38c31729fedb853b11570e562123 Reviewed-on: https://gerrit.libreoffice.org/74811 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit b653f21313f3b8ff9da99897e3a0c2df4a685b60) Reviewed-on: https://gerrit.libreoffice.org/74826 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-23Resolves: tdf#126039 erase old content before drawing new contentCaolán McNamara1-0/+3
Change-Id: I0006467f5c172b6a0cb8b9bc4c9a0181fd57a8ac Reviewed-on: https://gerrit.libreoffice.org/74584 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-22weld SpellDialogCaolán McNamara3-9/+9
a) use EditEngine instead of TextEngine as the former can be hosted in a foreign widget b) use a SfxGrabBagItem to hold the custom spellchecking info inside the EditEngine c) in longer paragraphs the current word is now auto-scrolled into view d) rename Invalidate to InvalidateDialog Change-Id: Ic6db019c32cdfd5f354c58ee7394fdaa040b86e1 Reviewed-on: https://gerrit.libreoffice.org/74535 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-19tdf#125782 use correct 'current point' for quadraticcurvetoRegina Henschel3-17/+31
Use the same way to get the 'current point' as in command arcangleto. The error was visible in shape teardrop. Change-Id: Ie7af2b9111150bae7e3ea492eeb439a0cc2bfe7c Reviewed-on: https://gerrit.libreoffice.org/73723 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit 39599fc689364b70cf83e834a5742cc2181b13b0) Reviewed-on: https://gerrit.libreoffice.org/74253 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-18tdf#120170 Prevent escape key press focus to documentJim Raykowski2-3/+8
...from style, fontname, and fontsize comboboxes used in sidebar tool boxes when sidebar is undocked Windows build does not show this bug but Linux does for SAL_USE_VCLPLUGIN's gen, gtk, and gtk3. This patch checks the combobox parent object type for type sidebar tool box and if so skips the release focus call that sets focus to the frames container window which incorrectly sets focus to the document for Linux build. Probably a lower level fix for this but I'm not at that level yet :-) Change-Id: Ie33ea4238f7e8715fbd0389efd9185598a528ced Reviewed-on: https://gerrit.libreoffice.org/72970 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit c81055eb075efffa9cd123913a684ac3258903d5) Reviewed-on: https://gerrit.libreoffice.org/74250 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-15remove some unused includesCaolán McNamara1-2/+0
Change-Id: I1a3512fd7fd50379ecd25389a894c2a3aadb7edb Reviewed-on: https://gerrit.libreoffice.org/74065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-13Resolves tdf#115858: More button should move the focus to 'Styles' windowMuhammet Kara1-1/+1
Change-Id: I71c834733ff0f3d4b89ecaeecb12631609e84c1d Reviewed-on: https://gerrit.libreoffice.org/73872 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> (cherry picked from commit a025132839b19ba952558b9dbec454c8a34c6489) Reviewed-on: https://gerrit.libreoffice.org/73895 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-06-10Related: tdf#111522 svx: fix crash with view1 doing textedit and resize/rotateMiklos Vajna2-13/+13
The two actually affected functions are SdrEditView::RotateMarkedObj() and SdrDragObjOwn::EndSdrDrag(), but it looks like the other functions in SdrEditView are safe to be changed the same way. I expect IsUndoEnabled() can't be changed, though: that would mean there would be no undo for the text edit itself, either. If other actions still crash, the pattern is the same: put a breakpoint on the SdrUndoAction constructor and see the backtrace to find the function that calls IsUndoEnabled() without calling CanDoSdrUndo() at the same time. Change-Id: If9324e311ec6e9f68a951559e903e14bb72ea31c Reviewed-on: https://gerrit.libreoffice.org/73669 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 9870ff897f088563426bee9567dd9cb722c2b929) Reviewed-on: https://gerrit.libreoffice.org/73748 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-06-08weld View3DDialogCaolán McNamara2-0/+1136
Change-Id: Ifd689c54574c08f026f6760efb39b5f927cb2625 Reviewed-on: https://gerrit.libreoffice.org/73706 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-06tdf#111522 svx: fix crash with view1 doing text edit and view2 doing sdr undoMiklos Vajna2-2/+18
If one view has an active text edit, then current code doesn't handle manipulating the undo text outside the text edit, so avoid problems by simply not adding an undo action to the undo stack for shape creation or move. Other actions might want to do the same in the future: check for CanDoSdrUndo() before calling SdrUndoFactory member functions. [ Found no existing test suite similar to CppunitTest_sw_uiwriter, so added one. ] (cherry picked from commit 3a874f1c80c37e8b35666e1d73161ff762eb7e4c) Change-Id: I3a364bf4fe6f9b0c13aa07283681b1045368cf7a Reviewed-on: https://gerrit.libreoffice.org/73594 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-05tdf#125062: distort hairline borders only if selection is usedXisco Fauli1-31/+35
Regression from 046df0a876b3d948bb1e14443c00c180bc8cccaa Use the fix for tdf#105998 only when 'selection' option is checked in the save dialog Change-Id: I8c4127c780736408e905ead48e0d3ee6ae149197 Reviewed-on: https://gerrit.libreoffice.org/73391 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 6c31c2b01dd32cc7ba1230f2c4a98b8f7def219b) Reviewed-on: https://gerrit.libreoffice.org/73555 Tested-by: Jenkins
2019-06-04Resolves tdf#125333 - Crash with FindReplaceRememberedSearches=0heiko tietze1-0/+2
Zero remembered searches crash the app when no result is found minimum set to 1 Change-Id: Ib2b4b195d018f0f11238699458066f4d128f8997 Reviewed-on: https://gerrit.libreoffice.org/72459 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> (cherry picked from commit def76a088dea12dfd9d9b796e975e742cbe44ce1) Reviewed-on: https://gerrit.libreoffice.org/73431
2019-06-03Resolves: tdf#125589 we are initially unsortedCaolán McNamara1-0/+7
so turn on sorting on first sort request Change-Id: I897f64c0695be8cca6d93e234a7d7c4718c94f78 Reviewed-on: https://gerrit.libreoffice.org/73345 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-02drop some unneeded includesCaolán McNamara1-2/+0
Change-Id: I13019ae1b991b5910c50e760a8a825bcf50509d2 Reviewed-on: https://gerrit.libreoffice.org/73336 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-02move SvxStandardDialog to last consumerCaolán McNamara2-37/+0
Change-Id: I02638b5a1a3c7a27c19320fedd291bbcb17bb9dc Reviewed-on: https://gerrit.libreoffice.org/73324 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-31drop unneeded includesCaolán McNamara1-0/+1
Change-Id: Ie0f52bb1d6866075d0b664bfc3ddc47c02e4f81b Reviewed-on: https://gerrit.libreoffice.org/73169 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-28drop some unneeded includesCaolán McNamara1-4/+1
Change-Id: I42b2ccbb4484ab2acb8208ad88c6f22e4af09f7d Reviewed-on: https://gerrit.libreoffice.org/73114 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-28tdf#120905 Remove temporary uno command.Gülşah Köse1-17/+0
Change-Id: Id12838cf08a2e5b74b53bd0036804b886b41098f Reviewed-on: https://gerrit.libreoffice.org/73041 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-05-28Fix domain in ui files (cui, dbaccess, svx)Julien Nabet1-1/+1
Change-Id: I6c09bf2af4b902fdc215ec31bf2dad490e41384e Reviewed-on: https://gerrit.libreoffice.org/73066 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-27tdf#42949 Fix IWYU warnings in include/svx/[sS][a-h]*Gabor Kelemen7-0/+8
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I84fc75e06e61e5391aef6e237c36daad95dedb84 Reviewed-on: https://gerrit.libreoffice.org/72550 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-27drop some unneeded includesCaolán McNamara2-6/+0
Change-Id: Icf19ae9811f6f4ee315869a7edd50e94dce4e6ae Reviewed-on: https://gerrit.libreoffice.org/73004 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-25tdf#125181 Update comment in unit test for added shapesRegina Henschel1-1/+1
I have recently added shapes star24 and star32 to the unit test, but forgotten to update the comment in the test accordingly. Change-Id: I712c652100cadedc06a0b16c8dd27dc078cdbbeb Reviewed-on: https://gerrit.libreoffice.org/72954 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-05-24Add a parameter to insert a text box directly.Jan Holesovsky1-1/+1
This is useful for the Online, where we want to insert the text box directly into the document so that it is visible right away. Change-Id: I09ab2efba758aac077fa37ddfd20b1486b35b3ef Reviewed-on: https://gerrit.libreoffice.org/72912 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-05-24Wrong downcast from svx::a11y::AccFrameSelectorChildStephan Bergmann2-17/+15
...to svx::a11y::AccFrameSelector (which are unrelated final classes). UBSan Calc "Format - Cells... - Borders - Line Arrangement - User-defined:" and clicking into the top-right corner of the widget caused > svx/source/dialog/frmsel.cxx:972:50: runtime error: downcast of address 0x60f0003dfa80 which does not point to an object of type 'a11y::AccFrameSelector' > 0x60f0003dfa80: note: object is of type 'svx::a11y::AccFrameSelectorChild' > e1 03 80 0d 90 4f c2 88 ce 7f 00 00 02 00 00 00 be be be be 00 00 00 00 00 00 00 00 00 00 00 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'svx::a11y::AccFrameSelectorChild' > #0 in svx::FrameSelector::SelectBorder(svx::FrameBorderType) at svx/source/dialog/frmsel.cxx:972:50 > #1 in svx::FrameSelector::MouseButtonDown(MouseEvent const&) at svx/source/dialog/frmsel.cxx:1114:21 [...] The code was like that ever since 60f11adb950e4f9645cc9ecb0f5af8235cc97366 "Integrate branch of IAccessible2", which had presumably confused AccFrameSelector and AccFrameSelectorChild here (while there'd apparently not been a deeper need for the static_casts anyway). Change-Id: I1f52629143dcfc84e57e9539a428fb0f51fdc72e Reviewed-on: https://gerrit.libreoffice.org/72910 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-24tdf#125445 Add methods for handles in gear6 and gear9 shapesRegina Henschel1-70/+115
The shapes 'gear6' and 'gear9' need very special methods to calculate the adjustment value from the handle position. Inserting these methods shifts the other cases one level down, therefore the patch looks large. The gear6 and gear9 shapes do not fit to the common test pattern, so they are not included in the unit test. Change-Id: I809e92d87118303332be87512062c431f235d859 Reviewed-on: https://gerrit.libreoffice.org/72796 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-05-23rename SvxGraphCtrl back to GraphCtrlCaolán McNamara10-56/+55
Change-Id: I340b1695588bea0f1ce15685731c522907fdb7ee Reviewed-on: https://gerrit.libreoffice.org/72806 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-23rename SvxGraphCtrlView back to GraphCtrlViewCaolán McNamara1-5/+5
Change-Id: I658773f4fc0409a73de56301f5457fa1fb9e4a28 Reviewed-on: https://gerrit.libreoffice.org/72805 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-23rename SvxGraphCtrlUserCall back to GraphCtrlUserCallCaolán McNamara1-2/+2
Change-Id: I9c348e34a07ab269217f35633cb3a54ea4f7cf68 Reviewed-on: https://gerrit.libreoffice.org/72804 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-23remove now unused GraphCtrlCaolán McNamara1-702/+0
Change-Id: I6d4aca59d5f9e24521876c36853b663b65a2d200 Reviewed-on: https://gerrit.libreoffice.org/72803 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-23weld FloatingContourCaolán McNamara7-577/+647
Change-Id: I055f01d2ce462009986801d4a603b0b72b1a621c Reviewed-on: https://gerrit.libreoffice.org/72787 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-23Add new customize and position merged dialogGülşah Köse1-0/+17
Change-Id: I898fb0830a9f53da4a7917cb5900f082e3a9d6b7 Reviewed-on: https://gerrit.libreoffice.org/71944 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-22New loplugin:dataStephan Bergmann5-31/+31
...following up on 1453c2c8f13bac64ecd1981af7cebf1c421808ac "prefer vector::data to &vector[0]" Change-Id: I7c113747d92d144a521d49b89384dd8bf1215c01 Reviewed-on: https://gerrit.libreoffice.org/72765 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-22tdf#42949 Fix IWYU warnings in include/svx/[h-r]*Gabor Kelemen27-1/+38
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib7e1d0f7483aa8b5cab320278714f2d5f36fdbd9 Reviewed-on: https://gerrit.libreoffice.org/72534 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-21turn off OutputToWindow during dtorCaolán McNamara1-0/+12
Change-Id: I46d45c2487b7d4ac99d48ce0fc49bed120291f3c Reviewed-on: https://gerrit.libreoffice.org/72668 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-21Fix typoAndrea Gelmini1-1/+1
Change-Id: I2279c3e3bb8f0e3d8ac0fe02b83d7f659fc00a02 Reviewed-on: https://gerrit.libreoffice.org/72622 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-21tdf#119775 Make keyboard use work for TableWindow popup windowJim Raykowski1-6/+31
This patch restores the ability to use the keyboard for the TableWindow popup window by not including the 'More Options...' button when activated by keyboard from a toolbox. It also limits handling of key input to SPACE, RETURN, and ESCAPE key input when mouse activated. Change-Id: I306bcb844a829ca7067b8496f37cb68f35fa754d Reviewed-on: https://gerrit.libreoffice.org/71813 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-05-20tdf#125181 Add shapes star24 and star32 to unit testRegina Henschel1-0/+0
The commit 500a70ba19d9c1207fd9121531950e55a70fd940 has fixed the error in the definition of shapes star24 and star32. They can now be included in the test file for unit test of preset shape handles. Change-Id: I94f63d37a7faaec4006104127fcc0443304ae0b8 Reviewed-on: https://gerrit.libreoffice.org/72612 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-05-20split width/height to allow intercept of how width is calculatedCaolán McNamara1-5/+6
in order to possibly get width on demand Change-Id: I1e6fcb6849705f2b166821516ebe72b179e00ee7 Reviewed-on: https://gerrit.libreoffice.org/72513 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-20Resolves: tdf#125375 add mouse events to maskCaolán McNamara1-1/+2
Change-Id: Ied64222c9996f83673a65f858ca351d72483e53a Reviewed-on: https://gerrit.libreoffice.org/72586 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-20svx lok: fix crash on select all when there is no mpMarkedObj yetMiklos Vajna1-1/+2
Fixes the online.git HTTPWSTest::testRenderShapeSelectionImpress() testcase by reverting one hunk of commit 3fb298f673db169a38c1258d66ec24821386eb40 (lok: writer: svg export transformed images, 2019-03-26). This was probably meant to be a cleanup, but getting the sdr mark, followed by getting the sdr object of the mark always gives us a shape, while directly accessing mpMarkedObj does not. Change-Id: Id733ba5c6fdf6fc86a3e9f7de62b4bdcbf9b06db Reviewed-on: https://gerrit.libreoffice.org/72039 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/72566 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2019-05-20lok: chart: constrained dragging of pie segmentsMarco Cecchetti1-13/+167
The extra information for the graphic selection is now formatted according to JSON syntax so that is easier to parse. Information for allowing the client to performa constrained dragging of a pie segment is appended when needed to the graphic selection message. A polygon approximation of the pie segment in svg format is attached too to the graphic selection message. Core now is able to handle a specific msg from the client with data about the new pie segment offset computed by the client on drag end. This information is dispatched by the chart controller to a specific method: executeDispatch_LOKPieSegmentDragging. Change-Id: I42e7742508fa3a453383bf7b95e47df169f24834 Reviewed-on: https://gerrit.libreoffice.org/70568 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2019-05-20lok: chart: informing the client about selection handling propertiesMarco Cecchetti1-0/+34
We hijack the chart CID protocol (CID:/classification/ObjectID) by inserting information about selection handling properties (draggable, resizable, rotatable) btw the classification section and the ObjectID section. This new section has the form: /Draggable=?:Resizable=?:Rotatable=? where in place of '?' there is 0 or 1. The hijacking occurs at the ChartController.getSelection method which is available through the XSelectionSupplier interface. Change-Id: Iaf920fe68e59c2595000e43d3fc1f976632cef18 Reviewed-on: https://gerrit.libreoffice.org/70567 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2019-05-20lok: writer: svg export transformed imagesMarco Cecchetti1-11/+26
Change-Id: I908a6e01573c35c0641519f4995730af0b033c33 Reviewed-on: https://gerrit.libreoffice.org/70565 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2019-05-20lok: shape selection: perform the needed unit conversion in a clever wayMarco Cecchetti2-94/+9
Change-Id: I505bd41801b5fd1898a9eddc81b102f2f7ae20b5 Reviewed-on: https://gerrit.libreoffice.org/70563 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2019-05-18Resolves: tdf#125104 crash on getting text desc of numberingCaolán McNamara1-4/+27
this seems to have been wrong for a very long time, but we used to get away with it back in the .src era with presumably amusingly random strings from other parts of the ui shown in the summary of changes are of the organizer page of the dialog Change-Id: If223182170ba8519d7899f8044f01c2a12f4e391 Reviewed-on: https://gerrit.libreoffice.org/72490 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-18remove remaining '0' responsesCaolán McNamara3-3/+3
Change-Id: I3134c8dcc92b82ab2c6008b3e39443a360f576eb Reviewed-on: https://gerrit.libreoffice.org/72499 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>