Age | Commit message (Collapse) | Author | Files | Lines |
|
Squashes two related patches from master:
Don't use rtl::Reference for the global / list state, so the
ref-count reflects the number of real users.
Hold a reference during ~OpenGLContext.
Fix mis-use in:
gltf rendering, OpenGL canvas, GL transitions & GL capable (charts)
Avoid GLX operations on un-initialized contexts.
Signed-off-by: Miklos Vajna <vmiklos@collabora.co.uk>
Conflicts:
vcl/source/opengl/OpenGLContext.cxx
vcl/workben/vcldemo.cxx
canvas/source/opengl/ogl_spritedevicehelper.hxx
Change-Id: I7ea29b544d53bb80b25fa6663d39f345bf8f4e64
Reviewed-on: https://gerrit.libreoffice.org/18443
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I2b45b7cf96af7950cf097c2b6a880e9eda021184
Reviewed-on: https://gerrit.libreoffice.org/18448
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-by: László Németh <nemeth@numbertext.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ice9a860ca839d37308b5c2f2eb639852fefe1d15
(cherry picked from commit dcb0738b631c61999364bd8500f401f93bbfb84e)
Reviewed-on: https://gerrit.libreoffice.org/18240
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
|
|
Change-Id: Ied562af293a4e970b9963f566d85a79375737954
Reviewed-on: https://gerrit.libreoffice.org/18221
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
getSvxBrushItemFromSourceSet() is called once for each property of a
frame style that is set, and the "solid" fill-style is set by first
applying the BackColorRGB and then BackTransparency property. So there
is an intermediate state that has fill-style NONE but a XFillColorItem
set - don't reset the color to white in that case!
Apparently writerfilter generally relies on the current reset-to-AUTO
implementation (loads of test failures), so for now limit the fix for
when we know that a frame style is imported from ODF.
(regression from 3d399b0e45720354fc64dc3d121ee486e01eff89)
(cherry picked from commit 79fb61efb847405fa47235002b52ee8efad5e339)
tdf#92379: sw: unit test for frame style background color
(cherry picked from commit 982537d77c2db463cc053cfdcd522530a3834c9e)
Change-Id: Ia987fe586ec819a1f3cd85acdbfb03c74ca0ec2c
Reviewed-on: https://gerrit.libreoffice.org/18037
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
As agreed in the bug report, a preview shouldn't be
themed by the OS theme.
(cherry picked from commit fa1807ad5457d10f8fa073c209a27547e8922c8c)
Conflicts:
include/svx/numvset.hxx
svx/source/dialog/svxbmpnumvalueset.cxx
Change-Id: Icdc5021c3ac614fe1d490fd513a407a81dbc169e
Reviewed-on: https://gerrit.libreoffice.org/18068
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: I9c384587c127ca077803bf8aae63d0e54eda6aaf
(cherry picked from commit be95c7430d2fd9858f41ee8e8882d987a5bbe749)
Reviewed-on: https://gerrit.libreoffice.org/18025
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
|
Change-Id: I59a07a62573b8d472d15f8594473e8e8d1077589
Reviewed-on: https://gerrit.libreoffice.org/17758
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Fixing missing characters (only characters of the basic Control font
showed by Insert special character dialog) and freezing (when
LibreOffice tried to replace hundred of characters [missing from the
chosen font] during scrolling in the insert special character dialog).
Change-Id: I8fd5bd233f16572eb2b740a8f8e7e8608c19d06f
Reviewed-on: https://gerrit.libreoffice.org/17792
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Reproduced with the gen vclplug
Change-Id: Ia8a5c73908f5af47ef55b4431b6e1e5a21609e7d
(cherry picked from commit b556f14fab25ddccbe9a54fe53450a641dbc5a49)
Reviewed-on: https://gerrit.libreoffice.org/17705
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Don't let long strings (in some languages) make it request so much space.
Change-Id: I5b2af9d7cc54d1ba772ae75971cfff27bee31a05
(cherry picked from commit d2f218f54369c6d7fb38d0b701aa86fdf5aae843)
Reviewed-on: https://gerrit.libreoffice.org/17699
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
this effectively reverts
commit c43ee00e5d2edfebfa148b310813335aab27db34
Author: Herbert Duerr <hdu@openoffice.org>
Date: Wed Aug 15 13:20:51 2001 +0000
#91025# reduce flicker in charmap dialog
in favour of the new double buffering
Paint is calling RecalculateFont which calls SelectIndex
which calls Update which calls Paint, boom
Change-Id: I69e9f53b7db09837ff08a2ce9fc6f81a52b5c794
(cherry picked from commit 79395c934771818686e488a7c2e382a00456c8a1)
Reviewed-on: https://gerrit.libreoffice.org/17674
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
The sidebar has width limit, so a panel shouldn't attempt to
resize more than that. Otherwise we'll get an endless loop.
(based on e98cf0c63d6c48ca7c1db87d7413d5c419690c76)
Change-Id: Ia36535637e3585595c673c7fc46a1a7b162b74ba
Reviewed-on: https://gerrit.libreoffice.org/17667
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I1ef697008dcd5e993c1d509fce055c5454d80f40
(cherry picked from commit 7d3fa6bae9f7a755eb2d0ca24bf1afd5f3646bb7)
Reviewed-on: https://gerrit.libreoffice.org/17668
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ieecad5f244703c4d2436e22a3ab50f719843eef4
(cherry picked from commit 68c6408b1725a8f506a8adb8c9af67a65e667f1c)
Reviewed-on: https://gerrit.libreoffice.org/17672
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Else, on any action done directly (not through the
FormControllerHelper) on the controller and raising an SQL error, this
would silently swallow the error message, and the operation would fail
without any message to the user.
E.g. when validating an insertion or modification in a grid control by
moving the cursor to a different line (as opposed to clicking the
"Save Record" button).
Change-Id: Ie569d9c826609f803f7b312c0469907155558ef2
Reviewed-on: https://gerrit.libreoffice.org/17268
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
This avoids arbitrarily switching to the first form in the document,
which would do a (premature!) save to the database of the
modifications pending in the active form. This may lead to a database
error, when the data is not in a shape to be written to the database,
e.g. when on an insertion row and not all mandatory fields have been
filled in. This then pops up an error message to the user.
Change-Id: I30bb533598ca707b892bb7155e54ce05d4ddf275
Reviewed-on: https://gerrit.libreoffice.org/17269
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
as opposed to implicitly keeping whatever unrelated string was there before.
Change-Id: Ifaf1b41e951e97f209ecb617b32ec4f7522b1d08
Reviewed-on: https://gerrit.libreoffice.org/17297
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
In particular when changing row.
1) Teach DbCellControl about "SelectedItems" as known value property.
2) Fix DbListBox::updateFromModel to actually use the SelectedItems
it reads from the model, as opposed to throwing it away.
Change-Id: I7074c13b3d271bf2362aa059378aa857682a040b
Reviewed-on: https://gerrit.libreoffice.org/17298
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
|
|
...if you call ResetPoolDefaultItem() first. Crash found by Varun Dhall.
Change-Id: I409484c172fb5843270aee2425844076a008b4df
(cherry picked from commit bcb1f81668d9b6a6d807ae32d60ccfce0b36ceb5)
Reviewed-on: https://gerrit.libreoffice.org/17320
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
SmShowSymbol handles font/fg/bg settings by itself, so make
ApplySettings noop there.
This partially reverts commit b010e4074e5d5ee3a3905f1351f04efafe937c2a
Reviewed-on: https://gerrit.libreoffice.org/17288
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 94ceda8b2fea37587424b664e17fa9ee8b01e158)
squashed commit from László Németh <laszlo.nemeth@collabora.com>
tdf#92600 fix missing font preview in character set widget
The previous fix for tdf#92600 (missing bold text in dialogs)
brought back the regression in the special character set
widget: the characters show always the default font
of the Control class instead of the chosen font, see in
the Insert->Special Character... dialog window of Writer.
Change-Id: Ib5074684ef1277d9b9b4646bd73dce4cbff3943e
2bdc2300f481dd680877f84ea2a717b9e749c64c
Reviewed-on: https://gerrit.libreoffice.org/17303
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
The new mime types were added the followings:
- eps -> image/x-eps
- wmf -> image/x-wmf
- bmp -> image/bmp
- pct -> image/x-pct
These new mime types are written in the attribute "media-type"
of each image in the file "manifest.xml"
Change-Id: I16edb625e331d3f917c6e8929df004191e317acc
Reviewed-on: https://gerrit.libreoffice.org/17123
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
(cherry picked from commit 4d84153e22bdda33b23deb4c32afcace4c1264f7)
svx: this was supposed to be "image/x-eps"
Change-Id: Ieb9d7f23a0ef1e4546c488a678dbfde085156216
(cherry picked from commit 5351f621d5eb599757af95213c4b391c0f34df2e)
Signed-off-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: If9757a5fa2bb93b56b9cf9f566972f687a4a3a45
Reviewed-on: https://gerrit.libreoffice.org/17036
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit d1046e7c3f66e5f3384ee1ef534ef28346702fc6)
refactor ensuring polygon has at least a line in it
just split that out into a standalone function, no logic
change
Change-Id: I061d5d716b3fc2a9fb6385e7fb249ce300752130
(cherry picked from commit 83b3349bb94d4c48db4da8fe5f8fdb9b19e633b9)
Reviewed-on: https://gerrit.libreoffice.org/17073
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: Icb70805969ccf55bd85fb38c03cf70c1e0b16554
(cherry picked from commit 40ade8d04380083e383d6a6e50e5c254fcde2b2f)
|
|
Change-Id: Iedb296732c0819a1d6cdc1c59b3f1718e2cd6d38
(cherry picked from commit 9a11e59e5699c5eb0854355d3dd3848bc895545c)
|
|
Change-Id: Ibf6c0cc2e6dc8fe6979632f6acb1b065984cd73f
(cherry picked from commit 78c73f42c8079ed6d37784e68da5170c86a68616)
|
|
If the Paint() is ~immediate after Invalidate() (which is the case
since the main loop has priorities), it makes no sense to
perform any kind of direct paint right after an Invalidate().
With this, we no longer hit the is_double_buffered_window() assert when
returning to editing Writer text after editing draw shape text.
Change-Id: I3b80ca08aa71d247fc0561133f907aef34de4001
(cherry picked from commit b05ff2cc713601730393123f6daa95e41df3b6ea)
|
|
When text is selected, the preview text is the first TEXT_WIDTH (80)
characters of the selection rounded up to the next word.
However when no word boundary is found, the preview text is as long
as the selection, which causes the preview to be less than usable
in some extreme cases.
This patch is to limit the preview text length when no word boundary
is found, thereby always resulting in predictable behavior.
Change-Id: I8a21638d601714db956b9b160664dfe1e5e49a4a
Reviewed-on: https://gerrit.libreoffice.org/16855
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit c3c6bf235af32781e83d4fed2867a16bfeafa659)
Signed-off-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: I43397f2b0caa31c334f87acf11fc96df2e051ad8
Reviewed-on: https://gerrit.libreoffice.org/16744
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
The original work of tdf#55430 tries to select an object under
another one on the second click, but these images are unselectable
so this fails. Red Hat has a whole new shiny bunch of templates which
have such images in their masters.
Check if the object is selectable before continuing
Change-Id: I182abaf50e8bb1084c5819dc9e1ffd8b386a9e93
(cherry picked from commit abbe4f9d64073d77c4be93b7c89c03d0651bacef)
|
|
The buffered overlay manager paints using a timer, which is problematic
if the given vcl::Window already supports double-buffering itself, so
always use direct (to the rendercontext) painting in that case.
Change-Id: I93144c02814fd511f333224ab058374c7da369f0
(cherry picked from commit 25ade7450ce41a46094d63123eabdf32bd68c918)
|
|
This reverts commit 601d7d38628bf93218fba15249c4654ae24e7396.
desktop and svx need these flags in case of OS X sandboxing
Change-Id: Ib811aa53bc2d71839961cdcea0dd4836ebdbc38c
(cherry picked from commit 57117cf52d4c91029cbabf852d1f82c386ac1d75)
Reviewed-on: https://gerrit.libreoffice.org/16572
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
This reverts commit 6c84442f99de109b585d3ba8964deb8dcf261c0f.
"tdf#87820 Images not displayed properly in Calc"
and replaces it with an alternative solution
Change-Id: Iecb560d43767f0e41e442a307eefcdcecb7589ef
(cherry picked from commit 2d196d0ee26b3840e56ec6537066a3b4a2f08691)
|
|
In the paints, we must use the size of the Window for the computations, not of
the RenderContext - the RenderContext can be much bigger than the Window in
the double-buffering case.
Fixes for example the list boxes, and many others.
Change-Id: I4c7607569f88b2d097587140858d0862e54b5ea6
Reviewed-on: https://gerrit.libreoffice.org/16421
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Change-Id: I2448787c306a8a4ba531c0560e0435fefadb4dc8
Reviewed-on: https://gerrit.libreoffice.org/16379
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
Decouple the actual window from rendercontext in UserDrawEvent.
Change-Id: Ic440c4e7f59fcffb7800c578146e8eb528cbb7b4
|
|
...near the end of SetupEntry, which appears to not be needed here
Change-Id: Ia273df8a22d26974572d8e9be8de2a27936ee496
|
|
Change-Id: I8541eb13d82d887ef589a0545d36db88e47932e7
|
|
Change-Id: Ib94c9f5eed0da67e846705f5c2c233c10583c791
(cherry picked from commit a44b770b59d322083cac6ac22cef20ce17a89e6d)
Signed-off-by: Michael Stahl <mstahl@redhat.com>
|
|
At least OutputDevice::acquire/release use a plain unguarded int and ++, --, so
apparently rely on the SolarMutex being locked whenever they are called. Fixed
those places that caused "make check" to fail for me when temporarily adding
DBG_TESTSOLARMUTEX() to OutputDevice::acquire/release. (A recurring pattern is
that a class fails to ensure the SolarMutex is locked around the destruction of
non-null VclPtr members.)
Change-Id: I77cba6f3908f2de1b516ce28f1c3c43b3f57a9c5
(cherry picked from commit 8e1ad966262932516b3368d9b5c44becb29524d4)
Signed-off-by: Michael Stahl <mstahl@redhat.com>
|
|
Addition of .uno:StyleApply , .uno:StyleUpdateByExample and .uno:StyleNewByExample uno commands to the sidebar
Change-Id: Iab6f1fb465066fce523fd376038a059189f1b842
Reviewed-on: https://gerrit.libreoffice.org/16279
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
Tested-by: Yousuf Philips <philipz85@hotmail.com>
(cherry picked from commit e436f31147c7eb75908a8750b0e4053c2efdca5b)
Reviewed-on: https://gerrit.libreoffice.org/16306
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
The items count of NumberingTypeMgr is limited by 8, but
some languages have more items, so remove that limitation.
Also fix the behavior of the 10th item. The old sidebar
popup had a "None" item, whose id was 10 (defined by
DEFAULT_NONE from include/svx/nbdtmg.hxx), and that causes
now the 10th item to behave as on/off toggle. Since we
don't have a "None" item anymore, get rid of that behavior
completely.
Change-Id: I5546ca637f9951cc093a7bbf8fda11dc35341d4e
(cherry picked from commit 71b35212265bb93b10ca35ab964a36e6b6cc552b)
|
|
Change-Id: I74d799f10d4a1d88256c683f913b8c639d2694c1
(cherry picked from commit 4331aa3cbab9ea7505e1d31ac674ee8ca5d9c314)
|
|
Change-Id: Id3cf58660bfcaf7424d027773894ce6888df788a
(cherry picked from commit ef530d397b021a9606bb3b3abe8c2290a1d94c59)
|
|
Regression from ed6b7d972bf1aee323947f22c6b5de430db4a9a5.
These buttons are implemented inside the sidebar, so just
changing command names in the ui file won't work.
Also, following the decision to use indent buttons across all
modules, there is no need for 2 separate toolboxes anymore.
Change-Id: Id9af0cd10fd0517be86b9793c187cd6508029732
Reviewed-on: https://gerrit.libreoffice.org/16199
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
(cherry picked from commit a861a234b0f5f39b06fd6180655182c167c3a94d)
|
|
This clobbers the functionality from commit:
06d731428ef6cf93c7333e8228bfb6088853b52f
make idle timers actually activate only when idle
Since now all rendering and re-sizing is done in idle handlers it
does effectively the opposite of what was intended. A better solution
would allow special-casing the processing of just rendering,
re-sizing and window management to spin for eg. progress bar
rendering.
Also add helpful debugging labels to the idle & timeouts.
Also cleanup the Idle vs. Scheduler handling.
Also ensure that starting an Idle triggers a mainloop wakeup.
Also add a unit test.
Change-Id: Ifb0756714378fdb790be599b93c7a3ac1f9209e6
|
|
Change-Id: I015306a37abeaef17830ceab0f39cb2f3a98155c
(cherry picked from commit 14aa5c58b8529f81c6ca12a18cbb77f63e27ba62)
|
|
Change-Id: Ia7281c853454e283150bba3c79aa9579363c7ca3
Signed-off-by: Jan Holesovsky <kendy@collabora.com>
|
|
It causes trouble to localiztation tools and also
makes hard to distinguish these items on the UI.
e.g. Edit -> Find & Replace -> Other options
-> Attributes.
(cherry picked from commit dd79dbedd6c7f889f5e39f146a1927d235bc8a59)
Change-Id: Ie7a17e02947200a570b5e6209c8a99d1883a6860
|
|
The fix is twofold:
1. retrieve transparency from colour in SvxBackgroundColorItem
(add QueryValue, PutValue methods, use additional memberID to
retrieve alpha channel as a bool property)
2. add CharBackTransparent bool property to Draw [text] shapes
Change-Id: I6e14b81cc82f6b4d7fdd4756ff2e4f75e9270361
|