summaryrefslogtreecommitdiff
path: root/svx
AgeCommit message (Collapse)AuthorFilesLines
2023-06-28tdf#155863 sd: fix resizing of cropped images to original sizeTibor Nagy1-13/+11
Resizing with the function "Original Size" (e.g. in the context menu) resulted distortion in case of cropped images, if the original image and its cropping have different aspect ratios. Now zoom the cropped image to the original resolution instead of stretching it to the same size. Change-Id: I5e59f8b48dc03844a739c3eb803e3195a12d9c6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153170 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit a4e12cbfc69cfe668fa30756a3c5843e911e22b1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153342 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-27tdf#156050: Fix how misspelling line is calculated for RTL textKhaled Hosny1-2/+4
Partially revert: commit 74b6c5ea3c333de7c5e7ef8636732edadd9083f2 Author: Khaled Hosny <khaled@libreoffice.org> Date: Thu Jun 8 16:41:18 2023 +0300 tdf#151968: Fix vertical position of RTL spelling wavy line Instead of changing how fStart and fEnd are calculated, calculate them like before then swap them. This seems to be more reliable, and matches what we do in Writer. Change-Id: Ia15408881666a86151a12fcf016cc81c1568f7e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153572 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org> (cherry picked from commit 2ef138de767c312188d41a7f206234eafac3108b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153597 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-06-23tdf#151968: Fix vertical position of RTL spelling wavy lineKhaled Hosny1-2/+6
Second try. This time making sure start > end even for RTL text. This also now works for horizontal, vertical and rotated Arabic text, in Writer and Edit Engine. Change-Id: I6fe1e9dbb9c071287054200a58d4ddddee073311 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152820 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-05-31tdf#155190 svx,sw: PDF export: don't tag SwNoTextFrame as ArtifactMichael Stahl1-1/+6
The problem is that inside of the Figure tag, in SwNoTextFrame::ImplPaintPictureGraphic(), ViewContactOfSwNoTextFrame and ViewObjectContactOfSwNoTextFrame are used to create and process another primitive sequence. ViewObjectContactOfSwNoTextFrame does not have access to a SdrObject, because that was already processed by the outer layer of code that called the SwFlyFrame painting code. Avoid running the code that assumes anything without an SdrObject is an artifact by disabling PDF tags altogether in ViewObjectContactOfSwNoTextFrame. (regression from commit 81ef84648515965bf67afaced946227d0f63a71e) Change-Id: I9fabe7f7e5296f8d850448ac44865f87cd164591 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152335 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 07a0c7419d2925a9c8622461073a5d34ffc93e3e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152313 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-29tdf#155436 svx: PDF export: fix crash on SdrMediaObj without URLMichael Stahl1-1/+3
Both sw and sd don't call CreateScreen() if there is no URL. (regression from commit e84b310b59825fd572d79def98c3d21566aac603) Change-Id: I087511bb6ed41b0e39321f6ca8684f60261f01cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152282 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 8061cd765c7854667550d6aafda5832715648876) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152228 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-19svx: check SfxObjectShell::Current()Xisco Fauli1-5/+10
See https://crashreport.libreoffice.org/stats/signature/static%20void%20%60anonymous%20namespace'::SvxStyleBox_Base::Select(bool) Change-Id: I6edce9c8bad1ee087ddf884ff47439cceee3f1de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151923 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2023-05-11Resolves: tdf#154535 create the OXFormsDescriptor on-demandCaolán McNamara2-18/+28
so we don't cause an unwanted Binding to be created unless we are forced to. Change-Id: Id78cbbb72ebd4e78b82a1ba614bbcb6488d04ce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150774 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-05-04Resolves: tdf#155140 gallery right click for context menu doesn't consume eventCaolán McNamara3-6/+7
Change-Id: I13b6d62561e3d9eed47f81c4268a6a32ff108b40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151289 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-04tdf#127322 svx: add back MID_GRAPHIC_URL to SvxBrushJustin Luth1-0/+1
This fixes the problem where gallery images could not be set as page or paragraph backgrounds. This URL attribute was removed in LO 6.1 with author Tomaž Vajngerl on 2018-03-09 09:41:44 +0100 commit c7ff07b2dab639b901c80f1f62efee4dd3ad549b remove MID_GRAPHIC_URL and related mappings, implementation Most of this was restored shortly thereafter with author Tomaž Vajngerl on 2018-05-07 16:30:35 +0200 commit 7a8ed362eb163ac15a000ba1cfc74b58315800a1 (patch) [API CHANGE] revert and deprecate *BackGraphicURL add *BackGraphic However, this piece wasn't restored. Change-Id: Ia74d2562b61135f3294a7d6ebfa72cfadb4bdb5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151342 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> (cherry picked from commit 2f474d5690d0c9850ef82efa26f2f82580c09a8d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151286 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-05-03fix mistake in commit "optimise ensureGeometry"Noel Grandin1-1/+2
In commit bfe32f3e50b5406810e740ac41368f101033e766 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed Jan 12 20:51:39 2022 +0200 optimise ensureGeometry I got the return value wrong for the early exit case. I am quite surprised this did not mess up something in the drawinglayer line handling. Change-Id: I6788ef8898575c89344f25f6e66c4ae0a999f013 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151268 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 7a2435b4ae52bbbe8bd7d0fd0cf6a32ee42aac98) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151277 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-21put floating frames under managed links controlCaolán McNamara3-21/+111
like we do for sections and ole objects that link to their content individual commits in trunk are: extract a OCommonEmbeddedObject::SetInplaceActiveState for reuse no behaviour change intended Change-Id: Ia1d12aa5c9afdc1347f6d4364bc6a0b7f41ee168 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150341 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 183e34a3f8c429c0698951e24c17844e416a3825) use parent window as dialog parent it makes no odds, but is more convenient for upcoming modification Change-Id: Ibc5333b137d2da089b3b701ff615c6ddf43063d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150342 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit f93edf343658abd489bde3639d2ffaefd50c0f99) adjust IFrameObject so it could reuse mxFrame for a reload of content Change-Id: I7eec3132a23faafd9a2878215a0a117a67bc9bf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150343 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 3a727d26fd9eb6fa140bc3f5cadf3db079d42206) query getUserAllowsLinkUpdate for the case of content in a floating frame similarly to how it works for the more common "normal" embedded objects Change-Id: I83e38dfa2f84907c2de9680e91f779d34864a9ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149971 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 52aa46468531918eabfa2031dedf50377ae72cf7) add a route to get writer Floating Frame links under 'manage links' Change-Id: If90ff71d6a96342574799312f764badaf97980eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150349 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 8b8a2844addbd262befb1a2d193dfb590dfa20be) allow SvxOle2Shape::resetModifiedState to survive having no SdrObject Change-Id: Iea059262c124e3f44249e49b4189732310d28156 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150538 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 02379929bd0e1d1676635f0ca1920422702ebb7c) create the FloatingFrameShape in a separate step to inserting it this is derived from the path taken by the AddShape(const OUString&) function for this case. No change in behavior is intended. Change-Id: Id09ae0c65a55a37743ad7c184070fb8dd97d8a7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150526 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit bafec47847a0b9697b3bbe9358e53f8118af3024) add a route to get calc Floating Frame links under 'manage links' much harder than writer because the organization and ordering of properties and object activation etc is different. This ended up ugly, but functions. We set FrameURL before AddShape, we have to do it again later because it gets cleared when the SdrOle2Obj is attached to the XShape. But we want FrameURL to exist when AddShape triggers SetPersistName which itself triggers SdrOle2Obj::CheckFileLink_Impl and at that point we want to know what URL will end up being used. So bodge this by setting FrameURL to the temp pre-SdrOle2Obj attached properties and we can smuggle it eventually into SdrOle2Obj::SetPersistName at the right point after PersistName is set but before SdrOle2Obj::CheckFileLink_Impl is called in order to inform the link manager that this is an IFrame that links to a URL Change-Id: I67fc199fef9e67fa12ca7873f0fe12137aa16d8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150539 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 07179a5a5bd00f34acfa8a3f260dd834ae003c63) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150753 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-20tdf#154882: svx: don't overwrite the first cell's styleMaxim Monastirsky1-1/+4
i.e. new Draw document, change the char formatting in the default drawing style (e.g. font size), insert a table and fill its cells with text. Save and reload. After reload the first cell inherits the formatting of the default DS, instead of its assigned cell style. But dragging the table around shows the correct formatting in the dragging overlay, and it's also correct when copy & pasting the table. This is caused by the order of things at import, as a table is created initially with a single cell at least, and it gets its cell style assignment too early. There is also similar code to what is changed here in SdrTextObj:: BegTextEdit, and it's rightfully overridden by SdrTableObj. This appears to be a regression from 4-0, but I'm not sure which commit and what exactly changed there. Change-Id: Id096c7b5f330d6abd8f5b01c96448a9d8aac8001 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149616 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit f0287aad967761d46cb6903fc0d985a536408176) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150716 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-20tdf#153190 Compressing tool calculates compression rate wrong on large imagesNoel Grandin1-1/+5
calculation used sal_Int32, which overflowed on large values, rather use floating point to do the calculation Change-Id: I15974c5bf785a800a8f71711acfa9895361bad7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150683 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit b167bc073b6b83110242bfbace107f6978e5bca7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150627 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-18Resolves: tdf#154870 label grayed out when it should not beCaolán McNamara1-1/+1
Change-Id: I1d84434622f09e6e91bea550f5dc0321cb7d89ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150556 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-17tdf#140730 a11y: Focus form control property dlg when it startsMichael Weghorn2-0/+3
Make sure the dialog gets focus again when it starts after having been welded in commit 1efeb17837c22499f00299c033ae59ba3910f7d7 Date: Mon Nov 4 13:06:04 2019 +0000 weld Property Browser (Tested with gen, kf5 and on Windows.) Change-Id: Ie5d28a60b459735d1f1fa4c2d5d679f3d5a27cec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150284 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit cf9f73ae78aa9654064abde8411ea2f921c38354) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150496 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-04-17tdf#154501 - Fileopen PPTX: Table with rotated text wrongNoel Grandin1-18/+18
regression from commit eec42f0dbcc79a4c9f456ce97fa1066b8031ea28 Author: Noel Grandin <noelgrandin@gmail.com> Date: Sun Aug 15 17:35:58 2021 +0200 pass OutlinerParaObject around by value where some of code I converted needed to be mutating the OutlinerParaObject that something else held, rather than mutating a local copy. Change-Id: Ib91dddb3fc0d4190868f9fd59becb0d366af5e19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150376 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit ad97694737c99889bc0eb21efccb83768d510361) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150329 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-07Resolves: tdf#154680 don't mark an empty fontname as italic for "unknown"Caolán McNamara1-3/+10
its used for 'ambigious' rather than 'unknown' Change-Id: I1aeb2f825c5e611e0a943a6ce5f3ab58658701bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150136 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-07tdf#154322 select the first entry of the current page by defaultCaolán McNamara2-0/+14
rather than default to nothing selected, if we switch pages and then back to page 1 this will be selected anyway, so start off that way Change-Id: Ia684a5e44b12c984df3920f18b34c99693a2702c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149428 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-04-03sw reqif-xhtml export: fix export of transparent TIFMike Kaganski1-1/+11
Since commit 22b50f1937de67e4ad9e692d6964aa5b8d33af7a (use libtiff for tiff import, 2022-05-21), transparent TIFs are imported correctly. As the result, reqif export started to output the transparent TIF images as GIFs, because XOutFlags::UseGifIfSensible handles case of transparency, and XOutFlags::UseNativeIfPossible didn't handle TIF. Additionally, the resulting mediatype was reported incorrectly: <reqif-xhtml:object data="[...].gif" type="image/tiff" ... > 1. Handle TIFs in XOutBitmap::WriteGraphic when XOutFlags::UseNativeIfPossible is specified. 2. Return the corrected mediatype from XOutBitmap::WriteGraphic, to inform the caller about the possible change. 3. Remove the XOutFlags::UseGifIfSensible flag when doing the reqif export, to avoid the format change at all. Change-Id: I99f7cfb8d12ef66d372700ec810bd8b269868ffd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149744 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149758 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit a222008d5452c2ace6779b38d06539d085bd3a66) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149755 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-28tdf#152234 drawinglayer,svx: PDF/UA export: add Alt text to form controlsMichael Stahl2-2/+7
Specification: ISO 14289-1:2014, Clause: 7.18.1, Test number: 3 A form field whose hidden flag is not set and whose rectangle is not outside the crop-box shall have a TU key present or all its Widget annotations shall have alternative descriptions (in the form of an Alt entry in the enclosing structure elements) Form controls are weird because they have an SdrObject with the usual name/title/description plus a property "HelpText" on the control itself which is already exported as "/TU" on the /Annot unless it's empty. Exporting the SdrObject properties via ObjectInfoPrimitive2D doesn't work as tragically that is only created for form controls when painting to the screen while PDF export takes a detour that needs special handling. Change-Id: Id96f7dd13f190ab439c099cd1f4acb70c1c9fdc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149554 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 002a6fee2fbd07c3f0cd1f1ddba39c691130727e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149602 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-26Resolves: tdf#154322 if entries are disabled while menu is active, update itCaolán McNamara2-26/+43
Change-Id: Id5cad5f2f4ac21db8675de16f1bc0ceeff39fe6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149427 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-03-26tdf#154307 remove instead of hide these menu entriesCaolán McNamara1-3/+3
because on kf5 they are getting shown, which suggests a wider more generic bug on that variant, but use remove for this specific case because that's ok for this usage and works around the problem for now. Change-Id: Ib2bc316cc33894253a0b6335ae8643d0c8d78794 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149304 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-03-25vcl,drawinglayer,svx,sw,sd: PDF/UA export: Annot StructElem for SdrMediaObjMichael Stahl6-1/+45
veraPDF complains: Specification: ISO 14289-1:2014, Clause: 7.18.1, Test number: 1 An annotation, excluding annotations of subtype Widget, Popup or Link, shall be nested within an Annot tag This is very similar to Link annotations, that is to say, extremely complicated to get it thought the convoluted PDF export code, with additional complication that the StructElem is produced by drawinglayer and the page annotation by sw. Put another map into PDFExtOutDevData where sw code puts stuff for the SdrObject that drawinglayer can find. The test had the problem that PDFObjectParser::parse() could not handle: <</Nums[ 0 [ 6 0 R ] 1 6 0 R ]>> Fix dropping the "1". Change-Id: If5bf7c552e26ebb7e631030b8aaecd4281e77acc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149314 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-17tdf#153704: Make sure the last script segment is also addedKhaled Hosny2-2/+2
Change-Id: Id6381d77cdf05c24a1b557206f530f4e004e8e52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148970 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-03-12Resolves: tdf#154087 update scrollbar range when search criteria changeCaolán McNamara1-3/+8
Change-Id: Iaf5f20c8952b15f3dcccb65277dadb171a705605 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148607 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-03-09tdf#148776 for scrolling set step size as height of a rowCaolán McNamara3-9/+23
similar to FontFeaturesDialog. FWIW gtk's viewport implementation automatically overwrites the step size to be 10% of the visible height (and page size of 90% of the visible height) Change-Id: If356724a47b0a10069f129bed4a40cfdee57bfa8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148138 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 4a88c5840e022ca896ce26ce1dfde2db7fb7df29) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148318 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-03-08tdf#149756 tdf#152545 PPTX import: position of standard connector - part2Tibor Nagy2-2/+29
and add new compatibility option "ConnectorUseSnapRect". Standard connectors (bentConnector3, bentConnector4, bentConnector5) are improved. MSO calculates the edge track differently, so have to add "ConnectorUseSnapRect" compatibility option: - For PPTX file format, it is set to true and use the snap rectangle - For ODP format, it is set to false by default and use the bounding rectangle. Follow-up to commit eec48130271188cab63665acedbabf1ff5e850a2 "tdf#148926 tdf#151678 PPTX import: position of standard connector - part1" (bentConnector2) Change-Id: Icca84708d6e10d44ebf7262415d055ce9cfc157d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146162 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148480 Tested-by: Jenkins
2023-02-22Resolves: tdf#148047 don't move focus if dropdown is activeCaolán McNamara1-0/+9
a bit of a corner case, for the popover gtk sets the focus in two steps, one to null, then to the final widget, not in just one step. On seeing the interim null case we assume that focus was lost and set it to the parent, which causes the popover to be dismissed while it's still appearing. Workaround this by ignoring the grab to parent while the popover is active. Change-Id: I1bdef51731bf714de2df93fbe6694e9ed3e366d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147368 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-02-14tdf#153332 reset background to default if new preview has no bgCaolán McNamara1-0/+6
but the old did Change-Id: I59ebd4d5974c5d67c4ac572b091febed879fc290 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146923 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-02-08Related: tdf#153438 this toplevel needs to be a GtkBoxCaolán McNamara1-6/+5
Change-Id: I04a503f77dcbfb03cfcfce26f0a94d3cb7f54b68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146619 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-02-01tdf#152726 Pasting Selection to Sheet as BMP Image, button test is largerNoel Grandin1-16/+20
regression from commit 720e4258ab5f00287098ff945a184bfb43911841 Author: Noel Grandin <noel@peralex.com> Date: Fri Aug 20 11:30:35 2021 +0200 use Primitive2DDecompositionVisitor in ViewObjectContact (tdf#105575) Revert the relevant piece, no idea what the underlying problem is. I suspect something is being tricksy and using settings from the current OutputDevice even though the point of the drawinglayer getPrimitive2DSequenceHierarchy is supposedly to be independant of that. Change-Id: I3026ff2ba5ce3751a4e4ebdf15954aae548493c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146352 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 4fde49387eeecc35d1ead6305b1fe1e30e09cccc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146322 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-01-23tdf#153154: m_xDataTypeLB is still in useXisco Fauli1-0/+1
Regression from 2e7f77d3fe01e36222d5ad84c18d7d7537092972 "loplugin:unusedfields" Change-Id: Ic9435ee9417f812281ad75039d4ef88f508bad62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145948 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-23tdf#148000 impress: Handle linebreaks on fontwork.Attila Szűcs6-12/+129
Split text lines in a paragraph, right before polygons are created for rendering, so eol will brake line in fontwork just like eop. Change-Id: Ie9e6764f9f91c2e19afd43dc9a212bd18c41c99d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145425 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit f9d6dd788e82a1964dab9cc0d0436c8c54b775c0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145804 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-01-19tdf#153088 format cells example text black on dark backgroundCaolán McNamara1-4/+13
with application colors, scheme: LibreOffice Dark enabled Change-Id: I465c97bf21b66c0122b59296d0c114bf115910ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145726 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-01-16svx: avoid divide by zero in SvxRuler::UpdateTabs()Xisco Fauli1-3/+3
Prevent lDefTabDist from ending up in a zero state. See https://crashreport.libreoffice.org/stats/signature/SvxRuler::UpdateTabs() Change-Id: I9335f3be12de5db4f4f0c3f434057d91f96733ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145457 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 93b042f488db7d036821efdb967747a1f9c838e0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145450 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-01-16tdf#153000: file types MSO_SPT=25 to 31 are wrongly renderedJulien Nabet1-7/+7
Description and analysis with MS ref + code pointer + solution here: https://bugs.documentfoundation.org/show_bug.cgi?id=153000#c0 all this thanks to Regina. Change-Id: I63a66e075bc67e3c7d833756026933b3447d0cd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145491 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 11319f419988443af85cf3c60dbed12d67fc183f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145449 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-31tdf#152683 LO Draw ignoring Undo:Resize Grouped ObjectNoel Grandin1-1/+1
regression from commit 4e24efb563cbe6fec4185b4f7ec3755b2fc05b6b tdf#54857 elide more dynamic_cast Change-Id: I4fbabe64649ee47a9360dd939b5f39d35bd29c51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144858 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 62ed082ee026023d332b2b4bbbc8a7b49580fa2e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144894
2022-12-30tdf#152737: Fix off-by-one errorsKhaled Hosny2-2/+6
Regressions from: commit 718af940435ae9d2ac90374e5880ecb38e96252c Author: Khaled Hosny <khaled@aliftype.com> Date: Fri Dec 16 00:10:34 2022 +0200 tdf#152533: Improve script handling in font preview and: commit bfecacb2487ba9470600e6f64056d9b1816ee96b Author: Khaled Hosny <khaled@aliftype.com> Date: Thu Dec 15 22:51:54 2022 +0200 tdf#152460: Improve script handling in style previews Change-Id: I7b12f5accbd65459d724676efb7bec947a7faaa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144880 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com> (cherry picked from commit 95f0dc2dc74401a097105fcfe745aba3e571d9c4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144898 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-12-21Resolves: tdf#152593 reuse Line Style preview code for Line Width previewCaolán McNamara3-32/+35
Change-Id: I842b3bfaeb63978377ebb3edaef4dfd94ec296a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144660 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-20Resolves: tdf#146933 wire up keypress events for table control widgetsCaolán McNamara2-29/+17
Change-Id: Idc8cc3c24d061537a76a37f4fa84951a41a42657 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144488 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-19Resolves: tdf#92051 add tooltips to section/table statusbarCaolán McNamara4-1/+179
Change-Id: I649eabbe266085fdbc0ca9c4a5506c0c2a270721 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144199 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144450 Tested-by: Caolán McNamara <caolanm@redhat.com>
2022-12-17check SfxObjectShell::Current()Caolán McNamara6-56/+71
SfxObjectShell::Current() can return null, it's based on the equally vile SfxViewFrame::Current() Change-Id: Ia5c7783680e9d8e5d3075078f16a2c15cb6f7a47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144355 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-16likely fix for frequent pShell->GetStyleSheetPool crashCaolán McNamara1-7/+8
SfxObjectShell: :Current can return null, it's based on the equally vile SfxViewFrame: :Current Change-Id: I1d937b92188deb06eef36af5d0835e173d588d2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144304 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-16tdf#152533: Improve script handling in font previewKhaled Hosny1-70/+49
Use Edit Engine to get the script types instead of trying to duplicate (poorly) its behaviour. This has the advantage of handling weak characters and digits properly and is closer to what would happen in the document itself. We probably should go further and render the preview entirely using Edit Engine (since the current code fails short of proper bidi handling), but this is a bigger change. Change-Id: I975cb2d96a4a18dbd8110686ca09649cab0ec2f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144284 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com> (cherry picked from commit 718af940435ae9d2ac90374e5880ecb38e96252c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144272
2022-12-16tdf#152460: Improve script handling in style previewsKhaled Hosny3-90/+56
Use Edit Engine to get the script types instead of trying to duplicate (poorly) its behaviour. This has the advantage of handling weak characters and digits properly and is closer to what would happen in the document itself. We probably should go further and render the preview entirely using Edit Engine (since the current code fails short of proper bidi handling), but this is a bigger change. Change-Id: I79b28067d80f66087e1d5e9399ba1a513de96c8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144283 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com> (cherry picked from commit bfecacb2487ba9470600e6f64056d9b1816ee96b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144271
2022-12-16svx: check SfxViewFrame::Current()Caolán McNamara5-28/+42
these ones look potentially worth backporting Change-Id: Ie7325cd5548c0c10c6b6df9c1a771d24b029b635 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144255 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-16Resolves: tdf#147640 default optional grids hiddenCaolán McNamara1-2/+2
they are always explicitly toggled on/off by the owner, but this way they will be no-show-all and not make visible on relocating to a new parent Change-Id: If17cb15988118875a680e4d1a04c148f47c7a7b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144187 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-16svx: fix null deref in ParaLineSpacingControl::ExecuteLineSpacingXisco Fauli1-2/+6
See https://crashreport.libreoffice.org/stats/signature/svx::ParaLineSpacingControl::ExecuteLineSpacing(long) Change-Id: Ide29a7e78bf1114f0ebc104fa8c245e52d590eea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144190 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-12-15resave with latest gladeCaolán McNamara1-119/+121
Change-Id: I00d1a4e727e411ea91d2a95b081d2a68f2b90ba2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144185 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-12-14Resolves: tdf#152495 crash on dismissing ruby dialog with ESCCaolán McNamara1-2/+6
Change-Id: I26af008a7ee7b105255a1aaacff7ff30813172a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144174 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-25 18:04:37 +0000