summaryrefslogtreecommitdiff
path: root/svx/source
AgeCommit message (Collapse)AuthorFilesLines
2015-03-02tdf#87820 Images not displayed properly in CalcHenry Castro1-0/+6
Fixed. After opening, images were not displayed properly in Calc 4.3 and 4.4 Change-Id: I1f0dd7e9d332889df81be84a6c1e28a09f509733 Reviewed-on: https://gerrit.libreoffice.org/14505 Reviewed-by: Zolnai Tamás <zolnaitamas2000@gmail.com> Tested-by: Zolnai Tamás <zolnaitamas2000@gmail.com> (cherry picked from commit 6c84442f99de109b585d3ba8964deb8dcf261c0f) Reviewed-on: https://gerrit.libreoffice.org/14721
2015-02-26Resolves: rhbz#1193971 clear hard-coded char props in table cells...Caolán McNamara2-18/+35
like we do already for shapes. So now when attempting to set replacement char properties on the entire cell, clear any hard-coded sub ranges within the existing paragraphs. This extends the effort of commit a217f3cb2dce71a4322f78ceb45edb6f171b2b65 Author: Matúš Kukan <matus.kukan@collabora.com> Date: Tue Aug 26 10:16:34 2014 +0200 bnc#770711: Make changing table text color in impress always work to encompass all character properties, not just color Change-Id: If8b426c3531b4678868d8351426db32c3c558650 (cherry picked from commit b14259b946686c753c0df42c519fc2537e871601) Reviewed-on: https://gerrit.libreoffice.org/14539 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-02-13Resolves: tdf#81429 select corresponding listbox entry if not currentEike Rathke1-8/+16
Change-Id: Ib475a43601ee22d33677ac45cd6ef9dba7e7c431 (cherry picked from commit a448f1bb9221f30f73574c580b506e00bf2ae61a) Reviewed-on: https://gerrit.libreoffice.org/14457 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-13tdf#60910 don't lose fontwork objectsDavid Tardon1-1/+1
This reverts commit 0685b2e73e48adb84cd01355d45551ab478ebcd5. (cherry picked from commit ecf0c4ba89e27cbb8cf7c7dd904cdd0b87dd5f52) Change-Id: I843dce1f9551529d125435e5e8eb9fa759a5af23 Reviewed-on: https://gerrit.libreoffice.org/14461 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-09tdf#47577 Zoom slider should only react to full clickRodolfo Ribeiro Gomes1-2/+13
Change-Id: If859754c956a634a96066ac407b70d6dd2759d53 Signed-off-by: Rodolfo Ribeiro Gomes <libo@rodolfo.eng.br> Reviewed-on: https://gerrit.libreoffice.org/14265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 53740bd71a0ae569da36b9293ef22842a0b53f1e) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-02-06cppcheck: Returning/dereferencing 'pEntry' after it is deallocated / releasedJulien Nabet1-0/+1
Cherry-picked from c20a2234c5cb9cb89611de8a8a34e9d1e7c7a972 Change-Id: If96b66d5bbfcf4426bb602909599cd36e1f3c994 Reviewed-on: https://gerrit.libreoffice.org/14350 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-30Resolves: tdf#88740 parse with locale decimal separatorEike Rathke1-10/+23
And use a proper string to double conversion and early bail out conditions. (cherry picked from commit 1884c0bbd40f0ded41d7a1656cb64fb1f6368c36) tdf#88740 fix sidebar angle rotation i18n (cherry picked from commit 9a7bf47098fe69b5c6069372708918ef94a9d597) use a less ugly string to double conversion, tdf#88740 follow-up And check string length before accessing characters.. (cherry picked from commit 3ba5ac834780fc2565aff99e42dd8c3b2202fba3) 30355f3aaf77b1952e21050e3593e575571d7aaa ac3c2bf2f67f0cc7fc106515a875512771676e01 f97a25cd2cab0dccf2154465da7c1235ef3ca8c6 Backport: added vcl/settings.hxx Change-Id: I6c89dd850405ad74ebd175800131cdcac19a8c86 Reviewed-on: https://gerrit.libreoffice.org/14243 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-28tdf#82524: Mismatch of ValueSet and metric field valuesKatarina Behrens1-0/+1
Regression from commit ab50bc9d4a72193c1fefcbf0652938995094bc41 which adds space separator between value and unit. As metric fields now output values with separator, LineWidthValueSet items must be adjusted accordingly, otherwise they'll never match Change-Id: I55778c9c0cc36d968a061e5e35b6db3f2a159977 (cherry picked from commit 8fd9c25ac66dd238d4c68be3974241a18cb21705) Signed-off-by: Andras Timar <andras.timar@collabora.com>
2015-01-19Resolves: fdo#88417 Dropdown for ruler settings should show radio buttonsCaolán McNamara1-11/+11
This reverts commit 9995222d1141b326197a387cc7897b3971ce9e9a and additionally converts the ruler settings to radio buttons and not checkboxes Conflicts: vcl/source/control/tabctrl.cxx Change-Id: Ie0eac5f07729447942065b7f415398165fbf067c (cherry picked from commit 251737f0dd186b0f169f5ba237e1e8c28a320e00) Reviewed-on: https://gerrit.libreoffice.org/14017 Tested-by: David Tardon <dtardon@redhat.com> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-01-19svx: ExternalToolEdit: don't terminate if SystemShellExecute throwsMichael Stahl1-3/+11
(cherry picked from commit 5e4dc857252c8eeaaa629af2fb6b392ab02036cf) Change-Id: Ia527a2c9467e2ab097cf688164f4176a52fa1d36 Reviewed-on: https://gerrit.libreoffice.org/13997 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-19svx: ExternalToolEdit: check that temp file is actually createdMichael Stahl1-2/+14
(cherry picked from commit c8ae30a720474db8efed3db31348f8ae52c149c3) Conflicts: svx/source/core/extedit.cxx Change-Id: I03e49493c549561b4dc806f1e191a73d06733cff Reviewed-on: https://gerrit.libreoffice.org/13996 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-19rhbz#1136013: svx: try to make the ExternalToolEdit not crash all the timeMichael Stahl1-19/+78
This thing was starting a timer that re-starts itself forever, and when the file it was watching changed, it would just assume the drawing objects were still there (and the document, for that matter...) (cherry picked from commit 5f6bdce0c0ac687f418821ce328f2987bf340cda) Conflicts: sc/source/ui/drawfunc/graphsh.cxx Change-Id: I35f187f0828097a05618dc1733dce819fc6bffc6 Reviewed-on: https://gerrit.libreoffice.org/13995 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-07Assume that as long as the model is the same, the shape doesn't change.Lionel Elie Mamane1-1/+1
Even if it is moved from not a page to a page or vice-versa. This allows assumptions made in the Base Form wizard to hold, namely that if one: 1) Creates controls (and their associated shapes) 2) Groups the shapes (in a GroupShape) Then all the shapes still remember their associated control and vice-versa. Change-Id: I31975970e7ea2f7978aea7f753de88ecd8e55234 Reviewed-on: https://gerrit.libreoffice.org/13559 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-01-07fdo#87555 ComboBox in table should use same formatting as floating ComboBoxLionel Elie Mamane2-16/+4
Same as fdo#67615 for TexFields, but for ComboBox. Same problem, same cause, same solution. ListBox seems not to have this problem :) Change-Id: I953c5452f6c313b8940fbd1048b4c901b331fc58 Reviewed-on: https://gerrit.libreoffice.org/13579 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-12-25Copying linked graphic between components is brokenZolnai Tamás1-1/+1
IsLinkedGraphic() is better to use here. Reproducer steps: -Insert an image to Impress as a link. -Copy this image (CTRL+C & CTRL+V) to Writer. Result: Image is not displayed. Change-Id: Iaf9b686b5c87caf5a0cc15425f8c5988f857bfe6 (cherry picked from commit 3650b66c366177877d30f6aae83a33bf683d3457) Reviewed-on: https://gerrit.libreoffice.org/13609 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-12-22Resolves: fdo#87422 set autocheck bitsCaolán McNamara1-0/+9
Change-Id: I8db4242f083a10bf8753f078002ff8676264b54c (cherry picked from commit c47d039fc80c0e42b14b567af843b2523af9e8bf)
2014-12-15fdo#87292 use system dependent path instead of file URLAndras Timar1-1/+5
Change-Id: I3da4cd7af16a8ecfb19ce23e01117e735e9dd8d6 (cherry picked from commit efe3e06dd1b99215d82b6373aa7434a8f25a22f2)
2014-12-09fdo#37682 paint the right areaDavid Tardon1-1/+1
Change-Id: Ic3d1f6e47bf068e60dca711c97e3f6b194d14049 (cherry picked from commit a68a7b831a5d1756ea9428e12bb89f69dc30950f)
2014-12-05-Werror,-WuninitializedStephan Bergmann1-1/+3
(in SvxGraphCtrlAccessibleContext ctor: base class 'comphelper::OBaseMutex' is uninitialized when used here to access 'comphelper::OBaseMutex::m_aMutex') Change-Id: Ic6791043828b7b9f69c76867e26ee02a5ee66817 (cherry picked from commit a8a8cb216fd2b25a1ed8b9c217685dccacaa428e)
2014-12-05-Werror,-WuninitializedStephan Bergmann1-2/+2
(in TableModel ctor: base class 'comphelper::OBaseMutex' is uninitialized when used here to access 'comphelper::OBaseMutex::m_aMutex') Change-Id: I2a54a1123384bdeaee917ad9f1f0047f13c3860f (cherry picked from commit f0332a4a77880a04697b93cec8f1c2b913f60d1a)
2014-12-05Broken castStephan Bergmann1-14/+1
All the way back since 2001 (ed53aaf5842e82f9a8d4d053b39e7db61c6d62ce "#89611# react for (Beamer!)Frame->dispose() from outside," adding member SfxChildWindow_Impl::xListener), that MyStruct hack was not in sync with SfxChildWindow_Impl, so ((MyStruct*)pImp)->bVisible = false; probably corrputed pFact rather than change bVisible. The origin of that MyStruct hack is lost to history, but probably stems from an ancient time when changes across modules where prohibitively expensive, esp. when some feature had to be crammed in shortly before release... Change-Id: I13dc30c96ef70b2cc09dc117231c021910e0ce1e (cherry picked from commit 0cb6a92f86e02f6342be5e8f931dc1849114230c)
2014-12-05ooo#93212 avoid slicing during construction of SdrPageDavid Tardon3-65/+41
Also hide copy ctor and assignment operator of all derived classes, to ensure that Clone() is the only method to make copies of them. Change-Id: Icb3b50c63b086abe8c9add32e3041fe19692d20b (cherry picked from commit 9638e6207c7fc48712b1b238177462c00f5011e8)
2014-12-03Linked graphic is not displayedZolnai Tamás1-0/+1
Regression from: 17475638138c92162be1c0f34cf1f9cc95c63579 Change-Id: Ie2d484fbe065c24d19938c8c9c68818bd1076f2d (cherry picked from commit 02b17c1bbdd19a978b9de646c0dacdad179c60de)
2014-11-27sidebar: Try to fix initial spacing valuesMaxim Monastirsky1-6/+8
Process SID_ATTR_METRIC status before any other, and call SetMax methods before SetValue, so indent values won't be truncated by a wrong max value. Change-Id: I36d8c0cce9561902aa2c4d531740f56c80207012 (cherry picked from commit 9a410f9cedbce5276aea48479812ff68210712b0)
2014-11-25fdo#85858: svx: fix mouse dragging of table row separators in WriterMichael Stahl1-2/+3
Add a work-around for Writer's usage of LONG_MAX to SvxColumnDescription: on 64-bit platforms the LONG_MAX added in SwView::StateTabWin() for SID_RULER_ROWS will overflow in vcl's LogicToPixel mapping and that causes wrong positioning of the row highlight lines. Probably Writer should use something other than LONG_MAX (no reason why these types need to be bigger than 32-bit anyway) but that needs a bigger cleanup. (regression from 4c60f722afdc0be5c129ce5f5ed6786d09d0051e) Change-Id: I08147462356368d48959a85a85ef7dd8dcae0943 (cherry picked from commit d288ee633d7964cf89a32a96e6e0af8c3c3e0db9)
2014-11-24loplugin:literaltoboolconversionStephan Bergmann1-1/+1
Change-Id: Ibecd561c1d27e129ad1f481bdb7f8a7bb4d0f8d8 (cherry picked from commit 40833b49ebdef2e5ab9ece33fc558fd0929f4e8d)
2014-11-24svx: punish evil-doers who put duplicate properties into custom shapesMichael Stahl1-1/+30
LO 4.3.2.2 is evidently able to export an ODF document that violates XML Well-formedness constraint: Unique Att Spec. <draw:enhanced-geometry draw:mirror-horizontal="false" draw:mirror-vertical="false" svg:viewBox="0 0 21679 2134682997" draw:text-areas="0 0 ?f3 ?f2" draw:mirror-vertical="true" draw:type="ooxml-rect" draw:enhanced-path="M 0 0 L ?f3 0 ?f3 ?f2 0 ?f2 Z N"> Not sure how to reproduce this, but the attributes there are apparently a serialization of SdrCustomShapeGeometryItem's aPropSeq, retrieved from a "CustomShapeGeometry" property, so add some input validation and assertions there. Change-Id: I91151365b507779a4bdc9cce2057d34f2376f005 (cherry picked from commit 7fcbb29db802acd8c0f32e8ff578ef4b2f82c46b)
2014-11-24fdo#86546 Open the right tab for more bullets and numberingMaxim Monastirsky1-4/+22
Change-Id: Ib8dda6eab89c92fa9bea98e3570896ea02692585 (cherry picked from commit cb6ced50c11ea71e5655c46e49f17f3b5921f526)
2014-11-24Revert "show pointer_move arrow when passing over an object boundary"Caolán McNamara1-1/+0
revert on 4-4 until figured out the extra piece needed to get this working nicely with table boundaries This reverts commit 961ed635515a346a4395b4abf29675e121ddd8ab.
2014-11-23Resolves: fdo#86466 Wrong background color shown in format table in impressCaolán McNamara1-12/+32
regression from commit 440e2031ce8cffc8dc573e359a330236f9c11dfb bnc#882627: Allow to edit spacing to contents even with no borders visible. which was an attempt to fix regression from commit 9e5342509b302ba1f816f21cc3ad1cb7093982e0 Date: Mon Jun 3 14:22:07 2013 +0200 copy values from the original item set ... because SfxAbstractDialog::GetOutputItemSet() only contains the items that have been _changed_ in the dialog. Now format color shows the expected color, and loading the sample for bnc#882627 and selecting cells and changing the border distance (etc) doesn't cause bulleting and paragraph alignment properties to be stripped away Change-Id: Id414e09faa221d151f393971654b17bbe9f46d81 (cherry picked from commit e91ab2104b62b689dca2c565cd81a8cb40885822) Reviewed-on: https://gerrit.libreoffice.org/13018 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-11-23some localizations (e.g. Slovenian) need more space for translated button textAndras Timar1-2/+2
Change-Id: I407d8d92c9669f606e4f8fbb95a37932f8f14956
2014-11-22fdo#86573: Impress does not show pictures anymoreZolnai Tamás1-2/+10
Regression from: 286e2f5c6ec829bc0987b1be7016699f7ef03e5e Sometimes SdrGrafObj import the image file just as a preview (with low resolution) and late when the real picture is needed it just throws this preview and tries to load the image again. This preview works only with package URL so in this case we should not forget that URL. Plus two other related potential image loss situation: - SetUserData() is called with empty image URL - Image preview is thrown when we actually have no package URL from we can import the image again. Change-Id: Ib21f400eb6d28133e8598e6b201209e5dd1a976f (cherry picked from commit f0b28806eebb1477066d44de49b5d1d61a8e84cf)
2014-11-22fdo#86517 make predefined palette names localizableAndras Timar2-8/+20
Change-Id: I3930757c02f9f976fb52cd75c9edab7cf75078c6 (cherry picked from commit 08d876b6b0b52d882350aa64eda784da56856166)
2014-11-21More fixes after SdrMetricItem changesStephan Bergmann1-1/+1
...like e0c2ea6bde31bd68e1794154b72fddcd40dda7f9 "Consistency around SdrMetricItem in svx/sderitm.hxx," similar to recent c3a9a9542b018f781ee12e6c8c943d4f19641afe "that's not right anyway, using the Distance as a which-id." Should all be found and fixed now with the removal of the unnecessary but harmful default value from the two-argument SdrMetricItem ctor. Change-Id: I6eaeb6633c9a350b18e02d476d2c8794a733cea8 (cherry picked from commit 226e0abd2c5ebd9fd591966b584d04e4ab5cd171)
2014-11-20that's not right anyway, using the Distance as a which-idCaolán McNamara1-1/+1
Change-Id: If6422d35b5d7b4b9a3cf9f16c34a1ee977b3085a
2014-11-19Move SdrObjPlusData out of SdrObject's header.Kohei Yoshida6-94/+189
It is only used locally within svx. Change-Id: Iae53de3d1cb2b1f5f2ba5cede2794f08dfef972c
2014-11-19loplugin:unreffunStephan Bergmann1-6/+0
Change-Id: I648b91e1124fcdad16ccd5d619192b72e4c8ec3f
2014-11-19Move SdrObjUserDataList out of the header.Kohei Yoshida1-0/+17
It's only used within SdrObject. This also eliminates the need to include boost's ptr_vector in the header file. Change-Id: I5ba9b424be21c5ee3280364de1d73b0fa3921129
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl7-0/+9
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18show pointer_move arrow when passing over an object boundaryCaolán McNamara1-0/+1
which removes the guessing you have to do when trying to find the edge of a pres_obj in impress after text has been filled in and there is no visible border anymore Change-Id: I470caec90cdeaa681da70f8ec3044c1d6d232a82
2014-11-18fdo#82708 editing statusbar tooltip textsYousuf Philips1-6/+6
Change-Id: I3ac2e46f89d5c1e4decb6d6aaf8487663e904a43 Reviewed-on: https://gerrit.libreoffice.org/12433 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl9-0/+11
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17cppcheck: Same expression on both sides of '||'Julien Nabet1-1/+1
Change-Id: I89c758366c2140f0033c1006f6a03bbc17ea8096 Reviewed-on: https://gerrit.libreoffice.org/12459 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-17-Werror,-Wunused-variableStephan Bergmann1-2/+0
...since 286e2f5c6ec829bc0987b1be7016699f7ef03e5e "Related fdo#82953: Forget package URL of image after it is loaded" Change-Id: If4cc941353b72f555dee26d158aee7b15b359a9c
2014-11-16Logically dead code related to embedded stream name in SwGrfNode\SdrGrafObjZolnai Tamás1-18/+2
See also: 286e2f5c6ec829bc0987b1be7016699f7ef03e5e Since embedded URL exists until the first swap in these lines are not needed anymore. Change-Id: Ie6bf8efe7808cf42f20f7b4b3f8cb927555c0ea8
2014-11-16Related fdo#82953: Forget package URL of image after it is loadedZolnai Tamás1-1/+1
It causes problems if we handle those imported images differently which are identified by a package URL, so after the first load remove this URL and handle images on the same way as inserted images. Some related bugs: * #i44367# * #i124946# * #i114361# * fdo#73270 The image in the test document has a special ID which is different from that one which is generated by LO internally so after ODF export the new generated image URL is different from the imported one. Change-Id: I4e7d3490674c5f86bec5c7c6e1c975dcafd7c265
2014-11-16vcl: let the ModalDialog ctor take an OUStringMiklos Vajna1-1/+1
Change-Id: I839435338f4acf80c40896b6c86f7ef122f5449d
2014-11-14more catch by referenceCaolán McNamara1-1/+1
Change-Id: I2db9f94a517f814ef0854190e6f1194501070409
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava17-39/+39
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14vcl: move the Impl class of MapMode ...uhm... out of the public header?Michael Stahl6-0/+6
And remove the tools/fract.hxx include. grep -l -r fract.hxx workdir/Dep/*Object* |wc -l before: 4569 after: 1851 Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3: libvcllo.so by 473k (0.35%) libswlo.so by ~1Mb (sadly that is just 0.2%) Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-14 02:01:11 +0000