summaryrefslogtreecommitdiff
path: root/svx/source/unodraw
AgeCommit message (Collapse)AuthorFilesLines
2013-12-17SvxTextEditSourceImpl::Notify(): attempt to fix chart2_unoapi crashMichael Stahl1-2/+18
Apparently SvxTextEditSourceImpl::mpView is not properly invalidated when the instance it points to is deleted; the SvxTextEditSourceImpl is registered as listener so try to handle this in Notify(); not sure if there isn't something that ought to have cleaned this up... Crash running with SAL_FORCE_IACCESSIBLE2=1: svxcorelo.dll!SdrPaintView::FindPaintWindow(const OutputDevice & rOut) Line 70 svxcorelo.dll!SvxTextEditSourceImpl::GetVisArea() Line 923 svxcorelo.dll!SvxTextEditSource::GetVisArea() Line 1113 svxlo.dll!accessibility::AccessibleTextHelper_Impl::UpdateVisibleChildren(bool bBroadcastEvents) Line 868 svxlo.dll!accessibility::AccessibleTextHelper_Impl::ProcessQueue() Line 1376 svxlo.dll!accessibility::AccessibleTextHelper_Impl::Notify(SfxBroadcaster & __formal, const SfxHint & rHint) Line 1530 svllo.dll!SfxBroadcaster::Broadcast(const SfxHint & rHint) Line 48 svxcorelo.dll!SvxTextEditSourceImpl::NotifyHdl(EENotify * aNotify) Line 1021 svxcorelo.dll!SvxTextEditSourceImpl::LinkStubNotifyHdl(void * pThis, void * pCaller) Line 1013 tllo.dll!Link::Call(void * pCaller) Line 123 editenglo.dll!Outliner::ImplBlockInsertionCallbacks(unsigned char b) Line 2098 editenglo.dll!Outliner::Clear() Line 2036 svxcorelo.dll!SdrOutlinerCache::disposeOutliner(SdrOutliner * pOutliner) Line 91 svxcorelo.dll!SdrModel::disposeOutliner(SdrOutliner * pOutliner) Line 1960 svxcorelo.dll!SvxTextEditSourceImpl::dispose() Line 489 svxcorelo.dll!SvxTextEditSourceImpl::Notify(SfxBroadcaster & __formal, const SfxHint & rHint) Line 458 svllo.dll!SfxBroadcaster::Broadcast(const SfxHint & rHint) Line 48 svxcorelo.dll!SdrModel::~SdrModel() Line 270 chartcorelo.dll!chart::DrawModelWrapper::~DrawModelWrapper() Line 191 chartcorelo.dll!chart::DrawModelWrapper::`vector deleting destructor'(unsigned int) chartcorelo.dll!boost::checked_delete<chart::DrawModelWrapper>(chart::DrawModelWrapper * x) Line 34 chartcorelo.dll!boost::detail::sp_counted_impl_p<chart::DrawModelWrapper>::dispose() Line 78 chartcorelo.dll!boost::detail::sp_counted_base::release() Line 104 chartcorelo.dll!boost::detail::shared_count::~shared_count() Line 381 chartcorelo.dll!boost::shared_ptr<chart::DrawModelWrapper>::~shared_ptr<chart::DrawModelWrapper>() chartcorelo.dll!boost::shared_ptr<chart::DrawModelWrapper>::reset() Line 626 chartcorelo.dll!chart::ChartView::~ChartView() Line 202 chartcorelo.dll!chart::ChartView::`scalar deleting destructor'(unsigned int) cppuhelper3MSC.dll!cppu::OWeakObject::release() Line 204 chartcorelo.dll!cppu::WeakImplHelper10<com::sun::star::lang::XInitialization,com::sun::star::lang::XServiceInfo,com::sun::star::datatransfer::XTransferable,com::sun::star::lang::XUnoTunnel,com::sun::star::util::XModifyListener,com::sun::star::util::XModeChangeBroadcaster,com::sun::star::util::XUpdatable,com::sun::star::beans::XPropertySet,com::sun::star::lang::XMultiServiceFactory,com::sun::star::qa::XDumper>::release() Line 115 chartcorelo.dll!com::sun::star::uno::Reference<com::sun::star::uno::XInterface>::~Reference<com::sun::star::uno::XInterface>() Line 106 chartcorelo.dll!chart::ChartModel::~ChartModel() Line 188 chartcorelo.dll!chart::ChartModel::`vector deleting destructor'(unsigned int) cppuhelper3MSC.dll!cppu::OWeakObject::release() Line 204 Change-Id: Ife6d6275eae74750858a7a7f57153c76a1a228a4
2013-12-16Clean-up uno/lbnames.hStephan Bergmann1-1/+0
Change-Id: I4bd729499aa8be58f04194656e35c1f79d5d4919
2013-12-12Get rid of MAP_CHAR_LEN macroStephan Bergmann1-26/+26
Change-Id: I0c8af0f3acdae7eb5167ea1dd4e0e4abf0357bb2
2013-12-12Fix C++03 digraphsStephan Bergmann1-6/+6
Change-Id: I456469c27b60290ad8280fe12fcb82958e1a6c85
2013-12-12Do not use C++-UNO internal static_type functions in client codeStephan Bergmann3-14/+14
...use cppu::UnoType instead. Change-Id: I507914b30ef8acda910ee4ecc0589fd328eb6f31
2013-12-12Remove unnecessary macro ITYPEStephan Bergmann1-8/+5
Change-Id: I9ade981c771367fd292600d73124f89b94a7a924
2013-12-12Don't hold css::uno::Type instances by pointerStephan Bergmann3-333/+306
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry. And as the arrays of such need to be initialized dynamically anyway, also change their name members to proper OUStrings while at it. Plus some const clean-up. Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
2013-12-11Revert "Don't hold css::uno::Type instances by pointer"Stephan Bergmann3-306/+333
This reverts commit 90f91088d238469b4a2262c91de3117ba40f5bde for now: Ach, old GCC doesn't like plain string literals to initialize members of OUString type... Change-Id: I50563a00406259bb5d41831e2a2796762450d097
2013-12-11Don't hold css::uno::Type instances by pointerStephan Bergmann3-333/+306
...in comphelper::PropertyMapEntry and SfxItemPropertyMapEntry. And as the arrays of such need to be initialized dynamically anyway, also change their name members to proper OUStrings while at it. Plus some const clean-up. Change-Id: I67d4d7b5773fb020605f369daf39528bec930606
2013-12-09implicit conversion of NULL constant to 'bool' [-Werror,-Wnull-conversion]Stephan Bergmann1-1/+1
...after 8a8981c603d2f45d0fac656e5b4b31bcabfabc92 "GetBasic and m_pBasic are unused." Change-Id: I7ccfcdcc3a7b005185a1de3050f3cccbc741f073
2013-12-06Default OMultiTypeInferfaceContainerHelperVar equalImpl parameterStephan Bergmann1-2/+0
...and assorted OUStringHash clean up Change-Id: I779904e1275e8df88f567beb388d1d11af9e9671
2013-12-05Get rid of comphelper::UStringLessStephan Bergmann3-15/+10
...default std::less<OUString> is just fine. Change-Id: Ib9d3c10f2817d757f3c19eb3d4607095883af91a
2013-12-05Remove obsolete SEQTYPE workaroundStephan Bergmann1-7/+7
Change-Id: I366b29038be034b03a16fa6d7f6873dc78d8d88f
2013-11-27Integrate branch of IAccessible2Steve Yin2-0/+26
Change-Id: I8327fb4ba2a86d4caa52b875221175b80464842a
2013-11-22replace OUString::reverseCompareTo("xxx") with operator==Noel Grandin1-8/+8
operator== with OUString and literal internally does a reverse-compare (via OUString::equalsAsciiL) anyway, so no need to keep explicit calls to OUString::reverseCompareTo with literal argument Change-Id: I799d9bcd0d5c308a9547ce7cacb2db6042fdb643
2013-11-22remove unnecessary RTL_CONSTASCII_STRINGPARAMNoel Grandin1-8/+8
A final pass through the code, converting code to use the new OUString and OString methods that can detect string literals. Change-Id: Ifa6382335e5650a1c67e52006b26354e0692c710
2013-11-20avmedia: Implement "block untrusted referer links" featureStephan Bergmann3-8/+10
See f0a9ca24fd4bf79cac908bf0d6fdb8905dc504db "rhbz#887420 Implement 'block untrusted referer links' feature" for details. This adds some further /*TODO?*/ comments, and one known problem (marked /*TODO!*/) is that movies/sounds are not blocked during a slideshow presentation. Change-Id: Ib2d0c7e4f7b02c4bdec0d8a90cee5e7e1bee8325
2013-11-20convert equalsAsciiL calls to startsWith callsNoel Grandin3-8/+8
Convert code like: aStr.equalsAsciiL( RTL_CONSTASCII_STRINGPARAM( "ActiveConnection" ) ) to aStr.startsWith( "ActiveConnection" ) which compiles down to the same machine code. Change-Id: Id4b0c5e0f9afe716a468d3afc70374699848dc33
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin2-4/+4
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19remove most use of RTL_CONSTASCII_USTRINGPARAM macroNoel Grandin1-1/+1
This is largely unnecessary when working with OUString Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-18Simplify avmedia::MediaItem::setURLStephan Bergmann1-1/+1
Change-Id: I9835b96813c6bf3d8690cdaa5de66ca07afdc801
2013-11-14rhbz#887420 Implement "block untrusted referer links" featureStephan Bergmann4-12/+28
For now, this checks for a trusted referer (if the BlockUntrustedRefererLinks configuration prop is set) in utl::MediaDescriptor::impl_openStreamWithURL and SvxBrushItem::GetGraphicObject. Checking in additional places will probably be necessary to block /all/ unwanted communication. Also, some places marked /*TODO?*/ currently pass in an empty referer (which is always considered trusted) and will probably need to be adapted. Ideally, Referer URIs would never be empty (and consistently use something like <private:user> for cases where access is explicitly initiated by the user and should never be blocked), but that's a very daunting task, so start small by identifying the places that potentially need blocking and adding appropriate Referer URIs there. Also, Referer information should always be computed as freshly as possible from the context in which an access attempt is made, but, again, always carrying the information from the context all the way to the relevant functions is a very daunting task, so for now store the information upon object instantiation in some cases (SvxBrushItem, SdrGrafObj, ...). The Referer URI (css.document.MediaDescriptor property; SID_REFERER) was already used to track macro execution, and there is one place in SfxApplication::OpenDocExec_Impl where opening of hyperlinks (explicitly clicked by the user) is done that needs the current document's URI as Referer to check execution of macro URIs but needs an empty (or <private:user>, see above) Referer to not block non-macro URIs. Special code has been added there to handle that. Change-Id: Iafbdc07a9fe925d9ee580d4f5778448f18f2ebd9
2013-11-08Resolves: #i123616# be more flexible regarding the data type for polygon dataArmin Le Grand1-3/+18
(cherry picked from commit 66c81c1a26d6d09c75c8b8ced44e4a0cf43819ee) Conflicts: svx/source/unodraw/unoshape.cxx Change-Id: I5ebb7b39a083bb6e007853f205bb39d434eb94ad
2013-11-08remove unnecessary use of OUString constructor in SVX moduleNoel Grandin13-51/+47
Change-Id: I1506daaa4a3b736ee6bbb00100fca24df8368298
2013-11-08earlier failure in debug modeLionel Elie Mamane1-1/+8
in the case that mpObj.get() is not a SdrOle2Obj* Change-Id: Idff7324242062665c137685096cd82284e24f0d9
2013-11-01Some Trivial clean-upStephan Bergmann1-3/+1
Change-Id: Ie48e8f5cbc455ef267ad756d82f8c0efee0ef065
2013-10-30fdo#54938: Convert svx to use cppu::supportsServiceMarcos Paulo de Souza8-84/+18
Change-Id: I3ab178924cb1c4240511f08625f244dac54e3913 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-28fixincludeguards.sh: svxThomas Arnhold3-7/+7
Change-Id: I885bbc431322ee233f8e67ec2bb5701af909046c
2013-10-23fdo#54938: Kill ServiceInfoHelper::supportsService and use cppu's instead.Marcos Paulo de Souza3-11/+6
Change-Id: I1c2d95e4c3fb6242dcb4cdb88cf9733471a3412b Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist1-4/+4
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-04fdo#39674 fix some spellingThomas Arnhold1-1/+1
Change-Id: I72e497fb97edf8782c69000576f42896594e1556
2013-09-05svx: new InteropGrabBag UNO prop in Shape serviceAndres Gomez1-0/+12
Added the new InteropGrabBag property to the Shape service and modified the JUnit UNO unit tests for it. Added specific implementation in the svx module for the SvxShape class. This new property is intended by now for its usage on preserving OOX's Smart-Art but it could also be used for preserving other attributes for interoperability among document formats. Change-Id: Idc7a8e91592399ff05effd4da6eaa2935f8f4d42 Reviewed-on: https://gerrit.libreoffice.org/5769 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2013-09-05convert svx/source/unodraw/*.cxx from String to OUStringNoel Grandin9-70/+64
Change-Id: Ief11702d496a16dfb784c31ef2c185a36fe70311
2013-09-05convert include/svx/xit.hxx from String to OUStringNoel Grandin3-5/+5
Change-Id: Ib5ba87a934fbe9220427145eb54e3de3c49b03ad
2013-09-02Resolves: #i122820# Corrected graphics creation...Armin Le Grand1-22/+69
allow bigger limits if directly requested (cherry picked from commit 50f1445bda91cb44a1a1e8636ab0bcb6a8c4f381) Conflicts: svx/source/unodraw/UnoGraphicExporter.cxx Change-Id: I33576ef9f95b9f8a9fa0ab6f6d83c93ecec8da9f
2013-08-31deleted code that was commented outPhilipp Riemer1-4/+0
This is a follow up commit to - 22d1beb78a475e4846af945afde1c4d6c263b5d6 - 1c7af455ab9345304a7ac48ce2e0310de2ac8a75 Change-Id: I7a67c3768c0d7e36784ee88fc46680037acb244d
2013-08-31fdo#62475 - remove visual noisePhilipp Riemer1-43/+1
This is a follow up commit to - 22d1beb78a475e4846af945afde1c4d6c263b5d6 - 1c7af455ab9345304a7ac48ce2e0310de2ac8a75 Change-Id: I102685391125f3b4f7bdf838f8bd17a2283d558d
2013-08-24Mark as constTakeshi Abe1-6/+6
Change-Id: Ib5849c9a652401dbac7e93bb69c18d95d31292af
2013-08-20Re-work 8bit characters in source code, or remove them.Michael Meeks1-2/+2
Change-Id: I93e14d4936c0ffbe03425d4a54bb0e09bc62b3e3 Reviewed-on: https://gerrit.libreoffice.org/5550 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@suse.com> Tested-by: Michael Meeks <michael.meeks@suse.com>
2013-08-18Use subfolder names from <config_folders.h>Tor Lillqvist1-1/+3
Change all instances of hardcoded "program", "share" etc subfolder names to use those from <config_folders.h> instead. In normal builds, the end result will not change. Change-Id: I91c95cd8e482818be67307e889ae6df887763f53
2013-07-28reduce use of UniString from ResID ctorCaolán McNamara1-3/+3
Change-Id: I8d7619e7807ff2d400ec5c7fd181375130245728
2013-07-26fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFOJelle van der Waa1-5/+0
Change-Id: I8fe1cdccfef61c3cac88a24d057615b0ceda682a Reviewed-on: https://gerrit.libreoffice.org/5126 Reviewed-by: Luboš Luňák <l.lunak@suse.cz> Tested-by: Luboš Luňák <l.lunak@suse.cz>
2013-07-26More "Keep passing XComponentContext into officecfg:: wrapper fns"Stephan Bergmann1-1/+1
Change-Id: Ie891f1afe8db2f3ac2f01e287e1caae4de3c3246
2013-07-26convert TakeObjNamePlural family to OUStringCaolán McNamara1-3/+1
Change-Id: I947e47934677a4f9ced0bfc0db3932bcbbb25f36
2013-07-26fdo#46037: no more comphelper/configurationhelper.hxx in svxJulien Nabet1-13/+2
+ sal_Bool -> bool conversion Change-Id: Id8dc56e61984af599dcd53bb2cc9665db5fa0a1e
2013-07-25convert TakeObjNameSingul family to OUStringCaolán McNamara1-3/+1
Change-Id: I0c667cbcfcc1ea1f04d113a53b7ba83c943052e4
2013-07-15fdo#57631 fix collection of property statesDavid Tardon1-10/+2
Change-Id: I607518da26c9430916d922b8e36143cc6dd76f25
2013-07-05Resolves: #i122649# reordering of color name definesArmin Le Grand1-4/+18
Patch by: hanya (cherry picked from commit 8d4d9f11b6c205407136d5feb9668c748b9794e1) Conflicts: svx/source/unodraw/unoprov.cxx Change-Id: I52464ac5b5ee38a7b9b93f9e43f0cee93d1c3051
2013-06-28remove toolkit/unohlp.hxx hackThomas Arnhold2-2/+2
Change-Id: Idb9971d848870f4d00dbf77e80e48bf7dfde8913 Reviewed-on: https://gerrit.libreoffice.org/4601 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-06-20Resolves: #i122318# Adapted color palette stuff, some cleanupsArmin Le Grand1-90/+78
(cherry picked from commit 710925d1d93a8ccf36957fa2f4d98d7dedb4cb9f) Conflicts: extras/source/palettes/standard.soc svx/inc/svx/dialogs.hrc svx/source/dialog/sdstring.src svx/source/unodraw/unoprov.cxx svx/source/xoutdev/xtabcolr.cxx Change-Id: I15899fc51e61e29da443838d1a42ea5d7c53acb9