summaryrefslogtreecommitdiff
path: root/svx/source/accessibility/svxpixelctlaccessiblecontext.cxx
AgeCommit message (Collapse)AuthorFilesLines
2019-09-03loplugin:constmethod in svxNoel Grandin1-1/+1
Change-Id: I6ae7c04479e3ea8ecd7535c33224a5e7095b64bb Reviewed-on: https://gerrit.libreoffice.org/78396 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-14loplugin:sequentialassign in svtools..svxNoel Grandin1-2/+1
Change-Id: I465a2479f347303e6d4faa39cb0a0f05aec3bf07 Reviewed-on: https://gerrit.libreoffice.org/70719 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11loplugin:unusedmethodsNoel Grandin1-5/+0
Change-Id: I34009aabf0befb346470b5c0d96ad8fc476b7c4e Reviewed-on: https://gerrit.libreoffice.org/60300 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-03weld SvxAreaTabPageCaolán McNamara1-436/+116
which itself has 5 sub tab pages Change-Id: If71e91248b5771af4845ad6dba997ac4c7841b5d Reviewed-on: https://gerrit.libreoffice.org/56112 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-25tdf#42949 Remove unnecessary localization headers of svxGabor Kelemen1-2/+0
Found by searching for the header names and the localization functions: git grep -l -e \<svx/dialmgr.hxx\> -e \<svx/strings.hrc\> -e svdglob.hxx | xargs grep -c -e SvxResId -e SvxResLocale -e ImpGetResStr | grep :0$ | grep -v /pch Change-Id: I45c979589165086288030031e713d536005a9833 Reviewed-on: https://gerrit.libreoffice.org/53241 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-06svx: Fix the sequence's lengthTakeshi Abe1-6/+5
Change-Id: I8b1798659efb798ca4f4883469118a297f40b83b Reviewed-on: https://gerrit.libreoffice.org/52466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-06use more Color in svxNoel Grandin1-4/+4
Change-Id: I78ea8db0d9c882cdc3813ff4fac0cdce9caf6ad1 Reviewed-on: https://gerrit.libreoffice.org/50801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27remove unused vclunohelper.hxx includesJochen Nitschke1-1/+0
Change-Id: I68178379e5493d0e738861a4dce5aa6e4b58cd22 Reviewed-on: https://gerrit.libreoffice.org/50393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-21loplugin:changetoolsgen in svxNoel Grandin1-2/+2
and fix the regex in the plugin for matching += operator Change-Id: I26b3e3fac1d4ef3e756cc9431b983b5f27ee76d6 Reviewed-on: https://gerrit.libreoffice.org/50037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19use std::array in createHistorical8x8FromArrayNoel Grandin1-4/+4
to make the assumption about the size of the array obvious in the code. Change-Id: I7ebe0b037e3be38f7e33c0160742f829288bb474 Reviewed-on: https://gerrit.libreoffice.org/49938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-23loplugin:includeform: svxStephan Bergmann1-1/+1
Change-Id: I4057fe05983fb2b63b592ffd325894c12b9cb5b2
2017-10-03new loplugin:blockblockNoel Grandin1-8/+4
Change-Id: I7b68b70fa4c7234e8882f7627026959a596968fd Reviewed-on: https://gerrit.libreoffice.org/43025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-21migrate to boost::gettextCaolán McNamara1-2/+1
* all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string") * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching MODULE .mo files * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui goes from l10n target to normal one, so the res/lang.zips of UI files go away * translation via Translation::get(hrc-define-key, imbued-std::locale) * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there to keep finding the .hrc file uniform) so magic numbers can go away there * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation mechanism * en-US res files go away, their strings are now the .hrc keys in the source code * remaining .res files are replaced by .mo files * in .res/.ui-lang-zip files, the old scheme missing translations of strings results in inserting the english original so something can be found, now the standard fallback of using the english original from the source key is used, so partial translations shrink dramatically in size * extract .hrc strings with hrcex which backs onto xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap * extract .ui strings with uiex which backs onto xgettext --add-comments --no-wrap * qtz for gettext translations is generated at runtime as ascii-ified crc32 of content + "|" + msgid * [API CHANGE] remove deprecated binary .res resouce loader related uno apis com::sun::star::resource::OfficeResourceLoader com::sun::star::resource::XResourceBundleLoader com::sun::star::resource::XResourceBundle when translating strings via uno apis com.sun.star.resource.StringResourceWithLocation can continue to be used Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
2017-07-07a11y: assert on switching hatch/bitmap area radio button tab thingsCaolán McNamara1-2/+3
Change-Id: I2525123dfe2c2dedcbf808f5d2f8e054e4c4bdf1 Reviewed-on: https://gerrit.libreoffice.org/39690 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-12remove unused uno::Reference varsNoel Grandin1-2/+0
found by temporarily marking Reference as SAL_WARN_UNUSED. Change-Id: I18809b62654467f890016adcc92576980ced393b Reviewed-on: https://gerrit.libreoffice.org/37511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-10new loplugin:inlinefieldsNoel Grandin1-5/+3
look for fields which can be declared inline in the parent class. start with some likely candidates in svx Change-Id: I56cdca273272b72bb728ed2e3f5e1e976f8c7c32 Reviewed-on: https://gerrit.libreoffice.org/36262 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna1-9/+9
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-14Convert WindowType to scoped enumNoel Grandin1-2/+2
Change-Id: I85cfe02f28729e13f2c0dd3d91cd89e6f3e3b6a9 Reviewed-on: https://gerrit.libreoffice.org/34219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann1-60/+39
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-27loplugin:expandablemethods in svxNoel Grandin1-24/+7
Change-Id: I0d193ddf07cc0ddc89b6ce2df6eb71d44e49b631 Reviewed-on: https://gerrit.libreoffice.org/30295 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-07-27improve passstuffbyref return analysisNoel Grandin1-1/+1
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-01Improve readability of OUString concatanation in SvxPixelCtlAccessibleMuhammet Kara1-6/+5
, SvxShowCharSetVirtualAcc , SvxBmpMask , SvxSuperContourDlg , and SvxTPView It is more readable and more efficient as a bonus. See: https://goo.gl/jsVAwy: Change-Id: Id0641673e1e6fb04b3193c2b8e9a2ab3156b4552 Reviewed-on: https://gerrit.libreoffice.org/26794 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-30Rename GetFoucsPosIndex() to GetFocusPosIndex()Muhammet Kara1-2/+2
Change-Id: Ic05d69976d053037c9d02cf5f8b843c6b590000c Reviewed-on: https://gerrit.libreoffice.org/26803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-06-02drop some more RTL_CONSTASCII_USTRINGPARAMNoel Grandin1-1/+1
Change-Id: I528b0ecb5282178d8e727471beb126cb7d3f2eb4
2016-03-08loplugin:constantparams in vclNoel Grandin1-2/+2
Change-Id: I2114436f4bef3ac71a3035a206186cefaf88bca1 Reviewed-on: https://gerrit.libreoffice.org/23023 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann1-4/+4
Change-Id: I71682f28c6a54d33da6b0c971f34d0a705ff04f5
2015-11-05use uno::Reference::set method instead of assignmentNoel Grandin1-3/+3
Change-Id: I2f8c9cb71a06f7796576509f605796624e654422
2015-10-31com::sun::star->css in svxNoel Grandin1-8/+8
Change-Id: If2c11fa548c5ebef2297d2491edd837b54e3707c Reviewed-on: https://gerrit.libreoffice.org/19690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-30convert Sequence<XInterface> constructions to use initializer listsNoel Grandin1-4/+2
Change-Id: I66475190cc0f18465c56b94af7bc0d5a1ca81242
2015-08-27tdf#92213 - don't crash fetching pixelctl a11y peer for un-parented window.Michael Meeks1-5/+7
Change-Id: Ie36f46e2eae72e8838aa5e45f96bd02fef45f7d5
2015-08-11loplugin: defaultparamsNoel Grandin1-1/+1
Change-Id: I513643385dc0a04b68c5cf4a5f43aa0804e572e6
2015-07-24-Werror,-Wunused-private-fieldStephan Bergmann1-10/+0
Change-Id: Ib32a73e4f74ce7ccd19327ecaed84c16b5c60779
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin1-15/+15
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-02loplugin:staticmethodsNoel Grandin1-1/+1
Change-Id: Ibf0c73ac17ec19ed672f66907db47057920babca
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin1-1/+0
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-23fdo#82577: Handle WindowNoel Grandin1-4/+4
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-08-31Typo: childs->childrenJulien Nabet1-2/+2
Change-Id: Ib27b3e125581884b90efc9cc33b6b2aadab73851
2014-08-25everything is independent from vos these days...Michael Stahl1-2/+0
Change-Id: Iccb94dcc31d6de8c9e4e7a31b3c2e36d4198b295
2014-08-19svx: Cleanup ASCII art and useless commentsChris Laplante1-19/+5
Change-Id: I5399362056276f324fd43eda05d3f606dc6f8c71 Reviewed-on: https://gerrit.libreoffice.org/11011 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-19Resolves: fdo#78841 crash because parent isn't SvxTabPageCaolán McNamara1-2/+5
regression from 60f11adb950e4f9645cc9ecb0f5af8235cc97366 Change-Id: I244dd9fba3dc8230fcac8710a1289151b25dcf6c
2014-04-15svx: sal_Bool->boolNoel Grandin1-9/+9
Change-Id: I464eba5fd5521c31868c6fc8a2137f17428d421e
2014-03-03SVX : Remove usage of DBG_CTOR and DBG_DTOR.Arnaud Versini1-11/+0
Valgrind is capable of detecting such bugs. No need for extra macros. Change-Id: I9f2ab3703feb5c49a831da124e161f98cb1bb3ab Reviewed-on: https://gerrit.libreoffice.org/8419 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann1-57/+57
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26callcatcher: update unused codeCaolán McNamara1-16/+0
Change-Id: I2d79938465800a6bfe8cc120b85dc449ff04a960
2014-02-25mrParentWindow can never be null, simplify around thatCaolán McNamara1-19/+16
Change-Id: Id290343219044aa8e668eb8f2e58b2d3c35a2ac7
2014-02-25pPixelCtl can never be null, which simplifies this a lotCaolán McNamara1-173/+76
Change-Id: Ic1c995794faa682001b472053ae9aebf95f0343b
2014-02-25callcatcher: update unused codeCaolán McNamara1-22/+0
Change-Id: Ia8e6abffb85b92ee4538fb0aeaee4e4aa18f2772
2014-02-24Adapt to osl_atomic_inc-/decrementStephan Bergmann1-2/+2
Change-Id: I848873b07ab05cefdc755a8bf1301907fdfbc299
2014-02-23Remove unneccessary commentsAlexander Wilms1-8/+8
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-21add missing modelinesCaolán McNamara1-0/+3
Change-Id: I1823890217eb11ba4206b9fd28389c633c7c4f89