summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)AuthorFilesLines
2019-08-15loplugin:sequenceloop in svtools..svxNoel Grandin14-23/+22
Change-Id: I81b54f6db69491492b2bc16f48b2296ad96e137d Reviewed-on: https://gerrit.libreoffice.org/77529 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-15replace ".get->" with "->"Noel Grandin1-1/+1
Change-Id: I327a6fda1fe0170da33e06b735f09a39421c8a58 Reviewed-on: https://gerrit.libreoffice.org/77469 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-12Fix typosAndrea Gelmini14-23/+23
Change-Id: I837907cc584b048f7c8f902a857cf0c473d649a5 Reviewed-on: https://gerrit.libreoffice.org/77252 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-07move WizardDialog to vclCaolán McNamara2-644/+0
Change-Id: I93d03601cb429687a9a73b7d28c595e69977bf87 Reviewed-on: https://gerrit.libreoffice.org/76901 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-07move Roadmap to vclCaolán McNamara6-980/+30
Change-Id: I3ddb2a4906351d4134c14a1e9af710c9e7aeb5c6 Reviewed-on: https://gerrit.libreoffice.org/76900 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-07move HyperLabel into vclCaolán McNamara4-212/+7
could this be merged with FixedHyperlink? Change-Id: I00abe4bfa62a55c7b62ccd40e6c0294699317f26 Reviewed-on: https://gerrit.libreoffice.org/76897 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-05Fix typosAndrea Gelmini3-4/+4
Change-Id: I66d48c809b263835016571772ce2ee529c16b8f4 Reviewed-on: https://gerrit.libreoffice.org/76960 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-01tdf#126282 add English (Sri Lanka) [en-LK] 0xA409 to language listEike Rathke1-1/+2
Change-Id: I2b02498684c952f9a6bf8f6bc17a3355c3607aac Reviewed-on: https://gerrit.libreoffice.org/76807 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): svtoolsStephan Bergmann17-145/+145
Change-Id: I4d42441adf5408e0281577078b0d5537acb02513 Reviewed-on: https://gerrit.libreoffice.org/76641 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-26cid#1448414 silence Explicit null dereferencedCaolán McNamara1-1/+1
Change-Id: Ia9ddcf960e2bef2ea8db72018602302dc6914bb5 Reviewed-on: https://gerrit.libreoffice.org/76364 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-25cid#1448414 silence Explicit null dereferencedCaolán McNamara1-0/+1
Change-Id: I8f378b935929cedfab30aa98b89a026c272dca2e Reviewed-on: https://gerrit.libreoffice.org/76246 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-24Fix typoAndrea Gelmini1-1/+1
"an URI", to complete: https://gerrit.libreoffice.org/#/c/75985/ Change-Id: I57489b05117fd12ae6aa22544437ab5bc6b5154f Reviewed-on: https://gerrit.libreoffice.org/76037 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-23dispose() methods should clear their smart pointersNoel Grandin1-0/+1
especiall the ref-counted ones Change-Id: Ib3bb029043b1b923010ef4a47bfc377e1f569da7 Reviewed-on: https://gerrit.libreoffice.org/76102 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-21tdf#125922 rename kde5 to kf5 + plasma5Jan-Marek Glogowski1-6/+2
Just as the gtk3 plugin isn't named GNOME, rename kde5 to kf5, as it is based on the KDE frameworks 5 libraries. This also includes: * a convenience alias to load the kf5 VCL plugin in case someone requests the kde5 plugin. * keep convenience kde5 configure switch, but warn about it * rename detected desktop from kde5 to plasma5 Change-Id: I6764a05b81a5edbf284484c234fee2649aacf735 Reviewed-on: https://gerrit.libreoffice.org/75313 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-21loplugin:referencecasting in slideshow..svtoolsNoel Grandin5-39/+29
Change-Id: Id0f0332d5d66c0bce309643bf42059b9bdc7d448 Reviewed-on: https://gerrit.libreoffice.org/75997 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-19cid#1448488 Unchecked return valueCaolán McNamara1-2/+3
Change-Id: If42c4f2215057120774b4ad7e2755e4e861bd828 Reviewed-on: https://gerrit.libreoffice.org/75898 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-18It's Classical Armenian, not Classic [xcl-AM]Eike Rathke1-1/+1
Change-Id: I1c714c8a9ecfd3cf73e645e1693101e7fce433e4 Reviewed-on: https://gerrit.libreoffice.org/75856 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-07-18cid#1448313 Uninitialized pointer fieldCaolán McNamara1-0/+1
Change-Id: I0e449be3c0ae4cfef88766e189e7255ff45e83f9 Reviewed-on: https://gerrit.libreoffice.org/75800 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-17loplugin:unusedmethodsNoel Grandin1-9/+0
Change-Id: Ie2285f64919d1c83b0a8df4ceb827f731e5cd609 Reviewed-on: https://gerrit.libreoffice.org/75739 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-16tdf#126232 - Button "Address Data Source..." should be renamedHeiko Tietze1-1/+1
Change-Id: Ic26ab5be526d8358e5a377bcf651ae38f6329fd3 Reviewed-on: https://gerrit.libreoffice.org/75683 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-07-16Resolves: tdf#120685 don't show decimal places for pointsCaolán McNamara1-2/+5
unless its been explicitly requested Change-Id: Id9f34b68404cb3bdcaea641583980fa14453f2d1 Reviewed-on: https://gerrit.libreoffice.org/75646 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15Simplify Sequence iterations in svtoolsArkadiy Illarionov28-289/+186
Use range-based loops, STL and comphelper functions Change-Id: I4197b5083327998169a39389b968e1ff99f13339 Reviewed-on: https://gerrit.libreoffice.org/75440 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-07-08use BitmapEx in EmbeddedObjectRef::DrawPaintReplacementNoel Grandin1-1/+1
Change-Id: Ia15a34abaf941ae4af34dbb3cb93a7525a746cd1 Reviewed-on: https://gerrit.libreoffice.org/75215 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-04remove some unneede vcl/bitmap.hxx includesNoel Grandin2-2/+0
Change-Id: Ibdc79538276992193e61f6dc16ddd3fd1ab80b82 Reviewed-on: https://gerrit.libreoffice.org/75069 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-03Remove some unused includesMiklos Vajna1-1/+0
See tdf#42949 for motivation. Change-Id: I89c082d62409b40c8472b865cc60b0d10923c9c1 Reviewed-on: https://gerrit.libreoffice.org/75015 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-25improve loplugin:simplifyconstructNoel Grandin1-1/+1
Change-Id: If863d28c6db470faa0d22273020888d4219e069e Reviewed-on: https://gerrit.libreoffice.org/74559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-25weld HyperLink DialogCaolán McNamara1-1/+1
Change-Id: Ic861b0a593505828a900fe2163125d6f5584a956 Reviewed-on: https://gerrit.libreoffice.org/74634 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-24move SvtIconChoiceCtrl to vclCaolán McNamara5-4679/+0
Change-Id: I5ed8af625cb46998649c4f11255d7676a11bdc94 Reviewed-on: https://gerrit.libreoffice.org/74605 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-21simplify some getSupportedServiceNamesNoel Grandin2-3/+2
Change-Id: I81195505d6006b6587f7b98c1545919083f0e588 Reviewed-on: https://gerrit.libreoffice.org/74497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-21Extend INetURLObject::setName and drop INetURLObject::SetNameMike Kaganski2-3/+3
Change-Id: I488313eeb363d2a9344d6bc801900d5b1f913020 Reviewed-on: https://gerrit.libreoffice.org/74463 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-06-21Drop INetURLObject::GetName and INetURLObject::GetExtensionMike Kaganski1-1/+2
They are just synonyms for GetLastName and GetFileExtension resp. Change-Id: Ic498c7025cc421b830394ed94d64529fd74fe7dd Reviewed-on: https://gerrit.libreoffice.org/74448 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-06-18loplugin:passstuffbyrefNoel Grandin1-1/+1
Change-Id: Icb7c22cf4ac95eab54d04e79312fb471ca27bceb Reviewed-on: https://gerrit.libreoffice.org/74246 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-18loplugin:logexceptionnicely in svtoolsNoel Grandin8-26/+33
Change-Id: I631f3750af2e9a26d0a034f5a22d5b0c2910325c Reviewed-on: https://gerrit.libreoffice.org/74142 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-17Add comphelper::getUnoTunnelImplementation templateArkadiy Illarionov3-4/+4
Use it instead of classname::getImplementation from UNO3_GETIMPLEMENTATION_* Change-Id: Ifcc8cfcd6369c576250008c76ce31ba79ea3a596 Reviewed-on: https://gerrit.libreoffice.org/74107 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-12Revert "improve empty tools::Rectangle (width)"Noel Grandin1-3/+3
This reverts commit a46a257794f1f53b294735fc876c394be23a3811. Too many issues, I'm going to try landing this in smaller pieces to make it easier to fix regressions Change-Id: Ie5e8979838017af86c119c887b580385ba068d54 Reviewed-on: https://gerrit.libreoffice.org/73859 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-11vcl: prefix members of SvImpLBoxMiklos Vajna1-179/+179
Change-Id: Ida7ca49ee99cf13029c6a1cb84b8d3b7ffe44ed7 Reviewed-on: https://gerrit.libreoffice.org/73799 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-06-08loplugin:unusedfieldsNoel Grandin1-7/+0
Change-Id: I9758fd606c7d4c251a3ac06661d642a47260b5fc Reviewed-on: https://gerrit.libreoffice.org/73674 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-07improve empty tools::Rectangle (width)Noel Grandin1-3/+3
This is the width part, the height part will come next. Instead of storing "empty" as a special value (which is easy to get wrong, eg. some image filters pass in that special value, expecting it to be a valid width), just use separate boolean values for width and height empty. Also lots of code was calling GetBottom() or GetRight() on an empty rectangle, getting back that magic value and doing calculations on it, resulting in completely bogus data. So (1) make the various Rectangle methods do something reasonable when the empty flags are set (2) fix various other code to handle empty better (3) assert when code accesses Bottom or Right and the empty flag is set. Change-Id: I1163378cd2773dd8b386210f83400bb6b4701069 Reviewed-on: https://gerrit.libreoffice.org/73564 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-07tdf#42949 Fix IWYU warnings in svl/Gabor Kelemen1-0/+1
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Except source/svdde/* which is WIN-specific Also recheck include/svl Change-Id: I32d3bcb6b14665c56c07a2f10526329b08c64cbe Reviewed-on: https://gerrit.libreoffice.org/73630 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-07tabbar: make ImplFormat more readableTomaž Vajngerl1-12/+15
Change-Id: Id9a188fc46d800212ff583a233f06553bf1b4596 Reviewed-on: https://gerrit.libreoffice.org/73591 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-06-04tdf#39593 remove IMPL_XUNOTUNNEL* macrosArkadiy Illarionov1-1/+1
Replace with UNO3_GETIMPLEMENTATION* macros. Replace single usage of IMPL_XUNOTUNNEL_MINIMAL with it's body. Change-Id: I7d4ad76399b999ebb2178ecf57edcf6bd2aa6c3e Reviewed-on: https://gerrit.libreoffice.org/73424 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-31tdf#124572 Reduce tab bar item widthTomaž Vajngerl1-1/+3
The width of an tab item is now reduced and is increased by the icon width when the protected icon needs to be drawn (so on demand). Change-Id: Ib4a4742b28ebab21d33e9408e3c416b1f28c6ac2 Reviewed-on: https://gerrit.libreoffice.org/73208 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-05-28Fix domain in ui files (sfx2, svtools)Julien Nabet2-2/+2
Change-Id: Icfa8a2d2f6283b0961aa99debadf1e3d29ddaa53 Reviewed-on: https://gerrit.libreoffice.org/73068 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-24Avoid broken static_castStephan Bergmann2-10/+20
...from SvtValueItemAcc to unrelated ValueItemAcc in ~SvtValueSetItem. The Svt* classes had been copied from the non-Svt* ones in 4883fd31141c3598b25a123033297f847cd18552 "weld ScTabBgColorDlg", but this static_cast had apparently been missed when copying ~SvtValueSetItem from ~ValueSetItem (and the originally copied SvtValueItemAcc::ParentDestroyed had later been removed with d4d037619638e1915d15dba81c38a1c9b3157972 "loplugin:unusedmethods"). But the static_cast in ~ValueSetItem would never have been necessary in the first place (though that needs partial reversal of 508c95f1b655d9cfa6be37a5a9de9aff6fd383bf "improve passstuffbyref return analysis", which had unhelpfully changed ValueSetItem::GetAccessible to return a reference). Change-Id: If1c9bb617ac4ad3c24371729504f9082594c048f Reviewed-on: https://gerrit.libreoffice.org/72914 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-22New loplugin:dataStephan Bergmann1-2/+2
...following up on 1453c2c8f13bac64ecd1981af7cebf1c421808ac "prefer vector::data to &vector[0]" Change-Id: I7c113747d92d144a521d49b89384dd8bf1215c01 Reviewed-on: https://gerrit.libreoffice.org/72765 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-20calc item width on requestCaolán McNamara1-3/+2
Change-Id: Ifa56a903b3c3a3962fd2ecf76ff101976e17fc05 Reviewed-on: https://gerrit.libreoffice.org/72600 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-20split width/height to allow intercept of how width is calculatedCaolán McNamara2-12/+16
in order to possibly get width on demand Change-Id: I1e6fcb6849705f2b166821516ebe72b179e00ee7 Reviewed-on: https://gerrit.libreoffice.org/72513 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-19Fix typoAndrea Gelmini1-2/+2
Change-Id: Iaf8b25dea7251ce535903ed24581ba80c5ac217f Reviewed-on: https://gerrit.libreoffice.org/72567 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-18remove remaining '0' responsesCaolán McNamara1-1/+1
Change-Id: I3134c8dcc92b82ab2c6008b3e39443a360f576eb Reviewed-on: https://gerrit.libreoffice.org/72499 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-17weld SvxIMapDlgCaolán McNamara2-3/+1
Change-Id: I5418176a015e61ef8eee4c2acd8e84b008f76f82 Reviewed-on: https://gerrit.libreoffice.org/72249 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 07:45:44 +0000