summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)AuthorFilesLines
2019-12-05Add a comment telling what "frame margin" means hereTor Lillqvist1-0/+1
Change-Id: Ie6d088217c066ec3091fb28925947175cf62634f (cherry picked from commit 21b68c4cd7ce108cf334607ced0b20e7b5914c20) (cherry picked from commit 51794501045a6f8b0f6f1c04b6aee2e28647b4ea) Reviewed-on: https://gerrit.libreoffice.org/84531 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-11-28don't put focus into unmapped windowsCaolán McNamara1-6/+7
defer until the color selectors are activated to grab focus, otherwise esc doesn't work to close a dialog under gtk3 until focus is put into some visible widget Change-Id: I297c2738c4103024bbefd70bbcb5d72b8429dd3e Reviewed-on: https://gerrit.libreoffice.org/83917 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e55a1dc163165cb79fc9113101d16ee8d3db7298) Reviewed-on: https://gerrit.libreoffice.org/83966
2019-11-19Resolves: tdf#128855 Add Kabardian [kbd-RU] to language listEike Rathke1-1/+2
Change-Id: I84cfc3aa3f018de1d6950617fe2a06402ce2ac2b Reviewed-on: https://gerrit.libreoffice.org/83103 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit b4008306febc147e9f8a3c91102304ec40671a07) Reviewed-on: https://gerrit.libreoffice.org/83174
2019-11-08loplugin:stringadd (clang-cl)Stephan Bergmann1-4/+2
Change-Id: Icf2894f77c90aa4620910d621249947bad4be8b7 Reviewed-on: https://gerrit.libreoffice.org/82269 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-07loplugin:unusedmethodsNoel Grandin2-42/+0
Change-Id: I65354c7476dfaede1a607441d7c1b0c7ad038df4 Reviewed-on: https://gerrit.libreoffice.org/82186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06loplugin:indentation find broken if statementsNoel Grandin2-2/+2
so I don't read the "then" block as being a sequential statements Change-Id: Ib2004acd3518bd4ebd2246f02a26c2c0a8bbab4c Reviewed-on: https://gerrit.libreoffice.org/82069 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-04move VCLXProgressBar to toolkitCaolán McNamara2-309/+0
Change-Id: I3aa21aff97346a9a43ad7b25621e8a8733fc4041 Reviewed-on: https://gerrit.libreoffice.org/82004 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-04move VCLXFixedHyperlink creation to toolkitCaolán McNamara1-14/+0
Change-Id: I3aa47a194f2b10b15faaa142c7dc6d57dffff96e Reviewed-on: https://gerrit.libreoffice.org/82002 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31setting has-default true on an element in a GtkPopover is fatalCaolán McNamara1-2/+2
in gtk 3.24.12 at least. in ColorWindow explicitly track which button is the 'default' one for the two modes instead of using get/use-default and then just grab_focus instead of setting has-default for these popover cases Change-Id: Ia226f847f666d2356c6ea4e8c47f5db8e2535410 Reviewed-on: https://gerrit.libreoffice.org/81834 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31Fix StringAdd::isCompileTimeConstantStephan Bergmann1-2/+2
...to find StringLiteral on the RHS of +=. Which revealed that the VisitCompoundStmt/checkForCompoundAssign logic needed to be fixed, too, so that s += side_effect(); s += "literal"; s += side_effect(); only gets combined to s += side_effect() + "literal"; s += side_effect(); and not all the way to s += side_effect() + "literal" + side_effect(); Change-Id: I432e3458b933a7d0ad6141c747b675cc8b0f0ba4 Reviewed-on: https://gerrit.libreoffice.org/81804 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-29remove unnecessary includesCaolán McNamara2-3/+2
Change-Id: Ia4a622b34ff3f71963cff7a1aa8658a4df12f04f Reviewed-on: https://gerrit.libreoffice.org/81676 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29SvtURLBox not used in any .ui files anymoreCaolán McNamara1-12/+0
Change-Id: I03802d3345ce29f52d026f2638cb19d6209cd9e2 Reviewed-on: https://gerrit.libreoffice.org/81495 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29weld fpicker clusterCaolán McNamara2-6/+50
Change-Id: I6566263809ff0032388a0b56571f0cf7428058d7 Reviewed-on: https://gerrit.libreoffice.org/81334 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-28svl: HTMLParser: stop inserting control character garbage into WriterMichael Stahl1-4/+15
E.g. rhbz433940-1.html contains literal ^G characters that are inserted as-is into SwTextNodes. This now triggers assert about CH_TXT_ATR_FIELDSTART in SwSubFont::GetTextSize_() that was added in 19a559b0ec9b806519c405651d6d2b2e14712b4a. Change-Id: I6aa7de41a04069e15b40865fd57894dae0fc10db Reviewed-on: https://gerrit.libreoffice.org/81606 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2019-10-25tdf#42949 Fix IWYU warning in include/vcl/window.hxxGabor Kelemen1-0/+1
The boost/property_tree/ptree.hpp added in commit 75b8db7fa7344a679d3c5dbdc8c5bd4228cdbc7c turns out to be rather expensive: it adds about 900 kB per compilation unit and window.hxx is included in about 2600 compilation units Replacing it with forward declaration header has reduced total includebloat from 26.1 Gb to about 22.7 Change-Id: I797608b54a62a5838c7a5d47355fb6bd736ad36c Reviewed-on: https://gerrit.libreoffice.org/81500 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-24lok: valueset: dump as property tree the selected itemHenry Castro1-1/+4
The client side requires the data of the selected item to apply CSS border styles. Change-Id: I19f662329e4cfce45e32f82dcf9398dc9c3ecaec Reviewed-on: https://gerrit.libreoffice.org/81421 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2019-10-23lok: svtools: change parameter from "ID" to "POS" in ValueSetUIObject classHenry Castro2-3/+3
The ValueSet control has an item list with a pair properties "(pos,id)". The "POS" parameter is the item "ID" not the position in the list and to not modify doc_sendDialogEvent function, let's have same uniform parameter for the action "SELECT". Change-Id: I5ce2cf0433bebcd77954f271c4aa09b0b446c0ab Reviewed-on: https://gerrit.libreoffice.org/81399 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2019-10-23lok: svtools: create ValueSetUIObject classHenry Castro6-1/+145
The ValueSet control is used in Layouts panel inside Sidebar of the impress document. Once the LO server sends the UI data to the client side that is transformed to mobile view using Mobile Wizard framework. The loleaflet client side has to send commands for the user interactions like to touch an item. e.g. Send "WindowId SELECT ID=300" The unit test simulates the scenario, so the ValueSet control executes the action. Change-Id: Ib6ec5db6ce2777e819f81a9dae74c4641bb7053b Reviewed-on: https://gerrit.libreoffice.org/81141 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/81354 Tested-by: Jenkins
2019-10-21move AutocompleteEdit to fpickerCaolán McNamara2-108/+0
Change-Id: I00b1b4f21ffcb183d098b8af296e1dea64a2a482 Reviewed-on: https://gerrit.libreoffice.org/81177 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-21loplugin:virtualdead unused param in ITableRendererNoel Grandin3-10/+7
Change-Id: I008ff69494af305485a022def72a14a04b26a19e Reviewed-on: https://gerrit.libreoffice.org/81183 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-18lok: dump as property tree the valueset controlHenry Castro1-0/+22
In order to create a container element at client side dialog using DialogWizard. It is required to send the items of the valueset control. Change-Id: Ib0fdc444c7126e6888e37c8a01f8e7f04c641d18 Reviewed-on: https://gerrit.libreoffice.org/81042 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2019-10-18make bin/update_pch.s always include code in trivial #if'sLuboš Luňák1-27/+30
E.g. #ifdef LIBO_INTERNAL_ONLY is always true for code that builds with our PCHs. Change-Id: I3cf311ea3621b909105754cfea2cb0116b8b67f5 Reviewed-on: https://gerrit.libreoffice.org/80961 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-17ODocumentInfoPreview not in any .ui filesCaolán McNamara1-3/+0
Change-Id: I8875a5b39e5a27df8b365e268bb2aab3c42300a4 Reviewed-on: https://gerrit.libreoffice.org/80959 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-17Rename OUStringLiteral1 to OUStringCharStephan Bergmann2-4/+4
It started out as a wrapper around character literals, but has by now become a wrapper around arbitrary single characters. Besides updating the documentation, this change is a mechanical for i in $(git grep -Fl OUStringLiteral1); do sed -i -e s/OUStringLiteral1/OUStringChar/g "$i"; done Change-Id: I1b9eaa4b3fbc9025ce4a4bffea3db1c16188b76f Reviewed-on: https://gerrit.libreoffice.org/80892 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-16loplugin:bufferadd loosen some constraintsNoel Grandin1-3/+2
and extend O*StringView to have a constructor that takes a pointer and a length Change-Id: I6120e96280f030757e855a6596efdae438b7e1e8 Reviewed-on: https://gerrit.libreoffice.org/80872 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-14loplugin:stringadd look for unnecessary temporariesNoel Grandin1-2/+2
which defeat the *StringConcat optimisation. Also make StringConcat conversions treat a nullptr as an empty string, to match the O*String(char*) constructors. Change-Id: If45f5b4b6a535c97bfeeacd9ec472a7603a52e5b Reviewed-on: https://gerrit.libreoffice.org/80724 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-10convert WriteCharPtr..getStr to WriteOStringNoel Grandin2-18/+18
and improve the WriteOString method, we can avoid the strlen here, we already have the length One change in behaviour to be noted - if the string contains trailing zero bytes, which ARE INCLUDED IN THE STRING LENGTH, i.e. I'm not talking about the normal terminating zero, then this patch changes behaviour because we will now write those zeros to the stream. Change-Id: I4668b9b9eb877f820b1dc70d6cd10ba2623bc0a2 Reviewed-on: https://gerrit.libreoffice.org/80597 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-07SvSimpleTableContainer is now unusedCaolán McNamara4-487/+0
Change-Id: I7762d95290a0b35de4f909895a4e28b52c436ed9 Reviewed-on: https://gerrit.libreoffice.org/80307 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05FileControl can be private inside svtoolsCaolán McNamara3-2/+74
Change-Id: I52edd5166edc9aceeafffed898835fe5bc46880c Reviewed-on: https://gerrit.libreoffice.org/80232 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05move file picker only code to fpickerCaolán McNamara11-3672/+61
Change-Id: I47cc2cb7db396a06a2abeffe4a5d40a039f21c58 Reviewed-on: https://gerrit.libreoffice.org/80222 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04SvtFileView not referenced in any .uis anymoreCaolán McNamara1-14/+0
through the fpicker constructs one directly Change-Id: Ic365231e78ca9425b97006a156273479d104eae9 Reviewed-on: https://gerrit.libreoffice.org/80211 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04find-unneeded-includes: ignore extra recommendationsGabor Kelemen1-6/+0
When IWYU is used to check cxx files it also checks associated hxx (but for .hxx -> .h too) files too and gives addition/removal recommendations There is no documented way of disabling this. Currently f-u-i does not differentiate between recommendations for the checked file and its header and prints everything. Which means sometimes I need to update .hxx files or blacklist warnings that interestingly are not shown when the same .hxx is checked with IWYU. The worst example is ucb/source/ucp/ftp/curl.hxx where IWYU gives recommendations for /usr/include/x86_64-linux-gnu/curl/curl.h Remedy this with considering the full filename + should add these lines: / should remove these lines: string as beginning of interesting recommendations Also remove some now obsolete blacklist entries from yaml files Change-Id: I1d139536992e4b56c699c31a4cc6491d373c2002 Reviewed-on: https://gerrit.libreoffice.org/80172 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-03loplugin:unusedmethodsNoel Grandin1-22/+0
Change-Id: I9790d053248ae6bd58ecc026c774014c4e5e04aa Reviewed-on: https://gerrit.libreoffice.org/80115 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-02move Breadcrumb to sole user in fpickerCaolán McNamara2-294/+0
Change-Id: I2028f921e78611698e82e50a652b67dba1ece909 Reviewed-on: https://gerrit.libreoffice.org/80054 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-02loplugin:stringadd in svtoolsNoel Grandin7-26/+14
Change-Id: Ic085990173051f421d1ffc7914574cb63a7ae21d Reviewed-on: https://gerrit.libreoffice.org/79982 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-01loplugin:stringconstant (clang-cl)Stephan Bergmann1-1/+1
Change-Id: Id1a82cea4444255fdb693e126b7571a406094624 Reviewed-on: https://gerrit.libreoffice.org/79916 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-26loplugin:virtualdead in vclNoel Grandin2-14/+0
Change-Id: I54cacce6d843f41f220ac5350868bd6d70dbc6b4 Reviewed-on: https://gerrit.libreoffice.org/79585 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-26survive focus change during disposeCaolán McNamara1-0/+3
Change-Id: I34b5941b01bc0880945aaae39e0b7c4beb4e0575 Reviewed-on: https://gerrit.libreoffice.org/79559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26drop unnecessary includes and update pchCaolán McNamara1-1/+1
Change-Id: Id7fa7d5b95c32fdc738a18208eb95eaec102d937 Reviewed-on: https://gerrit.libreoffice.org/79523 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26disinherit OWizardPage and SfxTabPage from vcl TabPageCaolán McNamara4-63/+30
Now that there's no need to support weld/unwelded mixes of pages in dialog any more. inherit from a BuilderPage which contains a Builder and Toplevel container BuilderPage Activate and Deactivate replace TabPage ActivatePage and DeactivatePage, allowing disambiguation wrt SfxTabPage ActivatePage and DeactivatePage. Change-Id: I5706e50fd92f712a25328ee9791e054bb9ad9812 Reviewed-on: https://gerrit.libreoffice.org/79317 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23tdf#39593 use getUnoTunnelImplementationArkadiy Illarionov1-8/+4
Change-Id: I78eb67913a568c610e38e5002f914773c4906dfd Reviewed-on: https://gerrit.libreoffice.org/79350 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-09-23do not require $(SRCDIR) in every gb_Library_set_precompiled_headerLuboš Luňák1-1/+1
Change-Id: I7b3a22584bb2e4d501f509ffcd80929feed23a4c Reviewed-on: https://gerrit.libreoffice.org/79360 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-21wizdlg only needed in vcl nowCaolán McNamara1-1/+1
Change-Id: I87d14fff339d18088795a876e2bf6c818b1674e3 Reviewed-on: https://gerrit.libreoffice.org/78973 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20drop newly unnecessary OGenericUnoDialog::DialogCaolán McNamara3-42/+41
Change-Id: If047d08cea93fdfacff9ee00c69cf57ba08c916c Reviewed-on: https://gerrit.libreoffice.org/78972 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20m_xVclDialog now unusedCaolán McNamara1-24/+1
Change-Id: I12c11451af5c5c9fe0d635a077eee0c57c6aa14f Reviewed-on: https://gerrit.libreoffice.org/78971 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20make WizardShell use RoadmapWizardMachineCaolán McNamara7-59/+57
Change-Id: Id7e1e163f17cd4866c37bbd6cad73b8c721f4dae Reviewed-on: https://gerrit.libreoffice.org/78969 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-19tdf#42949 Fix IWYU warnings in svtools/Gabor Kelemen110-292/+43
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ifc70900022efcd089c0874bd46e0aacaef0efb72 Reviewed-on: https://gerrit.libreoffice.org/78767 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-18The menu is called 'Form', not 'Forms'Andras Timar1-1/+1
Change-Id: I216e04bb54319cff5d790c5e223c6e49215d09a3 Reviewed-on: https://gerrit.libreoffice.org/79094 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-09-17move GetStandardText to stdtext.hxxCaolán McNamara1-2/+2
Change-Id: Iaf9b5107cf88390f62d5ca94bf985c77bcb8b7ad Reviewed-on: https://gerrit.libreoffice.org/79048 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-17weld DirectSQLDialogCaolán McNamara1-11/+14
Change-Id: I8f97068bb38a1fb888d60251f8f25506044c8451 Reviewed-on: https://gerrit.libreoffice.org/78970 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 05:50:54 +0000