summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)AuthorFilesLines
2017-10-30loplugin:constantparam in vclNoel Grandin1-1/+1
Change-Id: Ic32e4098dcdae5ca5d7fe2749badedabda86a90d Reviewed-on: https://gerrit.libreoffice.org/44043 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-28Related tdf#95694: Enable papersize & orientation listboxesKatarina Behrens1-1/+4
when called from File > Printer Properties > Properties. Anything else doesn't make sense, user opens this dialog in order to be able to edit the settings Change-Id: I9559829551e6d6144da972757ab98afa5696bbfa Reviewed-on: https://gerrit.libreoffice.org/43823 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-26vcl: make MapMode constructor explicitMichael Stahl16-45/+49
Insert constructor everywhere, except a couple places that apparently want to compare GetMapUnit(). Change-Id: I1910deb60562e5e949203435e827057f70a3f988
2017-10-26rename createOnShotInstance->createOneShotInstanceNoel Grandin1-3/+3
Change-Id: I8848784cd867714019f90bb7fc57ca7289e51f81 Reviewed-on: https://gerrit.libreoffice.org/43873 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-26Use the canonical abbreviation "pc" of pica, instead of "pi"Takeshi Abe1-1/+1
like as fixed at 8a5b178eb9f680fadcc8faa2e277623e8304b723. This change affects e.g. the string of the tooltip appearing when changing document margin in Writer by dragging ruler, after choosing pica as the unit in context menu. Change-Id: I55d2cea8b30016e2578c6a112f54e26d62741b44 Reviewed-on: https://gerrit.libreoffice.org/43819 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-10-26Refactor font substitute removing (vcl/svtools)Julien Nabet1-4/+1
+ replace list by vector for maFontSubstList Change-Id: I4d5668611212358c759fa5cf26f5341311551298 Reviewed-on: https://gerrit.libreoffice.org/43855 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-26Fix memory leakTakeshi Abe2-5/+5
Change-Id: I2638a8440601264ff00221ead28a71c891abae16 Reviewed-on: https://gerrit.libreoffice.org/43860 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-24loplugin:finalclasses in svtoolsNoel Grandin5-53/+38
Change-Id: I596342a3d32e116ac5994b60a5bd8717d4f6a5dd Reviewed-on: https://gerrit.libreoffice.org/43733 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-24tdf#113368: fix crash when closing dialog opened with BasicJulien Nabet1-0/+2
See bt https://bugs.documentfoundation.org/attachment.cgi?id=137222 3 0x00007fffebe196b7 in vcl::Window::GrabFocus() (this=0x0) at /tinderbox/buildslave/source/libo-master/vcl/source/window/window.cxx:3003 4 0x00007fffee473602 in FileControl::GetFocus() (this=0x28760b0) at /tinderbox/buildslave/source/libo-master/svtools/source/control/filectrl.cxx:177 5 0x00007fffebe1c99b in vcl::Window::CompatGetFocus() (this=0x28760b0) at /tinderbox/buildslave/source/libo-master/vcl/source/window/window.cxx:3694 6 0x00007fffebd62672 in vcl::Window::ImplGrabFocus(GetFocusFlags) (this=0x28760b0, nFlags=GetFocusFlags::NONE) at /tinderbox/buildslave/source/libo-master/vcl/source/window/mouse.cxx:377 7 0x00007fffebe196b7 in vcl::Window::GrabFocus() (this=0x28760b0) at /tinderbox/buildslave/source/libo-master/vcl/source/window/window.cxx:3003 8 0x00007fffebe0bfc5 in vcl::Window::dispose() (this=0x28778b0) at /tinderbox/buildslave/source/libo-master/vcl/source/window/window.cxx:449 9 0x00007fffebe6536c in Control::dispose() (this=0x28778b0) at /tinderbox/buildslave/source/libo-master/vcl/source/control/ctrl.cxx:65 10 0x00007fffebe6a4b6 in Edit::dispose() (this=0x28778b0) at /tinderbox/buildslave/source/libo-master/vcl/source/control/edit.cxx:265 11 0x00007fffebfa5ac0 in VclReferenceBase::disposeOnce() (this=0x2877bc8) at /tinderbox/buildslave/source/libo-master/vcl/source/outdev/vclreferencebase.cxx:42 12 0x00007fffee41f948 in VclPtr<Edit>::disposeAndClear() (this=0x28762c0) at /tinderbox/buildslave/source/libo-master/include/vcl/vclptr.hxx:208 13 0x00007fffee472f0e in FileControl::dispose() (this=0x28760b0) at /tinderbox/buildslave/source/libo-master/svtools/source/control/filectrl.cxx:89 Change-Id: I97fd3679a8692893047c22ff3e452a5c3e3f25c3 Reviewed-on: https://gerrit.libreoffice.org/43731 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-23loplugin:includeform: svtoolsStephan Bergmann37-53/+53
Change-Id: I7a25c2db8c097ae4512c8a8b7d8a272905b46e50
2017-10-23overload std::hash for OUString and OStringNoel Grandin2-2/+2
no need to explicitly specify it anymore Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec Reviewed-on: https://gerrit.libreoffice.org/43567 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-21loplugin:redundantcast handle dynamic_castNoel Grandin1-9/+2
Change-Id: I7855c76e820efce96778b1c19ec71dffcc4b4abb Reviewed-on: https://gerrit.libreoffice.org/43621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-20svtools: SvTreeListEntry's copy ctor is unnecessaryTakeshi Abe1-13/+0
Change-Id: Idce8773d96e30dacfc9ce13fdb9b399c2a8bf341 Reviewed-on: https://gerrit.libreoffice.org/43485 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-18use std::unique_ptr in SvTreeListNoel Grandin1-39/+34
Change-Id: Ibfba32d6855532aeb42c45f493a4f01f7d0cd4ee Reviewed-on: https://gerrit.libreoffice.org/43475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-06use rtl::Reference in SvXMLEmbeddedObjectHelperNoel Grandin1-22/+18
instead of manual ref-counting Change-Id: I559ebb3871dd3dd4a160bd83a259e36dd2f7b4d6 Reviewed-on: https://gerrit.libreoffice.org/43200 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-06Revert "remove handing of deprecated Storage path option"Noel Grandin1-7/+7
This reverts commit b71fdc67ed1efd421b9b1c747708958e8e09f73c. since Jochen indicates that there is a bug in it Change-Id: I786a7885a308cb43b99d9930ed385a75bbcd9495 Reviewed-on: https://gerrit.libreoffice.org/43192 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-05remove handing of deprecated Storage path optionJochen Nitschke1-7/+7
The only user of StoragePath was TemplateFolderCacheImpl::openCacheStream which uses TempPath for the cache file now. Change-Id: Ia21b5aa804222f28a3af3779a0ecc4789c1860b3 Reviewed-on: https://gerrit.libreoffice.org/41087 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-04add << operator for css::uno::ExceptionNoel Grandin8-44/+38
Change-Id: Ia23dafd07133779144965682df3b7125a3214235 Reviewed-on: https://gerrit.libreoffice.org/43046 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-03convert TPB_DISPLAY_NAME constants to scoped enumNoel Grandin1-5/+5
Change-Id: I0e4f9ce3392e48fc82c232ba3e6581f3b0d9af9f Reviewed-on: https://gerrit.libreoffice.org/43083 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-03new loplugin:blockblockNoel Grandin1-5/+3
Change-Id: I7b68b70fa4c7234e8882f7627026959a596968fd Reviewed-on: https://gerrit.libreoffice.org/43025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-01simplify some OUString compareTo callsMuhammet Kara1-1/+1
to either startsWith or == or != Change-Id: I595dd9d89d32134827980c4ba10f88584430137d Reviewed-on: https://gerrit.libreoffice.org/42988 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-01Resolves: tdf#112656 don't reset to default font if a custom font was setCaolán McNamara1-5/+2
the list has been laid out with the smaller custom font, including calculating the bounding box of the entry, then rendered with the default larger font Change-Id: I2ae569c9857d4e1016cbf55da4c3334c63dcf5f6 Reviewed-on: https://gerrit.libreoffice.org/42910 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-09-30Translate German comments and debug strings (leftovers)Johnny_M1-1/+1
Change-Id: I4ab8fbae47037f6e21c51713d1c51aaa5dc61f40 Reviewed-on: https://gerrit.libreoffice.org/42967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-29WB_MOVEABLE should not trigger tearoff modeMaxim Monastirsky1-1/+1
As any .ui based docking window gets it unconditionally, see extractDeferredBits function in builder.cxx. Change-Id: I339a72989ad09d8ea7106f5690fc950ee7ba35da
2017-09-28Remove dead code behind Calc "Live Data Streams" dialog's "scriptdata" buttonStephan Bergmann1-1/+1
...that has been disabled and hidden ever since 4c90ed782a09e2e4b8738b82028032c42d1a203d "Actually hide these two radio buttons (since there is no choice now)." This removes the sole user of SvScriptStream. (Unfortunately, removing the no longer needed #include <osl/process.h> from include/tools/stream.hxx triggered an avalanche of missing includes elsewhere.) Change-Id: I7b0e683b14c0eaf7f4737f62adc9d691826380c0 Reviewed-on: https://gerrit.libreoffice.org/42916 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-09-26Rename the basegfx::tools namespace to basegfx::utilsTor Lillqvist1-1/+1
Reduce potential confusion with the global tools namespace. Will hopefully make it possible to remove the annoying initial :: when referring to the global tools namespace. Unless we have even more tools subnamespaces somewhere. Thorsten said it was OK. Change-Id: Id088dfe8f4244cb79df9aa988995b31a1758c996 Reviewed-on: https://gerrit.libreoffice.org/42644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2017-09-26tdf#49634 Fix positioning of focus rectangle in Navigator content treeJim Raykowski1-0/+2
https://bugs.documentfoundation.org/show_bug.cgi?id=49634 Change-Id: I3beb41142281b2cda337b457ed287a2cc1f665a6 Reviewed-on: https://gerrit.libreoffice.org/42364 Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-09-24tdf#106762 Base SvxColorToolBoxControl on svt::PopupWindowControllerMaxim Monastirsky1-0/+13
This allows us to support tearoff without breaking gtk3/wayland. SvxColorWindow no longer inherits from FloatingWindow, so several call sites need also to be changed to use DockingManager. Change-Id: I5d0bc611bbd2a8b9bfd4335212d0ae7e8fc10593
2017-09-23loplugin:flatten in svl..svxNoel Grandin2-40/+32
and implement a check in the plugin to prevent us modifying the same patch of source code twice. This logic should probably be moved into plugin.cxx at some point. Change-Id: I7ebff6424cc8733bb2c8f7dba75eaaec68649290 Reviewed-on: https://gerrit.libreoffice.org/42660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-22Check availability of XPageCursorEike Rathke1-1/+1
Change-Id: I458655d52992e40c2330ec10628fcea0fdc00f76 Reviewed-on: https://gerrit.libreoffice.org/42655 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22GetGraphicSource: use DocumentToGraphicRenderer::isShapeSelected()Eike Rathke1-9/+2
Change-Id: I50852360a29b4d5fd08277fcb2198f7956f9ebe0 Reviewed-on: https://gerrit.libreoffice.org/42654 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22Introduce DocumentToGraphicRenderer::isShapeSelected()Eike Rathke1-0/+24
Change-Id: I66fc0e39a7a35969b937253c88326516949ea7e7 Reviewed-on: https://gerrit.libreoffice.org/42653 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-22Fresh run of bin/update_pch.shMike Kaganski1-19/+30
Change-Id: I69d4157aaf6570cecd51ea59df20556914942e06 Reviewed-on: https://gerrit.libreoffice.org/42565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-22Ditch now unused GraphicExportDialog, GraphicExportOptionsDialogEike Rathke5-397/+0
That was a dead end anyway, trying to partly reimplement SvFilterOptionsDialog ExportDialog, instead of implementing the necessary bits to use that one which has everything. Change-Id: Icde7422f2c2d7e26c07dfe921a4abda41e222b09 Reviewed-on: https://gerrit.libreoffice.org/42503 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-09-22Bin obsolete commentTor Lillqvist1-2/+0
Change-Id: Id3a3fd5317aef2acdc30605f816c2656990a94b6
2017-09-21Rename GetSelectEntryPos -> GetSelectedEntryPosSamuel Mehrbrodt7-22/+22
Change-Id: I0bd4cb463575af843c72d9c8aaf91742203532a4 Reviewed-on: https://gerrit.libreoffice.org/42283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-21Rename GetSelectEntry -> GetSelectedEntrySamuel Mehrbrodt4-10/+10
Change-Id: Ibb7d8c59c0e61b0e87455bd78f241d8691dd9dce Reviewed-on: https://gerrit.libreoffice.org/42282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-20unused aDDLastRectPos in SvxIconChoiceCtrl_ImplNoel Grandin2-2/+1
since commit bf2373daf50595c02741f63d941fda0462535d62 Date: Tue Jul 26 23:32:40 2011 +0200 callcatcher: remove unused methods Change-Id: I2eef2bdcd40d4b4b1da8cf7ca95b0194ea99216f
2017-09-19Writer export to PNG,JPG: switch to proper SvFilterOptionsDialogEike Rathke1-0/+3
With all bells and whistles, instead of the crude size/dpi JPG dialog even for PNG. Change-Id: I695a78643e07900822ec9253ac818efd52339cc0 Reviewed-on: https://gerrit.libreoffice.org/42498 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19Call getCurrentPageWriter() only for WriterEike Rathke1-1/+5
Change-Id: I81dd61c33a0bc69e43d3325b297c44e5b7b732bd Reviewed-on: https://gerrit.libreoffice.org/42496 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19Detect Writer doc independent of selection, we'll need that laterEike Rathke1-8/+17
Change-Id: Ieddbcd3e8b750ec4b32643aec0433f8638ee46ee Reviewed-on: https://gerrit.libreoffice.org/42495 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19DocumentToGraphicRenderer: suppress selection for Writer, it doesn't workEike Rathke1-0/+14
See FIXME comment. Change-Id: I7511f5b498029fedcbd0c39d5ec67288782330ae Reviewed-on: https://gerrit.libreoffice.org/42493 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19DocumentToGraphicRenderer: current page is 1 if selectionEike Rathke1-7/+4
Change-Id: I0d26cd4da6f39c27b06df53596f9f405c5b0771f Reviewed-on: https://gerrit.libreoffice.org/42491 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19oops..Eike Rathke1-1/+1
Change-Id: I78c5bff1cc7503de066b151658f01fdc5d4b303b Reviewed-on: https://gerrit.libreoffice.org/42490 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19Introduce DocumentToGraphicRenderer::hasSelection() and maSelectionEike Rathke1-17/+25
Change-Id: Ib7a9df04eb1b8646e20f58c3f9af3ee2dbbb13db Reviewed-on: https://gerrit.libreoffice.org/42489 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19Rename getCurrentPageWriter() to getCurrentPage()Eike Rathke3-3/+8
... and let getCurrentPageWriter() be a private implementation detail. Change-Id: Iaa14d8eab81e5750fbaf45adc6aab66eee9018eb Reviewed-on: https://gerrit.libreoffice.org/42488 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19'a'CurrentPage gets on my nervesEike Rathke1-9/+9
Change-Id: Ifb6137048d7206c1f3a718331ed8b42f746052bb Reviewed-on: https://gerrit.libreoffice.org/42487 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19Writer export to PNG|JPG dialog preparation, current page number nonsenseEike Rathke1-1/+7
... if selection, workaround to get SvFilterOptionsDialog displayed. Change-Id: I7ebf2bfa8054555db2365078a02effd88ce5836f Reviewed-on: https://gerrit.libreoffice.org/42486 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2017-09-19renderToGraphic: assert document and target sizeEike Rathke1-0/+3
Specifically a document width or height of 0 leads to div/0 => -nan(0x8000000000000) => MapMode with 2147483648 => Fraction numerator overflow assert. Catch already here. Change-Id: I06588c64104733c2df8c2e1d6983ad95c9a74e57
2017-09-19tdf#43157 Replace DBG_ASSERT() with assert() in tabbar.cxxUlrich Gemkow1-4/+3
Change-Id: I6a7cc500c973b09236d90a3bfb044407c58fc2ef Reviewed-on: https://gerrit.libreoffice.org/42142 Reviewed-by: Teodor Mircea Ionita <admin@shinnok.com> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-15 17:55:25 +0000