summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)AuthorFilesLines
2015-08-07Remove harmful ill-timed CellController disable on mouse button downLionel Elie Mamane1-10/+0
This disable will be done, in a better way, by the call to BrowseBox::MouseButtonDown below, *after* the destination of the mouse click has grabbed the focus, by a call to DeactivateCell(). If this is done here, while the "source" controller still has the focus, then the window's Disable() method will try to pass the focus the the "next control". However, the "next" control may belong to another form, and this will do a (premature!) save to the database of the modifications. This may lead to a database error, when the data is not in a shape to be written to the database, e.g. when on an insertion row and not all mandatory fields have been filled in. This then pops up an error message to the user. Change-Id: I38b1850319691b34232e51f131f8d099dc4a9114 Reviewed-on: https://gerrit.libreoffice.org/17270 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-07-16tdf#92706 - avoid dbaccess wizard crash.Michael Meeks1-8/+10
Hold a VclPtr on the window, make reset cleaner, and don't crash removing listeners from disposed windows. Change-Id: I3efb71117fc45562d5c740578f5e33dabb2684fe Reviewed-on: https://gerrit.libreoffice.org/17038 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-07-14tdf#91715: lock SolarMutex from dbaui::~ODatabaseAdministrationDialog()Michael Meeks1-0/+1
Change-Id: I91b78ec3a19b6f09ae6e9ff723ebda41d656f2fc (cherry picked from commit 0a7375e372ee9583d31d44a7cc7b6a21e6197bf1) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-07-02tdf#92434 - A series of hideous knock-on dbaccess crasher fixes.Michael Meeks1-1/+2
Focus events during dispose, unfortunate incoming a11y events, etc. Change-Id: Iee296b767839904f5f330786891bc2513ca06c0c Reviewed-on: https://gerrit.libreoffice.org/16672 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/16686 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-30Related tdf#92322: fix crash with doCursorJulien Nabet1-0/+2
0 0x00002aaaafaf3b0c in BrowseBox::DoShowCursor(char const*) (this=0x2f424e0) at /home/julien/compile-libreoffice/libreoffice/svtools/source/brwbox/brwbox1.cxx:182 1 0x00002aaaafafe392 in BrowseBox::GetFocus() (this=0x2f424e0) at /home/julien/compile-libreoffice/libreoffice/svtools/source/brwbox/brwbox1.cxx:2489 2 0x00002aaaafb27966 in svt::EditBrowseBox::GetFocus() (this=0x2f424e0) at /home/julien/compile-libreoffice/libreoffice/svtools/source/brwbox/editbrowsebox.cxx:237 3 0x00002aaab1b5706a in vcl::Window::CompatGetFocus() (this=0x2f424e0) at /home/julien/compile-libreoffice/libreoffice/vcl/source/window/window.cxx:3948 See https://bugs.documentfoundation.org/attachment.cgi?id=116859 Change-Id: I664884ee9333055707aecd7ad309c1a97596b71b Reviewed-on: https://gerrit.libreoffice.org/16583 Reviewed-by: Philippe Jung <phil.jung@free.fr> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-24uncommitted SvtOptionsDrawinglayer_ImplCaolán McNamara1-0/+2
Change-Id: I625722d3c9e915c0f90265c5036e7c03fe9052df (cherry picked from commit a8be3fba0a8678392c9bef9a3a2ced3cedef36f0)
2015-06-23rendercontext: Mass fix of using the wrong size.Jan Holesovsky8-17/+20
In the paints, we must use the size of the Window for the computations, not of the RenderContext - the RenderContext can be much bigger than the Window in the double-buffering case. Fixes for example the list boxes, and many others. Change-Id: I4c7607569f88b2d097587140858d0862e54b5ea6 Reviewed-on: https://gerrit.libreoffice.org/16421 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-06-19rendercontext: Fix crash with double-buffering in the Styles combo box.Jan Holesovsky2-26/+29
Decouple the actual window from rendercontext in UserDrawEvent. Change-Id: Ic440c4e7f59fcffb7800c578146e8eb528cbb7b4
2015-06-18Some missing SolarMutexGuard around VclPtr acquire/releaseStephan Bergmann1-0/+1
At least OutputDevice::acquire/release use a plain unguarded int and ++, --, so apparently rely on the SolarMutex being locked whenever they are called. Fixed those places that caused "make check" to fail for me when temporarily adding DBG_TESTSOLARMUTEX() to OutputDevice::acquire/release. (A recurring pattern is that a class fails to ensure the SolarMutex is locked around the destruction of non-null VclPtr members.) Change-Id: I77cba6f3908f2de1b516ce28f1c3c43b3f57a9c5 (cherry picked from commit 8e1ad966262932516b3368d9b5c44becb29524d4) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-06-15tdf#91727 - Unwind non-dispatch of idle handlers.Michael Meeks1-0/+1
This clobbers the functionality from commit: 06d731428ef6cf93c7333e8228bfb6088853b52f make idle timers actually activate only when idle Since now all rendering and re-sizing is done in idle handlers it does effectively the opposite of what was intended. A better solution would allow special-casing the processing of just rendering, re-sizing and window management to spin for eg. progress bar rendering. Also add helpful debugging labels to the idle & timeouts. Also cleanup the Idle vs. Scheduler handling. Also ensure that starting an Idle triggers a mainloop wakeup. Also add a unit test. Change-Id: Ifb0756714378fdb790be599b93c7a3ac1f9209e6
2015-06-12graphicexport.ui: Remove incredibly unhelpful “help” messagesAdolfo Jayme Barrientos1-59/+5
“1 is less quality, 100 is more quality.” You don’t say?! These are things that any person can deduce by themselves by looking at the sliding bar. Let’s not assume users are idiots who need to be told obvious things, and in *two* mostly identical sentences. Change-Id: Id1de16b078712009a1fce4d21f7509f873d35bc0 (cherry picked from commit 543389a813879d16bde12d3edcaa802c994ec1be)
2015-06-08tdf#90804 remove SfxFieldUnit enumAndras Timar1-7/+7
b78d881520f2eb658180e2c90ffee3d30a80f0ae removed unused values from SfxFieldUnit enum. This broke the mapping between SfxFieldUnit and FieldUnit. In fact SfxFieldUnit was redundant. Change-Id: I13c7e7d708c6eeab0de192f4cd110b0a23989a31 Reviewed-on: https://gerrit.libreoffice.org/16150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 7f4230675c6c78ebea8b6db3f3612e3ef6fb23df)
2015-06-07gcc4.6: remove trigraph sequences '<::'Thorsten Behrens1-2/+2
Change-Id: Iaea3121fbc4e826b5d1f76b052c21b4dcf18df70
2015-06-06Apply new VclPtr clang plugin to catch potential problems.Noel Grandin2-3/+3
Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-04fix cherry-pick from masterTomaž Vajngerl1-20/+20
Change-Id: I8c75292755877e678cadbda8cf5b2307150fa90c
2015-06-04forgot to change the Invalidate to InvalidateEntry in treelistboxTomaž Vajngerl1-1/+1
Change-Id: Ifa70abbecb6899d0e665039cecc2d9036ffc4b92 (cherry picked from commit 2e4380a0773acb72c5ee30e976b8af6ece71396a)
2015-06-04tdf#91677 fix flickering rulerTomaž Vajngerl1-136/+112
Change-Id: Ia14be98fbfd46871b2ac9bd42a07951d86722a8a (cherry picked from commit f64588a9238cf0cb122c43d927d73822eca3b6ae)
2015-06-03tdf#91199 add Venetian [vec-IT] to language listEike Rathke1-0/+1
Change-Id: Ide2837739a32142c39e933bda5761d620dcf2a35 (cherry picked from commit 43e4382a4cd301ea6decdc5b55f42669134ef8e3)
2015-06-03lok: Avoid instantiation of the slide sorter barJan Holesovsky1-2/+3
Change-Id: Ia21bea54d1d6bd34256cb45ed704c6f7785fc2fc
2015-06-01invalidate entry instead of everything in TreeListViewTomaž Vajngerl1-11/+6
Change-Id: I4f28267194a7b0053df25b7e9be993c7838eca32
2015-05-29tdf#91677 fix invidsible menu in BaseTomaž Vajngerl1-8/+4
Change-Id: Ie1a8d6125d4a9d67f06f7dc37aa4d5115ad1af28 Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-29fix highlight rendering for iconview with more effective clippingTomaž Vajngerl1-20/+38
Change-Id: I9d8f2341477b9b9c0acd71a7d33cd5a9a55757d2 Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-29fix drawing treelistbox with redefined background in dbaccessTomaž Vajngerl1-4/+8
Change-Id: Ia55797e3e42309f9d37d5335088f7657d99954de Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-29convert WINDOW_POSSIZE constants to scoped enumNoel Grandin3-7/+7
Change-Id: Id85137ffc7309a66b04132d588d289db136117b9 Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-29convert WINDOW constants for GetWindow() methods to scoped enumNoel Grandin2-4/+4
Change-Id: I0c7c6d095732704eb4ab48f1277a0592b1c7fa33 Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-29convert constants in include/vcl/settings.hxx to scoped enumsNoel Grandin4-19/+19
Change-Id: I2a110c017f13eca6ddbd70ef3ed195d24adef0a3 Reviewed-on: https://gerrit.libreoffice.org/15828 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com> Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-29convert POINTER constants to scoped enumNoel Grandin9-34/+34
Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19 Reviewed-on: https://gerrit.libreoffice.org/15825 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com> Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-28Rewrite all calls like Dialog(params).Execute()Philippe Jung2-2/+2
Replace all calls looking like ADialog(some params).Execute() by ScopedVclPtrInstance<ADialog>::Create(some parms)->Execute() Change-Id: I0b6f0a9ea5ef0a749ffa30ce131e9dc989604639 Reviewed-on: https://gerrit.libreoffice.org/15915 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-27tdf#91416 - fix some incorrectly allocated VirtualDevices.Michael Meeks1-1/+1
Change-Id: I9ebed313827986473c60e77b7e218b4c1b2487fe (cherry picked from commit f849d96463d967214bc063f6de912a082272c395)
2015-05-27Fix accidental mis-uses of VclPtr address-of operatorStephan Bergmann1-1/+1
Change-Id: I3a82423378d3198a25f90ddfbf42af55d85c96fb (cherry picked from commit 668408fa1c69eaf0f0a37f24e2ec8b4a38fe3db7, w/o the accidentally included sw/htmlexport-swobjects.patch)
2015-05-26Push without PopCaolán McNamara1-2/+3
regression from commit fb8f83c12e991ad01f049332c022697736d03986 Date: Mon May 11 14:33:01 2015 +0900 refactor TabBar to use RenderContext Change-Id: Ie77d23e164a880cec6ba5f5387070da1ada30760 (cherry picked from commit ca95160830305c507a776c3fc0b13c71dee0dbe7)
2015-05-26Audit all PostUserEvent calls and instrument for VclPtr.Michael Meeks6-13/+14
Hold a reference on the VclPtr while we're waiting for the UserEvent. Change-Id: I55c2671ca12eb14761c6a7dffd551af71547ecbd
2015-05-20bin/rename-sw-abbreviations.shlibreoffice-5-0-branch-pointChristian Lohmaier1-1/+1
renames the most annoying abbreviations in Writer (and partially in the shared code too). Change-Id: I9a62759138126c1537cc5c985ba05cf54d6132d9
2015-05-20mbHasInsertTab is not needed anymoreTomaž Vajngerl1-3/+1
Change-Id: Icc7eb914a16d6492146879967a6dc8b634d50b6e
2015-05-20convert QUEUE_STATUS constants to scoped enumNoel Grandin1-26/+26
Change-Id: I672e3a31c97fad91826dff1446d2d098d3d36150
2015-05-20convert FONT_SUBSTITUTE constants to scoped enumNoel Grandin1-3/+3
Change-Id: I8312f0117f33349218a09ccdfea946c66ceb1b3e
2015-05-20convert ANTIALIASING constants to scoped enumNoel Grandin2-3/+3
Change-Id: I175b8ea4e8bc01c3cdd3dd90506eba01b35e0085
2015-05-20convert DRAWMODE constants to scoped enumNoel Grandin3-7/+7
Change-Id: I36cbe8057d09226f8b302963bdd94dc5600b686f
2015-05-20convert IMAGE_DRAW_ constants to scoped enumNoel Grandin8-18/+18
Change-Id: I75619eeb902af4953a5ac1525605cf3f0f15e2c0
2015-05-20convert TEXT_DRAW constants to scoped enumNoel Grandin12-37/+37
Change-Id: Ic0f7f8fa236bb478b3598ae3fd3c1b30ebbf1a01
2015-05-20Remove include stdio (part4)Julien Nabet9-19/+2
Change-Id: Ic17885b22167eedd0e56b3e5027c09a1c3aac1d8 Reviewed-on: https://gerrit.libreoffice.org/15819 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-05-19check for and handle missing base in mail merge (related: fdo#33266)Bjoern Michaelsen2-0/+18
Change-Id: I3e362a873c28026cbecf005c07def1295aa920e0
2015-05-18WaE: unused-const-variableCaolán McNamara1-1/+0
Change-Id: Ic2ff538a6125e6c8b6730257bd7b97c9e39eb3ac
2015-05-18callcatcher: update unused codeCaolán McNamara4-36/+0
Change-Id: I43dd399368953c629916dad8104a296f837a6344
2015-05-18use RenderTools variant of DrawSelectionBackgroundTomaž Vajngerl1-3/+3
Change-Id: Ia7a0f0a4d62e478876743c019865e7878bcbf596
2015-05-18pass RenderContext to PreparePaint in TreeListBoxTomaž Vajngerl1-13/+12
Change-Id: I32961f5cd511b9ecc756e99ca95e4e9ddbc6b795
2015-05-18refactor how font, fg. and bg. are applied in widgets/controlsTomaž Vajngerl13-195/+184
- Move vcl::RenderContext to outdev. - Change some methods on vcl::Window to accept RenderContext as parameter. - Add ApplySettings to vcl::Window - This method is called before painting. Refactor existing classes that use InitSettings to have ApplySettings or mark the classes to be refactored later. - Add RenderSettings for adding defered settings to rendering. This is similar to ApplySettings but for more ad-hoc calls. Change-Id: I4ea58461f3b6b08ccfa3e0ddd1a4a3e04f8c4f45
2015-05-17cleanup tabbarTomaž Vajngerl1-373/+378
Change-Id: Ibb4922899f8b182c51a8e4d77e3b12a0b28e582a
2015-05-17tabbar: use a button for adding of tabs, move button before tabsTomaž Vajngerl3-36/+46
Change-Id: I89fcf7427694ea6fc9468220bae639b221d9ec28
2015-05-15tdf#62475: partial handmade fixesAndrea Gelmini1-1/+1
Change-Id: Ib9af202c43b916b9af4b4e18db35d470a8692fe4 Reviewed-on: https://gerrit.libreoffice.org/15712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-06 03:28:12 +0000