summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)AuthorFilesLines
2018-12-21tdf#122038: don't create another RestartDialog if already restartingMike Kaganski1-1/+4
otherwise it crashes/aborts in Window::dispose() with this backtrace: ucrtbased.dll!issue_debug_notification(const wchar_t * const message) Line 28 at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(28) ucrtbased.dll!__acrt_report_runtime_error(const wchar_t * message) Line 154 at minkernel\crts\ucrt\src\appcrt\internal\report_runtime_error.cpp(154) ucrtbased.dll!abort() Line 61 at minkernel\crts\ucrt\src\appcrt\startup\abort.cpp(61) vcllo.dll!SalAbort(const rtl::OUString & rErrorText, bool bDumpCore) Line 309 at c:\lo\src\core\vcl\source\app\salplug.cxx(309) vcllo.dll!Application::Abort(const rtl::OUString & rErrorText) Line 270 at c:\lo\src\core\vcl\source\app\svapp.cxx(270) vcllo.dll!vcl::Window::dispose() Line 275 at c:\lo\src\core\vcl\source\window\window.cxx(275) vcllo.dll!SystemWindow::dispose() Line 114 at c:\lo\src\core\vcl\source\window\syswin.cxx(114) vcllo.dll!Dialog::dispose() Line 647 at c:\lo\src\core\vcl\source\window\dialog.cxx(647) vcllo.dll!VclReferenceBase::disposeOnce() Line 43 at c:\lo\src\core\vcl\source\outdev\vclreferencebase.cxx(43) tklo.dll!VclPtr<vcl::Window>::disposeAndClear() Line 206 at c:\lo\src\core\include\vcl\vclptr.hxx(206) tklo.dll!UnoWrapper::WindowDestroyed(vcl::Window * pWindow) Line 294 at c:\lo\src\core\toolkit\source\helper\unowrapper.cxx(294) vcllo.dll!vcl::Window::dispose() Line 233 at c:\lo\src\core\vcl\source\window\window.cxx(233) vcllo.dll!SystemWindow::dispose() Line 114 at c:\lo\src\core\vcl\source\window\syswin.cxx(114) vcllo.dll!WorkWindow::dispose() Line 129 at c:\lo\src\core\vcl\source\window\wrkwin.cxx(129) vcllo.dll!VclReferenceBase::disposeOnce() Line 43 at c:\lo\src\core\vcl\source\outdev\vclreferencebase.cxx(43) tklo.dll!VclPtr<OutputDevice>::disposeAndClear() Line 206 at c:\lo\src\core\include\vcl\vclptr.hxx(206) tklo.dll!VCLXWindow::dispose() Line 947 at c:\lo\src\core\toolkit\source\awt\vclxwindow.cxx(947) fwklo.dll!`anonymous namespace'::XFrameImpl::disposing() Line 2184 at c:\lo\src\core\framework\source\services\frame.cxx(2184) cppuhelper3MSC.dll!cppu::WeakComponentImplHelperBase::dispose() Line 105 at c:\lo\src\core\cppuhelper\source\implbase.cxx(105) fwklo.dll!cppu::PartialWeakComponentImplHelper<com::sun::star::lang::XServiceInfo,com::sun::star::frame::XFrame2,com::sun::star::awt::XWindowListener,com::sun::star::awt::XTopWindowListener,com::sun::star::awt::XFocusListener,com::sun::star::document::XActionLockable,com::sun::star::util::XCloseable,com::sun::star::frame::XComponentLoader,com::sun::star::frame::XTitle,com::sun::star::frame::XTitleChangeBroadcaster,com::sun::star::beans::XPropertySet,com::sun::star::beans::XPropertySetInfo>::dispose() Line 90 at c:\lo\src\core\include\cppuhelper\compbase.hxx(90) fwklo.dll!`anonymous namespace'::XFrameImpl::close(unsigned char bDeliverOwnership) Line 1716 at c:\lo\src\core\framework\source\services\frame.cxx(1716) fwklo.dll!framework::Desktop::impl_closeFrames(bool bAllowUI) Line 1743 at c:\lo\src\core\framework\source\services\desktop.cxx(1743) fwklo.dll!framework::Desktop::terminate() Line 233 at c:\lo\src\core\framework\source\services\desktop.cxx(233) comphelper.dll!comphelper::OOfficeRestartManager::notify(const com::sun::star::uno::Any & __formal) Line 109 at c:\lo\src\core\comphelper\source\misc\officerestartmanager.cxx(109) tklo.dll!`anonymous namespace'::AsyncCallback::Notify_Impl(`anonymous-namespace'::AsyncCallback * __formal, void * p) Line 105 at c:\lo\src\core\toolkit\source\awt\asynccallback.cxx(105) tklo.dll!`anonymous namespace'::AsyncCallback::LinkStubNotify_Impl(void * instance, void * data) Line 97 at c:\lo\src\core\toolkit\source\awt\asynccallback.cxx(97) vcllo.dll!Link<void *,void>::Call(void * data) Line 84 at c:\lo\src\core\include\tools\link.hxx(84) vcllo.dll!ImplHandleUserEvent(ImplSVEvent * pSVEvent) Line 1935 at c:\lo\src\core\vcl\source\window\winproc.cxx(1935) vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent, const void * pEvent) Line 2486 at c:\lo\src\core\vcl\source\window\winproc.cxx(2486) vcllo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent) Line 285 at c:\lo\src\core\vcl\inc\salframe.hxx(285) vclplug_winlo.dll!ImplHandleUserEvent(HWND__ * hWnd, __int64 lParam) Line 4068 at c:\lo\src\core\vcl\win\window\salframe.cxx(4068) vclplug_winlo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, bool & rDef) Line 5721 at c:\lo\src\core\vcl\win\window\salframe.cxx(5721) vclplug_winlo.dll!SalFrameWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 5828 at c:\lo\src\core\vcl\win\window\salframe.cxx(5828) user32.dll!UserCallWinProcCheckWow() user32.dll!CallWindowProcW() opengl32.dll!wglWndProc() user32.dll!UserCallWinProcCheckWow() user32.dll!DispatchMessageWorker() vclplug_winlo.dll!ImplSalDispatchMessage(const tagMSG * pMsg) Line 410 at c:\lo\src\core\vcl\win\app\salinst.cxx(410) vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 441 at c:\lo\src\core\vcl\win\app\salinst.cxx(441) vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 512 at c:\lo\src\core\vcl\win\app\salinst.cxx(512) vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 441 at c:\lo\src\core\vcl\source\app\svapp.cxx(441) vcllo.dll!Application::Yield() Line 506 at c:\lo\src\core\vcl\source\app\svapp.cxx(506) vcllo.dll!Dialog::Execute() Line 1041 at c:\lo\src\core\vcl\source\window\dialog.cxx(1041) vcllo.dll!SalInstanceDialog::run() Line 881 at c:\lo\src\core\vcl\source\app\salvtables.cxx(881) vcllo.dll!weld::DialogController::run() Line 1364 at c:\lo\src\core\include\vcl\weld.hxx(1364) svtlo.dll!svtools::executeRestartDialog(const com::sun::star::uno::Reference<com::sun::star::uno::XComponentContext> & context, weld::Window * parent, svtools::RestartReason reason) Line 101 at c:\lo\src\core\svtools\source\dialogs\restartdialog.cxx(98) cuilo.dll!OfaTreeOptionsDialog::OKHdl_Impl(Button * __formal) Line 735 at c:\lo\src\core\cui\source\options\treeopt.cxx(735) cuilo.dll!OfaTreeOptionsDialog::LinkStubOKHdl_Impl(void * instance, Button * data) Line 704 at c:\lo\src\core\cui\source\options\treeopt.cxx(704) vcllo.dll!Link<Button *,void>::Call(Button * data) Line 84 at c:\lo\src\core\include\tools\link.hxx(84) vcllo.dll!Button::Click::__l2::<lambda>() Line 125 at c:\lo\src\core\vcl\source\control\button.cxx(125) vcllo.dll!std::_Invoker_functor::_Call<void <lambda>(void) &>(Button::Click::__l2::void <lambda>(void) & _Obj) vcllo.dll!std::invoke<void <lambda>(void) &>(Button::Click::__l2::void <lambda>(void) & _Obj) vcllo.dll!std::_Invoker_ret<void,1>::_Call<void <lambda>(void) &>(Button::Click::__l2::void <lambda>(void) & <_Vals_0>) vcllo.dll!std::_Func_impl_no_alloc<void <lambda>(void),void>::_Do_call() vcllo.dll!std::_Func_class<void>::operator()() vcllo.dll!Control::ImplCallEventListenersAndHandler(VclEventId nEvent, const std::function<void __cdecl(void)> & callHandler) Line 321 at c:\lo\src\core\vcl\source\control\ctrl.cxx(321) vcllo.dll!Button::Click() Line 125 at c:\lo\src\core\vcl\source\control\button.cxx(125) vcllo.dll!OKButton::Click() Line 1737 at c:\lo\src\core\vcl\source\control\button.cxx(1737) vcllo.dll!PushButton::Tracking(const TrackingEvent & rTEvt) Line 1260 at c:\lo\src\core\vcl\source\control\button.cxx(1260) vcllo.dll!vcl::Window::EndTracking(TrackingEventFlags nFlags) Line 320 at c:\lo\src\core\vcl\source\window\window2.cxx(320) vcllo.dll!ImplHandleMouseEvent(const VclPtr<vcl::Window> & xWindow, MouseNotifyEvent nSVEvent, bool bMouseLeave, long nX, long nY, unsigned __int64 nMsgTime, unsigned short nCode, MouseEventModifiers nMode) Line 703 at c:\lo\src\core\vcl\source\window\winproc.cxx(703) vcllo.dll!ImplHandleSalMouseButtonUp(vcl::Window * pWindow, const SalMouseEvent * pEvent) Line 1998 at c:\lo\src\core\vcl\source\window\winproc.cxx(1998) vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent, const void * pEvent) Line 2336 at c:\lo\src\core\vcl\source\window\winproc.cxx(2336) vcllo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent) Line 285 at c:\lo\src\core\vcl\inc\salframe.hxx(285) vclplug_winlo.dll!ImplHandleMouseMsg(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 3120 at c:\lo\src\core\vcl\win\window\salframe.cxx(3120) vclplug_winlo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, bool & rDef) Line 5475 at c:\lo\src\core\vcl\win\window\salframe.cxx(5475) vclplug_winlo.dll!SalFrameWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 5828 at c:\lo\src\core\vcl\win\window\salframe.cxx(5828) user32.dll!UserCallWinProcCheckWow() user32.dll!CallWindowProcW() opengl32.dll!wglWndProc() user32.dll!UserCallWinProcCheckWow() user32.dll!DispatchMessageWorker() vclplug_winlo.dll!ImplSalDispatchMessage(const tagMSG * pMsg) Line 410 at c:\lo\src\core\vcl\win\app\salinst.cxx(410) vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 483 at c:\lo\src\core\vcl\win\app\salinst.cxx(483) vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 512 at c:\lo\src\core\vcl\win\app\salinst.cxx(512) vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 441 at c:\lo\src\core\vcl\source\app\svapp.cxx(441) vcllo.dll!Application::Yield() Line 506 at c:\lo\src\core\vcl\source\app\svapp.cxx(506) vcllo.dll!Dialog::Execute() Line 1041 at c:\lo\src\core\vcl\source\window\dialog.cxx(1041) cuilo.dll!OfaTreeOptionsDialog::Execute() Line 2040 at c:\lo\src\core\cui\source\options\treeopt.cxx(2040) cuilo.dll!CuiVclAbstractDialog_Impl::Execute() Line 112 at c:\lo\src\core\cui\source\factory\dlgfact.cxx(112) sfxlo.dll!SfxApplication::OfaExec_Impl(SfxRequest & rReq) Line 1361 at c:\lo\src\core\sfx2\source\appl\appserv.cxx(1361) sfxlo.dll!SfxStubSfxApplicationOfaExec_Impl(SfxShell * pShell, SfxRequest & rReq) Line 1248 at c:\lo\src\core\workdir\sditarget\sfx2\sdi\sfxslots.hxx(1248) sfxlo.dll!SfxShell::CallExec(void(*)(SfxShell *, SfxRequest &) pFunc, SfxRequest & rReq) Line 207 at c:\lo\src\core\include\sfx2\shell.hxx(207) sfxlo.dll!SfxDispatcher::Call_Impl(SfxShell & rShell, const SfxSlot & rSlot, SfxRequest & rReq, bool bRecord) Line 356 at c:\lo\src\core\sfx2\source\control\dispatch.cxx(356) sfxlo.dll!SfxDispatcher::Execute_(SfxShell & rShell, const SfxSlot & rSlot, SfxRequest & rReq, SfxCallMode eCallMode) Line 854 at c:\lo\src\core\sfx2\source\control\dispatch.cxx(854) sfxlo.dll!SfxDispatcher::Execute(unsigned short nSlot, SfxCallMode nCall, const SfxItemSet * pArgs, const SfxItemSet * pInternalArgs, unsigned short nModi) Line 913 at c:\lo\src\core\sfx2\source\control\dispatch.cxx(913) sfxlo.dll!SfxDispatchController_Impl::dispatch(const com::sun::star::util::URL & aURL, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & aArgs, const com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> & rListener) Line 774 at c:\lo\src\core\sfx2\source\control\unoctitm.cxx(774) sfxlo.dll!SfxOfficeDispatch::dispatch(const com::sun::star::util::URL & aURL, const com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> & aArgs) Line 225 at c:\lo\src\core\sfx2\source\control\unoctitm.cxx(225) fwklo.dll!framework::MenuBarManager::Select(Menu * pMenu) Line 896 at c:\lo\src\core\framework\source\uielement\menubarmanager.cxx(896) fwklo.dll!framework::MenuBarManager::LinkStubSelect(void * instance, Menu * data) Line 832 at c:\lo\src\core\framework\source\uielement\menubarmanager.cxx(832) vcllo.dll!Link<Menu *,bool>::Call(Menu * data) Line 84 at c:\lo\src\core\include\tools\link.hxx(84) vcllo.dll!Menu::Select() Line 362 at c:\lo\src\core\vcl\source\window\menu.cxx(362) vcllo.dll!Menu::ImplCallSelect(void * __formal) Line 2140 at c:\lo\src\core\vcl\source\window\menu.cxx(2140) vcllo.dll!Menu::LinkStubImplCallSelect(void * instance, void * data) Line 2136 at c:\lo\src\core\vcl\source\window\menu.cxx(2136) vcllo.dll!Link<void *,void>::Call(void * data) Line 84 at c:\lo\src\core\include\tools\link.hxx(84) vcllo.dll!ImplHandleUserEvent(ImplSVEvent * pSVEvent) Line 1935 at c:\lo\src\core\vcl\source\window\winproc.cxx(1935) vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent, const void * pEvent) Line 2486 at c:\lo\src\core\vcl\source\window\winproc.cxx(2486) vcllo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent) Line 285 at c:\lo\src\core\vcl\inc\salframe.hxx(285) vclplug_winlo.dll!ImplHandleUserEvent(HWND__ * hWnd, __int64 lParam) Line 4068 at c:\lo\src\core\vcl\win\window\salframe.cxx(4068) vclplug_winlo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, bool & rDef) Line 5721 at c:\lo\src\core\vcl\win\window\salframe.cxx(5721) vclplug_winlo.dll!SalFrameWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 5828 at c:\lo\src\core\vcl\win\window\salframe.cxx(5828) user32.dll!UserCallWinProcCheckWow() user32.dll!CallWindowProcW() opengl32.dll!wglWndProc() user32.dll!UserCallWinProcCheckWow() user32.dll!DispatchMessageWorker() vclplug_winlo.dll!ImplSalDispatchMessage(const tagMSG * pMsg) Line 410 at c:\lo\src\core\vcl\win\app\salinst.cxx(410) vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 441 at c:\lo\src\core\vcl\win\app\salinst.cxx(441) vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 512 at c:\lo\src\core\vcl\win\app\salinst.cxx(512) vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 441 at c:\lo\src\core\vcl\source\app\svapp.cxx(441) vcllo.dll!Application::Yield() Line 506 at c:\lo\src\core\vcl\source\app\svapp.cxx(506) vcllo.dll!Application::Execute() Line 422 at c:\lo\src\core\vcl\source\app\svapp.cxx(422) sofficeapp.dll!desktop::Desktop::Main() Line 1619 at c:\lo\src\core\desktop\source\app\app.cxx(1619) vcllo.dll!ImplSVMain() Line 199 at c:\lo\src\core\vcl\source\app\svmain.cxx(199) vcllo.dll!SVMain() Line 234 at c:\lo\src\core\vcl\source\app\svmain.cxx(234) sofficeapp.dll!soffice_main() Line 169 at c:\lo\src\core\desktop\source\app\sofficemain.cxx(169) soffice.bin!sal_main() Line 48 at c:\lo\src\core\desktop\source\app\main.c(48) soffice.bin!main(int argc, char * * argv) Line 47 at c:\lo\src\core\desktop\source\app\main.c(47) soffice.bin!invoke_main() Line 79 at d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl(79) soffice.bin!__scrt_common_main_seh() Line 288 at d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl(288) soffice.bin!__scrt_common_main() Line 331 at d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl(331) soffice.bin!mainCRTStartup() Line 17 at d:\agent\_work\3\s\src\vctools\crt\vcstartup\src\startup\exe_main.cpp(17) kernel32.dll!BaseThreadInitThunk() ntdll.dll!RtlUserThreadStart() Change-Id: I0518c48e48a50b99a2a1eaf17335e116d63bc587 Reviewed-on: https://gerrit.libreoffice.org/65007 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 12edea426a31f57a9d5b1c65b34fb1336c5534e9) Reviewed-on: https://gerrit.libreoffice.org/65098 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-11Resolves: tdf#121954 basic input box used to have label on top of entryCaolán McNamara1-2/+2
so for a quiet life arrange it like that again. https://xkcd.com/1172/ Change-Id: I8d1f3a914f8792b8c91ccd1b98d1fbd2a25a4213 Reviewed-on: https://gerrit.libreoffice.org/64779 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-11-14Related: tdf#121181 basic input box used to have a very wide edit widgetCaolán McNamara1-4/+5
so for a quiet life make it around that width again Change-Id: I7ffc0dc6d989ada3f9bf483aa1f5c1ac1ac352fc Reviewed-on: https://gerrit.libreoffice.org/63100 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-10-12Revert "tdf#120158: fix ImplGetParameterString for typename"Stephan Bergmann1-25/+23
This reverts commit 40e22f1e1bd44a1aa56ff77b82f1306ed1076ebf. See the commit message of <https://gerrit.libreoffice.org/61684> "tdf#120158: Base CMimeContentType on INetMIME::scanContentType" why that change is considered a superior fix compared to the reverted one. Change-Id: I1a0d77edee5bb18a98890d2021c777bc4c148a26 Reviewed-on: https://gerrit.libreoffice.org/61686 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 3bc8e2f3ab69adb9196508688e5211dc171add95) Reviewed-on: https://gerrit.libreoffice.org/61689 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-11tdf#120158: fix ImplGetParameterString for typenameJulien Nabet1-23/+25
since type name might also contain unacceptable characters, encode all of them See comments 8/9/10 and 11 (bt here) of bugtracker + add SAL_WARN in catch (which would have avoided me to waste a lot of time chasing the root cause) Change-Id: If8555bba8cda011218206621216e0405615229eb Reviewed-on: https://gerrit.libreoffice.org/61601 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 40e22f1e1bd44a1aa56ff77b82f1306ed1076ebf) Reviewed-on: https://gerrit.libreoffice.org/61636 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-08Resolves: tdf#93372 format table in base is ignoredCaolán McNamara1-2/+20
since... commit b4bbb5e5d7b31caad2fbcc00382ad27df3c81001 Date: Sun May 17 22:56:46 2015 +0900 refactor how font, fg. and bg. are applied in widgets/controls revert the relevant piece, in this case there are two Windows/Contexts getting their settings manipulated, rather than the usual one Change-Id: I0a228aee6aaf1f58b2235fccf14dc63ffa96dd2d Reviewed-on: https://gerrit.libreoffice.org/61317 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 0be3a5eea3089c2b63cc821ffb282fd4ab8ec455) Reviewed-on: https://gerrit.libreoffice.org/61324 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-09-18crash editing previously added remote cmisCaolán McNamara1-0/+18
http://crashreport.libreoffice.org/stats/crash_details/61ba172a-ce27-46d7-8493-dc7cb688b10a presumably since... commit 767188fd1b1e1f504864f9489076283ebc413625 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu May 17 16:21:02 2018 +0100 make PlaceEditDialog a bit more ordinary which missed the other ctor Change-Id: Iece359b94afdd0d2c48afe7f301e7178180f1dc5 Reviewed-on: https://gerrit.libreoffice.org/60587 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-08-24tdf#119427: fix selectionChanged eventJulien Nabet1-0/+2
Regression from 0fb4ae8767fa5ff791cd42934b4215011a269eb0 Thank you Drew for the bibisection! Change-Id: Id444172d534374d71765bd4aca71b012cc2352f1 Reviewed-on: https://gerrit.libreoffice.org/59526 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 36123b42c5d3084f94d068874a0bac2cc849a66e) Reviewed-on: https://gerrit.libreoffice.org/59530 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-20Fix wizard step text stylingJan-Marek Glogowski2-64/+45
Moves all the SetTextColor handing into ApplySettings and just changes the ControlBackground depending on step state. Change-Id: I96234b6353afada7bc77e2f641a160c1cf25f48d Reviewed-on: https://gerrit.libreoffice.org/58857 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit a6a2cc8f0e6501b92988accee2c3674dcfb05a2f) Reviewed-on: https://gerrit.libreoffice.org/59320
2018-08-17Resolves: tdf#119013 do not over-aggressively reorder date particlesEike Rathke1-1/+1
In particular not when reading documents as we don't know what the original (default/system) locale was when the date format was created and stored and whether the format's date order actually matched the locale's ordering. Regression from commit 51478cefaa4e265b42e3f67eda0a64767ff3efba CommitDate: Tue Apr 18 17:01:27 2017 +0200 Resolves: tdf#107012 follow date order of the target locale Change-Id: I9d3bdbd512d95ed81ff6459e368a2d7497ec8a2d Reviewed-on: https://gerrit.libreoffice.org/59182 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 5b8007afdb97d416ee7c22bf9226e927d61e9bd3) Reviewed-on: https://gerrit.libreoffice.org/59215 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-12Resolves: tdf#115950 proper double click return and bail out, tdf#117063Eike Rathke2-3/+8
commit b649ce123dea372359ec571135a68eb3de844e5b CommitDate: Sun Apr 29 08:46:46 2018 +0200 tdf#117063 Modify tree list double click behavior in the navigator changed the return value in SvTreeListBox::DoubleClickHdl() from return !aDoubleClickHdl.IsSet() || aDoubleClickHdl.Call(this); to an unconditional true. Earlier there was commit 1b9af08481b8f7f4bd15a30508606dff56b8e74f CommitDate: Tue Mar 13 16:28:40 2018 +0100 tdf#116334: Actually when there is no handler, we have to return 'true'. - aDoubleClickHdl.Call( this ); - return false; + return !aDoubleClickHdl.IsSet() || aDoubleClickHdl.Call(this); and before that commit 7651e57573952758032ceb88f16e2dbbb6cc4e18 CommitDate: Thu Mar 1 15:41:13 2018 +0100 tdf#115950: Indicate that the dialog was already destroyed. - return true; + return false; Neither a constant false or true are correct return values here, but only the value the double click handler, if any, returned to indicate whether processing should continue (true) or not (false). If handlers don't return a proper value so the intended behaviour for tdf#117063 or anything else does not work then fix the handlers instead. If the handler returned false then don't even attempt to access anything in SvImpLBox::MouseButtonDown() because an OK handler may have destroyed everything and all is rotten. Change-Id: Ia90c21288bedd7e5078dbe4b3dd6d9f5199a2a98 Reviewed-on: https://gerrit.libreoffice.org/57225 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit c9d1655d455ad783694e6d7f0d2e6cf3d0d0acae) Reviewed-on: https://gerrit.libreoffice.org/57324
2018-07-03weld SwWatermarkDialogCaolán McNamara2-9/+23
Change-Id: Iff3ddfb4dd75088e39ea7675b085f1bbde2c2045 Reviewed-on: https://gerrit.libreoffice.org/56414 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-21move SvColorDialog to welded argumentsCaolán McNamara1-9/+7
Change-Id: Ieb04fc4684caa6df47b123ab06e280f2d204375a Reviewed-on: https://gerrit.libreoffice.org/56174 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-20weld SvxColorTabPageCaolán McNamara1-8/+110
Change-Id: I5dc6f949edcb34aa110dfa9415e2ac886d0dfa4c Reviewed-on: https://gerrit.libreoffice.org/56155 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-13weld SvxCharPositionPageCaolán McNamara1-1/+1
Change-Id: I2084702798e5b01eae5905dc54ad8413e6d5fae6 Reviewed-on: https://gerrit.libreoffice.org/55765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-01connect up accessibility locationCaolán McNamara2-11/+8
Change-Id: I226e42cf6bd7aa455514439f7303b490aa6d192d Reviewed-on: https://gerrit.libreoffice.org/55138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-31focus rect for value setCaolán McNamara1-0/+4
Change-Id: I208cf42db4256bb7286222781cf2bf29f843c673 Reviewed-on: https://gerrit.libreoffice.org/55122 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-30forcepoint#43 endless update ole2 preview recursionCaolán McNamara1-1/+11
Change-Id: I7a6a52d2ea63f840a8a1800fdf7039b1e7b24cdc Reviewed-on: https://gerrit.libreoffice.org/55003 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-28weld ScTabBgColorDlgCaolán McNamara3-0/+2636
Change-Id: I864382bc55dead850c13faae9958fb660fd4f156 Reviewed-on: https://gerrit.libreoffice.org/54920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-18make PlaceEditDialog a bit more ordinaryCaolán McNamara2-100/+104
the various part of PlaceEditDialog are unusual in binding multiple things to a set of shared widgets with a bunch of multiple LINKS to the same things and using the most recent one shown to displace the previous handlers End up with multiple notifications in the gtk3 case, rework this to have a single owner of the widgets so it can do what it wants to do. Change-Id: I65826a69ce2f1d4279f6e8091a518777fcfeca07 Reviewed-on: https://gerrit.libreoffice.org/54496 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-17weld SvxJavaClassPathDlgCaolán McNamara1-93/+108
Change-Id: I3938a05d96cb1fc171611e54fa34f780ba569268
2018-05-17loplugin:unusedfields in svtoolsNoel Grandin7-19/+8
Change-Id: Idbf5e0d715784a4141b3fc712d104f84bf04dfc6 Reviewed-on: https://gerrit.libreoffice.org/54450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-16silence -Wmaybe-uninitializedCaolán McNamara1-1/+1
Change-Id: I67fa35dd310fc11d52d455948cfecc40dbb1ffc8 Reviewed-on: https://gerrit.libreoffice.org/54419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15Resolves: tdf#117617 Add Iloko [ilo-PH] to language listEike Rathke1-1/+2
Change-Id: If8444a847fa652de8b7b834e08c3e5116721c987
2018-05-14weld AddInstanceDialogCaolán McNamara1-1/+11
Change-Id: I69bcb7fb9c18922a5de03e6f2dedd915a5851712 Reviewed-on: https://gerrit.libreoffice.org/54313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-09Change to Juǀ’hoanEike Rathke1-1/+1
Change-Id: Icb6f7562644e6f471448ed4024a8fa97a5c6549a
2018-05-08Add Ju|’hoansi [ktz-NA] and Naro [nhr-BW] to language listEike Rathke1-1/+3
Change-Id: I65c048a7d52432a7d268b9a0f58aba7efc12a16e
2018-05-04Add Malay Arabic [ms-Arab-MY] and [ms-Arab-BN] to language list, both CTLEike Rathke1-1/+3
Change-Id: Iac7dddf8b29048c504b9ec695ecd08e5bf12a768 Reviewed-on: https://gerrit.libreoffice.org/53828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-05-02Fix typosAndrea Gelmini1-1/+1
Change-Id: I56bd1a7ac204f4302261e46d0b8c5dd62c4b6df9 Reviewed-on: https://gerrit.libreoffice.org/53624 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-04-30weld SdSnapLineDlgCaolán McNamara1-2/+29
Change-Id: I3a8117719525fa204f29cc10a944376116050d61 Reviewed-on: https://gerrit.libreoffice.org/53658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-30loplugin:useuniqueptr in SvTabListBoxNoel Grandin1-30/+20
Change-Id: I02117072df781f5aa86eafadaf3611999762a3c5 Reviewed-on: https://gerrit.libreoffice.org/53605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-30loplugin:useuniqueptr in SvxIconChoiceCtrl_ImplNoel Grandin2-7/+3
Change-Id: I01524abe1059e79a77c54c8b00c7f43a8575283f Reviewed-on: https://gerrit.libreoffice.org/53600 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-30loplugin:useuniqueptr in SvTreeListBoxNoel Grandin1-8/+5
Change-Id: Ib5b4cb667e8c7979ba03a680af7923f9caf9dfc3 Reviewed-on: https://gerrit.libreoffice.org/53593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-30loplugin:useuniqueptr in BrowseBoxNoel Grandin3-149/+128
Change-Id: I079009f5e9f5e8c8d2666f79e2bfcefe662acf6a Reviewed-on: https://gerrit.libreoffice.org/53591 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-29loplugin:useuniqueptr in TableControl_ImplNoel Grandin2-7/+6
Change-Id: Ida89f2a72395e0a07d57100fda10fa0f739d9eef Reviewed-on: https://gerrit.libreoffice.org/53602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-29loplugin:useuniqueptr in TemplateFolderCacheImplNoel Grandin1-5/+5
Change-Id: I90749ac49fcd0194ec43b4dc23efd66484a3bed4 Reviewed-on: https://gerrit.libreoffice.org/53601 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-29loplugin:useuniqueptr in BrowserMouseEventPtrNoel Grandin1-5/+5
Change-Id: Idbde5b63fc1241bef0a9237727fa1b010ce1eef9 Reviewed-on: https://gerrit.libreoffice.org/53599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-29loplugin:useuniqueptr in SvtFileView_ImplNoel Grandin4-29/+19
Change-Id: I18f812354dcd6eed7e2fa6400401d40feea80d85 Reviewed-on: https://gerrit.libreoffice.org/53597 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-29loplugin:useuniqueptr in ExportDialogNoel Grandin2-7/+7
Change-Id: I84dd42783be04d7acb8c0d4a9afa920db0e22d8e Reviewed-on: https://gerrit.libreoffice.org/53596 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-29loplugin:useuniqueptr in RulerNoel Grandin1-8/+6
Change-Id: Iad5ca0c3744b7598af827e66855f4be108757bd9 Reviewed-on: https://gerrit.libreoffice.org/53594 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-29loplugin:useuniqueptr in FontNameBoxNoel Grandin1-4/+2
Change-Id: Icb362d46b34010dbfc97014d76a364b720c73b02 Reviewed-on: https://gerrit.libreoffice.org/53595 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-29loplugin:useuniqueptr in CalendarNoel Grandin1-37/+14
and remove some unused fields Change-Id: I66a40bae01a5186185383b1ec827d7da5d0b483e Reviewed-on: https://gerrit.libreoffice.org/53592 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-29weld SwEndNoteOptionPageCaolán McNamara1-1/+1
Change-Id: I2313352a66b088a4198ac8a96d2fd218bb2176fd Reviewed-on: https://gerrit.libreoffice.org/53608 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-29tdf#117063 Modify tree list double click behavior in the navigatorJim Raykowski1-3/+4
Change-Id: I369a7a2075aabd3574bdda39dac74e2b132f6923 Reviewed-on: https://gerrit.libreoffice.org/53074 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-04-25SvTabListBox::SetTabs, pass count explicitNoel Grandin2-13/+8
passing count as first element in array, dodgy. Change-Id: I49905b554b3b4d6cc3fa419a36389cd2e5ded463
2018-04-23weld SfxPrintOptionsDialogCaolán McNamara2-105/+90
and SwMMResultPrintDialog Change-Id: Icded6a26a3a151293bea0c9173334cf634283e89 Reviewed-on: https://gerrit.libreoffice.org/53299 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-23loplugin:singlevalfields improve unaryoperatorNoel Grandin1-5/+2
when we see a unaryoperator, unless it's one of a small set, we can know (mostly) that the field will not be written. there is still a small risk of false+ with code taking references via conditional expressions. Change-Id: I96fa808067576a50e5eaf425338e225b4e0bdd4e Reviewed-on: https://gerrit.libreoffice.org/53263 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-20loplugin:unusedfieldsNoel Grandin1-13/+3
Change-Id: I9c80805788d49b13552c168a36fdf395da19df26 Reviewed-on: https://gerrit.libreoffice.org/53196 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-20tdf#42949 Remove unnecessary localization headers of svtoolsGabor Kelemen4-7/+0
Found by searching for the header names and the localization function: git grep -l -e \<svtools/svtresid.hxx\> -e \<svtools/strings.hrc\> | xargs grep -c SvtResId | grep :0$ | grep -v /pch Change-Id: I861fed778660412dc73616da29503538b3fe9ccb Reviewed-on: https://gerrit.libreoffice.org/53136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-20loplugin:sallogareas (clang-cl)Stephan Bergmann1-2/+2
Change-Id: I2509f0c165de0f0754d93482825603da4644009a