summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)AuthorFilesLines
2016-12-09tdf#104495: prevent autotext to crash when drag&dropJulien Nabet1-1/+0
See bt https://bugs.documentfoundation.org/attachment.cgi?id=129407 For non regression, I retested tdf#91125 since the delete comes from https://cgit.freedesktop.org/libreoffice/core/commit/?id=06ecf7d2aebe64226142ee27c2512351960f8bb1 Change-Id: I7ce833ffce20f1f159242014ba8ffe0ce5b7b11c Reviewed-on: https://gerrit.libreoffice.org/31773 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 8776c20c1c72110d0f205150913eb17cdf3f1aaa) Reviewed-on: https://gerrit.libreoffice.org/31784 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 56261b0bb06e29b71e2cc555086100282e54d62e) Reviewed-on: https://gerrit.libreoffice.org/31793
2016-11-17backport various scoped enum conversion to make other backporting saferNoel Grandin6-48/+48
Convert ControlType to scoped enum Reviewed-on: https://gerrit.libreoffice.org/25554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> (cherry picked from commit 5c977a9ddff3c221c098a57855ede7c0ef4fe31f) Change-Id: Iaa13c3e7030296a97bab144103745867d43b4b19 Convert ButtonValue to scoped enum Change-Id: Ia882914fb99844f21ce89d7218321933ef084b22 Reviewed-on: https://gerrit.libreoffice.org/26036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> (cherry picked from commit 7fb70ff650ce3a1e4a39bd1b936f511d6be8986c) Convert RenderType to scoped enum Change-Id: I2f4bb201babc9050b19de2dacc0dea462255dfa2 (cherry picked from commit 8a70742bf395fc2aab6197f04ddbfbd8ee16f263) remove some unnecessary casting Change-Id: I451df09db58256fed68ce8537b2d8eb4b6ab6942 Reviewed-on: https://gerrit.libreoffice.org/26184 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> (cherry picked from commit 2ed5fa14f0e7624db241fde26e10fdd1009adfc7) Convert PART to scoped enum Reviewed-on: https://gerrit.libreoffice.org/26173 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> (cherry picked from commit cf5208b67180dc1deaeca611706087b1e2acc1ae) Change-Id: If4c2849beb207593d3d450ae3846ed24eaf66ca4 Reviewed-on: https://gerrit.libreoffice.org/30911 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-15tdf#88827 - double-thin border: MINGAPWIDTH is a valid widthJustin Luth1-1/+1
double-thin borders are available in the UI starting from 0.5pt. The actual minumum (as seen in a round-trip), is 1.10pt. (Each thin line is ~ .50pt, the gap is ~ .05pt, and then some approximations and rounding show it as 1.10 - at least that is how I understood it). 1.15pt is the first point at which the gap is larger than the minimum - and double_thins with a minimum gap were considered invalid, and thus were not imported. With this fix, double-thin borders created with a size less than 1.15pt are valid and visible on import. cherry-picked from master, commit 9259fcd40b1749cd421c433bcc436cb335cbbe43 Conflicts: sc/qa/unit/subsequent_export-test.cxx Change-Id: Ia8cff677516eca371b7e8a9ef7ba33a1b8f176bf Reviewed-on: https://gerrit.libreoffice.org/30856 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2016-10-07rhbz#1382401: Support surrogate pairs in HTMLOutFuncsStephan Bergmann1-14/+30
(cherry picked from commit 375b99cad4a79d26a6cbcd0f71bc12b312d95818) Conflicts: svtools/source/svhtml/htmlout.cxx plus cherry-pick of 6131bf9c96fb2ae37decf13e453f27304707271b "Minor performance improvement of previous patch" Change-Id: Ib578f758e4f5f355a79a014c2ad4660924dd34a4 Reviewed-on: https://gerrit.libreoffice.org/29592 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-02Resolves: tdf#98100 no valueset tooltips with extended tips...Caolán McNamara1-1/+1
and no offline help available. I feel this was the original (day-0-checkin) intent of the code, otherwise why bother with the "| HelpEventMode::BALLOON" as that makes no difference to the existing logic. And this per-item help is what other similiar widgets do. Change-Id: Idda130450db322acefd9ecc13986067790f9a614 (cherry picked from commit 281027ea88d4d683449d4ce2cdb0563223741465) Reviewed-on: https://gerrit.libreoffice.org/28542 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-08-03Resolves: tdf#96873 include template image to make it available in helpCaolán McNamara1-2/+3
alternatively move it into the helpimg dir and change the usage in helpcontent2, but do it this way to keep it together with the others Change-Id: I84c6b10aed948a5fea835dc86bade5a4390c716b (cherry picked from commit 61062608a27ceaef5424203d849f88c7fb77b8d0) Reviewed-on: https://gerrit.libreoffice.org/27826 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-08-03Resolves: tdf#94940 don't load font history if option is disabledCaolán McNamara1-1/+6
Change-Id: I70348b4e4bb85850331044e901c03aabb0d22ef8 (cherry picked from commit 171586cc4df4a9470251e50ce51338c2d53acf9b) Reviewed-on: https://gerrit.libreoffice.org/27657 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-08-03masses of MessBoxes not being disposed promptlyCaolán McNamara2-2/+2
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X (cherry picked from commit a860df25dd7bf62ecb6b3d3ed38803b981f56d52) Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f Reviewed-on: https://gerrit.libreoffice.org/27537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-23VclPtr: svtools error message dialog doesn't disposeCaolán McNamara1-0/+1
Change-Id: I83640cc60d5e0239d228c749c32f896df5e2d9f2 (cherry picked from commit d531743ca34232aedc0b437a9ff5807dea8d51ed) Reviewed-on: https://gerrit.libreoffice.org/26587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-05-26Resolves: tdf#96279 set correct parents for password dialogsCaolán McNamara5-10/+14
otherwise on Dialog::Execute before it becomes visible and a password dialog is needed the new dialog will automatically look for a parent, but will be parented by the main window because the dialog it should be a parent of is not visible yet. Change-Id: Ia34e43d7ef2b204b348f2eb5aab542ee8ffe840e (cherry picked from commit 7417311fc0f888223ae05f1cfc750de1735c5c9e)
2016-05-25vcl: replace boost::dynamic_bitset with boost::optional<std::bitset>Michael Stahl2-42/+73
The getTTCoverage either leaves the bitset empty or inits it with 128 bits, so it's not particularly dynamic. Change-Id: Iac0aa6a023acc54da86d681e75ca550faf91ef26 Reviewed-on: https://gerrit.libreoffice.org/25456 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-25Convert BMP_FORMAT to scoped enumNoel Grandin1-3/+3
Change-Id: I751ab762b6e6f961e9e73a8a2ca92a3f5a5eb1c8 Reviewed-on: https://gerrit.libreoffice.org/25189 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25Convert AUTOCOMPLETE to scoped enumNoel Grandin2-2/+2
Change-Id: I201c8f8b41855b2777f0e7131aeaf33cafb82804 Reviewed-on: https://gerrit.libreoffice.org/25438 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24Convert SnapType to scoped enumNoel Grandin1-9/+15
Change-Id: I3980c2999bab191bb9357c883868db17db79e81f Reviewed-on: https://gerrit.libreoffice.org/25353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24too much debug spew, SAL_INFO thisCaolán McNamara2-175/+161
Change-Id: Ia4e69fa0ffad14564d021b86fdbb0d3d3b8c71b8
2016-05-24Revert "remove some manual ref-counting"Noel Grandin3-10/+24
until I have a better understanding of the UNO reference counting. This reverts commit 111de438ea3e512a541281dc0716cc728ea8d152.
2016-05-24remove some manual ref-countingNoel Grandin3-24/+10
triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: Ie1abeaed75c1f861df185e3bde680272dbadc97f Reviewed-on: https://gerrit.libreoffice.org/25363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24ruler: close the polygon when drawing indent handle (gtk3, gl)Tomaž Vajngerl1-1/+3
Change-Id: I9d1d20f889f73c73a1b861485a956a25f743e245
2016-05-23resort restart reasonsCaolán McNamara1-30/+30
Change-Id: Ie7b57e7f3266f0f1c3576e82de3c949760c2916d Reviewed-on: https://gerrit.libreoffice.org/25358 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-23tdf#99211 Use the restart dialog for notifications about restartirem2-0/+54
Change-Id: I97a10cddafc464ccbdd37902c5d24b73246f5c3f Reviewed-on: https://gerrit.libreoffice.org/24877 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-22Convert DragMode to scoped enumNoel Grandin1-3/+9
Change-Id: I68dafefc74bad355047738605defd97f3c6bebcd Reviewed-on: https://gerrit.libreoffice.org/25209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19loplugin:unusedmethods in slideshow to svtoolsNoel Grandin1-7/+0
Change-Id: Icf0056e13c88d7d347e668adaeddd4ed72af85cf Reviewed-on: https://gerrit.libreoffice.org/25141 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19clang-tidy modernize-make-uniqueNoel Grandin1-2/+2
Change-Id: I550bb69ddcef69906027516ccde62cf8e87c295b Reviewed-on: https://gerrit.libreoffice.org/25138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19clang-tidy clang-analyzer-alpha.core.IdenticalExprNoel Grandin1-6/+0
Change-Id: I110d8d63d5a6657c18aba97227c046027eb8f7f4 Reviewed-on: https://gerrit.libreoffice.org/25086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19loplugin:unusedmethods in toolsNoel Grandin1-10/+1
Change-Id: I26a4ce6e849615d6d24632650ca03c40ab16502e Reviewed-on: https://gerrit.libreoffice.org/25089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin6-445/+0
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18tdf#95954: Reasonable background for roadmap widgetKatarina Behrens2-8/+13
also move setting control font/text style to ApplySettings func Change-Id: Iec71ebb42424e0d29fb5c5e155773b61bfcf2313 Reviewed-on: https://gerrit.libreoffice.org/25054 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-16convert IconChoice flags to scoped enumNoel Grandin3-71/+57
and removed unused entries Change-Id: Ibe7ebb7723d9418893a2e2768e2a84eb16d1a046 Reviewed-on: https://gerrit.libreoffice.org/24970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16convert SvImpLBox flags to scoped enumNoel Grandin3-108/+99
and remove the dead ones Change-Id: Iac72c4a4e16290936a9965afb8c637d181bccb2d Reviewed-on: https://gerrit.libreoffice.org/24965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16Give unique, comprehensible names to idles tdf#97087Muhammet Kara1-0/+5
Timers and idles should have programmer comprehensible, unique names. Change-Id: Ida131a4e3ddb7f065d876d78dd501fa831d4cf4a Reviewed-on: https://gerrit.libreoffice.org/24605 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-13convert SHOWTRACK to scoped enumNoel Grandin7-9/+9
Change-Id: Ibf06f6c79f80d7265ae3239c1ea0088118e92e21 Reviewed-on: https://gerrit.libreoffice.org/24894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13Typo: ExcecuteContextMenuAction->ExecuteContextMenuActionJulien Nabet3-5/+5
Change-Id: Ifb121344a8f235d71bab33c03808e3f44d7bee7c Reviewed-on: https://gerrit.libreoffice.org/24942 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-12use unique_ptrDavid Tardon3-58/+31
Change-Id: I49f08a066f3a5f6f3479060d8a528a7cfdfdc02c
2016-05-12avoid crash when using the New Slide toolbar popup in ImpressDavid Tardon1-0/+2
Change-Id: I5aeb77fa8764179699d884647e8734d413752130
2016-05-12do not try to use obj. that is already being disposedDavid Tardon1-6/+8
Change-Id: Ibb25e5bfc3e161be9fdac124b5a107a6d180bf1e
2016-05-12Convert RulerType to scoped enumNoel Grandin1-30/+30
Change-Id: I2233b70e5413bfa3156011e1b3306d539003795b Reviewed-on: https://gerrit.libreoffice.org/24879 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11Convert RulerExtra to scoped enumNoel Grandin1-3/+3
Change-Id: I81f5380e27a741ab6049bcec6b4136d8f2d1169a Reviewed-on: https://gerrit.libreoffice.org/24878 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11Convert RULER_MARGIN to scoped enumNoel Grandin1-13/+13
Change-Id: Ia8711614fdb9090faeebfe294cbb064ded20b5fb Reviewed-on: https://gerrit.libreoffice.org/24874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11Convert RULER_BORDER to scoped enumNoel Grandin1-10/+10
Change-Id: Ia8dcffe817e6f7a5f8470ce08c25103c527d221d Reviewed-on: https://gerrit.libreoffice.org/24854 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11Convert RULER_DRAGSIZE to scoped enumNoel Grandin1-12/+12
Change-Id: Iddf7562273072eb4d5d60efc730d5c40bfc79f46 Reviewed-on: https://gerrit.libreoffice.org/24852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11convert RULER_INDENT to scoped enumNoel Grandin1-19/+14
Also separate out the INVISIBLE flag into it's own bit, because the constant is shared with other fields. Also fix some dubious code in SVX that was setting stuff on the field that meant nothing. Change-Id: If460be575eee38b8e9f01af4d73f93f6426c604f Reviewed-on: https://gerrit.libreoffice.org/24853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11clang-tidy modernize-loop-convert in scripting to svtoolsNoel Grandin22-94/+80
Change-Id: I98229d14109cf243839d632feabde1391ea9bad5 Reviewed-on: https://gerrit.libreoffice.org/24847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Fix typosAndrea Gelmini2-2/+2
Change-Id: I1c1894fcf533291b34a662b6efb96dcfa75b92b3 Reviewed-on: https://gerrit.libreoffice.org/24760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann4-0/+8
Change-Id: I8fcd7bf2583c935e060a29e43c88614681d81d13
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann8-96/+97
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-06svtools: FontList loops with > 2^16 fontsMichael Stahl2-10/+8
Change-Id: Idfe5d76ee384dff3280f81686cbf408c2f675dc6
2016-05-06teach passstuffbyref plugin to check for..Noel Grandin1-2/+2
unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-04use Any constructor instead of temporariesNoel Grandin1-3/+1
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-05-03Prevent Any::setValue from reinterpreting bool* as sal_Bool*Stephan Bergmann4-13/+7
...which only happens ot work in environments where sizeof (bool) == 1. The simpler alternative is to use the operator <<= template without passing explicit UNO type information, anyway. The std::nullptr_t overloads are needed to disambiguate calls with a nullptr argument. (Which can at least be meaningful for VOID, but for other types what it happens to do is store a default value of the given type.) As std::nullptr_t is only C++11, this all needs to be LIBO_INTERNAL_ONLY. Change-Id: Iff06a6ba94250bd4ae4afc937c2a2bfa75f0888f
2016-05-03tdf#99211 Use the restart dialog for notifications about restartirem2-0/+18
Change-Id: I2093e99d7b377285f6b3248a90072f0dea12f732 Reviewed-on: https://gerrit.libreoffice.org/24556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-23 19:50:36 +0000