Age | Commit message (Collapse) | Author | Files | Lines |
|
Commit() of related _Impl class actually wasn't called anywhere
after 465359c35fcd8c30a2bedd3d0beb07c0c1c36cba removed it from
destructor.
The config was also never tagged as modified, so fix that too.
Change-Id: I8293fee20ec154d5d70a7cda8b015bf723b50c87
Reviewed-on: https://gerrit.libreoffice.org/19558
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
(cherry picked from commit 2e528df76b168a221c6d251d9b076bce5ba051a3)
Reviewed-on: https://gerrit.libreoffice.org/19688
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
|
|
from Writer with Chinese UI. When user configure UI language as
Chinese, style names are also translated. However when Copy-pasting
from Writer to Impress ( select RTF fromat with paste-special),
Chinese (unicode) style names are borken into multiparts, where
some of them are empty string. Neither deleting the abnormal
style nor saving the file can be achieved. The only remedy is to
remove style with emtpy name with macro. With this patch:
1) Catch NoSuchElementException and ignores it, so
user still has chance saving file.
2) Make sure style has valid number before inserting it.
3) Prevent text breaking into multiple tokens by handling ucN in
ScanText().
Change-Id: I417f70b81c23ac63c175cc13c548068873d13a38
Reviewed-on: https://gerrit.libreoffice.org/18148
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/19685
|
|
Change-Id: I06711afd5d668816608661f0fe433efd93fef99e
Reviewed-on: https://gerrit.libreoffice.org/19372
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
This commit fixes the writer image export (jpeg, png) that didn't
work because the export pixel size was set to 0 by default. Now
the default is set to document size (which depends on system DPI).
When exporting to a PNG the background was transparent, which may
not be desired. The background color is now by default white and
can be changed for DocumentToGraphicRenderer, but the dialog or
command line don't support such an option - for now.
Change-Id: I16ffd3cd60c47b52768f43ae4c4c170fc821033b
Reviewed-on: https://gerrit.libreoffice.org/19478
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
|
|
Change-Id: If070da723858b5e1221bda86e69225ee57ec9d02
(cherry picked from commit cfcf0254afe0ce9f4fd80606527bd1f14777f7e1)
Reviewed-on: https://gerrit.libreoffice.org/19467
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: Ia7748eae16c35a1d197b9f4aa5f391f496e7f2f2
Reviewed-on: https://gerrit.libreoffice.org/18122
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
|
|
with disabled rulers. (This fix was suggested by Tomaž Vajngerl.)
(Cherry-picked from the commit ed031895f6f5b361cccc6811b53c6f2b9cfc3e23)
Conflicts:
svtools/source/control/ruler.cxx
Change-Id: I161237cdb4941c0eaf934223b078acd94d72e21d
Reviewed-on: https://gerrit.libreoffice.org/18507
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
before drawing the new icon
(cherry-picked from
commit e74bc6b9a61dbc80caa6d2a8bfb79b3ac61c9899)
Conflicts:
svtools/source/control/ruler.cxx
Change-Id: Ibbdbed448f965848429ace28dcfae47efc982164
Reviewed-on: https://gerrit.libreoffice.org/18376
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Added a C++ and a GLSL implementation of a 64-bit CRC algorithm.
Changed hardcoded checksum value in ooxmlimport unit test (testN777345).
Change-Id: I16bb985a14866775efda49e21fe033ff64645896
Reviewed-on: https://gerrit.libreoffice.org/18254
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
|
|
Surprisingly SvtMenuOptions_Impl::ImplCommit() does not actually write
m_eMenuIcons for "ShowIconsInMenues" but something read out of
Application::Settings(), which appears to be deliberate (i#95318).
Whatever sets that does it after SetMenuIconsState() is called,
so keep the SvtMenuOptions modified by not calling Commit().
(regression from 765f6211b1371c1e40de386e715de6b3d1a8df86)
Change-Id: I368b65589d16753d80a1b9e9cc7d7df59c0f53da
(cherry picked from commit ce0bba5fc1090caa7fb80f1bcc6ce64f67f11238)
Reviewed-on: https://gerrit.libreoffice.org/17865
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
This disable will be done, in a better way, by the call to
BrowseBox::MouseButtonDown below, *after* the destination of the mouse
click has grabbed the focus, by a call to DeactivateCell().
If this is done here, while the "source" controller still has the
focus, then the window's Disable() method will try to pass the focus
the the "next control". However, the "next" control may belong to
another form, and this will do a (premature!) save to the database of
the modifications. This may lead to a database error, when the data is
not in a shape to be written to the database, e.g. when on an
insertion row and not all mandatory fields have been filled in.
This then pops up an error message to the user.
Change-Id: I38b1850319691b34232e51f131f8d099dc4a9114
Reviewed-on: https://gerrit.libreoffice.org/17270
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
Hold a VclPtr on the window, make reset cleaner, and don't crash
removing listeners from disposed windows.
Change-Id: I3efb71117fc45562d5c740578f5e33dabb2684fe
Reviewed-on: https://gerrit.libreoffice.org/17038
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I91b78ec3a19b6f09ae6e9ff723ebda41d656f2fc
(cherry picked from commit 0a7375e372ee9583d31d44a7cc7b6a21e6197bf1)
Signed-off-by: Michael Stahl <mstahl@redhat.com>
|
|
Focus events during dispose, unfortunate incoming a11y events, etc.
Change-Id: Iee296b767839904f5f330786891bc2513ca06c0c
Reviewed-on: https://gerrit.libreoffice.org/16672
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/16686
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
0 0x00002aaaafaf3b0c in BrowseBox::DoShowCursor(char const*) (this=0x2f424e0) at /home/julien/compile-libreoffice/libreoffice/svtools/source/brwbox/brwbox1.cxx:182
1 0x00002aaaafafe392 in BrowseBox::GetFocus() (this=0x2f424e0) at /home/julien/compile-libreoffice/libreoffice/svtools/source/brwbox/brwbox1.cxx:2489
2 0x00002aaaafb27966 in svt::EditBrowseBox::GetFocus() (this=0x2f424e0) at /home/julien/compile-libreoffice/libreoffice/svtools/source/brwbox/editbrowsebox.cxx:237
3 0x00002aaab1b5706a in vcl::Window::CompatGetFocus() (this=0x2f424e0) at /home/julien/compile-libreoffice/libreoffice/vcl/source/window/window.cxx:3948
See https://bugs.documentfoundation.org/attachment.cgi?id=116859
Change-Id: I664884ee9333055707aecd7ad309c1a97596b71b
Reviewed-on: https://gerrit.libreoffice.org/16583
Reviewed-by: Philippe Jung <phil.jung@free.fr>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I625722d3c9e915c0f90265c5036e7c03fe9052df
(cherry picked from commit a8be3fba0a8678392c9bef9a3a2ced3cedef36f0)
|
|
In the paints, we must use the size of the Window for the computations, not of
the RenderContext - the RenderContext can be much bigger than the Window in
the double-buffering case.
Fixes for example the list boxes, and many others.
Change-Id: I4c7607569f88b2d097587140858d0862e54b5ea6
Reviewed-on: https://gerrit.libreoffice.org/16421
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
|
|
Decouple the actual window from rendercontext in UserDrawEvent.
Change-Id: Ic440c4e7f59fcffb7800c578146e8eb528cbb7b4
|
|
At least OutputDevice::acquire/release use a plain unguarded int and ++, --, so
apparently rely on the SolarMutex being locked whenever they are called. Fixed
those places that caused "make check" to fail for me when temporarily adding
DBG_TESTSOLARMUTEX() to OutputDevice::acquire/release. (A recurring pattern is
that a class fails to ensure the SolarMutex is locked around the destruction of
non-null VclPtr members.)
Change-Id: I77cba6f3908f2de1b516ce28f1c3c43b3f57a9c5
(cherry picked from commit 8e1ad966262932516b3368d9b5c44becb29524d4)
Signed-off-by: Michael Stahl <mstahl@redhat.com>
|
|
This clobbers the functionality from commit:
06d731428ef6cf93c7333e8228bfb6088853b52f
make idle timers actually activate only when idle
Since now all rendering and re-sizing is done in idle handlers it
does effectively the opposite of what was intended. A better solution
would allow special-casing the processing of just rendering,
re-sizing and window management to spin for eg. progress bar
rendering.
Also add helpful debugging labels to the idle & timeouts.
Also cleanup the Idle vs. Scheduler handling.
Also ensure that starting an Idle triggers a mainloop wakeup.
Also add a unit test.
Change-Id: Ifb0756714378fdb790be599b93c7a3ac1f9209e6
|
|
“1 is less quality, 100 is more quality.” You don’t say?!
These are things that any person can deduce by themselves
by looking at the sliding bar.
Let’s not assume users are idiots who need to be told
obvious things, and in *two* mostly identical sentences.
Change-Id: Id1de16b078712009a1fce4d21f7509f873d35bc0
(cherry picked from commit 543389a813879d16bde12d3edcaa802c994ec1be)
|
|
b78d881520f2eb658180e2c90ffee3d30a80f0ae removed unused values
from SfxFieldUnit enum. This broke the mapping between SfxFieldUnit
and FieldUnit. In fact SfxFieldUnit was redundant.
Change-Id: I13c7e7d708c6eeab0de192f4cd110b0a23989a31
Reviewed-on: https://gerrit.libreoffice.org/16150
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 7f4230675c6c78ebea8b6db3f3612e3ef6fb23df)
|
|
Change-Id: Iaea3121fbc4e826b5d1f76b052c21b4dcf18df70
|
|
Omit the plugin, and sw's FrameControlsManager for now.
Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f
Reviewed-on: https://gerrit.libreoffice.org/16117
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Change-Id: I8c75292755877e678cadbda8cf5b2307150fa90c
|
|
Change-Id: Ifa70abbecb6899d0e665039cecc2d9036ffc4b92
(cherry picked from commit 2e4380a0773acb72c5ee30e976b8af6ece71396a)
|
|
Change-Id: Ia14be98fbfd46871b2ac9bd42a07951d86722a8a
(cherry picked from commit f64588a9238cf0cb122c43d927d73822eca3b6ae)
|
|
Change-Id: Ide2837739a32142c39e933bda5761d620dcf2a35
(cherry picked from commit 43e4382a4cd301ea6decdc5b55f42669134ef8e3)
|
|
Change-Id: Ia21bea54d1d6bd34256cb45ed704c6f7785fc2fc
|
|
Change-Id: I4f28267194a7b0053df25b7e9be993c7838eca32
|
|
Change-Id: Ie1a8d6125d4a9d67f06f7dc37aa4d5115ad1af28
Signed-off-by: Jan Holesovsky <kendy@collabora.com>
|
|
Change-Id: I9d8f2341477b9b9c0acd71a7d33cd5a9a55757d2
Signed-off-by: Jan Holesovsky <kendy@collabora.com>
|
|
Change-Id: Ia55797e3e42309f9d37d5335088f7657d99954de
Signed-off-by: Jan Holesovsky <kendy@collabora.com>
|
|
Change-Id: Id85137ffc7309a66b04132d588d289db136117b9
Signed-off-by: Jan Holesovsky <kendy@collabora.com>
|
|
Change-Id: I0c7c6d095732704eb4ab48f1277a0592b1c7fa33
Signed-off-by: Jan Holesovsky <kendy@collabora.com>
|
|
Change-Id: I2a110c017f13eca6ddbd70ef3ed195d24adef0a3
Reviewed-on: https://gerrit.libreoffice.org/15828
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
Signed-off-by: Jan Holesovsky <kendy@collabora.com>
|
|
Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19
Reviewed-on: https://gerrit.libreoffice.org/15825
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
Signed-off-by: Jan Holesovsky <kendy@collabora.com>
|
|
Replace all calls looking like
ADialog(some params).Execute()
by
ScopedVclPtrInstance<ADialog>::Create(some parms)->Execute()
Change-Id: I0b6f0a9ea5ef0a749ffa30ce131e9dc989604639
Reviewed-on: https://gerrit.libreoffice.org/15915
Tested-by: Jenkins <ci@libreoffice.org>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Change-Id: I9ebed313827986473c60e77b7e218b4c1b2487fe
(cherry picked from commit f849d96463d967214bc063f6de912a082272c395)
|
|
Change-Id: I3a82423378d3198a25f90ddfbf42af55d85c96fb
(cherry picked from commit 668408fa1c69eaf0f0a37f24e2ec8b4a38fe3db7, w/o the
accidentally included sw/htmlexport-swobjects.patch)
|
|
regression from
commit fb8f83c12e991ad01f049332c022697736d03986
Date: Mon May 11 14:33:01 2015 +0900
refactor TabBar to use RenderContext
Change-Id: Ie77d23e164a880cec6ba5f5387070da1ada30760
(cherry picked from commit ca95160830305c507a776c3fc0b13c71dee0dbe7)
|
|
Hold a reference on the VclPtr while we're waiting for the UserEvent.
Change-Id: I55c2671ca12eb14761c6a7dffd551af71547ecbd
|
|
renames the most annoying abbreviations in Writer (and partially
in the shared code too).
Change-Id: I9a62759138126c1537cc5c985ba05cf54d6132d9
|
|
Change-Id: Icc7eb914a16d6492146879967a6dc8b634d50b6e
|
|
Change-Id: I672e3a31c97fad91826dff1446d2d098d3d36150
|
|
Change-Id: I8312f0117f33349218a09ccdfea946c66ceb1b3e
|
|
Change-Id: I175b8ea4e8bc01c3cdd3dd90506eba01b35e0085
|
|
Change-Id: I36cbe8057d09226f8b302963bdd94dc5600b686f
|
|
Change-Id: I75619eeb902af4953a5ac1525605cf3f0f15e2c0
|
|
Change-Id: Ic0f7f8fa236bb478b3598ae3fd3c1b30ebbf1a01
|