summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)AuthorFilesLines
2014-11-14coverity#1242527 Arguments in wrong orderCaolán McNamara1-1/+1
doesn't seem to matter too much, I guess its only the top left corner that really matters for tooltips. This is the vertical scrollbar as used in e.g. writer->view->datasources Change-Id: I5bd6e563a9f02edae9ca166f073556c55878826c
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava6-9/+9
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-14vcl: move the Impl class of MapMode ...uhm... out of the public header?Michael Stahl9-0/+10
And remove the tools/fract.hxx include. grep -l -r fract.hxx workdir/Dep/*Object* |wc -l before: 4569 after: 1851 Shrinks some libraries, example from --enable-dbgutil Fedora gcc 4.8.3: libvcllo.so by 473k (0.35%) libswlo.so by ~1Mb (sadly that is just 0.2%) Change-Id: I09bd025d551a5d2c5528b938a68c6aa5f8f114a0
2014-11-13coverity#1251580 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: I5dcbd2289fc853bad2c0969fb3b202a1e7398a5a
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini13-21/+21
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11fdo#84938: replace HELPMODE_ constants with enumNoel Grandin8-17/+17
Change-Id: I44be5567e84cdabd8b10771ea37e28b8a88cc23e Reviewed-on: https://gerrit.libreoffice.org/12333 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-09fdo#86050 Let LibreOffice add scrollbars to widgets only when necessaryAdolfo Jayme Barrientos1-1/+0
Change-Id: I1a930a413c071d4d0c8855315dc85339e01b7d9b Reviewed-on: https://gerrit.libreoffice.org/12322 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-07fdo#84938: replace MOUSE_ modifier constants with enumNoel Grandin4-9/+8
and make the two categories of constants non-overlapping, we really don't need to risk confusion in order to save 6 bits in a data structure like this. Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
2014-11-07Update notes about swappingZolnai Tamás1-7/+8
Change-Id: I6b9f5f9c4a0bc87376a469835a50dc2cf598479e
2014-11-07Optimize ImplCheckSizeOfSwappedInGraphics() a bitZolnai Tamás1-32/+18
Store used size as a member so we don't need to recalculate it all the time and no need to use a size map. Change-Id: I1f929c5d3a56f545cef123bda087ecaf8ca0be4a
2014-11-07Why to have this compromise, do that what we say the users we do.Zolnai Tamás1-13/+1
Change-Id: Ia599644ff1f7591ac84bdca988883eaf5860297e
2014-11-07Swapping Graphic is a privilage of GraphicObject.Zolnai Tamás2-5/+3
This means more things: * Graphic won't swap out itself, so those classes which uses Graphic without GraphicObject won't need to deal with swapping. * When a Graphic is queried from GraphicObject the caller won't need to deal with swapping, because GraphicObject swaps it in before return. * GraphicObject will swap in the Graphic always when a swapping dependent data is queried (e.g. whole graphic, transformed graphic or AnimationNotifyHdl) Change-Id: I2bf6e37291ec94146f10aac4a35084682437ed16
2014-11-07Paint background images always via drawinglayerZolnai Tamás1-63/+0
Painting via GraphicObject is obsolete. See fdo#68927 where the problem was the quality of svg graphics, it seems a good idea to extend this improvement to all graphic type. Change-Id: I57a26d4fcfea8e4f666504a90281365e8a9a7e1d
2014-11-07Remove these useless static bool variables.Zolnai Tamás1-32/+14
Change-Id: I7a8ad7814231f129d5d1146ceb36eb2c22b2aff1
2014-11-07Ignore the swapped in graphic, but use its sizeZolnai Tamás1-3/+6
Change-Id: I75f17ab5e55119965fcede2b220979cefc1e26ab
2014-11-07Assign graphic data also during auto swap inZolnai Tamás1-0/+1
Change-Id: I09b8d11027f4a1e8470b81677388d4a573b372a6
2014-11-07Avoid an image loss situation of auto swappingZolnai Tamás2-3/+3
Before an image data is used GraphicObject should be swapped in. When a GraphicObject is swapped in auto swapping mechanism is triggered which can swap out some of the images. We should avoid to swap out the same image on which the swap in method was called before because the caller code assumes that the image data is there. Change-Id: Ia4addc370742aea5fbf185cf87e3c062a5ebf5be
2014-11-07Make SetSwapState() an internal methodZolnai Tamás1-1/+5
So we can be sure it is always called when user data changed. Change-Id: If107907afffb85a7a57817f5807847a5c028416c
2014-11-07Avoid using null pointer as a special indicatorZolnai Tamás1-2/+11
When ImpGraphic::ImplSwapOut() is called with null pointer it was assumed that it is becase the graphic is a link and so we don't need to swap out it actually (we can load it anytime using the link), only clear the graphic's internal data. The problem with that it can happen that ImplSwapOut() is called with null pointer accidentally on a non-link graphic object which leads to that we loose the graphic. Seems more robust to use an explicit indicator (GRFMGR_AUTOSWAPSTREAM_LINK) for links swapout. indicator Change-Id: Icf31524a192c7866278ba6a13eb85648aa69f554
2014-11-07Always call ImplAfterDataChange() when data is changedZolnai Tamás1-8/+4
Call it inside ImplAssignGraphicData() which assign GraphicObject members using Graphic's data. With that ImplAfterDataChange() method also called in constructors. It's important to call ImplAfterDataChange(), because this will trigger the auto swaping mechanism. Change-Id: I45af91f8df2fb5b0143fcc5eb05e82e4d408d0bc
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann6-8/+10
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06coverity#1242570 Untrusted value as argumentCaolán McNamara1-1/+11
Change-Id: Ic79bd1931ee291746b6dae138b3181d4baddbe3e
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin6-10/+8
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05markup with event type not checker typeCaolán McNamara1-1/+1
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-11-05coverity#737920 Uncaught exceptionCaolán McNamara1-26/+34
Change-Id: I282b874c22c373e078007a29bcbbe74b175a70d3
2014-11-05fdo#60906 - Make color configuration consistentIoan Radu1-10/+10
Sinchronize colors from colorcfg.cxx with settings.cxx Change-Id: If3a9c7ac2593e5a452a57590189ad787b807b83c Reviewed-on: https://gerrit.libreoffice.org/12199 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin1-1/+1
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-04coverity#1242516 reorg to silence Arguments in wrong orderCaolán McNamara1-5/+7
Change-Id: I0d7a93461f37d5ca18605cd94b630d70d871adfb
2014-11-03coverity#1250408 Division or modulo by float zeroCaolán McNamara1-1/+1
Change-Id: I64c0d1cb4c3182c03a7d7660c4736f665fc5f3dc
2014-11-01coverity#1250406 Division or modulo by float zeroCaolán McNamara2-11/+8
and coverity#1250407 Division or modulo by float zero coverity#1250408 Division or modulo by float zero Change-Id: I77e4483356f7c0b287a29637cf6b958ee665ffec
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin3-13/+13
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: https://gerrit.libreoffice.org/12179 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-31convert COMMAND_WHEEL constants to an enumNoel Grandin5-5/+5
Change-Id: I413d821a984ab556bd19c52704c04de6d828f699
2014-10-31KEY_ALLMOD is the same as KEY_MODNoel Grandin1-1/+1
so just dump it Change-Id: I006045aea345e84ff1944fc1ed1daa94bd7bca61
2014-10-30Improve SvSimpleTable classPalenik Mihály2-16/+51
It is possible to order columns. This is set in Expert Configuration dialog. The header's itembits weren't set correctly therefore mouse click handler didn't do anything. The comparsion was slow on big table. Conflicts: include/svtools/treelist.hxx svtools/source/contnr/simptabl.cxx Change-Id: I7e1301d40433ef45b3d0a3fb300909345ede9d4d Reviewed-on: https://gerrit.libreoffice.org/12070 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-10-30document array_vs_singleton dismissalsCaolán McNamara1-0/+1
Change-Id: I8d7eb4c01197e885abca717c7814c61a7641ac9d
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin12-12/+0
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-29coverity#1202781 Division or modulo by zeroCaolán McNamara1-2/+2
Change-Id: I2908c57badd079c8f19c679f40ed815ce2cba374
2014-10-29coverity#1078539 Division or modulo by zeroCaolán McNamara1-0/+3
Change-Id: Ifbe3cbd8fa93ee828ed95c19893c52b8134d3fd1
2014-10-29ref-counting vcl::Window subclassesNoel Grandin1-1/+1
Points of discussion -------------------- (*) where in the Window destructor should dispose() be called? It's a seriously large method. (*) we're going to need similar typedefs and declarations for every single sub-class of vcl::Window, I assume that I will need to create a macro to make it less verbose. TODO ---- Update clang plugin to verify that: (a) dispose() methods always call their superclass dispose() (b) dispose() methods don't forget to clear any references owned by that class. Change-Id: I873d5d5166f811e2f65e49327cc98862559fcf30
2014-10-28coverity#1157745 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: I06e8e946063dc54335f3b672105d5cd0b3ff71a4
2014-10-26Some notes about image swappingZolnai Tamás1-0/+14
Change-Id: Ifbda35d2bcd73a8ca196d39f0f621da78e8cc576
2014-10-24loplugin: cstylecastNoel Grandin1-1/+1
Change-Id: Ia0f5f0d0efbe4693aba347bff32cd694117251fe
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky9-39/+51
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky8-19/+19
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-23fdo#84938: replace MENUITEM constants with enumNoel Grandin1-1/+1
Change-Id: I7b0085af3b13bd6e1a50bf1e0e986d1524b52d7b
2014-10-23callcatcher: lots more unused post ww1 filter removalCaolán McNamara1-107/+0
Change-Id: I7bf6dc1d366093e797a19a8e555103c15b311ac8
2014-10-20crash in tools->options->advancedCaolán McNamara1-2/+2
regression from... commit 06562c678410e425de629109ce92933c2d89a8f6 Date: Sat Oct 18 10:36:36 2014 +0200 convert SV_BMP_ constants to enum Change-Id: I46cb7f649fa44d8967e0e7da03583157d2706f05 Reviewed-on: https://gerrit.libreoffice.org/12018 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com> Change-Id: I29486e8fe17d9e06e01c33f93d99ffc6ae3d017c
2014-10-20fdo#84938: replace TIB_ constants with enumNoel Grandin1-4/+4
Change-Id: I435ce2331fb49e7ce9fe97bdfddfaef706759a84 Reviewed-on: https://gerrit.libreoffice.org/12023 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-18convert SV_BMP_ constants to enumNoel Grandin1-28/+26
Change-Id: I46cb7f649fa44d8967e0e7da03583157d2706f05 Reviewed-on: https://gerrit.libreoffice.org/12018 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-17coverity#1247633 Uncaught exceptionCaolán McNamara1-2/+2
Change-Id: I4058089f45b39ddacc56ccf2259ce6e939abe4ee
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 12:57:51 +0000