summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)AuthorFilesLines
2021-09-14tdf#142415 mouse events not propogated to table control event handlersCaolán McNamara1-0/+33
handle this with explicit callbacks from the cell widget for those events Change-Id: Ie605ca4286afc0fbd321f339fb7963771a303df5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122063 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-31tdf#144183: restore 'erase' that was accidentally droppedMike Kaganski1-0/+1
... in d47ac2ebdb495b025eb26e17cbbe2509797c31f0 Change-Id: Ic4946b72a0ef599428af5b806754bda5f0906990 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121282 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 638acd81979f24262c29dc12e0289d7fc38fcd8b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121284 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-25ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara1-1/+1
Change-Id: I69b76dd2aed35fe2038e61eef343ee8d84f053f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120926 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 6f790c8b31360463670439e6857ea64f418ddfbd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120972 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-17tdf#143357 use a DateFormatter and a separate Calendar menubuttonCaolán McNamara1-2/+5
similar to what we ended up with in DateControl in svtools/source/brwbox/ebbcontrols.cxx Change-Id: I37c843ff7e1e8e39b318db80fe590ce5f796f46a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120453 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-10Resolves: tdf#143023 explicitly connect to ControlBase focus-[in/out]Caolán McNamara1-0/+1
instead of listening to the generic vcl::Window/Control focus events. The thing which really gets/loses focus is now a Widget hosted inside the ControlBase. also contains... fix comment Change-Id: Ia1783aff3fded7fd73de2b04b9aced647771a92c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119998 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> establish that DbCellControl Window member is always a ControlBase and remove resulting known redundant dynamic_casting Change-Id: I5f098ef1adee3ad5d2a2bc5fcd30523f980df2f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119999 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> EventWindow is always a svt::ControlBase Change-Id: I012d0bea687aa6d5965a4e2f6ce3899bfc629f1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120004 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-07-21tdf#143452: make 2 buttons in the date form control translatableJulien Nabet1-2/+2
Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=bafd50ee06d982e19d54fae0f9d8f968a2dedbd4 weld DateField Calendar floating window Change-Id: I43c108908c6e802f3a8014ccf3fa243bebcae0ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119293 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 73503ce975ce0923bfe2cfd075ac8b91de20f29e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119257 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-07-18make calendar button small-button style so it fits in limited heightCaolán McNamara1-0/+3
Change-Id: I1997ae2a3916372ded3d4120e4510144c6700777 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119035 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-07-15crashreporting: Crash seen in CachePreview from Idle UpdateHdlCaolán McNamara1-1/+4
the intent here is regenerate the previews if font settings changed which should mean that we restart at index 0 and not continue from the old index https: //crashreport.libreoffice.org/stats/crash_details/a01c5fcd-983b-40ab-b90a-8ee90286e5b8 Change-Id: I9604ad96cf6cc757d2d33469827d1295d309454d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118922 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-07-15a11y crash on teardown of FmXGridPeerCaolán McNamara1-4/+10
the XAccessible is destroyed before the attempt to dispose via the IAccessibleBrowseBox* so call that first before the XAccessible is destroyed Change-Id: I908a3fbc05f92b5e56b8b6f2bc0b27757d39d1fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118798 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-07-13Revert "flatten ValueSet item array"Caolán McNamara3-110/+110
I'm seeing a11y crashes in the impress slide transition ValueSet. The mxAcc member contains a ValueItemAcc which has a pointer back to the ValueSetItem so if its std::moved into another ValueSetItem then it continues to point to the older ValueSetItem and not the new one This reverts commit 30aa33e6a6b9fb230af96f619db27fcaf31ef914. Change-Id: I1fd81aa81e47f2e984dd47fdc8a905e25c9f6266 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118728 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-11Simplify Sequence/vector initializationsJulien Nabet1-3/+1
Change-Id: Ib02e25b4600666185cf0f8d0cc8d5c64186789c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117064 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-10Simplify Sequences initializations (sot/stock/svl/svtools/svx)Julien Nabet1-13/+2
Change-Id: Iec21851d69f4a8d5f557e9ed2d30e5f680cd62c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116943 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-09-Werror,-Wunused-but-set-variable (Clang 13 trunk)Stephan Bergmann1-5/+0
The (only) use of lineColor at > //m_pImpl->bUseGridLines ? _rDevice.SetLineColor( lineColor ) : _rDevice.SetLineColor(); had been commented out in 8578ba4dc736b53c3ca8461516e4024d276b3b05 "gridsort: consolidated and fixed table cell rendering" and then cleaned away completely with f4147a39374c7692728e8506961f23e59a069c45 "refactor TableControl to use RenderContext" Change-Id: I817800b26f4996a73a38fece22149ae87c2f9c01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116824 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-08Resolves tdf#131817 - Option to globally switch toolbar locking on/offHeiko Tietze2-63/+78
Reverts 6993d5d0f1079fe720a7da004b70b57361c99fc6 and sets Locked in GlobalSettings to true New UNO command ToolbarLock to toggle the state added to the toolbars menu Change-Id: I246280b2b7930f2bf686e6fc26383da4799b5028 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115797 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-06-06add x-office-calendar to allow symbolic namesCaolán McNamara1-1/+1
for gen map to existing sc/res/date.png Change-Id: Id85f5df27fd93deb7d1e653ae6cac1fb471d3470 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116761 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-04tdf#142638 crash leaving embedded object (GTK3)Noel Grandin1-0/+2
regression from commit 8d485ec0cd35ee1ae7684f2b6ca96c0f0c6f9dac Date: Sat May 29 08:34:28 2021 +0200 IsDisposed->isDisposed in vcl/../window Change-Id: I9bca182d7d7c4abf4c308bad44c0a3a0bb04a716 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116690 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-03HtmlWriter: add end tag checking and helper for attribute writingTomaž Vajngerl2-5/+41
Added an input variable to end to enter the name of which variable is ending. This is to check that the expected end tag is actually written. Added writeAttribute, which is independent from HtmlWriter and just writes the HTML attribute format to the stream. Change-Id: Ib00a4a37354cd1cb1781ba729ed4046a966e1eb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116629 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-01Add Sesotho {st-LS} 0x8030 to language listEike Rathke1-1/+2
Change-Id: Ifb304fb1a5ed05e79bcaaaf96e12171377973222 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116552 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-05-29flatten TabBar item listNoel Grandin1-137/+136
Change-Id: I75a57ffdd55de61cf6acc0e562e4ae76f0065585 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116373 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-29no need to allocate these on the heapNoel Grandin1-10/+10
Change-Id: I58847f8eb2c8dc17ca393a758d122cd3929deeb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116375 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-29flatten ValueSet item arrayNoel Grandin3-110/+110
and change mrParent to mpParent in ValueSetItem because references preclude copy construction and assignment Change-Id: Iabb0c6ccfa4eed645cf6ee75d7ff83f9c4ec5a1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116372 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-28tdf#142150 nothing already selected on MouseUp without previous MouseDownCaolán McNamara1-1/+3
if mouse down was on tooltip (possible on macOS) Change-Id: Icb4328fa6977356c3bac5f37d42e99ae8d4e4b98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116273 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-25tdf#142479 on 'return' select the entry the cursor is in before calling SelectCaolán McNamara1-0/+8
Change-Id: Ic11f8a12c93d1999dd6fbe555b9823660eb703d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116101 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-21add Toggleable as a separate thing to a ButtonCaolán McNamara6-9/+9
and inherit ToggleButton from both it and Button Change-Id: If0e500aca8d0ffa087cb5e2bfc1786372fbff4eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115921 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20move some headers inside modulesNoel Grandin4-2/+97
Change-Id: I2baa9e9334850cf72e8ea1e96a2177a1c052e589 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115868 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-19pass CheckButton argument instead of its Button baseclassCaolán McNamara1-1/+1
Change-Id: I76f446266fcc74ba2db928ef1c5e764eead57997 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115801 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-19ImplPlayWithRenderer never checks its OutputDevice against nullptrCaolán McNamara1-2/+1
just pass a reference instead and spread that around to some similar cases Change-Id: Ifb2dee8c7bf02a9f01982b928c90666cbbdd84fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115759 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-17split OutputDevice from WindowNoel Grandin9-51/+51
as part of a longer-term goal of doing our widget rendering only inside a top-level render- context. I moved all of the OutputDevice-related code that existed in vcl::Window into a new subclass of OutputDevice called WindowOutputDevice. Notes for further work (*) not sure why we are getting an 1x1 surface in SvpSalGraphics::releaseCairoContext, but to fix it I clamp the size there (*) might have to dump VCLXDevice, and move it's code down into VCLXWindow and VCLXVirtualDevice (*) can we remove use of VCLXDevice in other places, in favour of just talking to the VCL code? Change-Id: I105946377f5322677d6f7d0c1c23847178a720b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113204 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-07embeddedobj: handle getting the visible area on a threadMiklos Vajna1-0/+2
The Windows OLE2 implementation of the embedded object interface assumes that the same thread is used for loading and saving the embedded objects. This means that in case the main thread is used for loading (e.g. from remote UNO, but with OnMainThead=true), but a thread is used for storing (without an explicit OnMainThead=true), then the underlying win32 API call failed and we returned a fixed size in EmbeddedObjectRef::GetSize(). Fix the problem by explicitly checking for RPC_E_WRONG_THREAD and adding error handling for that case. Change-Id: Icf1e7722d33a809fa671d1505b2a0155af040c71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115236 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-05-06loplugin:unusedmethodsNoel Grandin1-1/+0
plugin code needed some updating because it was interacting badly with PCH code in pluginhandler::ignoreLocation Change-Id: I228f94a4e285747bd1d5b8536010f8617118cafa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115212 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-06Add English (Denmark) {en-DK} locale dataEike Rathke1-1/+2
Using ',' comma decimal separator and '.' dot group separator. ISO 8601 date(+time) formats. Inheriting calendar from {en-GB} (week-1stweek=4 first_weekday=2). Currency DKK 'kr.' symbol. Secondary currency EUR '€' symbol. See also https://lh.2xlibre.net/locale/en_DK/ Change-Id: Idcf1e52af0ac20412efa42d3873ab1e34a2f1eaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115177 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-05-05convert sal_uLong and tools::Long in vcl/settingsNoel Grandin1-1/+1
Change-Id: I69711b791884218f4a14c85fe69072b9ea06dc79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115109 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-03loplugin:stringadd improvement for appending numbersNoel Grandin1-4/+4
I was wrong, the Concat framework already optimised appending numbers by stack-allocating small buffers, so include them in the plugin Change-Id: I922edbdde273c89abfe21d51c5d25dc01c97db25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115037 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-03vcl: remove MetricVectorChris Sherlock1-1/+1
Change-Id: Ib700887ca79f423c65dfb75eea36bbfd808fa172 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114976 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-05-03sal_uLong->sal_Int32 in IMapCircleObjectNoel Grandin1-1/+1
Change-Id: I47f4901d38cfb14011a0b7db4cc38203e3e14e30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115009 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-03sal_uLong->sal_uInt32 in HTMLOutFuncsNoel Grandin1-2/+2
Change-Id: I112ac7c3eedcab912e54fb226c6253d88d64b6fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115003 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-02sal_uLong->sal_uInt32 in SvParserNoel Grandin2-18/+18
Change-Id: Ibe5599e1cc136330a8e9c089c7cc66d0ef4bc966 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115002 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-02throw() -> noexcept, part 2/3: Automatic loplugin:noexcept rewriteStephan Bergmann11-27/+27
Change-Id: I076f16d0536b534abf0ced4d76051eadb4c0e033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114949 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-02tdf#79049 speed up OOXML workbook load (4)Noel Grandin1-1/+1
Optimise LocaleDataWrapper for reads by initialising the data we in the constructor, so we don't need any kind of locking Reduces load time from 34s to 28s. Change-Id: I4bd3bddb30b70ba015fe5b1372534f9507762b74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114960 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-28use string_view in INetURLObject::encodeNoel Grandin2-5/+5
Change-Id: Ib686c6872388b02c8939d3b65f6bd25cda348bc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114754 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-27loplugin:stringadd convert chained append to +Noel Grandin1-40/+25
which can use the more efficient *StringConcat Also fix a crash in stringview plugin which started happening while I working on this. Change-Id: I91a5b9b7707d1594d27d80b73930f5afac8ae608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114568 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-27use more string_view in tools/streamNoel Grandin4-15/+15
Change-Id: I2a957cd72d71fea717734488cdb3670e0bcdd6f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114657 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-23we want the a11y screen locationCaolán McNamara1-1/+1
gen uses the absolute screen position so that's what's expected Change-Id: I4f51c272a49a640e0a387bc123b2cc17ea430d6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114551 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-20rename DrawFocusRect to InvertFocusRectCaolán McNamara1-2/+2
Change-Id: If7a951a3f5f68cebc7e7fedb810db74c99f94765 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114346 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-20uniformly remove xalign of 0Caolán McNamara1-2/+0
Change-Id: I7a866326cbe065c87a6cedc02f2925880d46d4af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114311 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-19convert some #define to OUStringLiteralNoel Grandin2-33/+33
Change-Id: I3d2ce76d30ec4f42495d27f1913c6718d2c5078f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114293 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-15loplugin:stringliteralvar look for assignmentsNoel Grandin1-3/+3
to O[U]String from char array literals, we can convert the char literals to O[U]StringLiteral and avoid a runtime allocation Change-Id: I15d8dddb2cd428b90740e39f20daf98e0941aa6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-14tdf#115464 Added "prevent input" in export dialogAditya Pratap Singh3-246/+304
Change-Id: Ib3e863e4318a3877a36b8ae47dc9b09f3c4b8918 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113422 Tested-by: Jenkins Reviewed-by: Aditya, Pratap Singh <adityapratapsingh51@gmail.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-04-12forward decl vcl::Window in uiobject.hxxCaolán McNamara1-0/+1
Change-Id: Ic4355a7cbf15e211b820e8343638100f729b4189 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113969 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-09Avoid user interaction when determining recent documents' MIME typesStephan Bergmann1-7/+31
After 6fcabbd6199869753fd6a266f23901962a77f556 "tdf#129153: Show MIME type icon in main menu File>Recent documents list", I e.g. got an "Authentication Required" dialog asking for user name and password if there was an sftp URI among my recent documents. Change-Id: Ic772c500f9dd2bc2418ea7dbea966e8478a35729 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113887 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-19 05:17:20 +0000