summaryrefslogtreecommitdiff
path: root/svtools
AgeCommit message (Collapse)AuthorFilesLines
2020-04-16fixes for code creating reversed RectanglesNoel Grandin1-2/+2
ie. where left > right or top > bottom These are all places where the code is self-evidently doing the wrong thing. Found by adding asserts to tools::Rectangle. In theory, this is legit, and code that wants a proper Rectangle is supposed to be first call Justify on a Rectangle, but lots of places don't do that, and that seems very dodgy to me. So lets work towards Rectangles always being in a valid state. Change-Id: I03296a624bd9b5b193e6aa8778addfb09708cdc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92310 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-16loplugin:buriedassign in svtools..svxNoel Grandin4-71/+100
Change-Id: I04bc97effddb213e9c1ac613b61d3a0bc38522ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92314 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-15add an IsEmpty method to tools::Size and use itNoel Grandin2-4/+2
Change-Id: I7f5201e2ea6c74329336e16bf219630e38ff92cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92264 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-11rename vcl::Window::Update to PaintImmediatelyNoel Grandin6-16/+16
To make the code easier to read. Change-Id: Iebc648150391939fba5d1cd815c72dbcf02ceec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-06remove newly unused stuffCaolán McNamara1-1/+0
Change-Id: Idce9955294372817c0dd1f40ebd38f16fc90eab5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91007 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-25no reason for the FontAntiAliasing setting being UNX-only (tdf#107744)Luboš Luňák1-15/+1
This dates back to the ancient times where no revision control history dares, so no idea why this was so, but it doesn't make sense, as at least Windows can disable AA for fonts too. And if some platform really wants to hide the setting, it should be enough just to hide the UI element, no reason for '#if defined( UNX )' all over the place. Change-Id: I76fc9ad157358321904573079ace5a3fe556f86a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91041 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-03-25Remove unused using declarations in oox...xmlsecurityGabor Kelemen5-10/+0
Found by: run-clang-tidy-10 -checks=-*,misc-unused-using-decls Change-Id: I3e95791e223ef01e140a6217e29a9efae428a784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90876 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-24weld writer navigatorCaolán McNamara1-0/+3
GtkToggleToolButton are much wider than vcl equivalents. Split the bottom toolbar into two toolbars. Rearrange their contents so the layout of each level visually match. Notes: Master documents have two modes, master content tree and the normal content tree. You can drag entries from the content tree into the document, drag mode drop down controls whether its a link or a copy etc that's dropped in. Documents can be dropped into the content and global trees. If outline tracking isn't active, then when content changes the tree is cleared and refilled, typically an effort is made to reselect the same entry that was previously selected. Additionally, if the amount of content didn't change an effort is made to scroll back to the location the scrollbar was at before the clear. Change-Id: I00c015145eac5b1acc3398d3c40861d830e4264a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89725 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-13Revert "loplugin:constfields in svtools"Noel Grandin21-56/+56
This reverts commit 07c4aa4298f062cee1894b80ef82e76d5ffcf4c7. Change-Id: Ic3f639581b9aca373f82c011f15be60d117b1943 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90476 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-12tdf#131297 Add Sundanese [sun-ID] to language listEike Rathke1-1/+2
Change-Id: I2935811e1fb3bc13cb61a849aeaf9e628a55cdf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90383 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-03-09save/restore the entry text of the fontsize widgetCaolán McNamara1-2/+6
instead of its value, because the min value is 2, but we set empty text to indicate multiple values are selected in the underlying text. Change-Id: If4232b500cd177a264aa5e6ca0537021483db95f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90208 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-04We have had C++11 for some time nowTor Lillqvist1-1/+1
Change-Id: I3946aba66a49518fb6c3fe6e1767babecddc956b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89962 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-02-21Drop o3tl::optional wrapperStephan Bergmann8-74/+74
...now that macOS builds are guaranteed to have std::optional since 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". The change is done mostly mechanically with > for i in $(git grep -Fl optional); do > sed -i -e 's:<o3tl/optional\.hxx>\|\"o3tl/optional\.hxx\":<optional>:' \ > -e 's/\<o3tl::optional\>/std::optional/g' \ > -e 's/\<o3tl::make_optional\>/std::make_optional/g' "$i" > done > for i in $(git grep -Flw o3tl::nullopt); do > sed -i -e 's/\<o3tl::nullopt\>/std::nullopt/g' "$i" > done (though that causes some of the resulting #include <optional> to appear at different places relative to other includes than if they had been added manually), plus a few manual modifications: * adapt bin/find-unneeded-includes * adapt desktop/IwyuFilter_desktop.yaml * remove include/o3tl/optional.hxx * quote resulting "<"/">" as "&lt;"/"&gt;" in officecfg/registry/cppheader.xsl * and then solenv/clang-format/reformat-formatted-files Change-Id: I68833d9f7945e57aa2bc703349cbc5a56b342273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-21loplugin:unusedmethodsNoel Grandin3-29/+0
Change-Id: I2194158d555958f0192d8d6c18e4c093608b8fb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89119 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-20loplugin:singlevalfieldsNoel Grandin3-30/+20
Change-Id: I9ff752b06facfbb04c10c8f9b46b650143b02ca4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89117 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-20Remove some unused includesMiklos Vajna1-0/+3
Change-Id: I28b007cff3a99bc40901ecdeaecacf42b4521574 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89058 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-19can avoid including svtools/ctrlbox.hxxCaolán McNamara1-2/+1
Change-Id: I953089dd1416cd24721241fff3a6d21354211a5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89018 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18Resolves: tdf#130757 Add Minangkabau [min-ID] to language listEike Rathke1-1/+2
Change-Id: I901e64c223723bf2eac908dda80796a7a2799147 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88985 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-18move svmedit.hxx internal to svtoolsCaolán McNamara4-3/+38
Change-Id: I52469e2029f292e7d5e9002cb9d098c14576a00d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88892 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18VclMultiLineEdit is sufficient hereCaolán McNamara1-6/+3
Change-Id: Id3e20d4eebb02f0022b138dfcd835ea70f1417f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88891 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18VclMultiLineEdit is sufficient hereCaolán McNamara1-2/+2
Change-Id: Ibacffee0520d7525d552820713f3d4d620e1f156 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88890 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-18move SVTXFormattedField, SVTXCurrencyField, SVTXNumericField to toolkitCaolán McNamara3-1132/+2
Change-Id: If22200a4f342d4d779c612dbace61a4cf99471ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88866 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17remove some unnecessary button.hxx includesCaolán McNamara1-8/+2
and update pches Change-Id: I61ca0be7a838e4eec6c41e0ece58d8a6b0e64c37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88861 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17Drop needless junit and python make conditionalsJan-Marek Glogowski1-2/+0
JunitTest and PythonTest modules check for these themself. Change-Id: Ia453bc99571738b01cc8f161f346cb6c37b2e429 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88832 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-02-16use fwd decls of StatusBarCaolán McNamara2-1/+3
Change-Id: Ib7ba9978e348a824a23310f9a4e6cfb6b7c18f0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88811 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-16use fwd declsCaolán McNamara5-4/+6
Change-Id: I06a4049d84d3ef755b713c045f686361782bdfc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88807 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-16move TreeControlPeer to toolkitCaolán McNamara4-1759/+0
Change-Id: Id5298615f0f3dad6e61955e23367c0345b33f2b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88813 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14remove recently unused functionsCaolán McNamara1-91/+1
Change-Id: Ie7645d7f9b8350d3a993c40541747dc8ac817ab9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88730 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14use fwd decl of SpinFieldCaolán McNamara2-1/+12
Change-Id: Ifea23e791ec53448a8591583f283b87430ef38c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88678 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14split StringToMetric and TextToValue into fieldvalue.hxxCaolán McNamara1-1/+1
Change-Id: I5d1102f7a50a7a246df9f6de8b7a6df6557eb54d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88682 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14split out MetricField value conversion functionsCaolán McNamara1-2/+3
Change-Id: I67a33bd2a5cb06dc66e471918b5c378044a2eff2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88679 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14use forward decls to reduce including unnecessary headersCaolán McNamara2-1/+2
Change-Id: Iaa25ac1ac99e0dcf09bce21f4bad8cb9b5568a1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88633 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14move VCLXFileControl to toolkitCaolán McNamara6-666/+1
Change-Id: I39bb417fe7e033a8f368fa04d4a30b2388bcddfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88615 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13factor out dialog hacksCaolán McNamara1-3/+4
Change-Id: Iceefc8d739fb93b97adfa1e35d8308f0c48f02e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88600 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12clang-analyzer-deadcode.DeadStoresNoel Grandin2-8/+8
Change-Id: Ifa384933569b27d0d08eb479bb95b799163ae386 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88450 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-11fix svtools' sVendor for langpack install for DebianRene Engelhard1-2/+1
after a21987977eae34eaf02fa109201c802f77ea68d1 Change-Id: I4bd2b37e3f006209f55bccca9fe117b0c0c4efbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87908 Tested-by: Jenkins Tested-by: Rene Engelhard <rene@debian.org> Reviewed-by: Rene Engelhard <rene@debian.org>
2020-02-11cypress: mobile: Font size combobox is broken on core/master.Caolán McNamara1-5/+0
so https://cgit.freedesktop.org/libreoffice/online/commit/?id=08d6c3fdf9bac4ad8318151ab1402690eb950f52 isn't needed Change-Id: I8836969ae064342835287a63065e591f083f2220 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-10Resolves: tdf#130550 Add Ligurian [lij-IT] to language listEike Rathke1-1/+2
Change-Id: I6a83bd754ebebf877d6638d5672194aefcf179bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88372 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-09Fix typoAndrea Gelmini1-2/+2
Change-Id: Ic5cca7e798240af9581782820409938755a5d920 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88318 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-08cid#1458164 silence Unchecked return valueCaolán McNamara1-1/+1
Change-Id: If5c77b40195e7f6599fa24c1317c22507043de32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88240 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-08replace some more copy/clear with swapNoel Grandin1-4/+2
Change-Id: I6501dd59682d2605e9b9856c2deaa02a873ce641 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88239 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-07rename URLBox back to SvtURLBoxCaolán McNamara1-38/+38
Change-Id: Icd90eeb492002c45ddd8ff562a6da411abead122 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88185 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07SvtURLBox is now unusedCaolán McNamara1-1005/+1
Change-Id: Iab78b3803272ceb62c4df74241b64f23b1437b03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88184 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-02-07move some headers inside svtools moduleNoel Grandin18-15/+913
Change-Id: I62fe3345aebe148010971bc8c487d96fa601d420 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88164 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-07loplugin:unusedmethodsNoel Grandin1-153/+0
Change-Id: I7296b2fc2862d0ad1f68658b19b2a25cb7609df1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88080 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-06no FontNameBox exists in any .ui file anymoreCaolán McNamara1-14/+0
Change-Id: I9ca3a4da0cd9bcc2b528d5c761a55efd2a4de2f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88106 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06drop unnecessary includeCaolán McNamara1-5/+5
Change-Id: Ifb7e34d5648238a1cf0a893a6713671fa6881161 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88066 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06rename SvtFontSizeBox back to FontSizeBoxCaolán McNamara1-15/+15
Change-Id: I2ec0c6dd376f3a192a62dc97f7454af946e2a5ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06drop newly unused FontSizeBoxCaolán McNamara1-146/+0
Change-Id: I8a84ce74888e1d3c468251ddd3633aedf6339a11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88064 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-06weld SvxFontSizeBox_ImplCaolán McNamara1-1/+10
which enables making a native gtk widget a member of a toolbar This widget wants to distinguish between a value getting selected by the menu or not, which is fairly tricky Change-Id: I9014785530bd0d82ffa66842f940feb2d3237e68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87971 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-13 00:58:12 +0000