summaryrefslogtreecommitdiff
path: root/svl
AgeCommit message (Collapse)AuthorFilesLines
2016-03-17Revert "tdf#98458 sw: make search in shape text optional"Jan Holesovsky1-14/+2
Actually there seems to be a simpler solution to the immediate performance problem which I'll commit next. It still might be necessary to introduce the search switch at some stage, but first let's see if there are complaints. This reverts commit 8e0b08c3053ed5472409b1ea7e02653aad38f7d6.
2016-03-17loplugin:constantparam in svlNoel Grandin5-27/+20
Change-Id: If23e43beb401047825641817e09d7fdeb904f9d9 Reviewed-on: https://gerrit.libreoffice.org/23317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17tdf#98458 sw: make search in shape text optionalMiklos Vajna1-2/+14
Instead of forcing it silently on everyone, add a new search option and enable it only in case it's requested, as shape search is expensive for large documents. (Regression from commit bdc1824ea7acfa2fe9d71cdbe57882acce155577.) Change-Id: Ibb6e76ad5c870dfd63b36429e16ef6d572f5f1fd
2016-03-16loplugin:constantfunction in ucbhelperNoel Grandin1-2/+1
Change-Id: I80e00b5ac2621378801f89532ed88b377ef72b60 Reviewed-on: https://gerrit.libreoffice.org/23297 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-10Avoid reserved identifiersStephan Bergmann1-11/+11
Change-Id: I815c839b19e5b2d7d5b5bab821614ad953006de2
2016-03-10Avoid reserved identifierStephan Bergmann1-3/+3
Change-Id: Iea66c7230f4570d6a2b88a514958788eb4105ffb
2016-03-09remove unused NOT_POOLABLE enum valueNoel Grandin6-38/+26
and simplify the resulting SfxItemInfo field down to a single bool Change-Id: I73e24e83d39afc7660ac85872ba96bc790713cb2 Reviewed-on: https://gerrit.libreoffice.org/23058 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-09loplugin:constantparam in svlNoel Grandin2-17/+12
Change-Id: Iefc441262cbdc6f115ea4ca5a673456b59477e13
2016-03-07loplugin:unuseddefaultparamsNoel Grandin1-3/+3
Change-Id: Ia414f7845425ef73859ed04853378e96cc738795 Reviewed-on: https://gerrit.libreoffice.org/22971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07tdf#97703 removed empty setUp/tearDown methodsChirag Manwani1-5/+0
Change-Id: I244d481bce4723d172e26c0d31aab0a541334604 Reviewed-on: https://gerrit.libreoffice.org/22959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-07loplugin:unuseddefaultparam in variousNoel Grandin1-9/+2
Change-Id: I03d7381aad055cbe9bd905e4082586073f4112e0 Reviewed-on: https://gerrit.libreoffice.org/22900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-01loplugin:unuseddefaultparam in svlNoel Grandin9-117/+48
Change-Id: Ifc82563c8930332d460df4d97935ba6e9946689f
2016-02-26add SvxSearchItem::GetWildcard() SetWildcard()Eike Rathke1-2/+22
Change-Id: I0aeb7fbcedad381a385ffe6649ac51e8c961ca11
2016-02-24let SvxSearchItem use SearchOptions2Eike Rathke1-3/+28
And all those places that interface to SvxSearchItem. Change-Id: I08915824a596cd0f247a89f44e4684cd22b98082
2016-02-23new loplugin: commaoperatorNoel Grandin1-1/+2
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-19new loplugin: find write-only fieldsNoel Grandin1-3/+0
Change-Id: I0f83939babacf92485420ee63f290a297d7cb717 Reviewed-on: https://gerrit.libreoffice.org/22498 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-17use consistent #define checks for the Windows platformNoel Grandin4-6/+6
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-12tdf#95857 Sort out German plurals ...danielt9981-7/+7
Made a start in removing the incorrect 'Infos' German plural Change-Id: Ie989351a7473fc35b563e63ce6a4fb229093af60 Reviewed-on: https://gerrit.libreoffice.org/22301 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-11[API CHANGE] add operator==/!= to UNO structsNoel Grandin1-2/+2
this is useful now that we are storing UNO structs in std::vector Change-Id: Ic558bcd669bd2b3cdf9eb8393269eb906ac52369 Reviewed-on: https://gerrit.libreoffice.org/22257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09UIDNA_CHECK_CONTEXTO is only available in ICU >= 49Stephan Bergmann1-1/+4
...unlike the rest of the createUTS46Instance stuff, which is available in 4.6. While it is desirable to have that check here, it probably doesn't make much of a difference in practice, and Rico Tzschichholz would like to have this working on Ubuntu 12.04, where only ICU 4.8.1 is available. Change-Id: I5bbd2ed296c6e068e175e7f8353cea37ed4d9e44
2016-02-09Remove excess newlinesChris Sherlock36-159/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09Formatting changes across all modulesChris Sherlock1-4/+0
+ Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08tdf#88205 Delete 'uno::Sequence' in svlkerem1-8/+4
Change-Id: I5f2d79bedcea2712070c4e50b6f9e6d0d0112920 Reviewed-on: https://gerrit.libreoffice.org/22193 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-02-08loplugin:unusedmethodsNoel Grandin1-278/+0
using an idea from dtardon: <dtardon> noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... <noelgrandin> dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-05Fix typosAndrea Gelmini1-1/+1
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-31OSL_THIS_FUNC is a rip-off of BOOST_CURRENT_FUNCTION so we can use thatCaolán McNamara1-1/+0
as a direct drop in I guess Change-Id: I3add63f1459f4e659019bd6db54da2f5431958ce Reviewed-on: https://gerrit.libreoffice.org/21941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin5-8/+8
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-20loplugin:unusedmethodsNoel Grandin2-86/+0
Change-Id: Ib2dc804f55d1a96ae01f2cf31b7d55956040a72e Reviewed-on: https://gerrit.libreoffice.org/21603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-14grml.. stupid oversight..Eike Rathke1-1/+5
Change-Id: I95b27000adfd0a29ed6e462f972340eee31d3a0b
2016-01-14it's unnecessary to buffer the string to create a string from it againEike Rathke1-19/+10
... just in case there was a negative number and a minus to be inserted. doubleToUString() does it already. Change-Id: I0052d7bc91b48efb5f14f2f6f5a7c672a1e50ea9
2016-01-14do it right and remove then superfluous mumbo-jumboEike Rathke1-28/+13
... that worked around cases where it went wrong. Change-Id: Icdd4bddfb341a3d0abe4183cf788c546dcddbd00
2016-01-14loplugin:unusedmethods unused return value in store,svlNoel Grandin2-14/+9
Change-Id: I369b3ae84af046242430977cec7d5c5e69fc27e7
2016-01-13-Werror=unused-but-set-variableStephan Bergmann1-2/+1
Change-Id: I01c18a1b8193f491a82988426ac4e673dd68897a
2016-01-13tdf#97077: So ppStaticDefaults can be null after allStephan Bergmann1-26/+27
...at least in Base, and the assumption in 43de9a5b0f68a77a10595b3f69c6145cd9be05b6 "What these SAL_INFO probably want to tell us..." was wrong Change-Id: Ic9377b72f35c130ecd34dbf76c1f6a0f4b235c69
2016-01-13loplugin:unusedmethods unused return value in include/svlNoel Grandin8-39/+16
Change-Id: I759fe8769daccea07c2157bfb5912df8ba285534
2016-01-10Fix typosAndrea Gelmini5-6/+6
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-06What these SAL_INFO probably want to tell us...Stephan Bergmann1-51/+46
...given the oldest incarnation of the code still available is HACK( "fuer Image, dort gibt es derzeit keine Statics - Bug" ) if ( ppStaticDefaults ) and HACK( "fuer Image, dort gibt es derzeit keine Statics - Bug" ) if ( ppStaticDefaults ) from cf7e1f9cc99e7c260cfab823f2c47f56035bdbd0 "INTEGRATION: CWS visibility03: #i45006# Moved from svtools/source/items/ (for svl/items1.lib)"... ...is that ppStaticDefaults should really be non-null, but "Image" (Draw? Impress?) needed a temporary (?) hack there. Test that assumption by asserting that ppStaticDefaults is non-null. Change-Id: I2a75547618da1d211c44176e4593f6951a0e0298
2016-01-06Revert "This probably is not worth displaying a warning about"Tor Lillqvist1-0/+1
It might be a useful warning. This reverts commit d202f851717bb5a8fe5fed98f747a1fd164d3225.
2016-01-05This probably is not worth displaying a warning aboutTor Lillqvist1-1/+0
Change-Id: Ic14af2992fa020f93329573354616d5b781af111
2016-01-05tdf#96708: don't modify document while copying to clipboardMike Kaganski1-3/+1
I.e., don't try to create auto-layout for clipboard pages which don't contain one; don't resize objects to text. Also, don't invalidate items that are equal to defaults, because explicitly set items are not the same as absent items: pasting an object without an item makes the property to inherit new target's default, while when the item is present, the default doesn't apply. Also, don't consider selected state of the page while stringifying - this makes selected page string to differ from not-selected clipboard page. Change-Id: I172e03e1a8c428e5fcae3a116cc9ad8de79f1a87 Reviewed-on: https://gerrit.libreoffice.org/20871 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-12-21crashtesting: post NPAPI removal crash fixingCaolán McNamara1-0/+2
Change-Id: I99d79735c375f3d632382a8efa0202517a293b1f
2015-12-15...and this looks like a memory leak, tooStephan Bergmann1-0/+6
Change-Id: I5e203fe8b58d687c0c294c75e385f0bbc858ba07
2015-12-15Memory leakStephan Bergmann1-1/+3
Change-Id: I99da487f0bed527eaacf47642884ae25fb0ae8b1
2015-12-15Bin unused function DbgCheckItemSetTor Lillqvist1-33/+0
Change-Id: Ia08e7ea3381cd450d2dadd8add723574634124e0
2015-12-15Bin silly 'STATIC DATA' commentsTor Lillqvist3-8/+0
Change-Id: I50e3772b7b479d2cf1eb644c7334d0f987874ccb
2015-12-03uno::Sequence->std::vector in SfxIntegerListItemNoel Grandin1-14/+10
Change-Id: Icdbb361feea2ebee74f9d0a906bdd3c2882443e8
2015-11-30loplugin:unusedfieldsNoel Grandin1-3/+0
Change-Id: Icac4ac1a2614e72bc9ff070819533e09eeb1a864
2015-11-28-Werror,-Wmicrosoft-enum-valueStephan Bergmann1-2/+2
Change-Id: I50aaeb264c901146c119192cbd961b20117788e1
2015-11-28Missing includeStephan Bergmann1-0/+1
Change-Id: I62fd53d6f39349405865783bc44edbb7929664a1
2015-11-27introduce SvNumberFormatter::GetFormatStringForExcel()Eike Rathke1-0/+56
Taking implementation from sc/source/filter/excel/xestyle.cxx GetNumberFormatCode(), slightly modified to ensure valid conversion and force en-US locale data. Also don't unnecessarily convert if format is for system locale and system locale is en-US. Change-Id: I9223eaa655132b4106a35c94cb0005559d7575b1