summaryrefslogtreecommitdiff
path: root/svl
AgeCommit message (Collapse)AuthorFilesLines
2016-08-22tdf#101636 Test index before reading OUStringLaurent Balland-Poirier1-1/+1
Change-Id: I0a4c02b172fc6d3273f6aa2cca855c27705b4d68 Reviewed-on: https://gerrit.libreoffice.org/28282 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 734eb8b034c8035565d091aa016ce3b8df838b19) Reviewed-on: https://gerrit.libreoffice.org/28314
2016-08-16tdf#101462 tdf#79399 lcl_matchKeywordAndGetNumber returns integerLaurent Balland-Poirier1-2/+2
This prevent [DBNumX] format codes to be recognized Fix in the same time tdf#79399 (import of [DBNumX] from XL) Do NOT fix yet tdf#79398 (export of [DBNumX] to XL) Change-Id: I08817818bf0ff30b4704bb69b2ac9aa3890c7aa6 Reviewed-on: https://gerrit.libreoffice.org/28071 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit b1ce5db192750210b1546417494664f91759719d) Reviewed-on: https://gerrit.libreoffice.org/28141 Tested-by: Laurent BP <laurent.balland-poirier@laposte.net> Reviewed-by: Laurent BP <laurent.balland-poirier@laposte.net>
2016-08-09do not resolve system locale when queried, rhbz#1364406 relatedEike Rathke1-1/+1
When loading older documents that calculated a number format on the fly an inherited but default format of a type could had been applied using the fixed resolved locale instead of the default system locale, which then was stored upon save and remained sticky. This because a format the formula depends on already was applied using the resolved system locale. http://bugs.documentfoundation.org/attachment.cgi?id=78559 of tdf#63267 exhibits the behavior on the hidden sheet 'Festwerte' when unprotected and inspecting number formats in column A under Datum. Change-Id: If23908f259458e988c5164cc5e268bfc9a6a6bcd (cherry picked from commit 0d386267458b881f15e555186b52f7e2517ceca1) Reviewed-on: https://gerrit.libreoffice.org/28004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-04tdf#101147 New approach to fix minute/month detectionLaurent Balland-Poirier1-6/+4
Other formats may be differently interpreted HH YY/MM => Month expected HH DD/MM => Month expected Change-Id: Iabb17911bf2907c02b6b898052b6933692f8074a Reviewed-on: https://gerrit.libreoffice.org/27886 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-04break the Excel rule for YMD and DMY, tdf#101147 follow-upEike Rathke1-2/+10
Clearly in {HH YYYY-MM-DD} the MM should not be minute. Also not in {HH DD.MM.YY}. Don't follow every bullshit. Period. It is debatable how to treat MDY, {HH:MM DD/YY} should be different from {HH MM/DD/YY}, Excel ironically takes both as minute, even in an en-US locale. (cherry picked from commit 88134dcba680418496f7a1c70a47fde0159ce390) Conflicts: svl/qa/unit/svl.cxx Change-Id: I13d39a36294e3c40cc0e9bf72026804b299bb264 Reviewed-on: https://gerrit.libreoffice.org/27813 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-08-01tdf#101147 Improve (again) minute/month detectionLaurent Balland-Poirier1-8/+15
For format like HH:MM:SS MM/DD second MM is detected as minute: see tdf#95339 New rules: - first M following each H is minute - first M following first S is minute Detection Month/minute now fully compatible with Excel even with unwanted detection: SS:MM:HH DD/MM/YY second MM is minute even if user would expect month Reviewed-on: https://gerrit.libreoffice.org/27560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit aa6bca0dfa0a58aae91eb5fa3564add642cd4238) Conflicts: svl/qa/unit/svl.cxx svl/source/numbers/zforscan.cxx Change-Id: Ia789fbc2dbd6d2dcbe9b9c34d3f288674966dd10 Reviewed-on: https://gerrit.libreoffice.org/27768 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-27Resolves: tdf#100046 the dreaded 1945-04-02 Double DST, also tdf#79663Eike Rathke1-1/+38
This is a combination of 5 commits. two more testDateInput() dates Found in comments of i18npool/source/calendar/calendar_gregorian.cxx Calendar_gregorian::setValue() (cherry picked from commit 17fb4d43e86bd9622fb1b2c4378ab1e63a0025f0) display data on test failure (cherry picked from commit 4097b95d62db14f738f69e3bb4d1162739f3a06a) add test data from tdf#79663, tdf#100046 related ... before changing anything. (cherry picked from commit 22dceea0ca3cd68463e390395aa8de479b680240) Resolves: tdf#100046 the dreaded 1945-04-02 Double DST, also tdf#79663 A coward not having changed this earlier, partially taken from a patch that was submitted for tdf#79663 but broke API, thanks to Isamu Mogi again. This removes all the clutter around timezone and DST correction that was necessary for early ICU versions, which apparently gets things right now and the clutter can still be confused by corner cases. (cherry picked from commit 8e91b0177cbf6554acf7ccfbcc573f647e7fcf4d) Conflicts: i18npool/inc/calendar_gregorian.hxx i18npool/source/calendar/calendar_gregorian.cxx activate the remaining 1945-04-02 test cases, tdf#100046 (cherry picked from commit 157b56a049a9a5f868d1f3b9856a631a40043a14) 432ba81929dd0badd48d2bd7b4344ceed4df2b43 edf89713de1eb02e501723f679bf059b5a43415e 9a90f933e8db8c6e0db145520ebf71cc27621abc 4d2f3d5602b162924c14348c0307a74ddeb93079 Change-Id: I4ab0aae15b7d97b22bc3a16d039542b5b49d3f14 Reviewed-on: https://gerrit.libreoffice.org/27559 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-25Resolves: tdf#101096 remove the "H after M" ruleEike Rathke1-3/+7
wrongly introduced with c9ed6e832213129cc579c1c309ce9dbd3593c57a Change-Id: Ic6c9c404ad0af11eb5d638f453150ee0da60e633 (cherry picked from commit c6e7dbaaa471861dcf76186ed3978ac95f81256e) Reviewed-on: https://gerrit.libreoffice.org/27526 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-25Revert "tdf#101096 Improve minute/month disambiguation"Eike Rathke1-9/+9
This reverts commit e9eb09d7e052e080a167102bea7eccdef8277c0b. There's a better solution to this. Change-Id: Ic4ca50af88069b6b3174da3600a77fe09c66655d Reviewed-on: https://gerrit.libreoffice.org/27525 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-07-25tdf#101096 Improve minute/month disambiguationLaurent Balland-Poirier1-9/+9
To fix tdf#95339 M-H was treated as minute-hour But for "D.M.H" it should be treated as day.month.hour THis commit extends test to detect if - in case of M.H: there is day or year previous M => M stands for month - in case of S.M: there is day or year after M => M stands for month Some ambiguous cases like S.M.D are now treated as it was previously (month) Change-Id: I048eb227a738b6c453e39d9208bef0d1fda136a0 Reviewed-on: https://gerrit.libreoffice.org/27514 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-12tdf#100842 Do not insert things in the middle of the numberLaurent Balland-Poirier1-0/+11
With fraction number format, if number is longer than number of digits in format jump to the beginning of number before inserting extras: strings, blank, star filling Do not do this for exponent of scientific format as it may contain unwanted 0 at beginning. Change-Id: Ide99f5cba198f76541f0e4e17b29469a99b57b9f Reviewed-on: https://gerrit.libreoffice.org/27097 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 0727e6e79994b66836841978a554b7f6855449dc) Reviewed-on: https://gerrit.libreoffice.org/27142
2016-06-03preserve ISO date+time format when editing such valuesEike Rathke1-19/+24
Change-Id: I6dcbe6c9aeff87d735303713f328c84203f76b60 (cherry picked from commit 020d395b59b4c631491ded910c0405584ef46e1c) Reviewed-on: https://gerrit.libreoffice.org/25843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-06-03add NF_DATETIME_ISO_YYYYMMDD_HHMMSS YYYY-MM-DD HH:MM:SS builtin format codeEike Rathke1-4/+20
Change-Id: I4fe6ef01a4c7fb795e4499e54aa55ebaaa0d433d (cherry picked from commit e7418e96cee263a0a74027335d7f5a119bb43ce2) Reviewed-on: https://gerrit.libreoffice.org/25842 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2016-06-02tdf#100122 Correctly treat fraction without integer partLaurent Balland-Poirier1-6/+8
If there is no integer part (with format such as ?/?): - sStr should be skiped - SFrac should be completed with the right number of ?, j==0 must also be treated in ImpNumberFill Change-Id: I57448eb3b0c68e10779d7fa565379e2604f7f63b Reviewed-on: https://gerrit.libreoffice.org/25612 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit a3471916370c53c6627ba4010489f539c174bdf9) Reviewed-on: https://gerrit.libreoffice.org/25803 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-30prevent out of bounds string accessEike Rathke1-10/+12
Yet another reminiscence of String to OUString conversion.. where the terminating NULL-character was obtained and SvNumberformat::InsertBlanks() effectively did nothing. Could be triggered already by entering an '_' underscore character as number format code, which is a place holder for blanks of the same width as the following character, which there isn't then yet. Change-Id: I0534e1417d4bd35e9e7ed4bd0170b9ea3b5fb575 (cherry picked from commit c75ce37560c05271ba56c9dd0d98c5001e83cc2f) Reviewed-on: https://gerrit.libreoffice.org/25692 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-25tdf#95339 Extend test to distinguish minute/monthLaurent Balland-Poirier1-0/+4
Detect minute in user number format such as SSMM or MMHH Change-Id: Iadb29dabba167b8f59903ff05e7367857378738a Reviewed-on: https://gerrit.libreoffice.org/25222 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-25SAL_FALLTRHOUGH in Windows-only codeStephan Bergmann1-1/+1
Change-Id: If35da46c209746a86687e1c3f60f72f2f08aa681
2016-05-24Implement basic TableStyle FamilyJakub Trzebiatowski1-2/+4
Change-Id: I3da13d26ced05e1948d483d432d6268b10c208b5 Implementing: getCount, getElementNames Reviewed-on: https://gerrit.libreoffice.org/25351 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-19loplugin:unusedmethods in slideshow to svtoolsNoel Grandin5-170/+1
Change-Id: Icf0056e13c88d7d347e668adaeddd4ed72af85cf Reviewed-on: https://gerrit.libreoffice.org/25141 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-19clang-tidy modernize-make-uniqueNoel Grandin1-1/+2
Change-Id: I550bb69ddcef69906027516ccde62cf8e87c295b Reviewed-on: https://gerrit.libreoffice.org/25138 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin5-54/+0
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18clang-tidy modernize-make-sharedNoel Grandin3-4/+4
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13Update mdds to 1.2.0. Note that the API version is also up.Kohei Yoshida1-5/+3
liborcus-0.11.2 is out only to make it buildable with mdds-1.2. Change-Id: I9648d827b008da252c57be0ebfd2efccb008ac70 Reviewed-on: https://gerrit.libreoffice.org/24944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2016-05-11clang-tidy modernize-loop-convert in scripting to svtoolsNoel Grandin7-42/+38
Change-Id: I98229d14109cf243839d632feabde1391ea9bad5 Reviewed-on: https://gerrit.libreoffice.org/24847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann4-6/+6
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-10Harmless missing breaks in switchStephan Bergmann1-0/+3
The fallthrough will only happen if eCodeType is anything but NF_KEY_MMM..., in which case the following cases will fall through to the end of the switch, too. Change-Id: I2fea503a0ce919dad645e3749b2173676fda5373
2016-05-09tdf#88657 calculate denominator lengthLaurent Balland-Poirier1-8/+15
Get length of denominator which could be different from numerator length Change-Id: I9f5c10917185eb029d52efbc0f20be5f81c74d10 Reviewed-on: https://gerrit.libreoffice.org/24712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-09convert SfxStyleFamily to scoped enumNoel Grandin4-21/+22
and update the RSC compiler to accept such In the process fix some confusion in SD where it was confusing SfxStyleFamily and the index of the relevant family (which other parts of the code in SVL use) Change-Id: I1efc9f85fbed8ab76eafe8f6e1ada411753ae5f9
2016-05-03Prevent Any::setValue from reinterpreting bool* as sal_Bool*Stephan Bergmann3-30/+24
...which only happens ot work in environments where sizeof (bool) == 1. The simpler alternative is to use the operator <<= template without passing explicit UNO type information, anyway. The std::nullptr_t overloads are needed to disambiguate calls with a nullptr argument. (Which can at least be meaningful for VOID, but for other types what it happens to do is store a default value of the given type.) As std::nullptr_t is only C++11, this all needs to be LIBO_INTERNAL_ONLY. Change-Id: Iff06a6ba94250bd4ae4afc937c2a2bfa75f0888f
2016-05-03tdf#97835 No decimal separtor for empty decimalLaurent Balland-Poirier1-13/+7
If decimal part is empty (with #) decimal separator should not be added. It was not removed if there was text after value. Change-Id: I891cad8b6bec0f27f4cef8aea80c5dad264f062d Reviewed-on: https://gerrit.libreoffice.org/24586 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-03tdf#61996 Skip quoted text in number formatLaurent Balland-Poirier1-5/+32
Quoted text should be detected and skiped before detecting conditions Change-Id: I1c78fed7f543fb335fbb8ec9ed50d9ab9dd10aa7 Reviewed-on: https://gerrit.libreoffice.org/24550 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-03tdf#31449 Correctly test if fraction has no integer partLaurent Balland-Poirier1-0/+10
Test if fraction format has no integer part is modified to take into account all cases: ??/?? or ##/## and do not detect false positive like ? ??/?? Change-Id: Ia8677a5ad496e5df56ce6bf1290323555e46ba0a Reviewed-on: https://gerrit.libreoffice.org/24540 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-05-01Fix typosAndrea Gelmini1-1/+1
Change-Id: Ifb7c33d6052efe5ea8a1e0e10b3178073cd29ca0 Reviewed-on: https://gerrit.libreoffice.org/24536 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-22SfxUndoAction::dumpAsXml: show address of undo itemsMiklos Vajna1-0/+1
The order of undo items on the undo stack is: the newest item is the first. But for grouped items SfxListUndoAction is a list, so newest elements go to the end of the list. It's easy to get confused without seeing the exact addresses. Change-Id: I5c336f2317e4f5869b9fd227c800b2e15d0644ff Reviewed-on: https://gerrit.libreoffice.org/24295 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-21Fix typosAndrea Gelmini1-1/+1
Change-Id: Ic4fbc8e7220eb4641f67ef4f85d4853608a369f4 Reviewed-on: https://gerrit.libreoffice.org/24257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann2-4/+4
Change-Id: I4a86e2484adfafb53831b9e1e9971514f017ce36
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin1-14/+13
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-15remove tools/solarmutex.hxxNoel Grandin1-3/+7
Deprecated in favour of comphelper::SolarMutex Change-Id: I159077562660de5df25601fa471447f4b64a2cf1 Reviewed-on: https://gerrit.libreoffice.org/24079 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-13tdf#94306 remove unused boost dependenciesJochen Nitschke1-1/+0
remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13loplugin:passstuffbyref in svlNoel Grandin2-2/+2
Change-Id: I1434d96ae800d8e155262831472cf632d640b4c5
2016-04-13tdf#94306 replace boost::noncopyable in stoc to xmlsec..Jochen Nitschke5-9/+14
Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Add missing default ctors. With this commit there should be no users of boost::noncopyable left. Change-Id: I6b1e47824912a6a80cc3f00f34938ebc048d8975 Reviewed-on: https://gerrit.libreoffice.org/24051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-11clang-tidy performance-unnecessary-value-param in svlNoel Grandin5-7/+7
Change-Id: I8abc272d12e62e25be358dc4c73008971f1cd609
2016-04-11cppcheck: silence warnings assertWithSideEffectJochen Nitschke2-2/+2
Mark some class methods as pure. warnings look like this: > dbaccess/source/core/api/RowSetBase.cxx > 593 assertWithSideEffect 398 warning Assert statement calls > a function which may have desired side effects: 'isAfterLast'. Change-Id: I1b69340c3714be4678b599fa9a8ca933122aa857 Reviewed-on: https://gerrit.libreoffice.org/23981 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-06remove some dead bits of DDENoel Grandin2-67/+5
Change-Id: Ieb1d4e23f1a62b56d14a655a676d9c7d5f33c51c Reviewed-on: https://gerrit.libreoffice.org/23849 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-05loplugin:nullptrStephan Bergmann1-10/+10
Change-Id: Iabc4df52491adff974de4656f626ab19848dd3f0
2016-04-05tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar1-4/+4
I removed OSL_DEBUG_LEVEL > 1 conditionals, replaced DBG_ASSERT to standard assert(..) and used SAL_INFO() in some places Change-Id: Ib6d6065e3f141e60f865fef1faacdb5598e12431 Reviewed-on: https://gerrit.libreoffice.org/23073 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-04-04loplugin:constantparam in i18nlangtagNoel Grandin1-1/+1
Change-Id: I3d7cbac7ca58f3de9771a1221196f851255f3fb9 Reviewed-on: https://gerrit.libreoffice.org/23802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04loplugin:constantparam in svlNoel Grandin3-8/+6
Change-Id: I6c336034a12fda493825b4a8388d3bde6bead910 Reviewed-on: https://gerrit.libreoffice.org/23729 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-30Use const_iterator when possible (svl except svdde)Julien Nabet12-37/+39
Change-Id: Ie19467a020d1839146d5a6324e54ccf223d99dd6 Reviewed-on: https://gerrit.libreoffice.org/23603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-29cid#1357162: Logically dead codeStephan Bergmann1-22/+15
...after 07da25064f75cdf7163669f9bf860a9ee2f8b33c "loplugin:constantparam in svl" Change-Id: I6f7cc3ca0822de079c0855ee46f66368bd78e0b7