summaryrefslogtreecommitdiff
path: root/svl
AgeCommit message (Collapse)AuthorFilesLines
2016-04-22SfxUndoAction::dumpAsXml: show address of undo itemsMiklos Vajna1-0/+1
The order of undo items on the undo stack is: the newest item is the first. But for grouped items SfxListUndoAction is a list, so newest elements go to the end of the list. It's easy to get confused without seeing the exact addresses. Change-Id: I5c336f2317e4f5869b9fd227c800b2e15d0644ff Reviewed-on: https://gerrit.libreoffice.org/24295 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-21Fix typosAndrea Gelmini1-1/+1
Change-Id: Ic4fbc8e7220eb4641f67ef4f85d4853608a369f4 Reviewed-on: https://gerrit.libreoffice.org/24257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann2-4/+4
Change-Id: I4a86e2484adfafb53831b9e1e9971514f017ce36
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin1-14/+13
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-15remove tools/solarmutex.hxxNoel Grandin1-3/+7
Deprecated in favour of comphelper::SolarMutex Change-Id: I159077562660de5df25601fa471447f4b64a2cf1 Reviewed-on: https://gerrit.libreoffice.org/24079 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-13tdf#94306 remove unused boost dependenciesJochen Nitschke1-1/+0
remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13loplugin:passstuffbyref in svlNoel Grandin2-2/+2
Change-Id: I1434d96ae800d8e155262831472cf632d640b4c5
2016-04-13tdf#94306 replace boost::noncopyable in stoc to xmlsec..Jochen Nitschke5-9/+14
Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Add missing default ctors. With this commit there should be no users of boost::noncopyable left. Change-Id: I6b1e47824912a6a80cc3f00f34938ebc048d8975 Reviewed-on: https://gerrit.libreoffice.org/24051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-11clang-tidy performance-unnecessary-value-param in svlNoel Grandin5-7/+7
Change-Id: I8abc272d12e62e25be358dc4c73008971f1cd609
2016-04-11cppcheck: silence warnings assertWithSideEffectJochen Nitschke2-2/+2
Mark some class methods as pure. warnings look like this: > dbaccess/source/core/api/RowSetBase.cxx > 593 assertWithSideEffect 398 warning Assert statement calls > a function which may have desired side effects: 'isAfterLast'. Change-Id: I1b69340c3714be4678b599fa9a8ca933122aa857 Reviewed-on: https://gerrit.libreoffice.org/23981 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-06remove some dead bits of DDENoel Grandin2-67/+5
Change-Id: Ieb1d4e23f1a62b56d14a655a676d9c7d5f33c51c Reviewed-on: https://gerrit.libreoffice.org/23849 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-05loplugin:nullptrStephan Bergmann1-10/+10
Change-Id: Iabc4df52491adff974de4656f626ab19848dd3f0
2016-04-05tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar1-4/+4
I removed OSL_DEBUG_LEVEL > 1 conditionals, replaced DBG_ASSERT to standard assert(..) and used SAL_INFO() in some places Change-Id: Ib6d6065e3f141e60f865fef1faacdb5598e12431 Reviewed-on: https://gerrit.libreoffice.org/23073 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-04-04loplugin:constantparam in i18nlangtagNoel Grandin1-1/+1
Change-Id: I3d7cbac7ca58f3de9771a1221196f851255f3fb9 Reviewed-on: https://gerrit.libreoffice.org/23802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04loplugin:constantparam in svlNoel Grandin3-8/+6
Change-Id: I6c336034a12fda493825b4a8388d3bde6bead910 Reviewed-on: https://gerrit.libreoffice.org/23729 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-30Use const_iterator when possible (svl except svdde)Julien Nabet12-37/+39
Change-Id: Ie19467a020d1839146d5a6324e54ccf223d99dd6 Reviewed-on: https://gerrit.libreoffice.org/23603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-03-29cid#1357162: Logically dead codeStephan Bergmann1-22/+15
...after 07da25064f75cdf7163669f9bf860a9ee2f8b33c "loplugin:constantparam in svl" Change-Id: I6f7cc3ca0822de079c0855ee46f66368bd78e0b7
2016-03-17Revert "tdf#98458 sw: make search in shape text optional"Jan Holesovsky1-14/+2
Actually there seems to be a simpler solution to the immediate performance problem which I'll commit next. It still might be necessary to introduce the search switch at some stage, but first let's see if there are complaints. This reverts commit 8e0b08c3053ed5472409b1ea7e02653aad38f7d6.
2016-03-17loplugin:constantparam in svlNoel Grandin5-27/+20
Change-Id: If23e43beb401047825641817e09d7fdeb904f9d9 Reviewed-on: https://gerrit.libreoffice.org/23317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17tdf#98458 sw: make search in shape text optionalMiklos Vajna1-2/+14
Instead of forcing it silently on everyone, add a new search option and enable it only in case it's requested, as shape search is expensive for large documents. (Regression from commit bdc1824ea7acfa2fe9d71cdbe57882acce155577.) Change-Id: Ibb6e76ad5c870dfd63b36429e16ef6d572f5f1fd
2016-03-16loplugin:constantfunction in ucbhelperNoel Grandin1-2/+1
Change-Id: I80e00b5ac2621378801f89532ed88b377ef72b60 Reviewed-on: https://gerrit.libreoffice.org/23297 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-10Avoid reserved identifiersStephan Bergmann1-11/+11
Change-Id: I815c839b19e5b2d7d5b5bab821614ad953006de2
2016-03-10Avoid reserved identifierStephan Bergmann1-3/+3
Change-Id: Iea66c7230f4570d6a2b88a514958788eb4105ffb
2016-03-09remove unused NOT_POOLABLE enum valueNoel Grandin6-38/+26
and simplify the resulting SfxItemInfo field down to a single bool Change-Id: I73e24e83d39afc7660ac85872ba96bc790713cb2 Reviewed-on: https://gerrit.libreoffice.org/23058 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-09loplugin:constantparam in svlNoel Grandin2-17/+12
Change-Id: Iefc441262cbdc6f115ea4ca5a673456b59477e13
2016-03-07loplugin:unuseddefaultparamsNoel Grandin1-3/+3
Change-Id: Ia414f7845425ef73859ed04853378e96cc738795 Reviewed-on: https://gerrit.libreoffice.org/22971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07tdf#97703 removed empty setUp/tearDown methodsChirag Manwani1-5/+0
Change-Id: I244d481bce4723d172e26c0d31aab0a541334604 Reviewed-on: https://gerrit.libreoffice.org/22959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-07loplugin:unuseddefaultparam in variousNoel Grandin1-9/+2
Change-Id: I03d7381aad055cbe9bd905e4082586073f4112e0 Reviewed-on: https://gerrit.libreoffice.org/22900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-01loplugin:unuseddefaultparam in svlNoel Grandin9-117/+48
Change-Id: Ifc82563c8930332d460df4d97935ba6e9946689f
2016-02-26add SvxSearchItem::GetWildcard() SetWildcard()Eike Rathke1-2/+22
Change-Id: I0aeb7fbcedad381a385ffe6649ac51e8c961ca11
2016-02-24let SvxSearchItem use SearchOptions2Eike Rathke1-3/+28
And all those places that interface to SvxSearchItem. Change-Id: I08915824a596cd0f247a89f44e4684cd22b98082
2016-02-23new loplugin: commaoperatorNoel Grandin1-1/+2
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-19new loplugin: find write-only fieldsNoel Grandin1-3/+0
Change-Id: I0f83939babacf92485420ee63f290a297d7cb717 Reviewed-on: https://gerrit.libreoffice.org/22498 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-17use consistent #define checks for the Windows platformNoel Grandin4-6/+6
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-12tdf#95857 Sort out German plurals ...danielt9981-7/+7
Made a start in removing the incorrect 'Infos' German plural Change-Id: Ie989351a7473fc35b563e63ce6a4fb229093af60 Reviewed-on: https://gerrit.libreoffice.org/22301 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-11[API CHANGE] add operator==/!= to UNO structsNoel Grandin1-2/+2
this is useful now that we are storing UNO structs in std::vector Change-Id: Ic558bcd669bd2b3cdf9eb8393269eb906ac52369 Reviewed-on: https://gerrit.libreoffice.org/22257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09UIDNA_CHECK_CONTEXTO is only available in ICU >= 49Stephan Bergmann1-1/+4
...unlike the rest of the createUTS46Instance stuff, which is available in 4.6. While it is desirable to have that check here, it probably doesn't make much of a difference in practice, and Rico Tzschichholz would like to have this working on Ubuntu 12.04, where only ICU 4.8.1 is available. Change-Id: I5bbd2ed296c6e068e175e7f8353cea37ed4d9e44
2016-02-09Remove excess newlinesChris Sherlock36-159/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09Formatting changes across all modulesChris Sherlock1-4/+0
+ Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08tdf#88205 Delete 'uno::Sequence' in svlkerem1-8/+4
Change-Id: I5f2d79bedcea2712070c4e50b6f9e6d0d0112920 Reviewed-on: https://gerrit.libreoffice.org/22193 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-02-08loplugin:unusedmethodsNoel Grandin1-278/+0
using an idea from dtardon: <dtardon> noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... <noelgrandin> dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-05Fix typosAndrea Gelmini1-1/+1
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-31OSL_THIS_FUNC is a rip-off of BOOST_CURRENT_FUNCTION so we can use thatCaolán McNamara1-1/+0
as a direct drop in I guess Change-Id: I3add63f1459f4e659019bd6db54da2f5431958ce Reviewed-on: https://gerrit.libreoffice.org/21941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin5-8/+8
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-20loplugin:unusedmethodsNoel Grandin2-86/+0
Change-Id: Ib2dc804f55d1a96ae01f2cf31b7d55956040a72e Reviewed-on: https://gerrit.libreoffice.org/21603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-14grml.. stupid oversight..Eike Rathke1-1/+5
Change-Id: I95b27000adfd0a29ed6e462f972340eee31d3a0b
2016-01-14it's unnecessary to buffer the string to create a string from it againEike Rathke1-19/+10
... just in case there was a negative number and a minus to be inserted. doubleToUString() does it already. Change-Id: I0052d7bc91b48efb5f14f2f6f5a7c672a1e50ea9
2016-01-14do it right and remove then superfluous mumbo-jumboEike Rathke1-28/+13
... that worked around cases where it went wrong. Change-Id: Icdd4bddfb341a3d0abe4183cf788c546dcddbd00
2016-01-14loplugin:unusedmethods unused return value in store,svlNoel Grandin2-14/+9
Change-Id: I369b3ae84af046242430977cec7d5c5e69fc27e7
2016-01-13-Werror=unused-but-set-variableStephan Bergmann1-2/+1
Change-Id: I01c18a1b8193f491a82988426ac4e673dd68897a
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 15:21:26 +0000