summaryrefslogtreecommitdiff
path: root/svl
AgeCommit message (Collapse)AuthorFilesLines
2014-08-19detect * with no character following as invalid format codeEike Rathke1-0/+5
... so adding it to the list in Format Numbers using the checkmark button is not possible. Change-Id: I57ca6a7a3617583a82a99c87291373b1fe4e246d (cherry picked from commit bf674ab0f3097ad122c727b4d86f004f8cce1f61) Reviewed-on: https://gerrit.libreoffice.org/10998 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-08-18prevent out-of-bounds string accessEike Rathke1-24/+32
... while entering a * star symbol format code and there's no fill character following the * yet, for example "xxx"* (cherry picked from commit 839cc63e7d1b78c56e04bafb46037e898ce2c455) more out-of-bounds string accesses (cherry picked from commit 349c93e0f5c9f231b2ff6854fcb795ca5881ca2d) Change-Id: I006f125ceefccba6a95ea033fd434d98e5d4f1c2 Reviewed-on: https://gerrit.libreoffice.org/10994 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-07-15fdo#81309: Adjust references during sort.Kohei Yoshida1-1/+23
(cherry picked from commit 5c6ee09126631342939ae8766fe36083d8c011e3) Conflicts: sc/inc/sortparam.hxx sc/source/ui/docshell/dbdocfun.cxx sc/source/ui/undo/undodat.cxx Change-Id: I2b98610f6b774400ecfaffe2905201c27fcab33f Reviewed-on: https://gerrit.libreoffice.org/10305 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-07-07fix crash on loading fdo70673-1.odsCaolán McNamara1-1/+1
rStr is NaN Change-Id: I8206ab322a08d558cf5f05750efd700875b2134c (cherry picked from commit 12ec403c547cca4d7e5f73ae3ef58ff8faf3721e) Reviewed-on: https://gerrit.libreoffice.org/10109 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-07-04fdo#78908 Revert "Merge back branch alg_writerframes to trunk"Miklos Vajna1-4/+0
This reverts commit 6e61ecd09679a66060f932835622821d39e92f01. Better not to have this on libreoffice-4-3 without 7d9bb549d498d6beed2c4050c402d09643febdfa (Related: #i124638# Second step of DrawingLayer FillAttributes..., 2014-06-02). Conflicts: cui/source/inc/backgrnd.hxx cui/source/inc/cuitabarea.hxx cui/source/tabpages/backgrnd.cxx cui/source/tabpages/tparea.cxx include/basegfx/numeric/ftools.hxx include/svx/svxids.hrc include/svx/unoshprp.hxx sc/source/ui/drawfunc/drawsh.cxx sd/source/ui/func/fuarea.cxx sfx2/source/dialog/tabdlg.cxx sw/inc/fillattributes.hxx sw/inc/format.hxx sw/inc/frmatr.hxx sw/inc/swatrset.hxx sw/inc/unobrushitemhelper.hxx sw/qa/extras/rtfexport/rtfexport.cxx sw/source/core/attr/format.cxx sw/source/core/attr/swatrset.cxx sw/source/core/doc/docfly.cxx sw/source/core/doc/notxtfrm.cxx sw/source/core/inc/frame.hxx sw/source/core/inc/frmtool.hxx sw/source/core/layout/fillattributes.cxx sw/source/core/layout/paintfrm.cxx sw/source/core/txtnode/fntcache.cxx sw/source/core/uibase/shells/frmsh.cxx sw/source/core/unocore/unobrushitemhelper.cxx sw/source/core/unocore/unoframe.cxx sw/source/core/unocore/unostyle.cxx xmloff/source/text/txtexppr.cxx xmloff/source/text/txtprhdl.cxx Also: Revert "cppcheck: Prefer prefix ++/-- operators for non-primitive types" This reverts commit 80ec4885e97b3fcb34b93e71ced52a4aab43ce93. Revert "WaE: implicit conversion of literal of type 'sal_Bool' to 'bool'" This reverts commit d5d10b03b1f3e4bf784ad35254cb55d719a8c1b3. Revert "i#124638 support for DrawingLayre FillStyle for GraphicFrames and ..." This reverts commit 4a0b5e569d070c286daefb0fdfe45c0dd15d241c. Revert "svx: fix SID_OFFER_IMPORT and SID_ATTR_CHAR_GRABBAG having the same SID" This reverts commit b66d87086804460c1986df1b832fd6b2ea075a90. Revert "SwXStyle::getPropertyValue: don't try to read a float into a sal_Int32" This reverts commit 1e3c7b854baac2502bed72ff8e3e1b21b507735b. Revert "SwXTextFrame: also restore semi-lost BackColorTransparency property" This reverts commit 102bb87ca1a5dee3a09442bf503a54bb703c79ea. Revert "SwXTextFrame: restore semi-lost BackColor property" This reverts commit 5ce92b73ce06c805c66e53c48aa2c70c722aaf60. Revert "DocxAttributeOutput: port to FillAttributes" This reverts commit ec221b7339f8fe5520926ef85b450daa94392780. Revert "MSWordExportBase::OutputItemSet: handle fill attributes as frame ones" This reverts commit 84c40768f8acb0342dcfa223133497f57620fc14. Revert "sw: put getSvx* and setSvx* to a namespace, now that these are public" This reverts commit ebf960960a69c1edb5da1994c330ddddbecac44d. Revert "sw: fix DOC/DOCX/RTF export of TextFrame background color" This reverts commit c7837b8caad61b8c0dfd3704a133cdeaffd69b06. Revert "sw: still use SvxBrushItem for page style background" This reverts commit e826950e9d7736a6e3f9042755ba1b528f58a505. Revert "cui: unused code in SvxAreaTabPage::ClickBitmapHdl_Impl" This reverts commit 2032e9f5d7683e49b8753d7c7362899c690005b6. Revert "cui: unused code in SvxAreaTabPage::ClickGradientHdl_Impl" This reverts commit f4fa202b31277276dc4f05046c82152c0830ef21. Revert "cui: unused code in SvxAreaTabPage::ClickColorHdl_Impl" This reverts commit 1478e89e08a54f02a137c74c0cde6ae75e80d9f3. Revert "cui: unused code in SvxAreaTabPage::ClickHatchingHdl_Impl()" This reverts commit e9c9f3f793a91525ac4fb74f8791ba74222515e4. Revert "svx: fix Writer's insert -> frame crash" This reverts commit 831b8751fc9f423fd4e459623e54801c0a020eb3. Revert "sw: adapt frame/templatedialog4.ui to FillAttributes" This reverts commit 55916fc50a5b2d6273bca8c9ef6253011cf4fdbc. Revert "-Werror,-Wunused-variable" This reverts commit d0542fe7251d9c6538331b22a4b5e2e294a92e97. Revert "loplugin:implicitboolconversion,literaltoboolconversion" This reverts commit 47862e75de51a4ac7476acff773b504fdc0d6e76. Revert "loplugin:saloverride" This reverts commit be89e8b8ac19c0feca8850ccaddd90205c63dbe5. Revert "loplugin:literaltoboolconversion" This reverts commit 355b31fe347479f63906e41300042ec5cb38837c. Revert "-Werror,-Wunused-private-field" This reverts commit df9d13dd2e754184a4c6e321b8910ee1bc0cafa1. Revert "-Werror,-Wunused-const-variable" This reverts commit d757a98001a65baf4066c2eda037a08ab1beda46. Revert "unused XFillStyleItem ctor" This reverts commit b735fe1d67e6ad7ad448e448f237dcabef1a1c38. Revert "unused XGradient::VclGradient" This reverts commit 5bbc90be755aae4b87125f9d748828d74efe645d. Revert "fix "transparency" of floating tables in docx import (fdo#77723)" This reverts commit 313b59d787357ef3da34e2833fefcf1143b09b5e. Change-Id: If855b090f94288d384f8733f88ef1172e68c50a6 Reviewed-on: https://gerrit.libreoffice.org/10077 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-07-03resolved fdo#80166 check input against date acceptance pattern plausibilityEike Rathke1-1/+37
... to prevent confusion of #.### input with D.M that then later is discarded as invalid date input instead of accepted as valid numeric input. (cherry picked from commit 836e504c859a5b67f7ab7ba842785951d41058cd) work around nonsense -Werror=maybe-uninitialized, fdo#80166 follow-up (cherry picked from commit 397362d8532d7b0abe38f2024dd2cefe2482d6a3) 0f9cf74550e43d174bf6ac75e70c51ab7f51ccf8 Change-Id: I178e28b7ef3b26d04eecc73e5e5c61ee41f89e32 Reviewed-on: https://gerrit.libreoffice.org/10035 Tested-by: David Tardon <dtardon@redhat.com> Reviewed-by: David Tardon <dtardon@redhat.com>
2014-06-27fdo#38513 - Accelerate non-poolable item add / remove.Michael Meeks8-67/+259
For large documents we create and destroy a large number of non-poolable SfxPoolItems, which get inserted into and removed from a vector. Unfortunately the performance of this (depending on pattern) is O(N) and this insert/remove/extend pattern can happen per text span we insert. This patch makes this O(const) via a hash. This gives a 5x speedup for the above bug; 176s to 34s or so, and moves the remaining performance issues elsewhere. Unfortunately, we have to retain the ordered array to keep the binary file format code (used for editeng cut-and-paste) in place, so have to keep both a hash, and an array, and a list around for free slots. cf. fdo#79851 where there is a start at removing that. This wastes space; but not that much - for a large open document collection we have O(100's) of SfxItemPools, and O(1000's) of SfxPoolItemArray_Impls; having fixed fdo#79851 we can consolidate this. Add skeletal unit test; translate several German comments; remove un-necessary include. Change-Id: Ie0de32b1a29217560c5591c71a6cd4e26d39a531 Reviewed-on: https://gerrit.libreoffice.org/9818 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2014-06-11allow additional i18n formats to define defaultsEike Rathke1-5/+8
a5f62d96b124564f522eac7925e9c3d22c37e503 would had liked to let usage="DATE_TIME" formatindex="55" define the default format of that usage, which wasn't possible. There is no reason to prevent this. Change-Id: Ibef453c8a07aa03b0a8bb626b9cf71d362be0699 (cherry picked from commit 7550e153e55222c68530a1a7f6914575f1e258c8)
2014-06-06resolved fdo#79719 recognize ##-MMM-## as date even if ambiguousEike Rathke1-8/+3
Force ##-MMM-## to be ##-MMM-#### if the first number is a day value. Note that the previous implementation of (bDay1 && bDay2 && ((bYear1 && !bYear2) || (!bYear1 && bYear2))) never matched anyway as the detection of bDay1 and bDay2 were changed to only yield true if bYear1==false or bYear2==false. Change-Id: If6bb6d3e1757015552eaa81c1f58d53c0794846e (cherry picked from commit a6992cd0d7c085ba05877e6f68ac0650dd09010f)
2014-05-28Related: fdo#79142 make SetName default to ReindexingCaolán McNamara1-1/+3
Change-Id: I408042bc7bf1a5a955203d65d2c68ebf9527b9b5 (cherry picked from commit 05e2fd162ef86ebe4ea2a2a679cabeae33e844f0)
2014-05-21ODS load perf: 7% of the time re-creating sheet name strings.Michael Meeks1-1/+0
No need to create cached versions of stringified sheet tokens for a given grammar at great for every formula that we compile; defer until use. Is this a large cost on save ? Change-Id: I8058ed564dbdc00ff45c02cb483c1a20a48af272
2014-05-20take a shortcut on common separating ASCII charactersEike Rathke1-3/+17
Change-Id: I991801b9a0b7be6024612c8f29262f2ebd8e6a64
2014-05-20resolved fdo#34724 Jan1 or 1Jan without separating character is not dateEike Rathke1-26/+59
Change-Id: I2cf02a26b81fa634c842df455de669f1c60241bc
2014-05-19hrc and src files: squeeze multiple newlinesThomas Arnhold1-3/+0
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-17Back out change for fdo#78119 now that we have StringContainsWord()Eike Rathke1-48/+21
This reverts commit 3b3b690c1f0479cfbebcfa68595f75a4994e7a5f. With the use of StringContainsWord() it is unnecessary to loop all available names.
2014-05-17resolved fdo#41166 match month and day name word instead of substringEike Rathke1-3/+8
Follow-up, check for ASCII first to avoid calls to i18n, and check the type flags instead of calls to CharClass methods that give unexpected results with their masks. Change-Id: I10e685998299dceb2dbcf1d87ae1de09680b8a99
2014-05-17resolved fdo#41166 match month and day name word instead of substringEike Rathke2-9/+57
Change-Id: I897dbcee47de574d91ba3e3b40a39a35b779fef8
2014-05-15update_pch: add svlThomas Arnhold3-0/+193
55s -> 28s How to find possible pch candidates: for i in `git grep -l 'gb_Library_set' -- '*.mk' | sort -u`; do if [ $(git grep 'precompiled_' $i | wc -l) == 0 ]; then echo missing: $(sed -n -e '/gb_Library_add_exception_objects/,/))/ p' $i | wc -l) files in $i else echo ok: $i fi done | sort -h -t' ' -k2 Change-Id: Ib9fe16c0afb6e6687881c987c3af7bf59b929fd4
2014-05-15fix-includes.pl: svlThomas Arnhold22-113/+113
Change-Id: I18fb7a677e2bb98c83f43f5af3fa988393dc23f9
2014-05-14Find places where uno::Sequence is passed by value.Noel Grandin1-1/+1
Implement a clang plugin to find them, and clean up existing code to pass them by reference. Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8 Reviewed-on: https://gerrit.libreoffice.org/9351 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-13remove dead codeNoel Grandin1-6/+0
Change-Id: Ic4fb478921714429af138ca212bd7f67f408d434
2014-05-12fdo#78119 find the longest match for month nameDavid Tardon1-21/+48
Change-Id: Idad7b083ce5528f5c735f3a8bd091819bf043fc8
2014-05-11coverity#982701 Improper use of negative valueCaolán McNamara1-0/+4
Change-Id: I3c932e8386d994450f05a876b6ad76ba141bd4e9
2014-05-11Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part10Julien Nabet1-1/+1
Change-Id: I67acda35fa127547dcea0cd18c9dc16db7c00294
2014-05-10coverity#738855 Uninitialized pointer fieldCaolán McNamara1-1/+3
Change-Id: If45c6b7399e19e9414a5ba24a1f6d2e5bb3f82a8
2014-05-10Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part8Julien Nabet1-12/+12
Change-Id: Ie16923d17541e84e0d7424fffe37caf410786abf
2014-05-09move INetContentTypes::scan() to INetMIME::scanContentType()Chr. Rossmanith2-46/+5
to avoid circular dependencies between svl and tools when using INetContentType::scan functionality for future handling of data urls in urlobj.cxx Change-Id: Iad13286769e8906aebf8208e4f532151ff2f3d13 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-06dflt -> defaultThomas Arnhold3-4/+4
Change-Id: I89f1f5771eb7d96da233a8c7386b906b2a3a9c3e
2014-05-06consistent percent sign in commentsThomas Arnhold1-1/+1
Change-Id: I9906b4e58fd8672e51f6aa2e56ec68bb28772500
2014-05-05simplify ternary conditions "xxx ? yyy : false"Noel Grandin2-5/+5
Look for code like: xxx ? yyy : false; Which can be simplified to: xxx && yyy Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
2014-04-22cppcheck: fix variable reassigned before the old value has been usedJulien Nabet1-3/+1
Change-Id: I866eaf946d4cd8eaa8e4b8799ddac5e0d5dc59bb
2014-04-21remove comments why a file gets includedThomas Arnhold1-1/+0
also remove some commented out code Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-11Introduce twip/mm100 conversion functions instead of duplicated macrosTor Lillqvist1-10/+6
Change-Id: Ib689e35b417e0e9016cd6a239c986e0603a99d62 Reviewed-on: https://gerrit.libreoffice.org/8837 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-04-11Use valid UNOIDL identifiers in TransliterationModulesExtraStephan Bergmann1-2/+2
ignoreDiacritics_CTL was introduced in LO 4.2, but is unpublished and appears to be rarely used, so changing it is hopefully OK. ignoreKashida_CTL is new in LO 4.3. Change-Id: I52c6d1e8c6b30eec4af22e3bbc72dd5874ef7151
2014-04-09Remove unused functionStephan Bergmann1-7/+0
Change-Id: I0d6f0d8a7ef851ef7ba1653d87db6a5bdbfb6d94
2014-04-08coverity#708261 Uninitialized scalar fieldCaolán McNamara1-0/+3
Change-Id: I997dad13c3b8931d1fd4eae09218b51cb4621263
2014-04-08fdo#77123: Add option ignore kashida to the searchFaisal M. Al-Otaibi1-1/+4
This patch will add new checkbox to ignore kashida in the search and replace dialog. Change-Id: I9e7179242751103b8418d922ade5b9145170ad15
2014-04-07Clean up function declarations and some unused functionsStephan Bergmann7-28/+57
Change-Id: Id7ecd49ea03f225fc350a31437c32b4a738d7199
2014-04-06coverity#708246: Unitialized scalar fieldNorbert Thiebaud1-0/+2
Change-Id: I3136db825bea07b4b5977b6067db91375720ebed
2014-04-06coverity#708257: Unitialized scalar fieldNorbert Thiebaud1-13/+15
Change-Id: Ib46e6f5cb52cd47c4c9914b2f15633f5e6af1fe6
2014-04-06coverity#708260: Unitialized scalar fieldNorbert Thiebaud1-3/+10
Change-Id: Iffad31bc60748fe58fe3524776dd56e907586342
2014-04-04coverity#738855 Uninitialized pointer fieldCaolán McNamara1-0/+2
Change-Id: I3c1528f2dd8e3bde2672ebc153c9cb5c5c0a13fd
2014-04-04svl/eitem.hxx: sal_Bool->boolNoel Grandin1-2/+2
Change-Id: I45dfd2429a490af3cc80f51340e0c05a91425668
2014-04-04svl/visitem: sal_Bool->boolNoel Grandin1-1/+1
Change-Id: I3d6ceb4dc8cea901a5b1cdcf00efa9074c75cca0
2014-04-04svl/style.hxx: sal_Bool->boolNoel Grandin1-1/+1
looks like I missed a couple of methods in my earlier conversion Change-Id: I07871a451bb5954feab57de0af4f7d0678f9a7b3
2014-04-04coverity#708244 Uninitialized scalar fieldCaolán McNamara1-2/+3
Change-Id: I99b68fd7efe69cc7ab7daa244cad4c1ac04c312d
2014-04-04cp#1000054: Avoid crashing.Muthu Subramanian1-1/+3
Change-Id: Iedafa35cfedce1d56468774fcb6bbfa8e42612df
2014-04-03remove unnecessary scope qualifier from sal_Bool usesNoel Grandin2-16/+16
i.e. convert "::sal_Bool" to "sal_Bool" Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03svl: sal_Bool->boolNoel Grandin4-22/+22
Change-Id: I6938314a08d061d2b07d9129742d74a989bd1385
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann5-5/+5
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 10:16:02 +0000