summaryrefslogtreecommitdiff
path: root/svl
AgeCommit message (Collapse)AuthorFilesLines
2019-04-03Introduce next Japanese gengou era 'Reiwa'Eike Rathke1-0/+3
Prepare for "Japan's Y2K" Gengou calendar era switch after 2019-04-30 The emperor Akihito will abdicate on 2019-04-30. The next emperor will be Naruhito, but so far neither the new era name (Heisei for Akihito) nor its abbreviation or a Unicode character are determined. At least introduce the new era with some dummy names (Naruhito,Na,N). Change-Id: I8c0af390ca0408ac259e47e7eaf2e49b5889c9ba Reviewed-on: https://gerrit.libreoffice.org/58142 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins Introduce next Japanese gengou era 'Reiwa' starting from 2019-05-01, which has been announced officially. This fills the provisional slot acknowledged at cacbb0faef77ae8462de9ff5c7307a6a2e28b2bb. Change-Id: Ifb12e6afaad4c66d455f664b46ec946e80324e87 Reviewed-on: https://gerrit.libreoffice.org/70157 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins Reviewed-on: https://gerrit.libreoffice.org/70185
2019-01-17Related: tdf#122509 prevent access of not existing base formatEike Rathke1-4/+5
Call to pFormat->HasPositiveBracketPlaceholder() with nullptr as obtained for the not existing nIndex was the immediate cause of the crash. Also obtain the type from the format if found instead of the separate GetType() call that again would need to find the format first. This clarifies that the other places accessing pFormat don't need additional checks because eType isn't UNDEFINED there. Reviewed-on: https://gerrit.libreoffice.org/66476 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit d807d6a65f439da88623e45b1dabe7d9ef36cd3c) According to https://crashreport.libreoffice.org/stats/signature/SvNumberformat::HasPositiveBracketPlaceholder() this occasionally happened in ~all releases, independent of the circumstances in tdf#122509, so let's backport to available release. Change-Id: I5d78ad73eeb4c3820c45d6a91b0e729ed22951a4 Reviewed-on: https://gerrit.libreoffice.org/66521 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-14tdf#120750: Revert "tdf#96248 delete SfxPoolItems with Which Id >= 4000"Xisco Fauli1-2/+9
This reverts commit c9493b344a9bd104d0a882f5e9407880c0c63c20. According to https://bugs.documentfoundation.org/show_bug.cgi?id=96248#c15 the asert was gone even before the patch... Anyway, better to have an assert than a crash Change-Id: I84389bf2e8e604f6967923c0eedaae3aec3455e6 Reviewed-on: https://gerrit.libreoffice.org/65115 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit c5d0d424bd7e78455cb6f9578cf2425ac0787004) Reviewed-on: https://gerrit.libreoffice.org/65159
2018-10-12ofz#10879 stay inside sSecStr boundsCaolán McNamara1-2/+2
Change-Id: I0ca70cdb9b80305c5339668d65d2c4c9977e7160 Reviewed-on: https://gerrit.libreoffice.org/61605 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-09-20svl: fix SfxItemIter on empty item setMichael Stahl1-1/+1
The problem is that IsAtEnd { return m_nCurrent == m_nEnd; } is never true because of the odd initialisation with m_nEnd > m_nStart. Change-Id: I477b0f111e2c2f47fe093800710a9b28ca8a5925 (cherry picked from commit 54d627e0c2ef64a8b09bc744384f6e3dd1d29d22) Reviewed-on: https://gerrit.libreoffice.org/60747 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-04Use INPUTSTRING_PRECISION to enable input of fraction of secondEike Rathke1-2/+2
This got lost when SvNumberFormatter::INPUTSTRING_PRECISION was introduced but not all places changed using the previous hard coded number 300, so input of fraction of second in time clock and duration was either truncated or not available at all, already since commit 0ce0dd5863208500d8d4658f1f68f34e254ab015 CommitDate: Tue Dec 1 16:58:07 2009 -0500 #i46511# Fixed one bug where the standard percent format incorrectly got unlimited precision. Change-Id: I9e4dd867b07090db16b23639fd01fb2cebb3f5d0 Reviewed-on: https://gerrit.libreoffice.org/59815 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 73c200d7e5779b18ee1406b7fbd2000a8c901589) Reviewed-on: https://gerrit.libreoffice.org/59838 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-25Related rhbz#1618703: Properly handle failure decoding master passwordStephan Bergmann2-6/+7
...when e.g. FIPS mode makes PasswordContainer::DecodePasswords fail by throwing an exception which needs to be caught in PasswordContainerHelper::addRecord (in uui/source/passwordcontainer.cxx, but which only catches NoMasterException, not generic RuntimeException) Change-Id: I877bb5126e79ac2c90b11ef6d31bf81a2927f409 Reviewed-on: https://gerrit.libreoffice.org/59511 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit e17987f4bd54fec7e0d94bdefdb94809255b3436) Reviewed-on: https://gerrit.libreoffice.org/59568 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-22Do not convert YMD date order to YDM and vice versa, tdf#107012 follow-upEike Rathke1-2/+9
Change-Id: I6362caae4dd0764a5f99f1b0453c17ecde4b53f1 Reviewed-on: https://gerrit.libreoffice.org/59213 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit a4c9e4539ee82c409add42e68329d4eb1100d62f) Reviewed-on: https://gerrit.libreoffice.org/59243 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-21One more "do not reorder date particles", tdf#113889 tdf#119013 follow-upEike Rathke1-1/+1
commit 5b8007afdb97d416ee7c22bf9226e927d61e9bd3 CommitDate: Thu Aug 16 18:54:31 2018 +0200 Resolves: tdf#119013 do not over-aggressively reorder date particles negated logic from bForExcelExport to bConvertDateOrder. This somehow slipped through in that commit. Change-Id: Ibe7e7f7dc669292f38136ceeced1ead120641a20 Reviewed-on: https://gerrit.libreoffice.org/59330 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 0281aa380a20672d55d1d672fd4a43bdcb6c224d) Reviewed-on: https://gerrit.libreoffice.org/59340 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-17Resolves: tdf#119013 do not over-aggressively reorder date particlesEike Rathke6-14/+16
In particular not when reading documents as we don't know what the original (default/system) locale was when the date format was created and stored and whether the format's date order actually matched the locale's ordering. Regression from commit 51478cefaa4e265b42e3f67eda0a64767ff3efba CommitDate: Tue Apr 18 17:01:27 2017 +0200 Resolves: tdf#107012 follow date order of the target locale Change-Id: I9d3bdbd512d95ed81ff6459e368a2d7497ec8a2d Reviewed-on: https://gerrit.libreoffice.org/59182 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 5b8007afdb97d416ee7c22bf9226e927d61e9bd3) Reviewed-on: https://gerrit.libreoffice.org/59215 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-27tdf#115007 add NatNum12 formatting to datesLászló Németh2-14/+114
to support variants of preposition, suffixation, article or their combinations. For example, Catalan "de març"/"d'abril", English "1st of May"/"First of May", Hungarian "május 1-je/május 2-a" (May 1/2) or Turkish "2018'de/2019'da" (in 2018/2019) usage can be automatic in templates and mail merge. When the date format contains more than a date keyword, it needs to specify in the NatNum12 argument which date element has got special formatting (described by libnumbertext formatting codes, and an optional initial capitalize/upper/title argument): '[NatNum12 ordinal-number]D' -> "1st" '[NatNum12 D=ordinal-number]D" of "MMMM' -> "1st of April" '[NatNum12 D=ordinal]D" of "MMMM' -> "first of April" '[NatNum12 YYYY=title year,D=capitalize ordinal] D"of "MMMM", "YYYY' -> "First of April, Nineteen Ninety" Note: set only for YYYY, MMMM, M, DDDD, D and NNN/AAAA in date formats. It's possible to extend this for other keywords and date + time combinations, according to the possible language requirements. Note 2: l10n date formats can use the new NatNum12 date formats from formatindex=60, see FormatElement in i18npool/source/localedata/ XML files and FormatElement specification: https://opengrok.libreoffice.org/xref/core/i18npool/source/localedata/data/locale.dtd#223 Change-Id: I598849f1492f4012e83cef9293773badbff16206 Reviewed-on: https://gerrit.libreoffice.org/55613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-on: https://gerrit.libreoffice.org/55767 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-06-21NatNum12: fix and add capitalization prefixes, tdf#115007 follow-upLászló Németh1-0/+9
Limit NatNum12 conversion only for the selected parts of the date format (this bug – double calls of getNumberText – was hidden by the space prefix " " and empty return values at the first calls, resulting unchanged dates yet). New prefixes: "capitalize", "upper" and "title" to handle optional capitalization. (In Calc, it was not possible to format the result of NatNum formatting, but some languages often need capitalization or title case to format numbers and currencies.) Thanks code clean up using enum WhichCasing to Eike Rathke. Reviewed-on: https://gerrit.libreoffice.org/55681 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> Conflicts: svl/qa/unit/svl.cxx Change-Id: I5fceb784930e6bc6d376116f5a42ad49cd248a54 Reviewed-on: https://gerrit.libreoffice.org/56202 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-06-21tdf#117575 treat thousand sep with ? in integer partLaurent BP2-10/+4
'?' was missing when treating thousand separator However, format with '?' in integer part are not saved in ODF. Change-Id: I1d684a31f800f10bf9a04babb0b9fec34e28e72a Reviewed-on: https://gerrit.libreoffice.org/55901 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 062e0999c2b7923e463f1611204a63f0bb7b6404) Reviewed-on: https://gerrit.libreoffice.org/56147
2018-06-19tdf#94792 performance regression for xlsx with chart with >1000 data labelsNoel Grandin1-5/+24
this speeds things up by 30% for me Change-Id: I7fa99e91b0b4f354329803b9c8fab827bd367dac Reviewed-on: https://gerrit.libreoffice.org/55812 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 20083840700518d8c0ec314974249254eb859de7) Reviewed-on: https://gerrit.libreoffice.org/55984
2018-06-11Derive NativeNumberXmlAttributes2 from NativeNumberXmlAttributes, tdf#115007 ↵Eike Rathke1-8/+21
follow-up Also ensure that transliteration-spellout and (transliteration-format,transliteration-style) are mutually exclusive and transliteration-spellout is only written if ODF version is >1.2, namespace 'loext' for 1.2 with extensions and namespace 'number' in anticipation of ODF 1.3 (may need to be adapted). Change-Id: I371dee8883ecb0d4638510c92b4bf59acd09f636 Reviewed-on: https://gerrit.libreoffice.org/55491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 807d4382cb021d2ac3ea99d6757a7b368a32941d) Reviewed-on: https://gerrit.libreoffice.org/55626 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2018-06-11tdf#115007: add import/export to NatNum12 (spell out numbers,László Németh1-2/+13
dates and money amounts, supporting all the XNumberText/libnumbertext formatting codes, for example "ordinal", "ordinal-number", "ordinal-feminine", etc., and ISO 4217 currency codes, also their possible combinations. NatNum12 formatting codes are stored by using the newly introduced (yet, loext:)transliteration-spellout attribute. creator-initials also added to token list Change-Id: I20f93c9d16778f142067a56d53b336d0acbe2d92 Reviewed-on: https://gerrit.libreoffice.org/54673 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 32f1c56d8ff5e6f87dbcf086fd3743d6d36182bc) Reviewed-on: https://gerrit.libreoffice.org/55625 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: László Németh <nemeth@numbertext.org>
2018-06-11tdf#115007: Use [NatNum12 params...] syntaxMike Kaganski2-7/+32
This allows using all the libnumbertext library functions. [NatNum12] gives cardinal number names (one, two, three, ...) [NatNum12 ordinal] gives ordinal number names (first, second, third, ...) [NatNum12 ordinal-number] gives ordinal indicators (1st, 2nd, 3rd, ...) [NatNum12 money USD][$-409] gives formal English (US) money text ... etc (see numbertext.org for syntax). Change-Id: I16dbb44d8d4bdb82a1b950de6d438c8311b554ff Reviewed-on: https://gerrit.libreoffice.org/54366 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 90d233b0311a208967a3e264820e00395bf057fb) Reviewed-on: https://gerrit.libreoffice.org/55624 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: László Németh <nemeth@numbertext.org>
2018-06-11Add unit test for NatNum12 decimals spell-outEike Rathke1-0/+3
Change-Id: I31c84eb2267b4978f110a4f38cbf4d2377d59400 (cherry picked from commit e025c561d75c6b1e04d3df0ba90b38d3801241ac) Reviewed-on: https://gerrit.libreoffice.org/55623 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Eike Rathke <erack@redhat.com>
2018-06-04Handle English vs locale's General keyword, tdf#33689 follow-up, tdf#107867Eike Rathke2-12/+41
Caller of ImpSvNumberformatScan::GetKeyWord() needs to know if English or locale's keyword was found and act on it. Pointed out by an assert when attempting to copy "STANDARD" length characters (8) from "General" (7), which doesn't harm because when not in debug it copied the terminating 0-character. However, the keyword name also needs to be replaced for the locale's resulting format code. Change-Id: Ia5211b307ea44c1ba9c2b86786368355c570d4a2 Reviewed-on: https://gerrit.libreoffice.org/55293 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit bfe6e9ecb18e8a3d9da368a1eb48e807ab9041cf) Reviewed-on: https://gerrit.libreoffice.org/55297
2018-05-30Resolves: tdf#117819 append trailing '0' as needed before separator insertionEike Rathke1-6/+25
To insert separators, literal strings between digits and other, the formatter operates backwards on the string obtained from doubleToUString() cleaned of the decimal separator. The number of decimals returned by doubleToUString() may be less than the decimals of the number format as entered by the user, which lead to separators inserted at wrong positions. This wrong behavior was triggered respectively made more obvious by commit 0f6203edf74832f84d8263d7a544d679203a4efc CommitDate: Wed Jan 13 14:47:57 2016 +0100 tdf#96918 display accurate integer double values up to (2^53)-1 which for integer values returns at most 15 decimals ('0' in this case). Before operating on the decimals' part ensure that the number of decimals matches the digits requested, and if shorter append trailing '0' characters for the required amount so the separators (and other strings) are inserted at the correct positions. Change-Id: Ic02652699ea7d6fae3b2b3348f6f7d183319e043 Reviewed-on: https://gerrit.libreoffice.org/55039 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 8b43f58891d4b422a8934050d839b0c2c1e3a18a) Reviewed-on: https://gerrit.libreoffice.org/55059 Tested-by: Jenkins <ci@libreoffice.org>
2018-05-28loplugin:passstuffbyrefNoel Grandin1-1/+1
Change-Id: I785e96599bbda029adf4698d11d7f981750dec07 Reviewed-on: https://gerrit.libreoffice.org/54802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit ff3bdde2527123fc9e011ff0d93e958174632186) Reviewed-on: https://gerrit.libreoffice.org/54914 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-18tdf#117539 Crash after cut and paste operation of a chart stickNoel Grandin1-0/+6
regression from commit 3d44b720f58366398e7f59c00dba6339712a670f loplugin:useuniqueptr in SfxItemPool_Impl where I accidentally removed some fallback code. Note that this does not fix the underlying bug where some pool is not correctly set up. Also, this only fixes the bug that I introduced in the above commit, another bug in the same area has subsequently been introduced, causing a crash in a different area when performing this operation. Change-Id: Iaae3b0dc82c740b498e3735273820647ef28fd01 Reviewed-on: https://gerrit.libreoffice.org/54522 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-18Remove some cruftStephan Bergmann1-4/+0
That block of code at the top of the file started out as #include "precompiled_svl.hxx" #ifdef WNT # include <prewin.h> # include <postwin.h> # undef ERROR #endif in d2a16264ec6cb1ca5e8178096b72053a357cb3fb "Initial unit test skeleton, copied and modified from sc", so assume the leftover #undef is unnecessary cargo-cult by now. Change-Id: I39637518d1507352b1eb2ed19168013d9fe635ac Reviewed-on: https://gerrit.libreoffice.org/54499 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-18Reuse existing config_host/config_libnumbertext.h.inStephan Bergmann2-4/+1
Change-Id: I28d0260531132216c5f0bd187d400ed47cc43326 Reviewed-on: https://gerrit.libreoffice.org/54498 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-17Fix dependencies for CppunitTest_svl_qa_cppunit.mkMike Kaganski1-8/+0
Change-Id: I391ea52f5137975073a674ac1ad380277fe99846 Reviewed-on: https://gerrit.libreoffice.org/54381 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-16NFC: unassigned variable pNewItem is always nullptrJustin Luth1-1/+1
In 2015 commit 2ebd79b3d214c62c0997606115ebc50700d6a760 a possible initialization of the variable was removed. So at this point pNewItem must return false. Change-Id: I5af9d8440463c96323c38a01f255c1dbb0113e09 Reviewed-on: https://gerrit.libreoffice.org/54395 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-05-15CppunitTest_svl_qa_cppunit: fix system-libnumbertext buildRene Engelhard1-0/+2
libnumbertext_numbertext package doesn't exist... Change-Id: I5fc7c9c2386c10a10f2980655292ab12beb1a977
2018-05-15tdf#115007: add NatNum codes for cardinal/ordinal number names/indicatorsMike Kaganski2-0/+26
... based on libnumbertext integrated since commit f1579d3d6c5f5f3a651825e035b93bee7a4f43c6. [NatNum12] gives cardinal number names (one, two, three, ...) [NatNum13] gives ordinal number names (first, second, third, ...) [NatNum14] gives ordinal indicators (1st, 2nd, 3rd, ...) Change-Id: Ie2afdeeb82da1b36e9755c02d7b2276c77be9c72 Reviewed-on: https://gerrit.libreoffice.org/54186 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-05-14Drop module-specific defines of DELETEZGabor Kelemen1-4/+0
The one in tools/solar.h is the only one needed. Change-Id: I7a4e041694fb61329d16f300be4f986eb8d4ec48 Reviewed-on: https://gerrit.libreoffice.org/54202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-05Fix typoAndrea Gelmini1-1/+1
Change-Id: I24a82ffcd060c72aeddddd76c4c5fe667d75f79b Reviewed-on: https://gerrit.libreoffice.org/53833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-04Use the currently active locale if no format passedEike Rathke1-2/+3
No format passed doesn't necessarily mean the init/system locale, use the locale set at SvNumberFormatter::IsNumberFormat() Change-Id: Ief1025fa14145396ba096842e2f3341496ce4ce8 Reviewed-on: https://gerrit.libreoffice.org/53829 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-05-04Avoid number scanner overhead for all General formatsEike Rathke1-0/+7
Change-Id: If28276a1f707c3eb462a013b5604a92ce56038d2 Reviewed-on: https://gerrit.libreoffice.org/53792 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-05-04Avoid number scanner overhead for the 0 General formatEike Rathke1-1/+3
Change-Id: Iec25db8caaccacfef760f269dd1a349f51455052 Reviewed-on: https://gerrit.libreoffice.org/53791 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-05-04Revert "Revert "Resolves: tdf#116579 consider both work locale and format...""Eike Rathke2-76/+107
This reverts commit f5a56c367fba1c42b4f9719b10ff3e86ad5e2ab1. Now that Basic is fixed to set the proper NfEvalDateFormat ... Change-Id: I448edd733b0370b22ff5d8c27fe2c993597c9f8f Reviewed-on: https://gerrit.libreoffice.org/53788 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-05-03Revert "Resolves: tdf#116579 consider both work locale and format locale ↵Stephan Bergmann2-107/+76
date patterns" This reverts commit dfb9138b8b5a239b46f189a717999bcaff19aa79, which caused CppunitTest_basic_macros to fail with > macro result for weekday.vb > macro returned: > Test Results > ============ > > Failed: : the return WeekDay is: 1 > Failed: : the return WeekDay is: 3 > Failed: : the return WeekDay is: 7 > Failed: : the return WeekDay is: 2 > Failed: : the return WeekDay is: 6 > Tests passed: 1 > Tests failed: 5 etc.
2018-05-02Resolves: tdf#116579 consider both work locale and format locale date patternsEike Rathke2-76/+107
If a format was set its locale's date acceptance patterns overwrote the work locale's patterns for the current input. Take both into account, with precedence depending on the NfEvalDateFormat set at SvNumberFormatter. Change-Id: Ie6e837447610d71eb9b8227e602d13d414cad612
2018-04-19convert SFXSTYLEBIT to scoped enumNoel Grandin2-30/+30
drop SFXSTYLEBIT_HIERARCHY because it has no overlap with these values, it's used an extra bit in SfxCommonTemplateDialog_Impl::LoadFactoryStyleFilter Change-Id: I8ee5ecb9b5f8d2087d8eedd1f5526260ec1e4018 Reviewed-on: https://gerrit.libreoffice.org/53089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-16loplugin:useuniqueptr in FSStorageNoel Grandin2-3/+2
Change-Id: Ib7d175905e3fc597e3350d6673cf4f4cc49c96f9 Reviewed-on: https://gerrit.libreoffice.org/52888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-16loplugin:useuniqueptr in SfxItemPool_ImplNoel Grandin5-23/+17
Change-Id: Ic3d695dd3ad4ee5ca6537f65d643d8736e3a5700 Reviewed-on: https://gerrit.libreoffice.org/52886 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-11return std::unique_ptr from SfxItemSet::CloneNoel Grandin1-8/+8
Change-Id: Ie747b5c8ff0b82b9f8d268f9a60dbde41b5f022b Reviewed-on: https://gerrit.libreoffice.org/52712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-07Prefix SfxStyleSheetBase::pPool memberStephan Bergmann1-20/+20
...just that one member; came in handy when researching a failure, and don't want to loose that improvement. Change-Id: Ia5434c4bd8131c37f93d32ce840859469ac258ef Reviewed-on: https://gerrit.libreoffice.org/52553 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-01remove unused processfactory.hxx includesJochen Nitschke3-4/+0
and fix fallout Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee Reviewed-on: https://gerrit.libreoffice.org/52206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-03-31explicitly pass false as arguments of createIteratorhimajin1000001-1/+11
StylePool::createIterator has default paramters,but StylePoolImpl's does not. Change-Id: I1eff95cd3dc9e9bf7bae04aa78920c2d82acabd8 Reviewed-on: https://gerrit.libreoffice.org/52160 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-29loplugin:virtualdown in svl,svtoolsNoel Grandin1-12/+0
I expect a lot of the overriding methods will be removed as soon as I run the unusedmethods plugin Change-Id: I4fb228724fcfba51a98d2113efb93cec1bc15c7c Reviewed-on: https://gerrit.libreoffice.org/52006 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-28Translate German variable namesJohnny_M1-16/+16
Akt -> Current in svl/style Change-Id: Id6f8f7b09a8ae1768708d9fd5d11003fef1e2e42 Reviewed-on: https://gerrit.libreoffice.org/51798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-03-27tdf#69977 improve creation of large chartsNoel Grandin1-3/+6
this patch only tweaks a few things around the edges. The bulk of the cost is down in the chart2 module where it creates ticks and labels. Change-Id: If73a16d2f0a7511f07eff379a9b5c1b38ef96786 Reviewed-on: https://gerrit.libreoffice.org/51931 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-21Remove redundant assertMike Kaganski1-1/+0
We had just returned on this condition Change-Id: I822a4fe62e24442800ca17b404862818095e641d Reviewed-on: https://gerrit.libreoffice.org/51685 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-20no need to construct a new object in SfxIntegerListItem::operator==Noel Grandin1-1/+1
looks like an obvious typo Change-Id: Icea0952ec8203725cf5ba1ec90bdddd82eca7b3c Reviewed-on: https://gerrit.libreoffice.org/51562 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-07use more Color in sfx2..svtoolsNoel Grandin1-3/+3
Change-Id: Idd951841ce7e9c4b4e5229bc24efe5c7b8042617 Reviewed-on: https://gerrit.libreoffice.org/50817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05Make LibreOffice buildable on Haiku.Kacper Kasper1-1/+1
* Obviously VCL wiring is missing, but most components do build. Change-Id: Ie853ada1423a8f4c2b647be59cd47a7730c42978 Reviewed-on: https://gerrit.libreoffice.org/50293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 19:29:37 +0000