summaryrefslogtreecommitdiff
path: root/svl/source/svdde/ddesvr.cxx
AgeCommit message (Collapse)AuthorFilesLines
2018-10-21tdf#120703 (PVS): redundant nullptr check; loop index sizeMike Kaganski1-7/+4
V668 There is no sense in testing the 's' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. V1029 Numeric Truncation Error. Result of the 'size' function is written to the 16-bit variable. Change-Id: I8e0598e892ca160ac074bccfed87c14367a3b46a Reviewed-on: https://gerrit.libreoffice.org/62139 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-20result of DdeQueryStringW unusedCaolán McNamara1-19/+4
since commit 88e3b846b8a4bd4ce5507d1bc5441ee4167e5326 Date: Wed Apr 6 11:28:44 2016 +0200 remove some dead bits of DDE Change-Id: I66b2f8365e3fed15391ff0fe2eb3c874b5054e91 Reviewed-on: https://gerrit.libreoffice.org/62070 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-23More loplugin:cstylecast on WindowsStephan Bergmann1-5/+5
Automatic rewrite (of loplugin:cstylecast and loplugin:unnecessaryparen) after cab0427cadddb3aaf1349c66f2fa13a4234ba4b2 "Enable loplugin:cstylecast for some more cases" and a409d32e7f6fc09e041079d6dbc3c927497adfed "More loplugin:cstylecast" Change-Id: Ib3355159dd08333e1b7a8d091caf2069cdcc7862 Reviewed-on: https://gerrit.libreoffice.org/48317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-19svl: Fix possible memleak at deleting DdeServiceTakeshi Abe1-19/+10
Change-Id: Ie10d4199999c4331af29dee2a8d98132488caa6e Reviewed-on: https://gerrit.libreoffice.org/44909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-29loplugin:unnecessaryparen (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I3a2b7ed3fdef3b77c0a052b10f88918aa616779e Reviewed-on: https://gerrit.libreoffice.org/45469 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-16svl: Drop unnecessary abstraction of DdeItemImpTakeshi Abe1-19/+1
Instead, just use std::vector<DdeItemImpData>. Change-Id: If0c4943bdf370211cd6e0466a899da718480a4ae Reviewed-on: https://gerrit.libreoffice.org/43415 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-05Rename and move SAL_U/W to o3tl::toU/WMike Kaganski1-4/+5
Previosly (since commit 9ac98e6e3488e434bf4864ecfb13a121784f640b) it was expected to gradually remove SAL_U/W usage in Windows code by replacing with reinterpret_cast or changing to some bettertypes. But as it's useful to make use of fact that LibreOffice and Windows use compatible representation of strings, this commit puts these functions to a better-suited o3tl, and recommends that the functions be consistently used throughout Windows-specific code to reflect the compatibility and keep the casts safe. Change-Id: I2f7c65606d0e2d0c01a00f08812bb4ab7659c5f6 Reviewed-on: https://gerrit.libreoffice.org/43150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-22Windows: avoid dependence on UNICODE define; prefer W functionsMike Kaganski1-32/+31
Change-Id: I95b90128e93f0d88ed73601bcc5a7ca9279d4cf1 Reviewed-on: https://gerrit.libreoffice.org/42560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-04-19loplugin:useuniqueptr (clang-cl)Stephan Bergmann1-5/+5
Change-Id: Ia854d1d6a8bd5f5f9a87aebb57337a992606c03f
2017-01-02use std::unique_ptrCaolán McNamara1-8/+8
Change-Id: I1c4f81e0ba0529b9e365c6ddb3d77a8a6a6d5741 Reviewed-on: https://gerrit.libreoffice.org/32649 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-15clang-cl loplugin: svlStephan Bergmann1-49/+50
The DdeInternal::Cli/SrvCallback functions apparently had broken signatures for 64-bit Windows (32-bit DWORD vs. 64-bit ULONG_PTR parameters), but I assume that was actually harmless, as I think that, for Windows x86-64, those arguments are pushed on the stack right-to-left (regardless of CALLBACK), and they are the last arguments, and SrvCallback doesn't look at them at all, and CliCallback only looks at the lower 32-bit DWORD of the first one (nInfo1). Change-Id: Id77749dd2d29180e2d11b0ae2ad248ac1a7f1bdf Reviewed-on: https://gerrit.libreoffice.org/29848 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-08svl: convert DBG_ASSERTs to assertMichael Stahl1-12/+11
Change-Id: Ied13d6588e1c6677898a8151fa881804c3c58ff1
2016-10-07svl: remove #include windows.h from svdde.hxxMichael Stahl1-24/+32
Move Win32 stuff over to DdeInternal class where it can be better encapsulated. Change-Id: Ia3d4c72cf7ad1b7d54bef5d175c579cd426407e7
2016-10-07Revert "More blind fix for --enable-pch Windows builds"Michael Stahl1-4/+4
This reverts commit 1b613450f85d052b7343eacefd79abbfe4f35e2f.
2016-10-07More blind fix for --enable-pch Windows buildsStephan Bergmann1-4/+4
Change-Id: I8e7c79a4d3a9d6c226f9d112c59ada5a7f76c7a4
2016-10-07Make _WIN32-only DDE code use proper HCONVStephan Bergmann1-20/+8
...instead of various integer types. Revealed that the GetConvId functions were unused. Change-Id: I6c6427bd8c14166e58bed3405084e3919bdc97f9
2016-10-06Replace DdeString conversion opreator with proper functionStephan Bergmann1-8/+8
Change-Id: Ia6a9b40ea33dd9bff8322d8cff1692926f6d1db0
2016-07-04remove comphelper::string::removeNoel Grandin1-2/+1
and replace it with OUString/OString::replaceAll Change-Id: I37b1c3b51251dfd9d749d6f1060c75b3a93d7f1a Reviewed-on: https://gerrit.libreoffice.org/26850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-06remove some dead bits of DDENoel Grandin1-37/+5
Change-Id: Ieb1d4e23f1a62b56d14a655a676d9c7d5f33c51c Reviewed-on: https://gerrit.libreoffice.org/23849 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-31rename _Disconnect to DisconnectCaolán McNamara1-2/+2
Change-Id: Ia7b5dce6dbdfd3cfd066003762f449b8bf1ff41a
2015-08-31Disconnect and Connect don't do anything nowCaolán McNamara1-11/+0
Change-Id: If18f530f613e7cb9d0c8f0989752f31178c97dcd
2015-08-31warning C4100: 'nId' : unreferenced formal parameterCaolán McNamara1-2/+2
Change-Id: Ib7df410c79dcdae343d4e7b250aad606fd777526
2015-08-31aDisconnectLink is never called, so remove itNoel Grandin1-1/+0
Change-Id: I9eba6d3f5335060f697ad53e7e2360ef2142609f
2015-08-31aConnectLink is never set, so remove itNoel Grandin1-1/+0
Change-Id: Idd4ecc2f9f566b2d1fa0127dae12fefe1e4479e8
2015-08-14fix windows build, 'unreferenced formal parameter'Noel Grandin1-3/+3
Change-Id: I0761b3c2220b3fa0c40836b1cd984a8d012bf8d6
2015-08-14fix windows build, partial revert of my commitNoel Grandin1-0/+10
adbc556c91ea4afaf3e952aa0a8329e004add63e "make Link<> instances typed" Change-Id: Ia8dd0d755e1c1ccf15938fc9f29bc83759d724a5
2015-08-14make Link<> instances typedNoel Grandin1-22/+3
and remove some unused code Change-Id: I934824401b5c528b07ad76f753f78440c4492885 Reviewed-on: https://gerrit.libreoffice.org/17703 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-08typoStephan Bergmann1-1/+1
Change-Id: I5bba34941d269c728d5d36af8216a481f6939ede
2015-06-08cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: I8b03c27188b02c3c4a9a9fbbe0df1fb1ae1c5caf
2015-03-18more cast hellCaolán McNamara1-7/+7
Change-Id: I125c08ed182786cbdae7b5afabdab0754c31053a
2015-03-18another round of build fixingCaolán McNamara1-3/+3
Change-Id: I79964b1e091b9a11a0e5724c6ce8465b31d25bff
2015-03-18create new 'enum class' SotClipboardFormatId to unify typesNoel Grandin1-1/+1
of which there are several. There are some issues here I am unsure of - the SW and SC and CHART2 modules essentially ignore the enum values and assign their own ids Perhaps I should change them to use the common values and create new enum values where necessary? - the sc/qa/ and sq/qa/ and starmath/qa/ code was doing some dodgy stuff. I translated the code to pass down the stuff numeric values to the underlying code, but perhaps further fixing is necessary? Change-Id: Ic06d723e404481e3f1bca67c43b70321b764d923
2015-03-11V668 no sense in testing the result of new against nullCaolán McNamara1-2/+0
Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
2015-01-12fdo#39440 reduce scope of local variablesMichael Weghorn1-4/+2
This addresses some cppcheck warnings. Change-Id: I46b9293eed0cba2ebca119cc1fb0a6334ea66308 Reviewed-on: https://gerrit.libreoffice.org/13844 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava1-1/+1
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-25fdo#75757: remove inheritance to std::vectorTakeshi Abe1-1/+17
from DdeItemImp. Change-Id: Idb26f982f96ddf1641fd8030d87c88b0cbc14f16 Reviewed-on: https://gerrit.libreoffice.org/11482 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-08-16svl: Remove ASCII art and pointless commentsChris Laplante1-106/+0
Change-Id: Idd8ea0cb7e7d58a29dbfcae084558320efe5fe43 Reviewed-on: https://gerrit.libreoffice.org/10945 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-07-25fdo#39468 Make svl/ German comment cleanPhilipp Weissenbacher1-20/+13
I went through all files manually and checked with the tool. Change-Id: I2eba5e61a0814dd88d7c2c001cd85db8032f1b9f Reviewed-on: https://gerrit.libreoffice.org/10545 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-11-10clean up #ifdef ICC codeMichael Stahl1-6/+0
According to the dmake documentation, ICC refers to Visual Age C++ for OS/2, which is not a supported compiler (or platform). Change-Id: Ic9e23bc7c44de110a3a312bd007beda3b660927d
2013-10-20drop unnecessary tools/string includesCaolán McNamara1-1/+1
Change-Id: I4278999b9b7d184c26036bbe9e3b98420f461e8c
2013-10-18some GetTokens hidden in windows only codeCaolán McNamara1-5/+5
Change-Id: I45da175fe0f72996b26d66c29e0e6a1b4115b896
2013-10-02bWeiter -> bContinuePhilipp Riemer1-10/+10
Change-Id: Ia0bba3c1610dce5d364fb584f04e0b66cc41fb20 Reviewed-on: https://gerrit.libreoffice.org/6077 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-09-26Missing #includeStephan Bergmann1-0/+1
Change-Id: I2af468933b1e9bdad1c6da1f881daaf068b6bec0
2013-07-07module svl: all String and some bool and related clean-upNorbert Thiebaud1-154/+172
Change-Id: I36eb559fa58dbe75384b7119c788af0048813aed Reviewed-on: https://gerrit.libreoffice.org/4733 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-06-10mingw64: change Link class to use sal_IntPtr instead of longFridrich Štrba1-4/+4
Change-Id: I2b78c7b714ff064f2f1b8a8eb161e5e2ae121eee
2013-06-04Some more sal_IntPtr dance, but enough for todayFridrich Štrba1-12/+6
Change-Id: Ic772181321e74713244223cc3d4542bd4cd2dc88
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák1-16/+16
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-03-11svl: fix buildThomas Arnhold1-4/+4
some more conversions from 7d1f4cdec307bb1e761bb5dd3d8231bba5833e10 Change-Id: I95e4fdf190e1f92501f3ec6ea09017e0c7bffe4f
2012-08-02strip down UniString some moreCaolán McNamara1-17/+17
Change-Id: Ibd749a70a7bbe8c1023edf7bd144aa6547147a12
2012-07-31Fix mingw build of svlFridrich Štrba1-5/+9
Change-Id: I9992dba75903fea3d31be73de69e49f439df3a41
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-24 16:45:49 +0000