path: root/svl/qa
AgeCommit message (Collapse)AuthorFilesLines
2015-05-19Update Apache Bugzilla’s URLAdolfo Jayme Barrientos1-1/+1
Change-Id: I6ef4ae530b7fb4e615100803ae6e3972d9b4545f
2015-04-15convert SFX_ITEM constants to scoped enumNoel Grandin1-4/+4
Change-Id: Ief8c30c356ba947727c5ab70092042816a0db99e Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2015-02-25remove NUMBERFORMAT_ constantsNoel Grandin1-2/+2
.. in favour of just using the underlying constants from css::util::NumberFormat Change-Id: I0c6b128b66c91b268f5ae300f9c17c7792df5e99
2015-02-18boost->stdCaolán McNamara1-0/+2
Change-Id: I412137e7e7b9b2b87f401bc140a9499d1fc012c6
2015-01-26-Werror,-Wmissing-bracesStephan Bergmann1-497/+497
Change-Id: I86f9b9ada62687e8159497bf428e18be1442c8a6
2015-01-26merge existing date input tests to new unit test, tdf#63230Eike Rathke1-28/+2
2015-01-26add older problems to unit test, tdf#63230Eike Rathke1-2/+8
Check that various older problems remain fixed.
2015-01-26add unit test for tdf#63230Eike Rathke1-0/+525
All problematic dates of Muchas gracias to Isamu Mogi!
2015-01-05java: remove dead codeNoel Grandin3-3/+0
found by UCDetector Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2015-01-02iss is unordered_multimap, so can't rely on orderCaolán McNamara1-0/+1
Change-Id: Ief399439bdde047dfbaef43f2262e6212db8bd7e
2014-12-19java: reduce visibility of some methods and fieldsNoel Grandin1-1/+1
found by UCDetector Change-Id: I0a0a00d1fae1fed2e6aef198b7a1482d7e7e29f0
2014-12-11java: reduce visibility of fields and methodsNoel Grandin4-8/+8
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: Tested-by: LibreOffice gerrit bot <> Reviewed-by: Noel Grandin <>
2014-12-10java: simplify the getMSF() methodsNoel Grandin2-5/+3
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3 Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2014-11-18Apply pimpl to svl::SharedStringPool.Kohei Yoshida1-0/+1
Change-Id: I351505f0c1cb25c47897e0cfffdb258f8e87081f
2014-11-18java: make fields final where possibleNoel Grandin1-1/+1
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-08-13java: reduce scope, make fields privateNoel Grandin1-1/+1
found by UCDetector Change-Id: I7f97e15667159cf8ee776e8f32fdcdec8ec00ed6
2014-08-12java: remove useless javadoc tagsNoel Grandin1-22/+0
that are not conveying any useful information Change-Id: Ic37934b8cc376fcdcb3d295232452f411dfd43b1
2014-08-05java: remove commented out codeNoel Grandin4-46/+0
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-07-23svl: fix comparison in new unit testMichael Stahl1-1/+1
Presumably the test should use the unused variable w, and the result should be 3 since that's how many styles were inserted. Change-Id: I34455020e1fb8c53204b6ee0632138c1077617a2
2014-07-23fdo#76754 Add return first to IndexedStyleSheets to speed up ods writingTobias Lippert1-0/+31
Change-Id: I6fc9fe8ce78ad9cc1a7c2fe3e13ed38ce468ce6c Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2014-07-23fdo#76754 Add Positions by StyleSheetFamily to IndexedStyleSheetsTobias Lippert1-2/+25
Change-Id: I4eade2d00d145d8f65ccd70a1c6bbd0a134a1ad5 Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2014-07-22fdo#76754 Speed up registration of new listeners to SfxBroadcasterTobias Lippert1-1/+1
Also change behavior for the GetListenerCount() method which now returns the count of listeners. The previous behavior is available in method GetSizeOfVector(). Change-Id: I5b03fa55a309f4ff5aea5e8830c137786fc07e89 Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2014-07-22Add unittests for SfxBroadcasterTobias Lippert1-0/+98
Change-Id: I9ecd8fec395eafbdc2675dda9fa25ac32761123c Reviewed-on: Reviewed-by: Noel Grandin <> Tested-by: Noel Grandin <>
2014-06-19related fdo#63230: Fix unit test for fdo#44286 to run in all localesIsamu Mogi1-1/+1
fdo#44286 test fails depending on system language. To fix it, this commit sets output language to LANGUAGE_ENGLISH_US. Erorr message: | $ LANG=fr_LU.UTF-8 make -rs CppunitTest_svl_qa_cppunit | [build CUT] svl_qa_cppunit | /home/master/src/libreoffice/workdirs/master/svl/qa/unit/svl.cxx:403:(anonymous | namespace)::Test::testFdo44286 | equality assertion failed | - Expected: 1902-04-22 | - Actual : YYYY-04-DD | | svl.cxx:403:Assertion | Test name: (anonymous namespace)::Test::testFdo44286 | equality assertion failed | - Expected: 1902-04-22 | - Actual : YYYY-04-DD | | Failures !!! | Run: 7 Failure total: 1 Failures: 1 Errors: 0 Change-Id: I58756c7508c7f02bec9c3b7b693032265d18c6ae Reviewed-on: Reviewed-by: Lionel Elie Mamane <> Tested-by: Lionel Elie Mamane <>
2014-06-18related fdo#63230: Add unit test for fdo#44286Isamu Mogi1-0/+32
It fails if 6013fe19a40dd16ce435a2428f7405b51930689e is reverted. Change-Id: Iabf13b15e3c26d7ebafdc9284642183f27723d8c Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2014-06-17fdo#38513 - Accelerate non-poolable item add / remove.Michael Meeks1-0/+117
For large documents we create and destroy a large number of non-poolable SfxPoolItems, which get inserted into and removed from a vector. Unfortunately the performance of this (depending on pattern) is O(N) and this insert/remove/extend pattern can happen per text span we insert. This patch makes this O(const) via a hash. This gives a 5x speedup for the above bug; 176s to 34s or so, and moves the remaining performance issues elsewhere. Unfortunately, we have to retain the ordered array to keep the binary file format code (used for editeng cut-and-paste) in place, so have to keep both a hash, and an array, and a list around for free slots. cf. fdo#79851 where there is a start at removing that. This wastes space; but not that much - for a large open document collection we have O(100's) of SfxItemPools, and O(1000's) of SfxPoolItemArray_Impls; having fixed fdo#79851 we can consolidate this. Add skeletal unit test; translate several German comments; remove un-necessary include. Change-Id: Ie0de32b1a29217560c5591c71a6cd4e26d39a531 svlThomas Arnhold3-35/+35
Change-Id: I18fb7a677e2bb98c83f43f5af3fa988393dc23f9
2014-05-09move INetContentTypes::scan() to INetMIME::scanContentType()Chr. Rossmanith1-3/+3
to avoid circular dependencies between svl and tools when using INetContentType::scan functionality for future handling of data urls in urlobj.cxx Change-Id: Iad13286769e8906aebf8208e4f532151ff2f3d13 Signed-off-by: Stephan Bergmann <>
2014-04-21remove comments why a file gets includedThomas Arnhold1-1/+0
also remove some commented out code Change-Id: Ia80c5c57d8d2a74418032de50eee95642cc0969d
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann1-1/+1
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-27Introduce INetContentType::scanStephan Bergmann1-0/+92
...for use in <> "new methodINetURLObject::getData() for data urls." Change-Id: Id381d7c328153fbea44c0efb80532b2961c6c2b7
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann2-12/+12
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-11fdo#30770 - Speed up xslx importTobias Lippert1-0/+160
Conflicts: include/svl/style.hxx Change-Id: Ie3d855923c651b6e05c0054c8e30155218279045 Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann1-10/+10
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-25Remove visual noise from svlAlexander Wilms1-14/+14
Change-Id: Ib914ec8d161e24f4e3e1fb8e7684a780d3ae6209 Reviewed-on: Reviewed-by: Björn Michaelsen <> Tested-by: Björn Michaelsen <>
2014-01-30fdo#63154 Removed unused solar.h ref. in linguc., sfx2, starmath, svl and svxAlexandre Vicenzi1-1/+0
Change-Id: I241661119371b75804fcf9215ff5e5da2a5b9265 Reviewed-on: Reviewed-by: Caolán McNamara <> Tested-by: Caolán McNamara <>
2013-10-23convert code to use OUString::endsWithNoel Grandin1-1/+1
Convert places that call aStr[aStr.getLength()-1] == 'x' to use the shorter form aStr.endsWith("x") Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
2013-10-11Fix equality operator for SharedString & write test for it.Kohei Yoshida1-6/+18
Change-Id: Ib592ca2fe359293da6c10aa9e1535a91627cfc43
2013-10-08Re-implement interning in order to return both string arrays.Kohei Yoshida1-43/+33
One is for the cased string and the other one for the non-cased one. Change-Id: I798687f2efecaaea73a09e0b3348f85a9d9e8c07
2013-10-05This DEBUG_UNIT_TEST stuff is unusedTor Lillqvist1-11/+0
Change-Id: I947713bda2c37e22199161a2c59e5d9ed00b37a2
2013-10-05unused function 'operator<<'Tor Lillqvist1-7/+0
Change-Id: I05d3877e2b0cb4bfccd3a2ae6f24abfd6507c46d
2013-10-04Rename StringPool to SharedStringPool because that's what it is.Kohei Yoshida1-3/+3
Change-Id: I2fc3ce4f0c2291d402cb470346d5561373fb51e7
2013-10-04Let's just use sal_uIntPtr straight.Kohei Yoshida1-2/+2
So that the user of this class won't have to include the header just to get the string ID type. Change-Id: I0ccbc18fe02644f69701f57b0b1b9c30fd141d83
2013-10-04A little more test on shared string pool's life cycle management.Kohei Yoshida1-0/+44
Change-Id: Ic676dd875c27ce60a0707903d7f22207764829e0
2013-10-04No need to intern strings here; all OUString's are ref-counted.Kohei Yoshida1-1/+1
Calling intern() simply moves it to a global hash storage. Now the test passes. Change-Id: I0a93420abce1c3adaaa61d469dff5f359dd5ada4
2013-10-04Add purge() method to purge unreferenced strings from the pool.Kohei Yoshida1-1/+21
But this code needs more work. Change-Id: I538eebf5eb1738a2cfeebc22052b3d5db6001b6b
2013-10-04Correct way to get case-insensitive string identifiers.Kohei Yoshida1-0/+4
Change-Id: Ia343165941231fab34c4904b7a2fa10b07fa32bb
2013-10-04Let's not expose the internal pointer. Define different ID type.Kohei Yoshida1-18/+21
To prevent the string ID's from being used to instantiate string objects, which can mess up shared string object's life cycles. Change-Id: Ibcd9a4fa9f591d5c27a9e1b50bc9f83ae230e86a
2013-10-04Write some rudimentary tests for the new shared string pool class.Kohei Yoshida1-0/+40
Change-Id: Ie66de46d69f664839aa0a2d056cd3b8df4d4989b
2013-05-16Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks1-3/+0
Change-Id: Ie154eadd9960b159f5a250cde93c4bd7a8a948cf