summaryrefslogtreecommitdiff
path: root/store
AgeCommit message (Collapse)AuthorFilesLines
2017-07-17loplugin:constparams in store,registryNoel Grandin4-8/+8
Change-Id: I5633203b372a9abd0138a396958c235ea8aaf66d Reviewed-on: https://gerrit.libreoffice.org/40039 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-10teach unnecessaryparen loplugin about identifiersNoel Grandin2-2/+2
Change-Id: I5710b51e53779c222cec0bf08cd34bda330fec4b Reviewed-on: https://gerrit.libreoffice.org/39737 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-02loplugin:casttovoid: storeStephan Bergmann2-2/+0
Change-Id: Idb679a4070202fe7baecab79b69a5a4cf395e7d7
2017-06-27loplugin:oncevar in starmath..svlNoel Grandin1-8/+4
Change-Id: I20e3796407c7e429a88d2811673929ac1141a41c Reviewed-on: https://gerrit.libreoffice.org/39280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-21loplugin:unusedfields store..svlNoel Grandin1-1/+0
Change-Id: I6070a683e5128271b84a10caccb548d07c950927 Reviewed-on: https://gerrit.libreoffice.org/39021 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-16Remove a bunch of comment cruft - esp. "the end." bitsChris Sherlock10-214/+8
Change-Id: I5a339a4211ec8eb547459996be69610b9f2b3766 Reviewed-on: https://gerrit.libreoffice.org/38147 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-06-05Improved loplugin:cstylecast to reference types: storeStephan Bergmann1-1/+1
Change-Id: I78213cb2b8812ebdd1354c045318d081e4197934
2017-05-30teach redundantcast plugin about functional castsNoel Grandin3-4/+4
Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0 Reviewed-on: https://gerrit.libreoffice.org/37910 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09cleanup osl/diagnose.h includesJochen Nitschke2-2/+0
with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-07revert OSL_ASSERT changesChris Sherlock2-3/+3
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert store from OSL_ASSERT to assertChris Sherlock2-3/+3
Change-Id: I7500a0021b33a50ca2e73220b2f8fa2f5ac16e22
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky1-1/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-03-03Remove redundant 'inline' keywordStephan Bergmann1-2/+2
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25loplugin: unnecessary destructor sfx2..storeNoel Grandin1-3/+0
Change-Id: Idbf2585e48cd89a43ab68c5c8819880d20461ccf Reviewed-on: https://gerrit.libreoffice.org/33514 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-11OSL_TRACE -> SAL in sfx2..svxNoel Grandin3-6/+6
Change-Id: I78cf8058a5682baa3d7b00a25feeb2d28fb3e66e Reviewed-on: https://gerrit.libreoffice.org/31799 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-14loplugin:countusersofdefaultparams in sot..svtoolsNoel Grandin4-6/+6
Change-Id: Ifce19de3518f3eaf5a1b6439f9053feee4a33c14
2016-10-07tdf#100302: gbuild: always use $(LFS_CFLAGS)Michael Stahl1-1/+0
Currently LFS_CFLAGS are only used in a handful of libraries but there's no obvious reason why it can't just be set everywhere. Also set it in windows.mk, i have no idea if it's needed for MinGW (certainly not for MSVC). Change-Id: I5f62e3011c2089abbf5539fc54c7ff10e07b1599
2016-09-30cid#1371195, cide#1371212: Replace PageHolder with shared_ptrStephan Bergmann8-164/+81
...removing the need for SharedCount, too Change-Id: I20c724c940c571aef1c12453da30c3e9fbb46466
2016-09-30Remove OStorePageData typedefStephan Bergmann5-12/+11
Change-Id: I9f4e8fa41a59325fe7036acb66d045a833294bd6
2016-09-30Remove "#if 1 /* EXP */"Stephan Bergmann1-2/+0
...whatever it was supposed to be good for Change-Id: I8f2a526aeaa484675e1bd6763fa692f8cbed2a51
2016-09-30No need for rtl_cache_* hereStephan Bergmann2-64/+7
...which shows that m_pCount will never be null Change-Id: I87c6e4bf5d258c59a8e91cd194c64b1ce85b4445
2016-09-19convert storeAccessMode to scoped enumNoel Grandin6-22/+22
Change-Id: I67705cdff0440487019a2992571147d648be1bfc
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl3-10/+10
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann10-12/+12
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-08-31store: remove STORE_IMPL_ISP2 and STORE_IMPL_CONCAT.Arnaud Versini2-10/+1
Change-Id: Iec6cff8da24515f17a5ad2b9ba6e1f92df124921 Reviewed-on: https://gerrit.libreoffice.org/28508 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-31store : Replace store::swap with std::swapArnaud Versini1-16/+10
Change-Id: I85c1026502dc69b229aaf287858ae76f9391a34d Reviewed-on: https://gerrit.libreoffice.org/28506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-29loplugin:countusersofdefaultparams in store..svtoolsNoel Grandin1-2/+2
Change-Id: I15b4400bddc5a4d0e3de5dfffe18b7e493f97df6 Reviewed-on: https://gerrit.libreoffice.org/27580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin1-4/+0
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann1-2/+2
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-04-13tdf#94306 replace boost::noncopyable in stoc to xmlsec..Jochen Nitschke4-15/+20
Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Add missing default ctors. With this commit there should be no users of boost::noncopyable left. Change-Id: I6b1e47824912a6a80cc3f00f34938ebc048d8975 Reviewed-on: https://gerrit.libreoffice.org/24051 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-11loplugin:constantparamNoel Grandin2-5/+4
Change-Id: Ie690088d7a7d568703afd22f544628fc8012a7e1
2016-03-10Drop __store_ prefix from static entity (avoid reserved identifier)Stephan Bergmann1-3/+3
Change-Id: Ib03727f6b47d8f013f78a590d36d568ebc405bf3
2016-03-01loplugin:unuseddefaultparam in storeNoel Grandin2-30/+17
Change-Id: I825eb075b73daa5bf52e1d41c32cf2100abebe47
2016-02-23new loplugin: commaoperatorNoel Grandin5-21/+56
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-01-14loplugin:unusedmethods unused return value in store,svlNoel Grandin1-28/+0
Change-Id: I369b3ae84af046242430977cec7d5c5e69fc27e7
2015-12-21loplugin:unusedfields in store,svtools,svxNoel Grandin1-19/+0
Change-Id: I9577c64e33950899c2e3467c7b481504e021d470
2015-12-10More loplugin:nullptr automatic rewrite (within templates)Stephan Bergmann1-5/+5
Change-Id: I9bc06cfb5eeb38fd7ae7fb25f876ea9f96e4a65a
2015-11-23loplugin:unusedfields in store/Noel Grandin1-3/+1
Change-Id: I0fae339e3736f98d5d534b8a01a3040c237c6621
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann12-92/+92
Change-Id: I2a4f84e8c36197a9d39a5bd36cb1e2401a956d87
2015-10-30loplugin:unusedmethodsNoel Grandin2-32/+0
Change-Id: Id3b5cd75d4357336ed592ef11a3f34d209f8e95f Reviewed-on: https://gerrit.libreoffice.org/19636 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-27loplugin:unusedmethodsNoel Grandin8-1014/+0
Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861 Reviewed-on: https://gerrit.libreoffice.org/19231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-22tdf#65108 use <> instead of "" in include lineFeyza Yavuz1-3/+3
Change-Id: Icc497610505d160ee7d0e3a129eb499fe4ba5c93 Reviewed-on: https://gerrit.libreoffice.org/19422 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-10-14coverity#1326107 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: I6f2dc9c12349a5175ed34e22fa29d875d6b9bd0a
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann7-40/+40
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann5-10/+10
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-07loplugin:mergeclassesNoel Grandin2-161/+88
Change-Id: I14985f98989861d74b3904ab79f3ced5a3d96f73
2015-10-07loplugin:mergeclassesNoel Grandin5-50/+16
Change-Id: I28d8bd79f266df7e9ea420f7238ed332ec4205a9
2015-10-05clang-analyzer-deadcode.DeadStoresStephan Bergmann1-2/+2
Change-Id: I490f345d382b62001cf29a64ed732e854bdc5f7b
2015-10-01tdf#42949 remove unnecessary includes using iwyuNoel Grandin1-0/+1
Change-Id: I13960721b7e15b1761aff8497391e39ae5645b89 Reviewed-on: https://gerrit.libreoffice.org/18616 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-29loplugin:removeunusedmethods, remove unused stuffNoel Grandin1-7/+0
Change-Id: I35456b2a3ad2a84a1d045f09cdfb29e4c19b8350
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-26 14:05:43 +0000