path: root/store
AgeCommit message (Collapse)AuthorFilesLines
2015-05-11Add back functionality erroneously removedStephan Bergmann2-2/+14
...with 09d5b31ebe187a4cd9f3efca5a7cb7f87e1e19f6 "loplugin:constantfunction: store," which apparently over-eagerly reduced functionality that happened to be constant in one specific implicit instantiation of a template, but not in others. (Plus, adapting the original code to silence false loplugin:staticmethods warnings.) Change-Id: I156df3aef1b3b0c9d36b2a54c57de29948749bde
2015-04-22Various #include <sal/log.hxx> fixupsStephan Bergmann1-0/+1
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. Cleaned up some, but something like grep -FwL sal/log.hxx $(git grep -Elw \ 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF') -- \*.cxx) shows lots more files that potentially need fixing before the include can be removed from rtl/string.hxx and rtl/ustring.hxx. Change-Id: Ibf033363e83d37851776f392dc0b077381cd8b90
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin13-66/+66
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-02loplugin:staticmethodsNoel Grandin1-1/+1
Change-Id: I1f6c6d13697aa397067478d6b07429120106e6bd
2015-03-31Reduce to static_cast any reinterpret_cast from void pointersStephan Bergmann1-1/+1
Change-Id: Ie38450a082dc840714051ad65c297886038e68f3
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann2-3/+3
Change-Id: Ibd23c1d96b093ae2670e7752691dad29c081639f
2015-03-24loplugin:constantfunction: storeNoel Grandin3-43/+26
Change-Id: I13284409404ef77eb16164b7ce2074259d2cad12
2015-03-13tdf#43157: Fix format string violations in OSL_TRACE etc.Stephan Bergmann2-3/+7
...for a 32-bit build, similar to what ee11e221d2108212619e1bbe7f029e7d9afdba32 "tdf#43157: Fix format string violations in OSL_TRACE etc." did for a 64-bit build Change-Id: I05dd79ede3e66cb9ab7a33792319eb34b34c82dd
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin4-12/+12
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-02-07loplugin:deletedspecialStephan Bergmann5-26/+11
Change-Id: I87b252d3d6e5322dbc4b6cc77b846766a0d35893
2015-02-05convert all remaining BOOST_STATIC_ASSERT to static_assertCaolán McNamara5-14/+8
and we can include a few less headers Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
2015-01-26followup code removal after changing virtual methods to non-virtualNoel Grandin1-42/+0
This cleanups up indentation and removes dead classes. This is a followup patch to commit 272b1dd55797aacf511fb4342b0054e3697243f6 "new loplugin: change virtual methods to non-virtual" Change-Id: I1c2139589cf8cb23bb9808defe22c51039d38de1
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin1-2/+2
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-19Suppress 1 cppcheck warning arrayIndexOutOfBoundsJulien Nabet1-0/+3
See Change-Id: I365befacf7d10bcbf0a159cfdcabd3eb1644d02b
2014-11-21Remvoe store/workben/Stephan Bergmann6-2585/+0
...probably not worth dragging that unused code around any more Change-Id: I4f22a704af862d8a1fe1f2202609f355ccee7c9c
2014-11-18More iwyu suggested headers removalRiccardo Magliocchetti2-5/+0
Signed-off-by: Riccardo Magliocchetti <> Signed-off-by: Stephan Bergmann <>, undid one remove that was detrimental to loplugin:unreffun Change-Id: I18d8252084d828f94ef7a954e1dbfb45743d7970
2014-11-12coverity#1242813 Unused valueCaolán McNamara1-2/+2
and coverity#1242867 Unused value Change-Id: I8ad069a5a84b97e956cafcd925fd733fb5ed9b2e
2014-11-04coverity#1242933 unused valueDavid Tardon1-1/+1
Change-Id: I416144a4ccf2856ce85ab4b24a69958615276cb9
2014-11-04coverity#1242809 unused valueDavid Tardon1-1/+1
Change-Id: I16430567b3d57016458bd7877c36bc6e01197741
2014-08-14warning C4189: : local variable is initialized but not referencedThomas Arnhold1-2/+1
Change-Id: I650fab8227fd8b6aeb4fd4d420cb820aefd80271
2014-07-18cid#1226495 Uninitialized scalar fieldNoel Grandin1-1/+1
Change-Id: I5f05fc312032c50639f147f27353aa560a69f65a
2014-07-10use SimpleReferenceObject in stoc moduleNoel Grandin10-148/+15
to replace hand-rolled version Change-Id: I30635aec81313e4e0d1b67b30c8992fd63bb1f67
2014-07-08WaE: C4754Tor Lillqvist1-2/+2
VS 2013 warns: Conversion rules for arithmetic operations in the comparison mean that one branch cannot be executed. Change-Id: I85f6df16b0ced94677568441d87a588bed1bfb9b
2014-06-13loplugin:staticcallStephan Bergmann1-11/+8
Change-Id: I2317522af91c8c60672c72a3b514767039930e22
2014-06-06Bin ugly (ab)use of preprocessor in headers (final part)Thomas Arnhold1-1/+0
Finish the work of ec8617568ff091026b2f17cce3b547b1633fa6c4 Only one is left: SC_PROGRESS_CXX Change-Id: Ifdc07ec377d7a84e92bc4b0a66ab82b1fc93f76a Reviewed-on: Reviewed-by: Thomas Arnhold <> Tested-by: Thomas Arnhold <>
2014-06-05various: remove SAL_THROW macroNoel Grandin2-6/+6
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-05-12fdo#43157 Remove OSL_POSTCOND, prefer SAL_WARN_IFMichaël Lefèvre7-35/+47
Change-Id: Ia89a2dce799c7ba90bcd19919195bfd2c7a4a180 Signed-off-by: Stephan Bergmann <>
2014-05-05simplify ternary conditions "xxx ? yyy : false"Noel Grandin2-2/+2
Look for code like: xxx ? yyy : false; Which can be simplified to: xxx && yyy Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d some smaller dirsThomas Arnhold10-30/+30
Change-Id: Ic25bd678dc299627299b22145efd7bebcf2b39d0
2014-04-07TypoStephan Bergmann1-1/+1
Change-Id: Ie264bfec4a8c34adcaa45c0a5cc43c1109d31c95
2014-04-07Fix READMEStephan Bergmann1-1/+5
Change-Id: Ib07a18d6592432e9e1716641938a6f336daa7b4b
2014-04-04Clean up unreferenced functionsStephan Bergmann4-49/+13
Change-Id: I1dbb864d030b61417f6d137fc967f158e9243ed7
2014-03-27remove PROFILE checksThomas Arnhold1-12/+0
never defined, follow-up of 512de6e75d34d2144392d1e78c25446f2d0b3a35
2014-03-27sfx2, sc: remove macros for using Windows NT Call ProfilerMichael Stahl1-17/+0
Apparently this tool was available for early versions of NT; googling finds a from 1992 but that is missing the CAP.dll so there's no way to use this anyway. Change-Id: I4718af0e175b78bcdad38bbca0fc9579b3b12111
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann7-53/+53
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-12No need for isKindOf to be SAL_CALLStephan Bergmann8-9/+9
Change-Id: Ia58af7d32904de01fdb5291203938c748cae94c6
2014-02-27Remove visual noise from storeAlexander Wilms16-88/+25
Change-Id: I6753eb480618af747ecf4a3ae3c666257761ce70 Reviewed-on: Reviewed-by: Stephan Bergmann <> Tested-by: Stephan Bergmann <>
2014-02-17store: sal_Bool -> boolStephan Bergmann11-16/+16
Change-Id: I7d108e7ae387f9c07cce182a0bb09b69a6608226
2014-01-28bool improvementsStephan Bergmann1-1/+1
Change-Id: Ibc5e3084e4bec40005779854ce7552a2eb39a7ed
2013-11-11convert OUString compareToAscii == 0 to equalsAsciiNoel Grandin1-1/+1
Convert code like aStr.compareToAscii("XXX") == 0 to aStr.equalsAscii("XXX") which is both easier to read and faster. Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-07-09Remove warning by using the right printf commandsArnaud Versini1-2/+2
Change-Id: Id476a0eb1f5965098c8cc2e2847547b1d23387eb Reviewed-on: Reviewed-by: Petr Mladek <> Tested-by: Petr Mladek <>
2013-06-20-Werror,-Wdeprecated-registerStephan Bergmann2-5/+5
Change-Id: I1ec3d7845477cfb5bc6a3d7f70ddabef12583e1b
2013-06-10mingw64: use the sal formatting strings in storeFridrich Štrba1-1/+1
Change-Id: Id6b8f4ed6df14bd80a7937001ec1cfb98acd7f52
2013-04-30Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks2-42/+8
2013-04-24gbuild: drop empty use_packages callsDavid Tardon1-3/+0
Change-Id: I8e9f70eb5d929c98b4379416c2259a74e31d587f Reviewed-on: Reviewed-by: David Tardon <> Tested-by: David Tardon <>
2013-04-24gbuild: drop uses of removed packagesDavid Tardon1-1/+0
Change-Id: I400fad08c0ae7b6b34bad63693f54856867e4dac Reviewed-on: Reviewed-by: David Tardon <> Tested-by: David Tardon <>
2013-04-23execute move of global headersBjoern Michaelsen6-1237/+0
see and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a
2013-04-12do not set soversion for private ure librariesMatúš Kukan2-59/+0
Change-Id: I2b2099d8fc00062f67c42e73c4b8a17a689db89d Signed-off-by: Stephan Bergmann <>
2013-04-10Revert "store: new ZipPackage_store_odk_headers"Michael Stahl3-9/+7
This reverts commit 5c60cebafdc6d6d773c794c0a4ee58d63782df22. The "store" library is not actually a stable URE interface. Conflicts: odk/ Change-Id: I221696515ba07b0155406a503c33760c58d1338f
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák7-25/+23
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09