summaryrefslogtreecommitdiff
path: root/starmath
AgeCommit message (Collapse)AuthorFilesLines
2014-11-03fix memory leak of pointers contained in m_aErrDescListTakeshi Abe2-12/+8
Change-Id: I9fcbdcd54978ccaffa5359c0afb0a1990356c218 Reviewed-on: https://gerrit.libreoffice.org/12205 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-11-02unused includes in RTF filter and related filesMiklos Vajna2-3/+0
Change-Id: Id13e10f2ceed3985c78ccc542e6677eccc0cb1c7
2014-10-31Resolves: #i118191# Red is not red enoughRegina Henschel6-20/+103
Enable Math to use 16 basic HTML colors Patch by: Regina Henschel <rb.henschel@t-online.de> Found by: <lapsap7+ooo@gmail.com (cherry picked from commit 529e59d90037748d0030191b93252e597935243e) Conflicts: starmath/inc/parse.hxx starmath/source/mathmlimport.cxx starmath/source/parse.cxx Change-Id: I08de0ce33928ead3635a3a87c81671b4cc4112ac
2014-10-31convert COMMAND_WHEEL constants to an enumNoel Grandin2-2/+2
Change-Id: I413d821a984ab556bd19c52704c04de6d828f699
2014-10-30HIG fixes for smath dialogsAdolfo Jayme Barrientos10-427/+217
Disabling manual resizing, setting modal flags, fixing spacing and adding missing colons to labels that precede controls. Change-Id: Id0f180355d302206a632af97dafb6a391c8b4472 Reviewed-on: https://gerrit.libreoffice.org/12105 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin2-2/+0
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-27fdo#84938: replace KEYTYPE_ constants with enumNoel Grandin1-3/+3
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328 Reviewed-on: https://gerrit.libreoffice.org/12104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky12-73/+73
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky9-49/+49
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-21fdo#84938: replace WINDOW_BORDER constants with enumNoel Grandin2-6/+6
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-17coverity#1247645 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Id6596945d51a1b9f8750aa0f46f6a061cb2e80c3
2014-10-17coverity#1247642 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ic7ffc47fd84f89029c140d68601971a5a2d58d0a
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon9-49/+49
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann1-1/+0
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-14SmViewShell: pImpl must outlive aGraphic memberStephan Bergmann2-2/+5
...as at least during CppunitTest_starmath_qa_cppunit, during ~SmViewShell, aGraphic's code calls back into SmViewShell's code calls into pImpl: SmViewShell::IsInlineEditEnabled() const starmath/source/view.cxx:2057:12 SmGraphicWindow::IsInlineEditEnabled() const starmath/source/view.cxx:227:12 SmGraphicWindow::CaretBlinkStop() starmath/source/view.cxx:297:10 SmGraphicWindow::~SmGraphicWindow() starmath/source/view.cxx:126:5 SmViewShell::~SmViewShell() starmath/source/view.cxx:1976:1 [...] This is somewhat symmetric to 0e263d61811480f3a9dbc6ad7c752f6cfae4e3fc "order pImpl before aGraphic because aGraphic deferences pImpl in ctor." Change-Id: I97494bebaf5747205a690e6d65fd05ba8fb61cab
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin6-12/+12
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-13vcl: Make ImplFontCharMap a pImpl and move functions to FontCharMapChris Sherlock1-3/+5
To do this, I've made FontCharMap a friend class for ImplFontCharMap, and have moved the functions directly into FontCharMap. In this patch, I am attempting to stop the direct use of ImplFontCharMap by anything other than FontCharMap. However, FontCharMap itself requires a refcounter, so we will use FontCharMapPtr to access the font character map. Change-Id: I509b990a8cbd911c5cc1572c7d24fc5348ca06d9 Reviewed-on: https://gerrit.libreoffice.org/11823 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-10-11convert SFX_CALLMODE constants to SfxCallMode enum classNoel Grandin6-22/+22
and fix a couple of bugs in SC and SW where the call mode was being passed to the hints parameter by accident Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58 Reviewed-on: https://gerrit.libreoffice.org/11916 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11convert vcl StateChangedType to enum classNoel Grandin2-3/+3
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11starmath: close SfxObjectShell in unit test to stop temp file leakageMichael Stahl1-0/+1
Change-Id: Iaf2df8a315b3e0c8cdd1f1a4a7d589682384ddaf
2014-10-10indentation fixesMiklos Vajna1-1/+1
Change-Id: I56664b455383f69137399e4c5fb28521ef813287
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca12-73/+73
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-02coverity#735498 Logically dead codeCaolán McNamara1-1/+1
Change-Id: Ia2a6df4aef944d81be41593ed001156d3f1ea054
2014-10-01coverity#1242448 Identical code for different branchesCaolán McNamara1-2/+2
Change-Id: Ie864a4d04ea1ae701ab5dbb5b93807e98d5f0f1c
2014-09-30fdo#82577: Handle RegionNoel Grandin1-1/+1
Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-27border_width from 12 to 6, as the rest of dialogsAdolfo Jayme Barrientos1-2/+3
I know the old GNOME HIG mentions extra spacing for queries, but I’ve never understood why -- not even GNOME itself respects that rule. It just looks inconsistent and wastes space. Change-Id: I181f800957f69b0943369791e460c7273b6b08f6 Reviewed-on: https://gerrit.libreoffice.org/11658 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-25editeng: std::auto_ptr -> std::unique_ptrStephan Bergmann1-1/+1
Change-Id: I25e3599a37d720cbcf70ea13ab30234e54637d53
2014-09-24Replace some std::auto_ptr function parameters with std::unique_ptrStephan Bergmann1-5/+8
Change-Id: Ic66d325fd9559c6dde9556c26e5b2a7e60376c49
2014-09-23fdo#82577: Handle WindowNoel Grandin16-65/+65
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-18fdo#82577: Handle FontNoel Grandin14-73/+73
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-15sd: sal_Bool -> boolStephan Bergmann2-2/+2
Change-Id: Id3f1afa21dccb0a30ae230accb5229a2be2c6b50
2014-09-12Turn SfxItemState into a C++11 scoped enumerationStephan Bergmann4-21/+21
...to gain further confidence in the claim "that none of the existing code tries to uses combinations of these enum values" (d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState") Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13 Reviewed-on: https://gerrit.libreoffice.org/11384 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-10Replace uses of old SFX_ITEM_ON alias with SFX_ITEM_SETStephan Bergmann1-1/+1
Change-Id: I64be7ca711dcd3ea7c4d5840a30f2f701d055e1b
2014-09-06SfxHint: convert home-grown RTTI to normal C++ RTTINoel Grandin1-2/+3
Also note that I fixed a bug in SvxFontMenuControl::Notify where the if statement had the check the wrong way around. Change-Id: I611e8929c65818191e36bd80f2b985820ada4411 Reviewed-on: https://gerrit.libreoffice.org/11147 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-06FloatingWindows are no longer loaded from resource filesCaolán McNamara1-1/+0
Change-Id: I2705bbb4db52779e0065400f09604384fd9cf151
2014-09-06convert floating RID_TOOLBOXWINDOW to .uiCaolán McNamara8-198/+289
well the dialog itself and the top toolbar, the other toolbars remain as resources as now Change-Id: If2bc5b2c108af0efb88fb018896806531cdafe60
2014-08-25Avoid possible memory leaks in case of exceptionsTakeshi Abe1-5/+4
Change-Id: Icc073be041ae0b0c690e869a0edaff3515d1d601
2014-08-22Resolves: fdo#82747 Crash on opening wikipedia ODT BookJulien Nabet1-0/+1
Test if there's indeed a subnode before testing its type Change-Id: I1bb32652ceb82b0818a8d2cd8d71b46dd96ef2aa Reviewed-on: https://gerrit.libreoffice.org/11050 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-20vcl: use enum for complex text layout constantsNoel Grandin2-5/+5
Since these constants are bitfield flags, we define some methods to make working with them reasonably type safe. Move the definitions to outdevstate.hxx, since we need the values there, and that appears to be the "root most" header file. Also dump TEXT_LAYOUT_BIDI_LTR constant, since it means the same thing as TEXT_LAYOUT_DEFAULT (ie. 0), and leaving it in causes people to write weird code thinking that it's a real flag. Change-Id: Iddab86cd6c78181ceb8caa48e77e1f5a8e526343 Reviewed-on: https://gerrit.libreoffice.org/10676 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-08-18remove unused WarningBoxesThomas Arnhold2-6/+0
Change-Id: I07c457a49646703af5d13f83ba033340309ee655
2014-08-13warning C4242: '=' : conversion from 'size_t' to 'sal_uInt16'Thomas Arnhold1-1/+1
Change-Id: I892a0418125e9c660577d6acccf78e82c2b7f56c
2014-08-12-Werror,-Wundefined-bool-conversionStephan Bergmann1-1/+1
Change-Id: I44327db80a923c2ee8e762b3ba5f5de771b8610e
2014-08-09remove now unused tabpage.hrcThomas Arnhold1-1/+0
as TP_WIDTH and TP_HEIGHT are unused now Change-Id: I06ec7af8c2b3386d76e36284eb56ea1ab6b9ec5d
2014-07-29Drop unnecessary SfxApplication::CreateResManager wrapperStephan Bergmann1-2/+1
Change-Id: I2b8662ec85b8f710aa17a2c6f59c4b35af7685f3
2014-07-26Massive 'Dialogdiet fail' and similar to 'Dialog creation failed'Matteo Casalin1-1/+1
Change-Id: I6ca6914e80c186699df42253de46a3690c5130f2
2014-07-23convert SfxItemState constants to a proper enumNoel Grandin2-7/+7
and while we're at it - use the enum type all over the place instead of passing around sal_uInt16 - don't use bitwise logic on enum values - use enum values instead of numeric constants Change-Id: I7f24cb4d242e1c00703e7bbcf1a00c18ef1e9fd4
2014-07-20vcl consitent use of long for corrdinateNorbert Thiebaud1-2/+2
most of length in vcl are calculated in 'long' but array of X position tend to be in sal_Int32. As a prep work to be able to support 'double' as the base type of Device Coordinate, harmonize the use of 'long' for non-float coordinate. Change-Id: I7cb33301ff6a5e2c62247b36a4e07e168a58a323
2014-07-17Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xxTobias Lippert3-3/+3
- Remove includes from files where they are not needed. - Update pch files Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5 Reviewed-on: https://gerrit.libreoffice.org/10342 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-07-08fdo#81036 escape ~ in .ui and fix a typo (straight apostrophe)Andras Timar1-1/+1
Change-Id: I652dc63cc0e8fb04d7c3115d66d60dabda60f0f4
2014-07-03use assert when followed by derefCaolán McNamara2-3/+3
Change-Id: I8405e4d8f9fa1de3ef6ee474321b4ac2b4ce1624
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 00:25:36 +0000