summaryrefslogtreecommitdiff
path: root/starmath
AgeCommit message (Collapse)AuthorFilesLines
2016-07-17remove wrong outdated commentMarkus Mohrhard1-1/+0
Change-Id: I3fe6957b73776152b90c34ac411167f6f4e9e4f5
2016-07-17uitest: annotate the math edit windowMarkus Mohrhard1-0/+1
Change-Id: Ic902ba191d632d6a9e399c6809a8e88fdfc26301
2016-07-15new loplugin unnecessary overrideNoel Grandin2-7/+0
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-15starmath: Make AdjustFontDesc() precede Prepare()Takeshi Abe2-3/+5
because what Prepare() does depends on both nFontDesc and token of the SmTextNode. Change-Id: Ib7f8c408eb8f95a10f27ccbd3d80cdd0d6ea6d56 Reviewed-on: https://gerrit.libreoffice.org/27210 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-07-14starmath: Drop redundant SetLineColor() callTakeshi Abe1-2/+0
10 lines later the same code appears again. Change-Id: I06bccbb89e9bc3dd1339ca4f8c2482a2ee75c9f2 Reviewed-on: https://gerrit.libreoffice.org/27176 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-07-13Moved SfxModule owner to SfxApplicationMark Page2-13/+7
::GetAppData replaced with SfxApplication::GetModule that now returns SfxModule* SfxModule no longer registers self for ownership instead it is now registered using SfxApplication::SetModule Change-Id: Ifbbe1b2b4c5122da8e643b7926d47878d116c6c8 Reviewed-on: https://gerrit.libreoffice.org/26914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-12starmath: no need to create temporary string for comparisonTakeshi Abe1-1/+1
Change-Id: I906ef285ec6164284924ca4771a6da758bd23fd6 Reviewed-on: https://gerrit.libreoffice.org/27140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-11starmath: Prefer assert to SAL_WARN hereTakeshi Abe1-1/+1
as defined enum cases are exhausted. Change-Id: I6564cc0cd64d593f6aa02f0651ecb490bf7845bd Reviewed-on: https://gerrit.libreoffice.org/27081 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-07-08tdf#47813 Fix alignment for SmUnHorNodeTakeshi Abe3-19/+99
Originally SmUnHorNode::Arrange() was somewhat kludgy. This change implements a similar manner with SmBinHorNode::Arrange(). Change-Id: Ic18d2e7f70becfabb2c651719926e358a4585526 Reviewed-on: https://gerrit.libreoffice.org/26841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-08starmath: Fix missing negationTakeshi Abe1-1/+1
which was a regression from fa614231733800f4a961b77e36c86f8840d12251. Change-Id: Ia7bab72dbd6f82519024809cf6384e1442a02327 Reviewed-on: https://gerrit.libreoffice.org/27033 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-07-07starmath: Remove a couple of unused error codesTakeshi Abe4-17/+2
Change-Id: Iae3118150cf9119e48b1740ea630dea0ebef895a Reviewed-on: https://gerrit.libreoffice.org/26998 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-07starmath: Drop useless PE_BINOPER_EXPECTEDTakeshi Abe4-8/+2
as no code generates the error. Change-Id: I86f2db28030090e0a9284e7771f26821468bb685 Reviewed-on: https://gerrit.libreoffice.org/26974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-07-06starmath: Drop unused PE_UNEXPECTED_END_OF_INPUTTakeshi Abe1-1/+1
Change-Id: Ic5e6df6d332ef20dec22ac84544f53e0e79f5eb1 Reviewed-on: https://gerrit.libreoffice.org/26938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-07-06restore loplugin:vclwidget checking for calling clear() on VclPtr fieldsNoel Grandin1-0/+2
Change-Id: I85eda1c33016c1461d897fc0a3b70457209a7405 Reviewed-on: https://gerrit.libreoffice.org/26806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-05starmath: Remove unused GetRect()Takeshi Abe1-1/+0
Change-Id: I8544520a920f5ba2863a9d1b74e73f5cf47238aa Reviewed-on: https://gerrit.libreoffice.org/26887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-07-04SfxModule to use initializer_list instead of variadic argumentsMark Page1-1/+1
The compiler can perform type checking with initializer lists Change-Id: I1d26b56a3a2b67fe719f33d758ca9b0c95ebd4d1 Reviewed-on: https://gerrit.libreoffice.org/26852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04remove comphelper::string::removeNoel Grandin2-3/+3
and replace it with OUString/OString::replaceAll Change-Id: I37b1c3b51251dfd9d749d6f1060c75b3a93d7f1a Reviewed-on: https://gerrit.libreoffice.org/26850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-04starmath: Drop unused definitionTakeshi Abe2-6/+1
Change-Id: Ifb91d3a913d6fe3f92ef93bd0e25b8c6152727f3 Reviewed-on: https://gerrit.libreoffice.org/26872 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-07-01Make SmStructureNode's ctor initialize the number of sub nodesTakeshi Abe2-24/+14
This also drops newly unused SetNumSubNodes() as a result. Change-Id: I9b33cb547eb6883da4b45dc5760144cce8fa14ee Reviewed-on: https://gerrit.libreoffice.org/26795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-06-29starmath: Replace OSL_ENSURE with assertTakeshi Abe1-2/+2
as negative n would be undefined for OUString::copy(..., n). Change-Id: I950ec60656142450a5d5f6804324f6080c9c4c2a Reviewed-on: https://gerrit.libreoffice.org/26753 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-29starmath: SmBinDiagonalNode's 3rd child must be SmPolyLineNodeTakeshi Abe1-3/+4
Change-Id: If3b81de299eca8b398a65534d1b201bf38daf19f Reviewed-on: https://gerrit.libreoffice.org/26733 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-06-28loplugin:singlevalfields in variousNoel Grandin2-4/+2
Change-Id: Ia0d8f463a4dba9ec63aa0159441e3e607dd3bf5e Reviewed-on: https://gerrit.libreoffice.org/26738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-28starmath: This condition must be metTakeshi Abe1-4/+1
Otherwise, the following static_cast would be broken. Change-Id: Iad4738292ed6903eed78d5af98f77194d5a1d8fe Reviewed-on: https://gerrit.libreoffice.org/26696 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-06-26starmath: Fix invalid static_castTakeshi Abe2-4/+4
It was an undefined behavior that static_cast'ing a pointer to SmVisibleNode to SmStructureNode's. Change-Id: Ic391175a5535cec84bd7f9ec58fa13a411398331 Reviewed-on: https://gerrit.libreoffice.org/26676 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-25starmath: Drop unnecessary definitionsTakeshi Abe2-14/+5
Change-Id: I709e612fd03dfa50d6f7bcfa4545fcd23f0ebe60 Reviewed-on: https://gerrit.libreoffice.org/26654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-06-25starmath: Remove unused definitionTakeshi Abe2-7/+1
Change-Id: I46674e606ad7ef586597c926a21dd745ee762011 Reviewed-on: https://gerrit.libreoffice.org/26634 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-06-24starmath: IndexOfSubNode() is for SmStructureNode onlyTakeshi Abe1-11/+13
... not for the base class. Change-Id: I9f6a6de93a4db964c8b019349049fdef4afaf224 Reviewed-on: https://gerrit.libreoffice.org/26583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-06-23tdf#97527 - vcl: reference-count MenuNoel Grandin1-3/+4
some places are marked with "dodgy"- need to check those to see what is going on, because they are leaving dangling pointers behind in the Menu class Change-Id: I41d5c7c0fec2f70ce9e3ffdc48cd03d26c0a869b Reviewed-on: https://gerrit.libreoffice.org/26516 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-23starmath: Add a test case for parsing -Takeshi Abe2-0/+98
Change-Id: I0fc0b7e2abbadee2f13d477c5ddd2290f37487a0 Reviewed-on: https://gerrit.libreoffice.org/26563 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-06-22Drop unused #includeTakeshi Abe3-29/+0
Change-Id: Ic0cf4605cc7d02fdd537d05cbaa744c52126e6f1 Reviewed-on: https://gerrit.libreoffice.org/26545 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-06-21This can be an assert()Takeshi Abe1-25/+22
Change-Id: I2b0a8f50359e5b12fa27bf48c355f736e2b05033 Reviewed-on: https://gerrit.libreoffice.org/26491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-06-20starmath: Possible cases are exhaustedTakeshi Abe1-1/+1
Change-Id: Icc48aa8ffa6a56f804c4d01f2fb3bcdf7de838d4 Reviewed-on: https://gerrit.libreoffice.org/26397 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-06-16starmath: more assertions holdTakeshi Abe1-21/+20
Change-Id: I9a7fb2f4d45c5b34c0ea1d186dd90353fedc8a6d Reviewed-on: https://gerrit.libreoffice.org/26299 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-06-14tdf#94205: Some remaining new+std::move -> o3tl::make_uniqueStephan Bergmann1-2/+1
Change-Id: I6a9a46d37bf09f6b497d591498c40103f4c96f59
2016-06-14starmath: SmTableNode has type NTABLETakeshi Abe1-3/+4
Change-Id: I406b38f41c694d7b4df4d2bc78e7731eb2ef02e4 Reviewed-on: https://gerrit.libreoffice.org/26210 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-06-13starmath: SmElement owns SmNodeTakeshi Abe3-12/+15
SmNodePointer is no longer used, so drop it. Change-Id: I5194cc7e1d9e551f4131cbcac0d84351bb2f2eab Reviewed-on: https://gerrit.libreoffice.org/26146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-06-10Clean up uses of Any::getValue() in starmathStephan Bergmann1-14/+13
Change-Id: I2f3be0d3473331b8dbd5d008b79acfbfed65f847
2016-06-10Pass it by const refTakeshi Abe2-10/+16
Change-Id: I0c2b48a503e2501210af690f02858dade994a733 Reviewed-on: https://gerrit.libreoffice.org/26048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-06-09tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko2-8/+2
This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-08remove "object is disposed" warning in OBroadcastHelperVar::removeListenerNoel Grandin1-0/+1
doesn't add anything of value. Change-Id: Ie2dea7c43570640284771c992d0072ab61de425e Reviewed-on: https://gerrit.libreoffice.org/25871 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08starmath: The formula tree must be of type SmTableNodeTakeshi Abe6-25/+14
This also omits the last push & pop on m_aNodeStack at the end of parsing. Change-Id: Iefff8fa801ea7cb9015d6cba0d5a972dee675cb7 Reviewed-on: https://gerrit.libreoffice.org/26003 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-06-07starmath: Make ctors explicitTakeshi Abe9-38/+38
Change-Id: Ic1b7ce74f73bd41824e0af78675b4e18af32b1f5 Reviewed-on: https://gerrit.libreoffice.org/25960 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-06-06tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl3-4/+4
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-06Revert "Revert "Simplify sfx2 removing SfxModuleArr_Impl and dummy SfxModule ↵Noel Grandin1-1/+1
flag"" This reverts commit abde31a2bc68302e1afafe1fcc3f5d85369010f8. Since my analysis was completely incorrect, and the bug was elsewhere.
2016-06-06Revert "Simplify sfx2 removing SfxModuleArr_Impl and dummy SfxModule flag"Noel Grandin1-1/+1
This reverts commit e319ef1171dab61fff2201f5c1470ca09894c395. Apparently, at some point, someone added a 'bool bDummy' param to SfxModule, but only updated 2 of the 5 callsites. Since we're passing in pointers here, at the other call sites, the bDummy param evaluated to 'true'.
2016-06-06Simplify sfx2 removing SfxModuleArr_Impl and dummy SfxModule flagMark Page1-1/+1
The SfxModuleArr_Impl is a static container of SfxModule, since this is private to the SfxModule class it does not require wrapping. The bDummy flag is unused, and complicates the class Change-Id: Ib03b215543a0c37d4edf20b2d0fc141a783e115e Reviewed-on: https://gerrit.libreoffice.org/25859 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06remove unused constants in HRC filesNoel Grandin1-33/+0
Change-Id: Ia034fb16ce75caeb69fd746d4a602cd5fcfef6d1 Reviewed-on: https://gerrit.libreoffice.org/25817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Convert ComplexTextLayoutMode to scoped enumNoel Grandin2-5/+5
Change-Id: I257f8e15fec92f0701235a6fe4b6a2272498c4f1 Reviewed-on: https://gerrit.libreoffice.org/25667 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-03Null pointer dereferences must not happenTakeshi Abe1-1/+4
This is a follow-up of 09981cd6383ecb99e4b6c83b98b03af5cf3ff59b. Inspired by coverity#1362478 etc. Change-Id: If5507c52552393cccbb255cbf4b7e9f4b80db917 Reviewed-on: https://gerrit.libreoffice.org/25840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-06-02coverity#1362478 Explicit null dereferencedCaolán McNamara1-36/+39
and coverity#1362479, coverity#1362480, coverity#1362481, coverity#1362482, coverity#1362483, coverity#1362485 Change-Id: Ia3a32b69bcbe5ac3e7cc50dacfa02e8bf1aab787
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-21 01:15:26 +0000