summaryrefslogtreecommitdiff
path: root/starmath
AgeCommit message (Collapse)AuthorFilesLines
2016-01-18loplugin: unused return valuesNoel Grandin2-9/+5
Change-Id: I9c61a46c57894bc63a57740206c0bcb4a16553af Reviewed-on: https://gerrit.libreoffice.org/21571 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-18vcl: change Font::SetName() to Font::SetFamilyName()Chris Sherlock3-4/+4
Change-Id: I9b7bd1ec25955981ebcb9085579cbb9fbaa802d5 Reviewed-on: https://gerrit.libreoffice.org/21560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-17vcl: rename Font::GetName to Font::GetFamilyNameChris Sherlock7-15/+15
Change-Id: Ie20871a3078bf875c1782b7761d60591a9c9704f Reviewed-on: https://gerrit.libreoffice.org/21529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-16revert vcl patch series that brok Mac and WindowsNorbert Thiebaud7-19/+19
revert: 9bc2f3de8672e812f3a67541c6d7069b434a7e42 vcl: add comment about ImplFontMetric::{Get|Set}LineHeight() 26371f105bc44e04469ec03fc5bb12505e651c6b vcl: FontAttributes::GetSlantType() -> FontAttributes::GetItalic() 2dd0b4317372b8022efe3911b38b4fa02956d8b9 vcl: font.hxx and metric.hxx cleanup, make ctors explicit and the dtor virtual 5ab13bf3ead3539e4ad847656da81e7eb6029652 vcl: tabify font.hxx f99550dae55e40e49bf9c9875053fe2abb4c71ca vcl: change Font::SetName() to Font::SetFamilyName() 2b297116cb6bb1061c43e5714e2609c8ee9f57d2 vcl: rename Font::GetName to Font::GetFamilyName Change-Id: I23f38921187d66b970ca815eb30dda4222a2da62
2016-01-16vcl: change Font::SetName() to Font::SetFamilyName()Chris Sherlock3-4/+4
Change-Id: I54a4036544c680c4a49607677af776aa7a433fbc Reviewed-on: https://gerrit.libreoffice.org/21510 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-16vcl: rename Font::GetName to Font::GetFamilyNameChris Sherlock7-15/+15
Change-Id: I83927e0992dfe0a2a79d139818a9f45d3761aae5 Reviewed-on: https://gerrit.libreoffice.org/21509 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-15starmath: only use WordProcessingML elements in DOCX filesMichael Stahl6-9/+26
Change-Id: I1b0f6d67bd0db0796756fd920ab92303a7ee7d79
2016-01-14loplugin:unusedmethods unused return value in starmathNoel Grandin10-25/+11
Change-Id: Ic70c3d727ecadd082f7e5d293fc2b279b1287b8f
2016-01-13vcl: Create accessor and mutator for int and ext leading in FontMetricChris Sherlock1-2/+2
Accessor and mutator created for external and internal leading space in FontMetric. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit tests - check to ensure that can set external and leading space - check equality operator on FontMetric after setting both external and internal leading space - enhanced tests to also check the inequality operator Change-Id: I973970dd0b0631c5eca3e89039dce57ac3a3eb63 Reviewed-on: https://gerrit.libreoffice.org/21454 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-12tdf#87118 LibreOffice should not claim to use version 1.01 of MathMLTakeshi Abe1-1/+1
Call it MathML 2.0 instead. Change-Id: Ifecd52cfcded680bbddf680f2600a42b1c7568d9 Reviewed-on: https://gerrit.libreoffice.org/21304 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-12starmath: Assert that SmRootNode always has three childrenTakeshi Abe1-3/+5
Change-Id: I9d1b47fc7fc26254f331967dd58f60d88bd2112f Reviewed-on: https://gerrit.libreoffice.org/21036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-11loplugin:privatebase: Make various derivations publicStephan Bergmann1-1/+1
...assuming they were implicitly made private by accident rather than by design. (And private derivation can cause unexpected failure of dynamic_cast, cf. 63b67ab5cab8cf7576a68cabe5fb1a42c6ad800c "Use public derivation, and remove then-unnecessary downcasts.") Change-Id: Id821afba34fd2f155e30fac903567707e46d1fde
2016-01-10Fix typosAndrea Gelmini7-10/+10
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-10Cleanup FontCharMapPtr variable prefixesChris Sherlock1-4/+4
Change-Id: Ib106b91ab71ee45d5ad469d0beaf4ebaef8b57e1 Reviewed-on: https://gerrit.libreoffice.org/21306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-07starmath: Remove unused resource itemsTakeshi Abe2-43/+0
Change-Id: Ia64d33a6a755f6a0c1418c7230f4734a06febed4 Reviewed-on: https://gerrit.libreoffice.org/21187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-01-06starmath: Remove toolbox.hrcTakeshi Abe3-31/+0
Usage of NUM_TBX_CATEGORIES was gone at 3dfe2fc394ca1e168e800ffcc3ac0f69b4eeb173. Change-Id: Ic0fea85ad143de02102e3745f310966a8b94192e Reviewed-on: https://gerrit.libreoffice.org/21153 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-01-06starmath: Fix bogus warningTakeshi Abe1-1/+1
RID_PRINTUIOPTIONS has 9 items. Change-Id: Ie7aee00e0219151b1573217ca670a93925de67cc Reviewed-on: https://gerrit.libreoffice.org/21154 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-01-06tdf#90341 Clean up excessive const_cast'ingTakeshi Abe1-2/+2
RequestApplyChanges()'s call sites do not require its constness. Change-Id: Iaf9108375db7503fe1a3bd8275e13dbdddf95ab5 Reviewed-on: https://gerrit.libreoffice.org/21068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-05Make SotFactory private to sot/ and clean a bitMatúš Kukan1-1/+2
Change-Id: Ia683280a3e95eee995e036db6bde5d28852f92ff
2016-01-05starmath: Drop nonexistent friendTakeshi Abe1-4/+0
SmClipboardChangeListener was gone at 5ed3fa4c39a67b2b12b4206bef6680fb757e1b75. Change-Id: Ia826ecbeb53eb1d5cb41bd39fe250cdaf60268cd Reviewed-on: https://gerrit.libreoffice.org/20987 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2016-01-05tdf#94205: Use o3tl::make_unique insted of new+std::move.Sheikha AL-Hinai1-4/+2
Change-Id: I9ff14760479d2ac882546e2e5b74ab750ba2fa4b Reviewed-on: https://gerrit.libreoffice.org/20984 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-01-04vcl: split classes out of metric.hxxChris Sherlock1-0/+1
Change-Id: Id3b155abec7b7a2ff43d0a35e98709f5ee51c6b9 Reviewed-on: https://gerrit.libreoffice.org/21069 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-04Cleanup after removing vcl::FontInfo classChris Sherlock1-5/+5
Change-Id: I544eac439cb7277e47a23a90c6fbc45496161c3b
2016-01-03vcl: Excise vcl::FontInfo classChris Sherlock1-1/+1
This may sound crazy, but literally vcl::FontInfo serves no purpose that I can see. The inheritance chain is like this: ┌────────────────────────┐ │ │ │ vcl::Font │ │ │ └────────────────────────┘ ^ ╱ ╲ │ │ ┌────────────────────────┐ │ │ │ vcl::FontInfo │ │ │ └────────────────────────┘ ^ ╱ ╲ │ │ ┌────────────────────────┐ │ │ │ FontMetric │ │ │ └────────────────────────┘ vcl::FontInfo (which, incidentally, needs to be put into the vcl namespace due to collisions with poppler!) literally does nothing and is acting as a bridge between FontMetric and vcl::Font. Unlike a bridge though, this bridge doesn't actually *do* anything. So I'm removing it, which means one less class to deal with in the vcl fonts world. Change-Id: I32725669c9bca7fbb0846b6a062135464046e4f6 Reviewed-on: https://gerrit.libreoffice.org/21058 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2015-12-31starmath: Manage SmDocShell's pCursor via std::unique_ptrTakeshi Abe2-12/+10
Change-Id: Id9c67638e5c2e535cc06e9566c9a169471f55da8 Reviewed-on: https://gerrit.libreoffice.org/20856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2015-12-29tdf#32062: Add testMarcos Paulo de Souza1-0/+13
Change-Id: I0af72c436c2eca6741bfaa6e6570ce74f486c112 Reviewed-on: https://gerrit.libreoffice.org/20996 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-12-24Fix tdf#32062: Math overwrites selected area when click on elementMarcos Paulo de Souza1-0/+5
Change-Id: I42ce83d1647d054419dbf664dfbfb2bc1cd01338 Reviewed-on: https://gerrit.libreoffice.org/20729 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2015-12-23starmath: Avoid warning C4819Takeshi Abe1-3/+3
Change-Id: I051b2058e7c7f0424faf49f027330b1bbc93c2d9 Reviewed-on: https://gerrit.libreoffice.org/20869 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2015-12-23starmath: Manage SmEditAccessible's pTextHelper via std::unique_ptrTakeshi Abe2-6/+12
Change-Id: Iefd4314823efec28a8497b5a993fdd01ed12811e Reviewed-on: https://gerrit.libreoffice.org/20849 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2015-12-23starmath: Assert that a parent always finds its childTakeshi Abe2-29/+12
Change-Id: I6cb75e0d62141dba2809aaec62761cedd8c3257a Reviewed-on: https://gerrit.libreoffice.org/20733 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2015-12-22Indentation fixesMiklos Vajna1-1/+1
Change-Id: Idcb2b7e01a84d49c3b0cf53f6d53265111e68fdd
2015-12-21loplugin:unusedfields in sfx2,slideshow,starmath,stocNoel Grandin1-6/+4
Change-Id: If3622b23c45dd3a2a4e9869452142d1f6b47919e
2015-12-17This probably should be a referenceStephan Bergmann1-1/+1
...ever since SmXMLContext_Helper was introduced in a0c8015b88b16a4192000bd841eeff594dae9c65 "#81141# MathML->StarMath editable text display" Change-Id: Ida4a4022159138a49c7c94ccb0ed90a8a149b796
2015-12-17Remove unused ToolPanel (aka TaskPane)Samuel Mehrbrodt3-6/+0
Superseded by the Sidebar Change-Id: I54970d71cd9d42de4f47b223e50dd9474b40632a Reviewed-on: https://gerrit.libreoffice.org/20724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-12-17starmath: Drop const modifier of SmNode::Arrange's 1st argumentTakeshi Abe2-97/+96
as well as SmNode::AdaptToX / AdaptToY's. It was pointless because the client code in the functions always cast it off. Change-Id: I00c690bd98a566fb167708216d766a2894de669f Reviewed-on: https://gerrit.libreoffice.org/20710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-16assert that no ODF import happens without a BaseURLMichael Stahl1-4/+4
Change-Id: I4520a9d0350349cb083ed627a19264a3a97e090f
2015-12-10starmath: SmElementPointer is not shared actuallyTakeshi Abe2-8/+4
... rather, it's owned by maElementList. So, use just std::unique_ptr<SmElement> instead. Change-Id: Id18466083535677e0f7d07f8c523b433c5e2a9ec Reviewed-on: https://gerrit.libreoffice.org/20490 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-10starmath: Prefix members of SmDrawingVisitorTakeshi Abe2-24/+25
Change-Id: Ia7efb3db2d1e76aad8873cf5822107b4666249de Reviewed-on: https://gerrit.libreoffice.org/20281 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-12-10Drop unused typedefTakeshi Abe1-2/+0
Change-Id: I2bc18d48ebf4401d9af576fb1b98b69ff44ab334 Reviewed-on: https://gerrit.libreoffice.org/20485 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-12-09starmath: Pass by const referenceTakeshi Abe1-2/+2
Change-Id: I703bedf5bcf2f2ea3b54eb0fc3a641ff246f4568 Reviewed-on: https://gerrit.libreoffice.org/20486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-12-08consolidate MSO format ClassID magic numbers in msfilter/classids.hxxMichael Stahl1-3/+3
Change-Id: I673eeaa4168f769cb002995c43d986ee5f2030b2
2015-12-01Fix typo in commentTakeshi Abe1-1/+1
Change-Id: I62c80cb0aa25374b41dcfde2ff6e03bd3c465bf5
2015-11-28Remove unused codeNicola Povoleri1-7/+0
Found by scanbuild. Change-Id: Ie46c056327747bbcb3a9eb0890cf74be7179ea24 Reviewed-on: https://gerrit.libreoffice.org/20257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Reviewed-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
2015-11-27starmath: Kill unnecessary castTakeshi Abe1-4/+4
Change-Id: I714c11941cfed207f10a5048a14b4cf72b4f255c Reviewed-on: https://gerrit.libreoffice.org/20222 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-26starmath: Prefix members of SmCaretDrawingVisitorTakeshi Abe2-30/+30
Change-Id: I9d033a67f6073f3da368f8241ac48c7d391b89c9 Reviewed-on: https://gerrit.libreoffice.org/20080 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-23starmath: Prefix members of SmCaretPos2LineVisitorTakeshi Abe2-16/+17
Change-Id: I277a66d32af51af7e28fd424dedd7980619e9d6e Reviewed-on: https://gerrit.libreoffice.org/20104 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-11-22cppcheck: redundantAssignmentTakeshi Abe1-1/+0
Change-Id: Iad347c2575cdbd6ee117461ea89f16234ecdd49e
2015-11-20Remove last redundant toolbar:style propertiesSamuel Mehrbrodt1-1/+1
Change-Id: I42fa834464fd4cd7f0c1f11e310c1145fb1f071b
2015-11-20starmath: Use std::unique_ptr for exception safetyTakeshi Abe1-4/+3
Change-Id: Idc71dc410000b88463440dd18f41ff945b7616d7
2015-11-19Remove redundant toolbar:style attributesSamuel Mehrbrodt1-1/+1
These have been defined in the widgets Change-Id: If46a6862872286a454804846128bd8658f60af9b