summaryrefslogtreecommitdiff
path: root/starmath
AgeCommit message (Collapse)AuthorFilesLines
2015-01-27Fix a single quote slipped inTakeshi Abe1-1/+1
See void SmNodeToTextVisitor::Visit( SmFontNode* pNode ) for comparison. Change-Id: Id7e58fef3b715ef2a4bcb4e1a1d390aadf917b5f Reviewed-on: https://gerrit.libreoffice.org/14193 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/14197
2014-12-11Remove resizable:False property from dialogs containing GtkEntry.Jan Holesovsky2-2/+0
As agreed with Adolfo (and others) at the Design hangout on 2014-12-10. Change-Id: Ibe0e8075566523e746866b9d2c15c348c345d2df
2014-12-09capitalize Infinite tooltip in Elements panel of MathStanislav Horacek1-1/+1
Change-Id: I15e5a7c9a37a4908adcdc0d3396c82845e442b66 Reviewed-on: https://gerrit.libreoffice.org/13346 Reviewed-by: Wesley J. Landaker <wjl@icecavern.net> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-23fix typo in color nameStanislav Horacek1-1/+1
Change-Id: I0bd01210cea6336a09ada718fe2b3c06b07942ce Reviewed-on: https://gerrit.libreoffice.org/13071 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-11-20fix memory leaks caused with SmNodeStackTakeshi Abe3-106/+101
SmNodeStack now frees its own pointers after use. Change-Id: Ie43eb887810a3424109708c956ccbdf97fc5a2e5 Reviewed-on: https://gerrit.libreoffice.org/12970 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-17"#pragma hdrstop" looks quite obsoleteMichael Stahl2-8/+0
Change-Id: Id4b01f02d5d90215164c07b8076498df65978fa3
2014-11-17assert that no other types than TGOPER can happen in SmParser::Oper()Takeshi Abe1-6/+1
TOVERBRACE/TUNDERBRACE belongs to TGPRODUCT. Change-Id: I34b23858fb70f38ffd82e373e16ab68632d6e303 Reviewed-on: https://gerrit.libreoffice.org/12508 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-16Mark as noncopyableTakeshi Abe1-11/+3
Change-Id: Ibbec7a5d9b6726865da14c9bdfad8b8118f85e5b
2014-11-15Math: Remove aqua and fuchsia from the Elements DockMarcos Paulo de Souza1-6/+1
We can remove these colors from the UI because these colors are equal to cyan and magenta, and will be useful just in the import/exports filters. If the user still wants to use aqua and fuchsia, they can type them in the Math editor. Change-Id: Ia93d458e07b218aa007ec43bd490f774e5b4ea5b Reviewed-on: https://gerrit.libreoffice.org/12467 Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-11-16Avoid possible memory leaks in case of exceptionsTakeshi Abe1-6/+4
Change-Id: I06525aa32bc17464291126ed676809e23e4227b1
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava4-35/+35
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-13Avoid possible memory leaks in case of exceptionsTakeshi Abe1-8/+5
Change-Id: I411f8f800b7c7f23a7e581a36689f52ff99362c0
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini2-2/+2
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11stop duplicate definition of lcl_popOrZero()Takeshi Abe4-93/+70
This renames it to popOrZero() in node.hxx. Also one more call site found in mathmlimport.hxx. Change-Id: I3f0281315146347280d0836ceadcfdf9c80fa166 Reviewed-on: https://gerrit.libreoffice.org/12310 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-09separate parse.hxx into smaller partsTakeshi Abe6-147/+197
... so that node.hxx no longer needs to include parse.hxx. Change-Id: Iac1e21c208e3f0e3fd8ece16eee345e81574a0aa
2014-11-06Avoid possible memory leaks in case of exceptionTakeshi Abe1-6/+3
Change-Id: Ie8c1a3e54bda4ec650f5d5da3928d3c44e4008a8
2014-11-04Math: Add new colors in the SidebarMarcos Paulo de Souza4-1/+149
Regine add new colors to Math in fe5840aab17e366749c373e4f8683e06e40b4b05 and this commit just take those new colors and show in the Math Sidebar. Change-Id: Idd67cf4a04b2855970b115aac8d15d6506f73298 Reviewed-on: https://gerrit.libreoffice.org/12239 Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com> Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-11-04mark as noncopyableTakeshi Abe1-5/+2
Change-Id: Ic464974087f9f8fb161aaffde232668ba01c2f62
2014-11-04include <list> where neededTakeshi Abe2-1/+2
Change-Id: Ia6784bf95d9d0c57b79bdf7373f4836709563b7a
2014-11-03fix memory leak of pointers contained in m_aErrDescListTakeshi Abe2-12/+8
Change-Id: I9fcbdcd54978ccaffa5359c0afb0a1990356c218 Reviewed-on: https://gerrit.libreoffice.org/12205 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-11-02unused includes in RTF filter and related filesMiklos Vajna2-3/+0
Change-Id: Id13e10f2ceed3985c78ccc542e6677eccc0cb1c7
2014-10-31Resolves: #i118191# Red is not red enoughRegina Henschel6-20/+103
Enable Math to use 16 basic HTML colors Patch by: Regina Henschel <rb.henschel@t-online.de> Found by: <lapsap7+ooo@gmail.com (cherry picked from commit 529e59d90037748d0030191b93252e597935243e) Conflicts: starmath/inc/parse.hxx starmath/source/mathmlimport.cxx starmath/source/parse.cxx Change-Id: I08de0ce33928ead3635a3a87c81671b4cc4112ac
2014-10-31convert COMMAND_WHEEL constants to an enumNoel Grandin2-2/+2
Change-Id: I413d821a984ab556bd19c52704c04de6d828f699
2014-10-30HIG fixes for smath dialogsAdolfo Jayme Barrientos10-427/+217
Disabling manual resizing, setting modal flags, fixing spacing and adding missing colons to labels that precede controls. Change-Id: Id0f180355d302206a632af97dafb6a391c8b4472 Reviewed-on: https://gerrit.libreoffice.org/12105 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin2-2/+0
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-27fdo#84938: replace KEYTYPE_ constants with enumNoel Grandin1-3/+3
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328 Reviewed-on: https://gerrit.libreoffice.org/12104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky12-73/+73
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23Fraction: Revert "fdo#84854 it seems long is not enough on 32 bit"Jan Holesovsky9-49/+49
This reverts commit 582ef22d3e8e30ffd58f092d37ffda30bd07bd9e. Conflicts: svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx Change-Id: I80abc7abdeddc267eaabc9f8ab49611bb3f8ae83
2014-10-21fdo#84938: replace WINDOW_BORDER constants with enumNoel Grandin2-6/+6
Change-Id: I91ca8e09971aee26f16257a4fd01125cfb2ebcdb
2014-10-17coverity#1247645 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Id6596945d51a1b9f8750aa0f46f6a061cb2e80c3
2014-10-17coverity#1247642 Uncaught exceptionCaolán McNamara2-2/+2
Change-Id: Ic7ffc47fd84f89029c140d68601971a5a2d58d0a
2014-10-16fdo#84854 it seems long is not enough on 32 bitDavid Tardon9-49/+49
Fraction used BigInt internally for computations, rational does nothing like that. Change-Id: I3e9b25074f979bc291208f7c6362c3c40eb77ff5
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann1-1/+0
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-14SmViewShell: pImpl must outlive aGraphic memberStephan Bergmann2-2/+5
...as at least during CppunitTest_starmath_qa_cppunit, during ~SmViewShell, aGraphic's code calls back into SmViewShell's code calls into pImpl: SmViewShell::IsInlineEditEnabled() const starmath/source/view.cxx:2057:12 SmGraphicWindow::IsInlineEditEnabled() const starmath/source/view.cxx:227:12 SmGraphicWindow::CaretBlinkStop() starmath/source/view.cxx:297:10 SmGraphicWindow::~SmGraphicWindow() starmath/source/view.cxx:126:5 SmViewShell::~SmViewShell() starmath/source/view.cxx:1976:1 [...] This is somewhat symmetric to 0e263d61811480f3a9dbc6ad7c752f6cfae4e3fc "order pImpl before aGraphic because aGraphic deferences pImpl in ctor." Change-Id: I97494bebaf5747205a690e6d65fd05ba8fb61cab
2014-10-13create a macro library for implementing bit-flags typesNoel Grandin6-12/+12
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, changed from a macro- to a template-based solution. (Unfortunately MSVC 2012 does not support explicit conversion operators. Worked around that with explicit #ifs rather than some HAVE_EXPLICIT_CONVERSION_OPERATORS and SAL_EXPLICIT_CONVERSION_OPERATOR ainticipating we hopefully soon move to a baseline that requires unconditional support for them.) Change-Id: I4a89643b218d247e8e4a861faba458ec6dfe1396
2014-10-13vcl: Make ImplFontCharMap a pImpl and move functions to FontCharMapChris Sherlock1-3/+5
To do this, I've made FontCharMap a friend class for ImplFontCharMap, and have moved the functions directly into FontCharMap. In this patch, I am attempting to stop the direct use of ImplFontCharMap by anything other than FontCharMap. However, FontCharMap itself requires a refcounter, so we will use FontCharMapPtr to access the font character map. Change-Id: I509b990a8cbd911c5cc1572c7d24fc5348ca06d9 Reviewed-on: https://gerrit.libreoffice.org/11823 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-10-11convert SFX_CALLMODE constants to SfxCallMode enum classNoel Grandin6-22/+22
and fix a couple of bugs in SC and SW where the call mode was being passed to the hints parameter by accident Change-Id: Ief805410b3f7035e012e229e77f92d5832430f58 Reviewed-on: https://gerrit.libreoffice.org/11916 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11convert vcl StateChangedType to enum classNoel Grandin2-3/+3
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11starmath: close SfxObjectShell in unit test to stop temp file leakageMichael Stahl1-0/+1
Change-Id: Iaf2df8a315b3e0c8cdd1f1a4a7d589682384ddaf
2014-10-10indentation fixesMiklos Vajna1-1/+1
Change-Id: I56664b455383f69137399e4c5fb28521ef813287
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca12-73/+73
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-02coverity#735498 Logically dead codeCaolán McNamara1-1/+1
Change-Id: Ia2a6df4aef944d81be41593ed001156d3f1ea054
2014-10-01coverity#1242448 Identical code for different branchesCaolán McNamara1-2/+2
Change-Id: Ie864a4d04ea1ae701ab5dbb5b93807e98d5f0f1c
2014-09-30fdo#82577: Handle RegionNoel Grandin1-1/+1
Put the VCL Region class in the vcl namespace. Avoids clash with the X11 Region typedef. Change-Id: I6e008111df7cf37121fbc3eaabd44a8306338291
2014-09-27border_width from 12 to 6, as the rest of dialogsAdolfo Jayme Barrientos1-2/+3
I know the old GNOME HIG mentions extra spacing for queries, but I’ve never understood why -- not even GNOME itself respects that rule. It just looks inconsistent and wastes space. Change-Id: I181f800957f69b0943369791e460c7273b6b08f6 Reviewed-on: https://gerrit.libreoffice.org/11658 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-25editeng: std::auto_ptr -> std::unique_ptrStephan Bergmann1-1/+1
Change-Id: I25e3599a37d720cbcf70ea13ab30234e54637d53
2014-09-24Replace some std::auto_ptr function parameters with std::unique_ptrStephan Bergmann1-5/+8
Change-Id: Ic66d325fd9559c6dde9556c26e5b2a7e60376c49
2014-09-23fdo#82577: Handle WindowNoel Grandin16-65/+65
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-18fdo#82577: Handle FontNoel Grandin14-73/+73
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-15sd: sal_Bool -> boolStephan Bergmann2-2/+2
Change-Id: Id3f1afa21dccb0a30ae230accb5229a2be2c6b50