summaryrefslogtreecommitdiff
path: root/starmath
AgeCommit message (Collapse)AuthorFilesLines
2019-07-21loplugin:referencecasting in slideshow..svtoolsNoel Grandin4-13/+8
Change-Id: Id0f0332d5d66c0bce309643bf42059b9bdc7d448 Reviewed-on: https://gerrit.libreoffice.org/75997 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-20cid#1448322 try silence Splice iterator mismatchCaolán McNamara1-1/+2
Change-Id: If419d66811e5a60d50575f7b984811a29785459a Reviewed-on: https://gerrit.libreoffice.org/76019 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-27Breeze: fix for tdf#125879rizmut1-8/+8
- Breeze & Colibre: Rearrange Navigator's element - elementary & KJ: Add some Draw's tabbed icons - Reenable menubar icons Change-Id: Ic10c80e4674393714664568ff0914acdc54b5990 Reviewed-on: https://gerrit.libreoffice.org/74791 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-06-25improve loplugin:simplifyconstructNoel Grandin2-3/+3
Change-Id: If863d28c6db470faa0d22273020888d4219e069e Reviewed-on: https://gerrit.libreoffice.org/74559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-21simplify some getSupportedServiceNamesNoel Grandin2-3/+3
Change-Id: I81195505d6006b6587f7b98c1545919083f0e588 Reviewed-on: https://gerrit.libreoffice.org/74497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-18loplugin:passstuffbyrefNoel Grandin1-1/+1
Change-Id: Icb7c22cf4ac95eab54d04e79312fb471ca27bceb Reviewed-on: https://gerrit.libreoffice.org/74246 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-18loplugin:logexceptionnicely in starmath..svgioNoel Grandin1-2/+3
Change-Id: I356e574e28338f6fddc6932b4e41a461d851406d Reviewed-on: https://gerrit.libreoffice.org/74141 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-17Add comphelper::getUnoTunnelImplementation templateArkadiy Illarionov1-1/+1
Use it instead of classname::getImplementation from UNO3_GETIMPLEMENTATION_* Change-Id: Ifcc8cfcd6369c576250008c76ce31ba79ea3a596 Reviewed-on: https://gerrit.libreoffice.org/74107 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-13tdf#120047 Support attribute harpoon/wideharpoon in MathTakeshi Abe15-3/+30
... for an alternative style of vectors. They are vec/widevec analogs but with COMBINING RIGHT HARPOON ABOVE (U+20D1). The new attribute names are deliberately long in order to make fewer accidental collisions with variable names in formulae of exising documents. This also adds a glyph uni20D1 to OpenSymbol. Change-Id: I31666e57808aa0e0327500916d3b862549891886 Reviewed-on: https://gerrit.libreoffice.org/72987 Tested-by: Jenkins Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2019-06-11tdf#42949 Fix IWYU warnings in include/svx/[sS][v-Z]*Gabor Kelemen1-0/+1
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie2a4122d67d2d40732e6fd00b584f33edd802c5b Reviewed-on: https://gerrit.libreoffice.org/73476 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-06-09loplugin:constantparamNoel Grandin3-5/+3
Change-Id: I7bbc4e1546acf58f1ca24bfec5e465bad5ca90de Reviewed-on: https://gerrit.libreoffice.org/73732 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-08loplugin:unusedmethodsNoel Grandin5-17/+0
Change-Id: I52efd8d843d0e4cc7a6adefb0eb95aa50469af38 Reviewed-on: https://gerrit.libreoffice.org/73693 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-04tdf#39593 remove IMPL_XUNOTUNNEL* macrosArkadiy Illarionov1-1/+1
Replace with UNO3_GETIMPLEMENTATION* macros. Replace single usage of IMPL_XUNOTUNNEL_MINIMAL with it's body. Change-Id: I7d4ad76399b999ebb2178ecf57edcf6bd2aa6c3e Reviewed-on: https://gerrit.libreoffice.org/73424 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-03SM add a border to the editor and the element listJan-Marek Glogowski2-2/+2
Change-Id: I708476919ce7750df6a691d75fe594c3f44d9126 Reviewed-on: https://gerrit.libreoffice.org/73173 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-29SM disable localized characters on element parsingJan-Marek Glogowski2-43/+48
The special character tokens are localized character names! This means that at least in German the %mu wasn't replaced in the example, as the parser expected %my. So tell the parser to expect non-localized input. And share it for all the parsing. Change-Id: I4c3c0f35eb61c37a2101b51b445e7cc888a1f429 Reviewed-on: https://gerrit.libreoffice.org/73172 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-29tdf#65587 SM implement ElementControl accessibilityJan-Marek Glogowski7-11/+1136
This took me ages to implement. I'm still not 100% sure, it works correct. One main problem was the loop where the ATK listener will rebuild the list of children based on the current child count. Then there is the "broken" SPI bridge behaviour. I could actually test this with the gtk3 backend just fine, if I started LO *after* the accerciser. Otherwise the displayed tree will be really broken and the add and remove child events won't be correctly processed, because some Windows in the hierarchy will return a negative parent index. And generally the accerciser has various problems, with most result in Python backtraces an inconsistent app state, but even SIGSEGV happened a few time. Already have some patches for the easy reproducible ones. No idea what will happen on any other setup then Linux with ATK. Change-Id: I3280fd8622966be74e3833621952d95a2671d214 Reviewed-on: https://gerrit.libreoffice.org/73077 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-29SM add some help to the examplesJan-Marek Glogowski2-5/+11
This way the example buttons will have a name for better accessibility, instead of being blank. Change-Id: Ib8a509bc7a9895297eecd8a0db9455f367d93159 Reviewed-on: https://gerrit.libreoffice.org/73171 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-28SM move categories into SmElementsControl...Jan-Marek Glogowski2-71/+68
... and drop the special examples handling. All these lists are already static. The only "drawback" are the previously range-based for loops in SmElementsDockingWindow. Change-Id: I7a6cfbe74c29fcc14557aef1d5ef31d599b33fc0 Reviewed-on: https://gerrit.libreoffice.org/73076 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-28SM add tooltip to element categories listboxJan-Marek Glogowski1-22/+11
Since there is also no other information, like a label. Also removes one unneeded level of layout indirection. I'm not sure about the root placeholder child added by glade, but other dialogs have it too, so keep it. Change-Id: I235cc1ab5ea9ef37079353ee150eb000cb665dd1 Reviewed-on: https://gerrit.libreoffice.org/73075 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-28tdf#125454 SM use theming for element listJan-Marek Glogowski2-4/+20
This uses the same background color then the edit entries and changes the focus from the gray filled rectangle to a non-filled rectangle using the general highlight color. Change-Id: I4b44811e768266ccd2081a8e3ef61483a803da3b Reviewed-on: https://gerrit.libreoffice.org/72795 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-23tdf#65587 SM handle page keys in the ElementControlJan-Marek Glogowski2-18/+98
The page handling implementation is a little bit tricky, because the elemnt list is not handled like a grid but a list. Normally one would keep the horizontal cell and just scroll vertically. Instead this implements a kind of circle. Vertical offset is consistet, so you have the same amount of steps for up and down, but up runs left and down runs right. Change-Id: I296a46e98f7e00a59fd0a0ba358c981b49ac86cd Reviewed-on: https://gerrit.libreoffice.org/72793 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-23tdf#65587 SM add key navigation to ElementControlJan-Marek Glogowski3-41/+181
This adds arrows + home + end key navigation. The grid is handled like a list. For convenience Left + Up and Right + Down keys work in the same way. Change-Id: I757184e5161f2c7ac9b241294a5edc304c882497 Reviewed-on: https://gerrit.libreoffice.org/72792 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-22SM fix vertical ElementsControl modeJan-Marek Glogowski1-23/+55
Switches the ScrollBar to horizontal in vertical mode and adapts the scrolling. Change-Id: I35370d74175ccd1f117b17f7d7ffa25119f2e612 Reviewed-on: https://gerrit.libreoffice.org/72791 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-19increase delta for some starmath testsNoel Grandin1-2/+3
after commit 13894996601daf10d133f4a71eb0b26794d782bc Date: Sat May 4 21:46:31 2019 +0200 handle empty Rectangle better in starmath these test results now seem to depend on display scaling somewhat Change-Id: Ib998f8b033a80d16e00414b0ceded806ddadc917 Reviewed-on: https://gerrit.libreoffice.org/72545 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-15SM fix element control scrollbarJan-Marek Glogowski2-12/+28
The element layouting must always be done without a scrollbar, so it can be decided, if a scrollbar is needed. If it's needed the first paint will update the scrollbar accordingly. This also sets the scrollbar's page size to the control height, so clicking in an empty area will correctly scroll the widget not just a single pixel. Change-Id: Ib9a0eb1952bc0355f683cd8d116c61f9c9d462c4 Reviewed-on: https://gerrit.libreoffice.org/72315 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-15tdf#90297 set default SmEditWindow backgroundJan-Marek Glogowski4-9/+14
This implements ApplySetting for the proper background of the undocked SfxDockingWindow. In addition, like all other code, this sets the text color via the EditEngine font objects and therefore reverts the uneeded EditEngine interface from the original commit ea191cf9807d ("tdf#90297 use field colors for math's edit engine"). Change-Id: Ib7df4ce730da92a1e41f58b8348a5aec18208166 Reviewed-on: https://gerrit.libreoffice.org/72312 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-15SM handle background theme changesJan-Marek Glogowski6-45/+36
Replaces ApplyColorConfigValues with standard ApplySettings. I also opted to use COL_WHITE for the elements list, as the highlight color is also hard-coded to some light gray. Change-Id: I8be9d5897bf1dda4078b91d4df34a3339ac6cf31 Reviewed-on: https://gerrit.libreoffice.org/72314 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-15SM constify SmElementJan-Marek Glogowski2-23/+8
Change-Id: I6334a6c87cb548c434f0dae05e7cb2cc6e6fd66a Reviewed-on: https://gerrit.libreoffice.org/72316 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-14tdf#90297 use field colors for math's edit engineJan-Marek Glogowski5-39/+36
This adds a maTextColor to the EditEngine, which will override the default AutoColor. There is also a NOCOLORS mode and I thought about using it instead, but it defaults to COL_BLACK and overriding this seems wrong. Since the EditEngine does the whole drawing and now has the explicit FieldColor() and FieldTextColor() for background and text, my guess is we don't need an ApplySettings implementation. Change-Id: I6c2ecc843a3e07de98f97c86fc00a3b83cb78d97 Reviewed-on: https://gerrit.libreoffice.org/72197 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-05-10handle empty tools::Rectangle in SmDocShell::SetVisAreaNoel Grandin1-2/+4
Change-Id: Iccea3b686b02e03552fa5c836ee5a29103930d04 Reviewed-on: https://gerrit.libreoffice.org/72056 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-09regenerate PCH headers for the 4 new levelsLuboš Luňák1-29/+26
Plus some build fixes triggered by this. Change-Id: I59b21def706598ceffd45ae5b1f0262ec9c1ad50 Reviewed-on: https://gerrit.libreoffice.org/71581 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-09Related tdf#38889: Sync sub menus Tools > MacrosJens Carl1-0/+4
Synchronize sub menu Tools > Macros by adding "Edit Macros" across the different applications menus. Change-Id: I16185034955d889afe8a508a3522bb0a63f29545 Reviewed-on: https://gerrit.libreoffice.org/71827 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com>
2019-05-08crashtesting: many asserts in SmTextNode::PrepareCaolán McNamara2-3/+0
e.g fdo58094-1.mml since... commit 13894996601daf10d133f4a71eb0b26794d782bc Date: Sat May 4 21:46:31 2019 +0200 handle empty Rectangle better in starmath Change-Id: I01d11352b8bc9f6dcf6d6565fa41b84d549f620f Reviewed-on: https://gerrit.libreoffice.org/71963 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-05handle empty Rectangle better in starmathNoel Grandin3-3/+12
which required fixing a unit test to call Prepare, otherwise the nodes are not ready for layout Change-Id: I763c1b05d4dfafa73ebaee55d080876848de94f6 Reviewed-on: https://gerrit.libreoffice.org/71800 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-03Use hasElements to check Sequence emptiness in sfx2..svxArkadiy Illarionov1-1/+1
Similar to clang-tidy readability-container-size-empty Change-Id: Icabd773f3b924d465b33e8581175f1fcf70c282e Reviewed-on: https://gerrit.libreoffice.org/71704 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-28tdf#120703 PVS: V581 ifs with identical conditionsMike Kaganski1-10/+5
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Change-Id: I11fa13677c7980e6ac17fc4358406472ee784e41 Reviewed-on: https://gerrit.libreoffice.org/71446 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-28Minimize scope of variablesJan-Marek Glogowski1-7/+8
Change-Id: I6602c84b9bd7143e5e7b224c17559b083c9b7f9c Reviewed-on: https://gerrit.libreoffice.org/71439 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-04-27tdf#42949 Fix IWYU warnings in include/svx/[a-D]*Gabor Kelemen1-0/+1
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9770343f31f882427c9ae13e363b59cd1fb47e98 Reviewed-on: https://gerrit.libreoffice.org/71295 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-19Further cleanup of FastSerializerHelper's startElement/singleElement[NS]Mike Kaganski1-97/+96
Drop FSEND_t: C-style varargs code was replaced since version 6.0 in commit d43fc40718217d89cc95cc3c0bc0b8e7926abcc0, so it's time to remove the last bits. Drop int-to-string macros that are simple wrappers over OString::number. Avoid unnecessary string type conversions. Change-Id: I86478577b8e469f99b5a90619e5f78a61f4f23fb Reviewed-on: https://gerrit.libreoffice.org/70964 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-15tdf#42949 Fix IWYU warnings in include/editeng/[a-e]*Gabor Kelemen2-0/+2
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I81917d697adf79b1bd0de4cc262d3cd6bc8eb36f Reviewed-on: https://gerrit.libreoffice.org/70710 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-14tdf#120703 PVS: Silence V522 warningsMike Kaganski1-2/+5
V522 There might be dereferencing of a potential null pointer. Change-Id: Ie4bc74a734a6d5a73838a27e0d80cc8e51595839 Reviewed-on: https://gerrit.libreoffice.org/70730 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-14loplugin:sequentialassign in starmath..svlNoel Grandin1-2/+1
Change-Id: I95d7b67cd8b6b68c087ff96fdb6bb283ab8b49ec Reviewed-on: https://gerrit.libreoffice.org/70718 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-08tdf#42949 Fix IWYU warnings in include/sfx2/[t-z]*Gabor Kelemen7-0/+11
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib3252828385d1dc8faf48a428b1593199647a679 Reviewed-on: https://gerrit.libreoffice.org/70383 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-01tdf#42949 Fix IWYU warnings in include/sfx2/[sS]*Gabor Kelemen4-0/+6
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I4a3baffa8944b522b16b50975185759081662020 Reviewed-on: https://gerrit.libreoffice.org/69945 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-29tdf#124410 re-call SetScrollBarRange when aSymbolSet changesCaolán McNamara2-4/+13
and do the work that depends on size happen at size-changed instead of first-draw Change-Id: Ia2605ba9bb875be9248a009a6f26f01cbbbd4632 Reviewed-on: https://gerrit.libreoffice.org/69928 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-28tdf#42949 Fix IWYU warnings in include/sfx2/[e-M]*Gabor Kelemen2-0/+4
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6e97c7ed6c0211dfafee83b9bdbea672e415fc49 Reviewed-on: https://gerrit.libreoffice.org/69715 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-25tdf#42949 Fix IWYU warnings in include/sfx2/[a-D]*Gabor Kelemen3-0/+3
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I444cb71bc3d045072a4b1f9eed279ed7e425a0d4 Reviewed-on: https://gerrit.libreoffice.org/69481 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-16clarify that set_visible(true/false) is just show/hideCaolán McNamara1-3/+3
ditch duplicate method Change-Id: Iea35d6437f48809a06e093241bddf301f00c502b Reviewed-on: https://gerrit.libreoffice.org/69302 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-13Resolves: tdf#124028 dangling "completion" entries block responsesCaolán McNamara1-1/+0
so e.g. math font dialog doesn't react to button clicks. since... commit ab8e0f5832fa910f8b1abd36d7cb3929cbac2395 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jan 18 17:08:58 2019 +0000 Resolves: tdf#122484 replace gtk autocomplete with vcl-alike autoselect remove the entrycompletions but left the reference to them Change-Id: Ia02d0e657fc114692f69f88890192c470a1cab22 Reviewed-on: https://gerrit.libreoffice.org/69208 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-08tdf#42949 Fix IWYU warnings in starmath/*/*cxxGabor Kelemen19-28/+19
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I18dc216a59a5770456b20162c881c8726e2f44b2 Reviewed-on: https://gerrit.libreoffice.org/68788 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-17 10:05:38 +0000