summaryrefslogtreecommitdiff
path: root/starmath
AgeCommit message (Collapse)AuthorFilesLines
2017-06-13Use unique_ptr for SfxPrinter::pOptionsStephan Bergmann2-5/+10
Change-Id: I46be77225c0323f8b7f293de9c022f0de6f425b7
2017-06-13starmath: SvStream::Seek()/Tell() uses sal_uInt64, not sal_uLongTakeshi Abe2-9/+9
Change-Id: I210a9969f4bf6a1dc5c199836abec08d78968c36 Reviewed-on: https://gerrit.libreoffice.org/38702 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-06-13starmath: SvStream::ReadBytes() returns std::size_t, not sal_uLongTakeshi Abe1-1/+1
Change-Id: I734e653343dcc563f1eb2312e5136fa5efe0f5fa Reviewed-on: https://gerrit.libreoffice.org/38701 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-06-12pass comphelper::PropertySetInfo around using rtl::ReferenceNoel Grandin1-3/+2
and remove some manual ref counting Change-Id: Ib78122fbbf914e87e0aef1f8fffe3952639e5b22 Reviewed-on: https://gerrit.libreoffice.org/38607 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-06replace SVSTREAM_OK with ERRCODE_NONENoel Grandin2-3/+3
since the first is #define'd to the second, and offers no extra value Change-Id: I2c67e09ea3aa5361b8e7dfe7a20858c6ae054450 Reviewed-on: https://gerrit.libreoffice.org/38406 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-05clang-tidy performance-unnecessary-value-paramNoel Grandin2-4/+4
Change-Id: I6ed8c54c7c45931d91709cc818f2483c70197192 Reviewed-on: https://gerrit.libreoffice.org/38400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-31disambiguate dual use of toolbar idsCaolán McNamara2-3/+1
for toolbar title string resource and identifier (for config) Change-Id: I2657c3cbb586a62d8075db7cb43cc064b2030f28 Reviewed-on: https://gerrit.libreoffice.org/38274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-31clang-tidy readability-redundant-control-flowNoel Grandin1-2/+0
Change-Id: I832f7ef0f1bd55e365db7e49823fe8bc30390c04 Reviewed-on: https://gerrit.libreoffice.org/38215 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-30teach redundantcast plugin about functional castsNoel Grandin2-3/+3
Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0 Reviewed-on: https://gerrit.libreoffice.org/37910 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-19loplugin:stringcopy: starmathStephan Bergmann6-7/+7
Change-Id: I2687b8ce4b20871f50401cbc50746c35b9668eba
2017-05-19make string translation loading more uniformCaolán McNamara11-77/+71
change various ResId classes that use conversion operator to OUString to functions that return a OUString drop various defines drop unnecessary toString calls Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92 Reviewed-on: https://gerrit.libreoffice.org/37817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-18Revert "Fix typos"Stephan Bergmann5-6/+6
This reverts commit 26a67002fcb9381b54de6cae1aaa37120d49066a. "Iff" is not a typo, see 2a65bf32ec270484dcea4d22d3c93552dc0c24dd "Revert 'Typo: iff->if'".
2017-05-18Fix typosAndrea Gelmini5-6/+6
Only replaced "iff" with "if" Change-Id: Ib9dfa5c12b05500043147fe3b65f923b1b12a581 Reviewed-on: https://gerrit.libreoffice.org/37782 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-05-18loplugin:unusedmethodsNoel Grandin2-76/+0
Change-Id: I1c50d176e793397a1f9625f797a3750cf191a61c Reviewed-on: https://gerrit.libreoffice.org/37679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-16loplugin:unusedfields improve write-only analysisNoel Grandin2-16/+6
by whitelisting a couple of methods we know only write to their parameters Change-Id: Id7aef9c03c23d10c27707b21eb9a0db4a6c2757c Reviewed-on: https://gerrit.libreoffice.org/37647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-15remove some unnecessary lockingNoel Grandin2-2/+0
Change-Id: I7da9e82930d3fe8f927c495aeca270b8bb5cf65c Reviewed-on: https://gerrit.libreoffice.org/37602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-12remove unused uno::Reference varsNoel Grandin1-1/+0
found by temporarily marking Reference as SAL_WARN_UNUSED. Change-Id: I18809b62654467f890016adcc92576980ced393b Reviewed-on: https://gerrit.libreoffice.org/37511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-11Fix typosAndrea Gelmini1-1/+1
Change-Id: I204178ed4cf0fd3f43043cf1dfde85bb27002fee Reviewed-on: https://gerrit.libreoffice.org/37498 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-11starmath Word export: remove redundant 'virtual' keywordsMiklos Vajna2-22/+22
Change-Id: I7b8600ae6516ffe5f30bbefbd554b9e7a2614211 Reviewed-on: https://gerrit.libreoffice.org/37494 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-05-09remove unnecessary empty OUString fields and varsNoel Grandin1-4/+2
Change-Id: I940120087a0bc6b1b0abc30a3e7727ce22b7d9a7 Reviewed-on: https://gerrit.libreoffice.org/37394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08teach loplugin:constantparam about simple constructor callsNoel Grandin3-5/+5
Change-Id: I7d2a28ab5951fbdb5a427c84e9ac4c1e32ecf9f9 Reviewed-on: https://gerrit.libreoffice.org/37280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08tdf#106479 Make edit context menu dispatcher basedMaxim Monastirsky6-1622/+270
This allows us to add there any .uno command and also get the icon and keyboard shortcut for it. Use this to add clipboard commands. Change-Id: Ic42c28add7771f322491e8e7d6df052e3c2c8d75 Reviewed-on: https://gerrit.libreoffice.org/37353 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-05-07tdf#107644: Crash on inserting formulaJulien Nabet1-1/+1
See https://bugs.documentfoundation.org/attachment.cgi?id=133085 Accessibility related Change-Id: I87063e50a59b06f4f5a974764de9aa34e111b4fb Reviewed-on: https://gerrit.libreoffice.org/37315 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: sam tygier <samtygier@yahoo.co.uk> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-07revert OSL_ASSERT changesChris Sherlock1-1/+1
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert starmath module away from OSL_ASSERT to assertChris Sherlock1-1/+1
Change-Id: I446eb5831dd41edac0752d1c4813a7e711042cd3
2017-05-05starmath: Convert SmHorAlign to scoped enumTakeshi Abe4-11/+15
Change-Id: Ie75749ebbea2ec74e2f16b1c42a55fbcd71845c3 Reviewed-on: https://gerrit.libreoffice.org/37270 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-05-05Defining SID_UNICODE_NOTATION_TOGGLE once is enoughMaxim Monastirsky1-18/+0
Change-Id: I6d63ee582ad5530ecb713dd65350912ee27dc15d
2017-05-05Drop premature mode lineTakeshi Abe1-2/+0
Change-Id: I718184564eee226a72e4db5e804a99257d278db5
2017-05-04loplugin:checkunusedparams in starmathNoel Grandin9-28/+28
Change-Id: I1a2299f66e077879863ac0e694e42196c9432458 Reviewed-on: https://gerrit.libreoffice.org/37192 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02untranslated strings are just stringsCaolán McNamara15-790/+412
removes starmaths InsertCommand in favour of InsertCommandText Change-Id: I5659adcaa28e5b5861d1a1cc5d2afa84009490f6 Reviewed-on: https://gerrit.libreoffice.org/37113 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-02loplugin:checkunusedparams in editengNoel Grandin1-1/+1
Change-Id: I2b770d40ac2339cd2b04a765a6d970675d2ea1c1 Reviewed-on: https://gerrit.libreoffice.org/37133 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-01Return values of sdi "method slots" were unusedMaxim Monastirsky1-3/+3
Also expand nested methods. Only diff in workdir/SdiTarget is for SID_STYLE_WATERCAN from sw/sdi/_basesh.sdi which changed the .uno name from WatercanStyleModeOnOff to StyleWatercanMode, to match the name in sfx2/sdi/sfx.sdi (it was forced by svidl to have the same name). Change-Id: Iaeac9f4f10a36cb0b3afe3de2b6def8cd90edc6d
2017-04-28loplugin:salunicodeliteral: starmathStephan Bergmann8-30/+30
Change-Id: Ic02e71ccb2d5fe2e3505853c6e164f17e26361b2
2017-04-28loplugin:cppunitassertequals: starmathStephan Bergmann1-26/+26
Change-Id: I09b1d5c6ac271041963e7043487c79f6b92649ca
2017-04-27tools: move errcode.hxx to the vcl moduleChris Sherlock1-1/+1
Change-Id: I17e5a033de5f0aeb0a726744f7b464cdab6e2ee3 Reviewed-on: https://gerrit.libreoffice.org/36854 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-27starmath: Convert SmScaleMode to scoped enumTakeshi Abe7-33/+38
Change-Id: I88024e9cc1147cc44a087315968c3462ab5baf73 Reviewed-on: https://gerrit.libreoffice.org/36978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-04-26use strong_int for LanguageTypeNoel Grandin1-4/+4
Change-Id: If99a944f7032180355da291ad283b4cfcea4f448 Reviewed-on: https://gerrit.libreoffice.org/36629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-26starmath: Show all Functions' menu items in Command MenuTakeshi Abe1-64/+51
I am not sure why nested submenu does not work, but found GNOME HIG <https://developer.gnome.org/hig/stable/menus.html> says that > Submenus (...) should never contain other submenus. Change-Id: Id2f06efb596b66af74d4877b1e42c0c00e310b19 Reviewed-on: https://gerrit.libreoffice.org/36881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock6-0/+6
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-23starmath: Show underscore which does not mark a mnemonic keyTakeshi Abe1-1/+1
Change-Id: I119f308d59b309bf432421a50c616032f6c74e87 Reviewed-on: https://gerrit.libreoffice.org/36826 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-04-23starmath: Fix wrong ids in Command Menu to be inserted as commandsTakeshi Abe1-23/+23
Change-Id: I56343724ce8d2a2040aa2f354868a474743fb04d Reviewed-on: https://gerrit.libreoffice.org/36760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky6-6/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21remove some old MSVC workaroundsNoel Grandin1-6/+0
Change-Id: I6abd8aaffb27b3c85df7c0518f7f576be4e32222 Reviewed-on: https://gerrit.libreoffice.org/36660 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-20loplugin:unusedmethodsNoel Grandin2-2/+0
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672 Reviewed-on: https://gerrit.libreoffice.org/36718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-19starmath: Keep entries in Command Menu untranslatableTakeshi Abe1-43/+43
Change-Id: I079dbe10bc5ef335354bcc94354644f0ec0c3c5a Reviewed-on: https://gerrit.libreoffice.org/36685 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-19convert MeasurementSystem to scoped enumNoel Grandin1-1/+1
Change-Id: I5d26c50aa0e2c68edab6ee217ae6bdb0ee45dc09 Reviewed-on: https://gerrit.libreoffice.org/36525 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-18convert starmath context menu to .uiCaolán McNamara6-1557/+1605
Change-Id: I0ab984aac0103a0d2bbb3c7a7c0bbd797eba7454
2017-04-18tdf#95992 "Edit" > "Compare Document..." opens dialog that is...Matteo Casalin1-1/+1
misnamed "Insert" Issue is that the caption of the dialog is handled by generic code, which was not designed with comparison in mind. This fix extends the captions that can be used by such generic codes, without modifying the underlaying architecture. Letting callers directly provide caption text might be more versatile, though. The fix is extended to: * Writer Merge functionality * Calc Compare/Merge functionalities which use the same dialog (and thus were also displaying "Insert"). Change-Id: I452b37bf7d0024924c87316cd47572c09b373b65 Reviewed-on: https://gerrit.libreoffice.org/35285 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-04-18starmath: Convert SmNodeType to scoped enumTakeshi Abe14-262/+262
Change-Id: I30921f9426e0e50ab8c6dfb1e86400847176b707 Reviewed-on: https://gerrit.libreoffice.org/36613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-04-14starmath: size() > 0 -> !empty()Takeshi Abe4-8/+8
Change-Id: Id7c73870f58ebf04c2703cdf8b3d0ffe258b2c0d Reviewed-on: https://gerrit.libreoffice.org/36545 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-17 21:47:04 +0000