summaryrefslogtreecommitdiff
path: root/starmath
AgeCommit message (Collapse)AuthorFilesLines
2014-08-25Avoid possible memory leaks in case of exceptionsTakeshi Abe1-5/+4
Change-Id: Icc073be041ae0b0c690e869a0edaff3515d1d601
2014-08-22Resolves: fdo#82747 Crash on opening wikipedia ODT BookJulien Nabet1-0/+1
Test if there's indeed a subnode before testing its type Change-Id: I1bb32652ceb82b0818a8d2cd8d71b46dd96ef2aa Reviewed-on: https://gerrit.libreoffice.org/11050 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-08-20vcl: use enum for complex text layout constantsNoel Grandin2-5/+5
Since these constants are bitfield flags, we define some methods to make working with them reasonably type safe. Move the definitions to outdevstate.hxx, since we need the values there, and that appears to be the "root most" header file. Also dump TEXT_LAYOUT_BIDI_LTR constant, since it means the same thing as TEXT_LAYOUT_DEFAULT (ie. 0), and leaving it in causes people to write weird code thinking that it's a real flag. Change-Id: Iddab86cd6c78181ceb8caa48e77e1f5a8e526343 Reviewed-on: https://gerrit.libreoffice.org/10676 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-08-18remove unused WarningBoxesThomas Arnhold2-6/+0
Change-Id: I07c457a49646703af5d13f83ba033340309ee655
2014-08-13warning C4242: '=' : conversion from 'size_t' to 'sal_uInt16'Thomas Arnhold1-1/+1
Change-Id: I892a0418125e9c660577d6acccf78e82c2b7f56c
2014-08-12-Werror,-Wundefined-bool-conversionStephan Bergmann1-1/+1
Change-Id: I44327db80a923c2ee8e762b3ba5f5de771b8610e
2014-08-09remove now unused tabpage.hrcThomas Arnhold1-1/+0
as TP_WIDTH and TP_HEIGHT are unused now Change-Id: I06ec7af8c2b3386d76e36284eb56ea1ab6b9ec5d
2014-07-29Drop unnecessary SfxApplication::CreateResManager wrapperStephan Bergmann1-2/+1
Change-Id: I2b8662ec85b8f710aa17a2c6f59c4b35af7685f3
2014-07-26Massive 'Dialogdiet fail' and similar to 'Dialog creation failed'Matteo Casalin1-1/+1
Change-Id: I6ca6914e80c186699df42253de46a3690c5130f2
2014-07-23convert SfxItemState constants to a proper enumNoel Grandin2-7/+7
and while we're at it - use the enum type all over the place instead of passing around sal_uInt16 - don't use bitwise logic on enum values - use enum values instead of numeric constants Change-Id: I7f24cb4d242e1c00703e7bbcf1a00c18ef1e9fd4
2014-07-20vcl consitent use of long for corrdinateNorbert Thiebaud1-2/+2
most of length in vcl are calculated in 'long' but array of X position tend to be in sal_Int32. As a prep work to be able to support 'double' as the base type of Device Coordinate, harmonize the use of 'long' for non-float coordinate. Change-Id: I7cb33301ff6a5e2c62247b36a4e07e168a58a323
2014-07-17Renamed brdcst.[hc]xx to SfxBroadcaster.[hc]xxTobias Lippert3-3/+3
- Remove includes from files where they are not needed. - Update pch files Change-Id: I0188e3934ef429008c1ef495ab1d5b27f38664d5 Reviewed-on: https://gerrit.libreoffice.org/10342 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-07-08fdo#81036 escape ~ in .ui and fix a typo (straight apostrophe)Andras Timar1-1/+1
Change-Id: I652dc63cc0e8fb04d7c3115d66d60dabda60f0f4
2014-07-03use assert when followed by derefCaolán McNamara2-3/+3
Change-Id: I8405e4d8f9fa1de3ef6ee474321b4ac2b4ce1624
2014-07-01coverity#1038321 Unintended sign extensionCaolán McNamara2-9/+9
and coverity#1038320 Unintended sign extension coverity#1038319 Unintended sign extension coverity#1038318 Unintended sign extension coverity#1038317 Unintended sign extension coverity#1038316 Unintended sign extension coverity#1038315 Unintended sign extension coverity#1038314 Unintended sign extension Change-Id: Ib8015baf8ffec48e1b2d6ce1e7ce284fb36303b0
2014-06-27remove SFX_APP() macro that was a mer wrapper for SfxGetApp()Norbert Thiebaud1-3/+3
Change-Id: I480a789c767dd671775c9d70d96bf71908f21f5b
2014-06-24new compilerplugin returnbyrefNoel Grandin3-6/+5
Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-23fdo#76203 - use consistent titlecase for UI title labelsJoren De Cuyper4-7/+7
Change-Id: Icae67c083ca867c89cff7f9d5d44dbbe4aadcba9 Reviewed-on: https://gerrit.libreoffice.org/9858 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-20fdo#79973 : LO crashes while opening the document.PriyankaGaikwad1-1/+3
Description: - If the equation ends with two dots(.) then file get crash. - In SmParser::NextToken() the file get crash because string index is out of bound. Change-Id: I5f25814220d556d53c10d4ca33a38b4d0d451438 Reviewed-on: https://gerrit.libreoffice.org/9840 Reviewed-by: Muthu Subramanian K <muthusuba@gmail.com> Tested-by: Muthu Subramanian K <muthusuba@gmail.com>
2014-06-19fdo#71076, fdo#71767: Preserve number formats when charts are copied.Kohei Yoshida1-2/+4
Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a
2014-06-19coverity#707196 Uncaught exceptionCaolán McNamara1-7/+17
Change-Id: I4f42040c7e12507365f12d09f80d3641b4d5ca02
2014-06-19coverity#706063 Unintended sign extensionCaolán McNamara1-2/+2
Change-Id: Idaec46756ef22bcec1335c219fdc3ebf64c43fc3
2014-06-19coverity#706062 Unintended sign extensionCaolán McNamara1-1/+1
Change-Id: I96e3054de033c550a54c8393c82d0efbe6f2e08d
2014-06-13loplugin:staticcallStephan Bergmann2-2/+2
Change-Id: I7639df64242e5b30f9857363b3be33d61bf28594
2014-06-11Change SfxTabPage ctor SfxItemSet param from ref to pointerStephan Bergmann1-1/+1
...and also corresponding param of CreateTabPage function type and corresponding Craete functions. There were some call sites that passed undefined "null pointer references" and SfxTabPage internally uses a pointer member pSet that is checked for null anyway. Change-Id: I4eb3636155eac46c9c9d26e6e6e842e85d7e95af
2014-06-11Change SfxTabPage::Reset param from ref to pointerStephan Bergmann2-10/+10
...there was a call site that passed undefined "null pointer reference" (apparently in a case where the passed argument was actually unused) Change-Id: I663d4264b7a84f44ca69c732f3bc502f614b2b2a
2014-06-10Change SfxTabPage::FillItemSet param from ref to pointerStephan Bergmann2-9/+9
...there were a number of call sites that passed undefined "null pointer references" (apparently in cases where the passed argument was actually unused) Change-Id: I19799e90f0cd8e98367782441a5ea9df27b59830
2014-06-06coverity#708822 Unused pointer valueCaolán McNamara1-1/+1
Change-Id: I6ccd4c2ab97237806652059d6ae2cd23a6dc1625
2014-06-04DeInitVCL at end of testsStephan Bergmann1-0/+1
This required some changes to the framework: * Init-/DeInitVCL is no longer done per individual test in BootstrapFixture, but once per CppunitTest invocation in a new vclbootstrapprotector (similarly to the exisiting unobootstrapprotector). CppunitTests that need VCL now need to declare gb_CppunitTest_use_vcl. * For things to work properly, the UNO component context needs to be disposed from within DeInitVCL (cf. Desktop's Application::DeInit called from DeInitVCL). The easiest solution was to introduce an Application::setDeInitHook (where the hook is called from DeInitVCL) specifically for vclbootstrapprotector to call. * PythonTests don't (yet) call DeInitVCL; they still hook into BootstrapFixture's original test_init functionality (to call InitVCL), and do not make use of the vclbootstrapprotector. Change-Id: I4f3a3c75db30b58c1cd49d81c51db14902ed68b2
2014-06-04avoid problems with poppler's and vcl's FontInfo during runtimeMarkus Mohrhard1-1/+1
Change-Id: I1dbd256812cccae1e6ed0ad8bb34ce427e5e5be8
2014-05-30coverity#705239 Missing break in switchCaolán McNamara1-0/+2
Change-Id: Ic11f6640b6c60feed06ee988796823aaada76739
2014-05-28update_pchThomas Arnhold1-2/+0
Change-Id: I5316693452427ed76a7738b090de023b110caa40
2014-05-28starmath: remove hard-coded valueThomas Arnhold1-1/+1
Change-Id: I58dad585c5de24ebd06ce9bcc64e49e8973850bb
2014-05-28Related fdo#71616: Fix scrollingThomas Arnhold1-0/+1
Change-Id: I9c57de1179d7db19f1fa2b104017dd379f854749
2014-05-28starmath: directly create utf8 OUStringThomas Arnhold1-1/+1
This fixes: warn:rtl.string:14867:1:sal/rtl/strtmpl.cxx:1269: rtl_uString_newFromLiteral - Found char > 127 Change-Id: I1f868406501c83918fc3c06dd0b68eb1f6604f26
2014-05-28starmath: no need to set those on every paint eventThomas Arnhold1-5/+5
Change-Id: Ife149baf15d6f38a2a316e124b78bdb7e1b64967
2014-05-28Related fdo#71616: Set correct BaseSizeThomas Arnhold1-1/+1
BaseSize has to be set in 100th mm, otherwise the scalable brackets are far too thin. See starmath/source/cfgitem.cxx: pFormat->SetBaseSize( Size(0, SmPtsTo100th_mm( nTmp16 )) ); nTmp16 is 12pt -> 422 100th mm (at least for me). Let's reuse that. Change-Id: I69571ae002f790199ab423955b1635eda42096eb
2014-05-28Resolves: fdo#71616 Elements dock: Better display of scalable bracesThomas Arnhold1-0/+27
Change-Id: I2255be738aa2230b4102030891026f1f9ad2c38f
2014-05-28Resolves: fdo#65583 Elements Dock window needs scroll barThomas Arnhold2-12/+66
Based on the patch on Bugzilla by Marcos Paulo de Souza <marcos.souza.org@gmail.com> Change-Id: I215b83894f228b1cc8908f98858b85c8d5378ddb
2014-05-28starmath: directly use white colorThomas Arnhold1-3/+1
Change-Id: I3b0e4ecd5def28c6b9f4639b8df16a2a0ea0008c
2014-05-27Resolves: fdo#77831 use classic token rules for user-defined char (%foo)Caolán McNamara2-1/+8
Change-Id: Iebae064986ad722d445c8d654e39e338e104f021
2014-05-27cid#707198 Uncaught exceptionNoel Grandin2-2/+2
Change-Id: Ibfe57b366207550b0f3c0e9cb7e8da1078531742
2014-05-27cid#707199 Uncaught exceptionNoel Grandin2-2/+2
Change-Id: I4ff6cdf0f7d48318a948865784c66f992fe52e3d
2014-05-27Remove unnecessary semicolonsPeter Senna Tschudin1-1/+1
A simplified version of the semantic match that finds this problem is follows: (http://coccinelle.lip6.fr/) // <smpl> @r1@ statement S; position p,p1; @@ S@p1;@p @script:python r2@ p << r1.p; p1 << r1.p1; @@ if p[0].line != p1[0].line_end: cocci.include_match(False) @@ position r1.p; @@ -;@p // </smpl> Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e Reviewed-on: https://gerrit.libreoffice.org/9493 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-26coverity#736052 Missing break in switchCaolán McNamara1-1/+1
Change-Id: I9e067659dea49683ceda9553b3d35254576079db
2014-05-23Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20Julien Nabet2-7/+7
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
2014-05-20WaE: -Wunused-variableThomas Arnhold1-8/+0
Change-Id: Ic39102eaa8f0f5f6ea58173103ca8c5dc5c55185
2014-05-19hrc and src files: squeeze multiple newlinesThomas Arnhold4-8/+0
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-19Resolves: fdo#78829 align to top instead of centerCaolán McNamara1-47/+47
Change-Id: Iff4125e108df535d90afd940a9787eb8e011c9bd
2014-05-14Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part12Julien Nabet1-1/+1
Change-Id: I7c514b7a1d86f52d77672b826b1f08b825fd7aa7