summaryrefslogtreecommitdiff
path: root/sot
AgeCommit message (Collapse)AuthorFilesLines
2014-04-07Remove unused functionsStephan Bergmann1-6/+0
Change-Id: Ifa8fad734c716deeed32137f09cbe88378d11faf
2014-04-07Replace SV_DECL/IMPL_REF macros with SvRef templateStephan Bergmann1-2/+2
Change-Id: I0ef2e67f6d61e0ce118c0f5e926b8194ef9d8058
2014-04-03remove unnecessary scope qualifier from sal_Bool usesNoel Grandin1-1/+1
i.e. convert "::sal_Bool" to "sal_Bool" Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-01Explicitly mark overriding destructors as "virtual"Stephan Bergmann4-6/+6
It appears that the C++ standard allows overriding destructors to be marked "override," but at least some MSVC versions complain about it, so at least make sure such destructors are explicitly marked "virtual." Change-Id: I0e1cafa7584fd16ebdce61f569eae2373a71b0a1
2014-03-30MSVC helpfully provides warning C4310: cast truncates constant valueMichael Stahl2-2/+2
Change-Id: I985216d7bade6cbb3a037b07fe44438543d63ba0
2014-03-30sot: convert that to SAL_INFOMichael Stahl1-1/+2
Change-Id: Iaf2de623c0893b0f500d54ce6558bf40af6e655b
2014-03-30deploy some asserts to detect truncated STREAM_SEEK_TO_ENDMichael Stahl2-0/+5
Since STREAM_SEEK_TO_END is now 64 bits it could happen that some existing code uses it in some indirect manner and it gets truncated to 32 bits somewhere (on 32 bit platforms); try to detect that with asserts. Of course the checked value is now a valid stream position, so perhaps the checks should eventually be removed. Change-Id: I4248c00d758220bdc3ee94c7aa7a7bd4c86c57f0
2014-03-30sot: fix some bizarre resize code that creates 4G temp files on 32bitMichael Stahl1-4/+1
StgTmpStrm::SetSize(): the nEndOfData - 1 may underflow if nEndOfData=0 which happened to be the same value of STREAM_SEEK_TO_END before but not any more; also it's a mystery to me why the last byte in the buffer would need to be overwritten with 0 here. This also fixes the failure of ww8_export test. Change-Id: Iefe5a22c667ee83fbc315d772f357b913105ad93
2014-03-29Fix some types in virtual methods to properly override.Matúš Kukan4-5/+5
Thanks to SAL_OVERRIDE! Adapting to 1258b576aef2ff3cdd4f44e1c03edb8c862a79f6 Change-Id: Iafc9660312ad33f6136c15170c35a59e61c76b26
2014-03-29tools: support 64-bit file positions in SvStreamMichael Stahl4-18/+18
Bump stream positions to 64 bits on: SvLockBytes::SetSize() SvStream::SeekPos() SvStream::SetSize() SvStream::SetStreamSize() SvStream::Seek() SvStream::SeekRel() SvStream::Tell() SvStream::remainingSize() SvStream::nActPos SvStream::nBufFilePos Change-Id: I0521fd60d31d1a33e5634cbf51dd42edc46ad919 TODO: adapt callers of Seek()/SeekRel()/Tell()/remainingSize()
2014-03-28coverity#1078520 Logically dead codeCaolán McNamara1-1/+1
Change-Id: I91ff819bbbca9f74236bcec725b98f8065a84a50
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann7-57/+57
...mostly done with a rewriting Clang plugin, with just some manual tweaking necessary to fix poor macro usage. Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26Split TYPEINFO into plain and TYPEINFO_OVERRIDEStephan Bergmann2-3/+3
...where the latter contains SAL_OVERRIDE annotations Change-Id: Id64794b388d83dfe7026440e8b20a5b5efd412d1
2014-03-18Find places where OUString and OString are passed by value.Noel Grandin2-4/+4
It's not very efficient, because we generally end up copying it twice - once into the parameter and again into the destination OUString. So I create a clang plugin that finds such places and generates a warning so that we can convert them to pass-by-reference. Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361
2014-03-05debug only code SotFactory::Find(SvGlobalName const&)Noel Grandin1-0/+2
Change-Id: Ia7e94a0580a26dad874b2f53b4bc17d5c4b6d115
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann3-56/+56
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-25Remove visual noise from sotAlexander Wilms12-41/+41
Change-Id: I731691d4cac8567938407a514a25e13b2baa7958 Reviewed-on: https://gerrit.libreoffice.org/8314 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23Remove unneccessary commentsAlexander Wilms4-51/+51
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb Reviewed-on: https://gerrit.libreoffice.org/8182 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-20cid#1078823 Dereference before null checkNoel Grandin1-1/+1
Change-Id: If1a3f54ee38cd97693cebaea680b46ba846b2e71
2014-02-19sot: sal_Bool -> bool fixupStephan Bergmann2-3/+3
Change-Id: I53777b6f72f5ff60228e40e9ec2a0e909e059fcf
2014-02-12Perhaps it's better to use nMaxLegalStr here than using hardcoded 32.Kohei Yoshida1-3/+3
Change-Id: Idee4667f5ef9aa71af05139b6fc7ee8a5166b398
2014-02-12more SvStream:operator>> conversionNoel Grandin1-1/+1
Convert the template based read_lenPrefixed methods to regular methods. Change-Id: Ifd0e93aca055e55a0575e4377ec2b8e266dfb019 Reviewed-on: https://gerrit.libreoffice.org/7895 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12convert SvStream::operator>> methods to ReadXXX methodsNoel Grandin5-54/+54
First, I updated the clang rewriter to do the conversion. Then I lightly hand-tweaked the output for the few places where the rewriter messed up, mostly when dealing with calls on "this". Change-Id: I40a6a977959cd97415c678eafc8507de8aa3b1a9 Reviewed-on: https://gerrit.libreoffice.org/7879 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-02-12fdo#52547 SOT: Prefer embedding image data to embedding linked image.Andrzej Hunt1-9/+9
When copying an image from e.g. Firefox or Chromium the clipboard will contain both the image itself, and the url of the image -- presumably it makes more sense to store the image data itself if it is available -- the order of the items in the *_FREE_AREA_Copy defines the order of preference for which data in the clipboard should be used. Change-Id: Id8b862a9f2fce3a34adbb16509e9b7372500a239 Reviewed-on: https://gerrit.libreoffice.org/7928 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-10remove commented codeMarkus Mohrhard1-6/+1
Change-Id: Ibc04f08b52d754263151ee66d03b58abe2f4e4ee
2014-02-10fix crash during xls import, related fdo#36580Markus Mohrhard1-2/+2
Looks like a possibly invalid xls file but let us just do the right thing and not crash. Change-Id: Id96db06798cd19d96938ca84956046e5a5e5b529
2014-02-04convert specialised SvStream::operator>> methods to ReadXXX methodsNoel Grandin5-11/+11
as preparation for converting the SvStream::operator>> methods on primitive types Change-Id: I62f134bced15c687d6e0d46924f56e8d1c3d95b9 Reviewed-on: https://gerrit.libreoffice.org/7798 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-30Resolves: #i124085# disabled CF_DIBV5...Armin Le Grand2-1/+43
(no advantages but some problems), increased png support (cherry picked from commit c991f7cae8dcb306cb0d1f32bc5fcd8ea0a1ea81) Change-Id: I52bef1295b32eb3692a0428c96edd0c55287f34a
2014-01-28bool improvementsStephan Bergmann3-3/+3
Change-Id: Ia8d1f04a78dfd1b7fd6a3bd1e23f643b4bb7911f
2014-01-22remove SvStream::operator<< methodsNoel Grandin1-1/+1
.. and convert the last few places still using those methods. Change-Id: Id2cd8f9c0dd281df43af439d4fef65881f34a6fd Reviewed-on: https://gerrit.libreoffice.org/7495 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-20Removed unused solar.h reference in sotAlexandre Vicenzi2-4/+0
Change-Id: If49a8b583c8805e31abe158c31b3d2c9c79e6e27 Reviewed-on: https://gerrit.libreoffice.org/7518 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-01-16convert SvStream::operator<< overloads to more explicit methodsNoel Grandin4-7/+7
This is in preparation for more conversion of SvStream::operator<< calls to use more explicit method names. This converts the subclasses that have their own convenience overloads of operator<< to use normal methods. Change-Id: I5efd5d9a24c264cb86d2471303dd5849bf91ba80
2014-01-10Add FIXME for odd sal_Int32/bool mismatchStephan Bergmann1-1/+3
Change-Id: Ief4a1b2879c36b6e5440d2a7ebea1681f50ff3b1
2014-01-10StgStrm::Write returns sal_Int32, not boolStephan Bergmann1-1/+1
Change-Id: Idfc30d55a0c282c9869a6470ca99ac9cb7f6b817
2014-01-10Use proper bool operationsStephan Bergmann1-1/+1
Change-Id: I93aef8d7c1824d906919a5d7043709fbf1586c3a
2014-01-10re-write SvStream operator<< to non-overloaded methodsNoel Grandin5-64/+64
This is the actual re-write. Use a clang rewriter to rewrite SvStream::operator<< to methods like WriteuInt32. Note that the rewriter is not perfect, and I hand-tweaked the output. In particular, I had to adjust places doing things like (*this) << 1; Change-Id: I5923eda3f4ebaa8b452b6ef109e726e116235a2a Reviewed-on: https://gerrit.libreoffice.org/7342 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-01-09remove unnecessary use of OUString*Noel Grandin1-5/+3
in FileList. There no benefit in storing a ref-counted value class like OUString by pointer in a std::vector. Change-Id: I302bc460de67c7fe324d745f3225df4e17195486
2013-12-27cppcheck: reduce scopeJulien Nabet1-2/+1
Change-Id: If8220e82165d8ab85906584baa3827e3b6f5c2f4
2013-12-20typo fixesAndras Timar1-1/+1
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
2013-12-17Adapt all (non-extension, SharedLibrary) .components to environment="..."Stephan Bergmann1-2/+2
Change-Id: I56f38bd786f3a026cb2908f28540dc9c4003af83
2013-12-17Remove unnecessary use of OUString constructor in + expressionsNoel Grandin1-1/+1
Convert code like aFilename = OUString::number(nFilePostfixCount) + OUString(".bmp"); to aFilename = OUString::number(nFilePostfixCount) + ".bmp"; Change-Id: I03f513ad1c8ec8846b2afbdc67ab12525ed07e50
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin1-2/+2
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-11remove unnecessary use of OUString constructorNoel Grandin2-20/+15
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
2013-11-04remove redundant calls to OUString constructor in if expressionNoel Grandin1-2/+2
Convert code like: if( aStr == OUString("xxxx") ) to this: if( aStr == "xxxx" ) Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04remove redundant calls to OUString constructorNoel Grandin1-8/+7
Change code like this: aStr = OUString("xxxx"); into this: aStr = "xxxx"; Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-10-30fdo#54938: Convert svx to use cppu::supportsServiceMarcos Paulo de Souza1-13/+2
Change-Id: I3ab178924cb1c4240511f08625f244dac54e3913 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-29Related: fdo#70483 add regression testCaolán McNamara1-0/+0
Change-Id: I390cb550e050dc49ab6adee4f7ec57ef6744e57f
2013-10-29micro optimize this a bitCaolán McNamara1-3/+2
Change-Id: Ie7c36f95b9e594d6cda4c4371d51e79e6d387fd1
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist5-5/+5
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-16i123485 secured file import scanning existing pagesArmin Le Grand1-4/+12
(cherry picked from commit 04b38114b0ca4be9895d8f9fa842b6cb390c8036 and adapted to the rewritten scanBuildPageChainCache) Change-Id: Ib90d0563be5aeb69aa14c28b3304e42f3cc46162 Reviewed-on: https://gerrit.libreoffice.org/6272 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 23:05:28 +0000