summaryrefslogtreecommitdiff
path: root/sot
AgeCommit message (Collapse)AuthorFilesLines
2015-01-20Some more loplugin:cstylecast: sotStephan Bergmann2-10/+10
Change-Id: I7192a4d29937fc6222457a4a0f53db11e620fcdc
2015-01-16remove unnecessary parenthesesNoel Grandin4-7/+7
left over from "SVStream operator>> to Write method" conversion Change-Id: I619eb743d7890d5c70d0a94e51ce263567fa6f3b
2015-01-09override the overloading of "overload" to decrease cognitive (over-)loadMichael Stahl1-1/+1
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
2015-01-07fix windows buildNoel Grandin2-2/+2
and a handful of other currently uncompiled spots, after my commit 7f8f277b94704a289fbbd1b836e4e5d66311580d "fdo#84938: convert STREAM_ #defines to 'enum class'" Change-Id: I550f6fb850e1d71a6f08767eeb222a18071b89d5
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin11-134/+109
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-04boost::unordered_map->std::unordered_mapCaolán McNamara2-2/+5
Change-Id: I82f668ef72e916d2ff11df5cda2a02653999f66f
2014-12-30fdo#84229 - don't set error when seeking beyond end of valid data.Michael Meeks1-2/+13
XclImpStream and elsewhere does an initial seek to the end, then a tell to work out the true length of the stream. In order to let us attempt to rescue data from the beginning of otherwise corrupt / truncated streams, we should avoid setting an error here. Interestingly, we also (probably) don't want to return the true length of the valid data - as this is how SotStorage has worked historically. Change-Id: Ie0ff0e183220b81871ae3bf83980a24b57ac8694
2014-12-30fdo#84229 - add sot storage unit test.Michael Meeks2-0/+26
Change-Id: Ic11c397984602bf8a2e292bc901cd7bf71ad555d
2014-12-19java: reduce visibility of some methods and fieldsNoel Grandin1-1/+1
found by UCDetector Change-Id: I0a0a00d1fae1fed2e6aef198b7a1482d7e7e29f0
2014-12-18sot: Use appropriate OUString functions on string constantsStephan Bergmann2-7/+7
Change-Id: Id787ebbfaa95c29b3f6337286fa78b089038258e
2014-12-11java: reduce visibility of fields and methodsNoel Grandin2-5/+5
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: simplify the getMSF() methodsNoel Grandin1-2/+1
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3 Reviewed-on: https://gerrit.libreoffice.org/13406 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10java: remove some comment noiseNoel Grandin1-1/+1
Change-Id: I4d15a0e606f468346bc5d2f43af2e14bcc758e13 Reviewed-on: https://gerrit.libreoffice.org/13405 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl1-0/+1
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl5-0/+7
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini3-11/+11
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann1-1/+1
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin1-1/+1
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-01coverity#1247614 Unchecked return valueCaolán McNamara1-1/+6
Change-Id: I658a7f6c8410cfa38512bb45651e5332fbde3194
2014-10-17java: final fields that can be staticNoel Grandin1-2/+2
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-15sot: stop leaking temp files from StgTmpStrmMichael Stahl1-1/+1
The problem is that "aName" is stored as a file path, but osl_removeFile only works with URLs. Change-Id: I6929efc89a9e1a2292f038482b88d38946e6e4e8
2014-10-03rename SvRef::AddRef to AddFirstRefNoel Grandin3-9/+9
to make it's intended purpose clearly distinguishable from AddNextRef Change-Id: I5da780b48b19fd873667b648031bc394113f953b Reviewed-on: https://gerrit.libreoffice.org/11763 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-29loplugin: cstylecastNoel Grandin4-23/+25
Change-Id: I28443b688f8ab752162846e5cea661f26d269cad
2014-09-29loplugin: cstylecastNoel Grandin3-4/+4
Change-Id: I53b69a488c70769cbb841db519bc28fd211dc087
2014-09-26remove unnecessary casts in calls to SvStream.WriteUInt32Noel Grandin1-1/+1
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I1d848f19f82783e6eabf2da37dbde78fe36ea1e0
2014-09-26remove unnecessary casts in calls to SvStream.WriteInt32Noel Grandin3-14/+14
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I0c0172519479be0535a447e41a592fbf782751bd
2014-09-26remove unnecessary casts in calls to SvStream.WriteInt16Noel Grandin2-3/+3
left over from our conversion of the SvStream output operators to more specific methods Change-Id: Ie44bec6b988f3e46fe78d14b740818c9141f5df0
2014-09-26remove unnecessary casts in calls to SvStream.WriteUCharNoel Grandin2-2/+2
left over from our conversion of the SvStream output operators to more specific methods Change-Id: I2ea4c7d97e745b3e6a3834f41ac7bfefa4883c7a
2014-09-26cleanup GUID/ClsId/CLSID typesNoel Grandin3-26/+26
- rename GUID to SvGUID so we don't need an #ifdef WIN32 - drop ClsId struct, since it is used interchangeably with GUID and has the same structure Change-Id: Idf5c14c82a6861ef585fb57896a9b12cfe40374c
2014-09-15Clean up StorageMode parameter of SotStorage::OpenSotStorageStephan Bergmann1-3/+2
...which was only used to transport either STORAGE_TRANSACTED or sal_False (i.e., 0, meaning "not STORAGE_TRANSACTED"). Change-Id: I25a894262bbefdb6c0634309bccfb1e56dad7d88
2014-09-11create a master document template typeCaolán McNamara3-4/+3
of application/vnd.oasis.opendocument.text-master-template with suffic otm https://lists.oasis-open.org/archives/office-comment/201002/msg00042.html desktop/icons/oasis-master-document-template.icns is just a copy of desktop/icons/oasis-master-document.icns because I can't draw Change-Id: I0d18c79c4c893e97505052884ee8be97d0f117a1 Reviewed-on: https://gerrit.libreoffice.org/11350 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-08-19java: use Boolean.valueOf instead of instantiating Boolean objectsNoel Grandin1-1/+1
Change-Id: Ie41d6b0170a035a694dd270c311a137fd1810e74
2014-08-18ErrorBox->MessageDialogCaolán McNamara1-26/+2
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
2014-08-13update_pchThomas Arnhold1-0/+2
Change-Id: Ic1dae7aac2f4367b4196ba3128c0aea9be1fbbda
2014-08-12java: remove useless javadoc tagsNoel Grandin1-3/+0
that are not conveying any useful information Change-Id: Ic37934b8cc376fcdcb3d295232452f411dfd43b1
2014-08-06fdo#81835 Don't prefer GDI Metafiles to RTF/HTML -- correctly.Andrzej Hunt1-1/+1
Was first introduced by 538c13f3d1756f2d105115f64ab1bc0b7426eebc We should process clipboard formats in order of descriptive-/ usefulness -- however png/bmp are special cases (as browsers will add an html equivalent to their clipboard when copying raw images, with the raw image being the preferred target format) and were therefore moved up in the paste-preference list, mistakenly it was assumed that GDI Metafiles should be subject to the same treatment, but it appears that Word (and Wordpad?) will provide both RTF (preferred) and GDI for formatted text. Change-Id: I731986fc9d70e7aeb64e53764e32cfec3e27eca1
2014-08-06Revert "fdo#81835 Don't prefer GDI Metafiles to RTF/HTML"Andrzej Hunt1-1/+2
Accidentally removed GDI metafiles from calc too. This reverts commit a96a7ce51aa98fb9ee97ea3803e2b7e648611008.
2014-08-05fdo#81835 Don't prefer GDI Metafiles to RTF/HTMLAndrzej Hunt1-2/+1
Was first introduced by 538c13f3d1756f2d105115f64ab1bc0b7426eebc We should process clipboard formats in order of descriptive-/ usefulness -- however png/bmp are special cases (as browsers will add an html equivalent to their clipboard when copying raw images, with the raw image being the preferred target format) and were therefore moved up in the paste-preference list, mistakenly it was assumed that GDI Metafiles should be subject to the same treatment, but it appears that Word (and Wordpad?) will provide both RTF (preferred) and GDI for formatted text. Change-Id: I731986fc9d70e7aeb64e53764e32cfec3e27eca1
2014-08-05java: remove commented out codeNoel Grandin1-16/+0
Change-Id: I44e2043e5da23bc9421c03e550ef1d8b7ebaad36
2014-07-29Include <algorithm> for std::minTor Lillqvist1-0/+2
Change-Id: I6d73e4d732da36bcd446b1d10273d88d941b9c1a
2014-07-21coverity#707195 Uncaught exceptionCaolán McNamara1-10/+10
Change-Id: Idaeb36f01632cc91cc9fc3d5febd249e39e44ae2
2014-07-12Avoid possible memory leaks in case of exceptionsTakeshi Abe6-53/+46
Change-Id: Id0304366c4e6191db85527935f5bc5cdb0aeb8d8
2014-07-10use SimpleReferenceObject in StgPageNoel Grandin3-17/+5
to replace hand-rolled version Change-Id: I5301ef1df786b08b3c5d585a366d95722506f220
2014-07-07DBG_ASSERT->assert when followed by dereferenceCaolán McNamara1-6/+5
Change-Id: Ic1c999ffdc391ea01be5711721e7c9e63179473e
2014-07-01clang scan-build: various warningsCaolán McNamara1-1/+2
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-06-26OSL_ENSURE->assertCaolán McNamara1-1/+1
Change-Id: Ib8ba49e89d03eaf3b3aae94dbbf121898ba9e8de
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin3-9/+1
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-04update_pch: add a bunch of pch filesThomas Arnhold3-0/+108
connectivity: 3m52s -> 2m47s cppcanvas: 28s -> 13s cppuhelper: 20s -> 14s dbaccess: 2m38s -> 2m01s hwpfilter: 16s -> 13s sot: 21s -> 16s Change-Id: I49286bfe6be73dd1b861be632b95e17a99e82f8a
2014-05-28fdo#78801 fdo#52547 Paste preference is image, then html, then text.Andrzej Hunt1-18/+18
c47db038f98aaf7aec3cbe57c4e5683591afa23e was an attempt to fix fdo#52547, i.e. to make sure that the actual image data was stored if an image was being pasted from a browser (where the clipboard contains both image data, but also an html construct which would instead embed the image from the web). However the new ordering inadvertently meant that strings would be preferred to html -- i.e. copying a mixture of text+image from a webpage would result in only the text being stored. The new ordering causes images copied from the browser to still have the actual image data stored (rather than a link in the case of the html being stored), but html is still preferred to plaint text. (This is primarily as a result of Firefox (and possibly other browsers) changing their clipboard to contain an html construct which links to the original image, in addition to the raw image data-- and html previously being preferred to images in the paste ordering meant that the linked version would be pasted by default, which is not the expected result when copying an image.) Change-Id: Ice9b37cf3dd25d8cdb0e04f19a6b2f3661018564
2014-05-28Avoid undefined signed integer overflowStephan Bergmann1-7/+2
Change-Id: Idbb8109c36dfe1c8ed4acb8dff1a1538e386abd8
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-29 04:05:07 +0000