summaryrefslogtreecommitdiff
path: root/sot
AgeCommit message (Collapse)AuthorFilesLines
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin1-13/+0
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13convert EXCHG_OUT_ACTION_FLAG to scoped enumNoel Grandin1-904/+915
and split it off into its own field and parameter Change-Id: Ib13dea5e9475a74cd66a0da4e5ec50a51fbda9d5 Reviewed-on: https://gerrit.libreoffice.org/24926 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11clang-tidy modernize-loop-convert in scripting to svtoolsNoel Grandin3-22/+17
Change-Id: I98229d14109cf243839d632feabde1391ea9bad5 Reviewed-on: https://gerrit.libreoffice.org/24847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-04use Any constructor instead of temporariesNoel Grandin1-12/+4
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-04-30Fix typosAndrea Gelmini1-1/+1
Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73 Reviewed-on: https://gerrit.libreoffice.org/24317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin1-2/+2
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke1-2/+2
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin1-1/+1
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-13tdf#94306 replace boost::noncopyable in sfx2 to sotJochen Nitschke1-2/+3
Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Add missing default ctors. Make some overloaded ctors explicit, seems cppcheck doesn't flag: T(const template<X>& rx). Change-Id: I63c5a3ac84a33ea6d49868e2d9aa281ada79958e Reviewed-on: https://gerrit.libreoffice.org/24050 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-11cppcheck: silence warnings assertWithSideEffectJochen Nitschke1-4/+4
Mark some class methods as pure. warnings look like this: > dbaccess/source/core/api/RowSetBase.cxx > 593 assertWithSideEffect 398 warning Assert statement calls > a function which may have desired side effects: 'isAfterLast'. Change-Id: I1b69340c3714be4678b599fa9a8ca933122aa857 Reviewed-on: https://gerrit.libreoffice.org/23981 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04loplugin:constantparam in sotNoel Grandin1-10/+10
Change-Id: I8bf1ee672f035831d197e4a65bd40bae41278da0 Reviewed-on: https://gerrit.libreoffice.org/23800 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04remove some unnecessary realloc'ingNoel Grandin2-4/+3
Change-Id: If3ba03d5928d3c8267ab14e26e5a5afbc37afef5 Reviewed-on: https://gerrit.libreoffice.org/23756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17loplugin:constantparam in sotNoel Grandin6-26/+24
Change-Id: I380b5a824b1bc8cd322471519d2d87ab7f2bca1c Reviewed-on: https://gerrit.libreoffice.org/23320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-11tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar1-10/+9
I removed OSL_DEBUG_LEVEL > 1 conditionals and replaced them with OSL_DEBUG_LEVEL > 0 as suggested in easy hack Change-Id: I6495bf203365356e0969a057f5238c2343931d2b Reviewed-on: https://gerrit.libreoffice.org/23061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-10tdf#97591: mark RTF clipboard format as text/rtfOliver Specht1-1/+1
text/rtf replaces text/richtext which is not RTF Change-Id: I2be750b595ba23ed75698b68c0d4ffd8f3a12870 Reviewed-on: https://gerrit.libreoffice.org/23086 Reviewed-by: Oliver Specht <oliver.specht@cib.de> Tested-by: Oliver Specht <oliver.specht@cib.de>
2016-03-10Extract Directories from BootstrapFixtureBaseStephan Bergmann1-2/+2
(as some tests derive from the latter only for the Directories part, not for the setUp/tearDown overrides: those tests will be cleaned up next) Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f Reviewed-on: https://gerrit.libreoffice.org/23078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-07tdf#97499 Remove some Default arguments in unordered containerJaskaran1-2/+1
Change-Id: Ic008e244b8ae1888fa45379371f5525ee77f6087 Reviewed-on: https://gerrit.libreoffice.org/22887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-03-07improve defaultparams lopluginNoel Grandin1-2/+1
to catch calling params with defaults like "= OUSString()" Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9 Reviewed-on: https://gerrit.libreoffice.org/22932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-01loplugin:unuseddefaultparam in sotNoel Grandin2-3/+3
Change-Id: I36f88f060377fa754d4a47956932d73c47d14ece
2016-02-23new loplugin: commaoperatorNoel Grandin6-19/+76
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-17use consistent #define checks for the Windows platformNoel Grandin2-2/+2
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09Remove excess newlinesChris Sherlock3-12/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-05Fix typosAndrea Gelmini1-1/+1
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-02-02boost::hash->std::hashNoel Grandin1-2/+2
Change-Id: If4d1e4071995f07212fad958b0226d5824d168f8 Reviewed-on: https://gerrit.libreoffice.org/21989 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin2-3/+4
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-19sot: accept JPEG as a clipboard format where we accept PNG alreadyMiklos Vajna2-0/+43
Change-Id: I64602d31e8aa873e2280f86eaf618dd6007acaf1
2016-01-18loplugin: unused return valuesNoel Grandin1-8/+3
Change-Id: I9c61a46c57894bc63a57740206c0bcb4a16553af Reviewed-on: https://gerrit.libreoffice.org/21571 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-14loplugin:unusedmethods unused return value in sotNoel Grandin3-18/+10
Change-Id: Icb5382a411a1cb035581f0cef5f6fae60bfb4940
2016-01-13loplugin:unusedmethods unused return value in include/sotNoel Grandin3-18/+10
Change-Id: I8da6d5f60b6c65ff0da8659045da1cd7666fb1d9
2016-01-10Fix typosAndrea Gelmini2-2/+2
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-05tdf#74608: Ctor function for css.embed.OLESimpleStorageMatúš Kukan5-249/+114
Change-Id: I20b91ad65514e27094ff702d1d94a48ef9a82fe6
2016-01-05SotFactory is in fact not used: remove + cleanupMatúš Kukan7-430/+28
Also SotData_Impl is used only in exchange.cxx now. Move there. Change-Id: I548095c2226d92aea4193bb1a3671e2381996435
2016-01-05Make SotFactory private to sot/ and clean a bitMatúš Kukan6-13/+127
Change-Id: Ia683280a3e95eee995e036db6bde5d28852f92ff
2015-11-26mark UNO structs as SAL_WARN_UNUSED, where possibleNoel Grandin1-1/+0
Change-Id: Ie3de518f60c9f1313c68df54dbdc1fb2804f1f0d
2015-11-25loplugin:unusedfields in include/sot,include/svl,include/svtoolsNoel Grandin1-1/+0
Change-Id: Ia2dd13c2c48b127ab85311a668fa1f37608d360a
2015-11-23loplugin:unusedfields in sot/Noel Grandin1-4/+0
Change-Id: Ia1711d9289992525ed366f3dedcf95b6289f1eaa
2015-11-17Add SvStream::ReadUtf16 (don't assume sal_Unicode is unsigned short)Stephan Bergmann2-2/+2
Change-Id: I74f34e3389582617fa83f8f4a3d6867cf87189e1
2015-11-16use initialiser list for Sequence<OUString>Noel Grandin1-2/+1
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02 Reviewed-on: https://gerrit.libreoffice.org/19978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15Fast PCH generator and optimized PCH filesAshod Nakashian1-66/+52
Ported update_pch.sh to Python with improved performance and features. The new script is invoked from the same update_pch.sh which calls it for each library in parallel, although it can be invoked directly. The ported script (update_pch) updates all PCH files in ~15 seconds where the old script took ~4500 seconds. In addition, the new script supports 3-tiered headers (system, module, and local) and is very flexible to support other improvement. It has a per-library optimal configuration settings that can be updated using another new scripts (update_pch_autotune.sh) which finds optimal per-PCH settings. PCH files have been generated using the new scripts which builds significantly faster (2-3x, depending on module and configuration) and the intermediate binaries are noticably smaller (by several GBs). The new script stamps each generated PCH file with the command that generated it to make it trivial for users to update them, and also adds the command to invoke another script (update_pch_bisect) that helps find missing headers or conflicting headers that may break the build after updating the PCH. Finally update_pch has built-in unit-tests for makefile parsing and other core functionality. Change-Id: Ib933b50e50374d7e2e7e3e95ba8799b0cc8a27fa Reviewed-on: https://gerrit.libreoffice.org/19965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-15use initialiser syntax for Sequence<OUString>Noel Grandin1-2/+1
replaced using the script: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence< OUString > (\w+)\(1\); .*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g" Change-Id: I23688a91562051a8eed11fc2a85599545c285c34 Reviewed-on: https://gerrit.libreoffice.org/19967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-115th step to remove tools/rtti.hxxOliver Specht4-9/+0
tools/rtti.hxx removed completed the interface of some Sdr.* Items and removed pseudo items Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a Reviewed-on: https://gerrit.libreoffice.org/19837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-10Missing includesAshod Nakashian4-4/+44
Restored some missing includes and refactored sot/formats.hxx. Change-Id: I11b7102b06889f426f5e0f3efa3a835c6e774d88 Reviewed-on: https://gerrit.libreoffice.org/19891 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann14-136/+136
Change-Id: I147f1ca886d5194d0e7180c427923225ef4ef927
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann2-8/+8
Change-Id: I7b5b2a21182d0b841a6104f2dddb16c13abb32f4
2015-11-05use uno::Reference::set method instead of assignmentNoel Grandin1-2/+2
Change-Id: Ib93d762cf523e0029bbed16e08beebd9f418ae24
2015-11-04yyyyyNoel Grandin1-3/+2
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-10-30UNO: no need to use OUString constructor when calling createInstanceNoel Grandin1-1/+1
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526 Reviewed-on: https://gerrit.libreoffice.org/19682 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-29com::sun::star->css in smoketest,sotNoel Grandin6-96/+96
Change-Id: I59a083cd53baa76ea271cfc0470487899b92dca4 Reviewed-on: https://gerrit.libreoffice.org/19666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-27sal_uLong to sal_uInt64/sal_SizeMatteo Casalin2-13/+11
Change-Id: I4032b08225f1b530a43f1a8c09c5fc3515f45ced
2015-10-27Fix StgTmpStrm::GetSizeStephan Bergmann1-3/+3
Change-Id: I49891d6c2149154c4fd524f79f3cbda17568fa7e