summaryrefslogtreecommitdiff
path: root/sot/source/sdstor/storage.cxx
AgeCommit message (Collapse)AuthorFilesLines
2017-12-18convert DecodeMechanism to scoped enumNoel Grandin1-2/+2
(cherry picked from commit bfde4866e07746eafa2f0d6173c29d805cc35ad0) (cherry picked from commit 3de922d4a695e253d4ca2d42b70e0b35b52e9b7c) Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-11-21loplugin:countusersofdefaultparams in include/sot..svlNoel Grandin1-3/+3
Change-Id: Idb022a4a6fb950f1b259abbba57daed9401732d9 Reviewed-on: https://gerrit.libreoffice.org/31038 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-18includes should be at the top of the fileNoel Grandin1-3/+3
not randomly scattered through the code found with something like: git ls-files *.cpp | xargs grep -Pzl "(?s){.*#include" Change-Id: I9c242fa4ef99e8677f2800d7ec9f16d16e488351 Reviewed-on: https://gerrit.libreoffice.org/30952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-10tdf#89307: Removed SvRef::operator T*()Jacek Fraczek1-2/+2
Conditional statements are using SvRef::Is() method. Changed static_cast<T*>(svRef<T>) occurances to svRef.get(). Added operator == and != to SvRef. SbxObject::Execute is using SbxVariableRef internally. SbxObject::FindQualified is using SbxVariableRef internally. Change-Id: I45b553e35d8fca9bf71163e6eefc60802a066395 Reviewed-on: https://gerrit.libreoffice.org/29621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl1-4/+4
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke1-1/+1
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-28loplugin:singlevalfields in variousNoel Grandin1-17/+0
Change-Id: Ia0d8f463a4dba9ec63aa0159441e3e607dd3bf5e Reviewed-on: https://gerrit.libreoffice.org/26738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-06tools: rename SvStream::Read/Write to ReadBytes/WriteBytesMichael Stahl1-2/+2
Change-Id: Ib788a30d413436aa03f813aa2fddcbc4d6cd2f9a Reviewed-on: https://gerrit.libreoffice.org/25972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin1-13/+0
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04loplugin:constantparam in sotNoel Grandin1-10/+10
Change-Id: I8bf1ee672f035831d197e4a65bd40bae41278da0 Reviewed-on: https://gerrit.libreoffice.org/23800 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-17loplugin:constantparam in sotNoel Grandin1-2/+2
Change-Id: I380b5a824b1bc8cd322471519d2d87ab7f2bca1c Reviewed-on: https://gerrit.libreoffice.org/23320 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-13loplugin:unusedmethods unused return value in include/sotNoel Grandin1-2/+1
Change-Id: I8da6d5f60b6c65ff0da8659045da1cd7666fb1d9
2016-01-05SotFactory is in fact not used: remove + cleanupMatúš Kukan1-70/+0
Also SotData_Impl is used only in exchange.cxx now. Move there. Change-Id: I548095c2226d92aea4193bb1a3671e2381996435
2016-01-05Make SotFactory private to sot/ and clean a bitMatúš Kukan1-4/+8
Change-Id: Ia683280a3e95eee995e036db6bde5d28852f92ff
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann1-12/+12
Change-Id: I147f1ca886d5194d0e7180c427923225ef4ef927
2015-11-04yyyyyNoel Grandin1-3/+2
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-10-29com::sun::star->css in smoketest,sotNoel Grandin1-5/+5
Change-Id: I59a083cd53baa76ea271cfc0470487899b92dca4 Reviewed-on: https://gerrit.libreoffice.org/19666 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-27sal_uLong/long to ErrCodeMatteo Casalin1-1/+1
Change-Id: I2ba2d867785765e4850c60070e86419f66e25f57
2015-10-19loplugin:defaultparamsStephan Bergmann1-1/+1
Change-Id: I84dd06c86c811914acc8688877dfaf3b6c0ba60b
2015-10-06 tdf#94559: 4th step to remove rtti.hxxOliver Specht1-2/+2
replaced use of PTR_CAST, IS_TYPE, ISA in idl, editeng, sc, sd, sw, sfx2, sot, starmath Change-Id: I4a5bba4fdc4829099618c09b690c83f876a3d653 Reviewed-on: https://gerrit.libreoffice.org/19132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-09-17boost->stdCaolán McNamara1-2/+1
Change-Id: Ifde84627578283bd057d7393eb7e5578ef5c029a
2015-09-13cppcheck: noExplicitConstructorCaolán McNamara1-8/+8
Change-Id: I39194062ba68c4cb1ccc9b93c629f005ccd02497
2015-08-19Clean up remaining utl::LocalFileHelper::Convert...Stephan Bergmann1-3/+2
together with 58d68a1bc9146334376206ae7ba8b1a6594a1040 "ConvertURLToSystemPath->getSystemPathFromFileURL" and 28f3464a571a23a2c16bd0980e9021b95d011511 "ConvertSystemPathToURL->getFileURLFromSystemPath," this replaces all those Convert... functionality with direct calls to the corresponding osl::FileBase functions. Change-Id: I2876171cd337a5eb939d25d8cf1e0c1253ff73a7
2015-08-05loplugin:unusedmethodsNoel Grandin1-20/+0
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba Reviewed-on: https://gerrit.libreoffice.org/17506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03-Werror,-Wunused-private-fieldStephan Bergmann1-10/+6
Change-Id: I59979f84602276c9a8aa1ffc1d145c1ef8f0a31f
2015-07-31tools: prefix members of SvStreamMichael Stahl1-6/+6
Change-Id: Iba845749d645bc1cf9eb6d6c41829717831bc487
2015-07-30loplugin:unusedmethodsNoel Grandin1-11/+11
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971 Reviewed-on: https://gerrit.libreoffice.org/17378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-06loplugin:unusedmethods sotNoel Grandin1-10/+0
Change-Id: I14e8bb3e4e38ade1044ce1c50c9676a65152724c Reviewed-on: https://gerrit.libreoffice.org/16733 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-03expand out some sot macrosNoel Grandin1-6/+74
Change-Id: Ic583fe767e5f85628f8270ec740ce3e72fe56ded Reviewed-on: https://gerrit.libreoffice.org/16722 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-29remove custom RTTI from SotFactoryNoel Grandin1-4/+0
unused Change-Id: I22f55aa403cd97ce2c5bf6a521c14a693e4373a7
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe1-2/+2
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-05-07Reduce enum class StorageMode to bool transactedStephan Bergmann1-10/+10
Change-Id: I04e53d7de9f2f26e9338a82f7d5ae5dab1682712
2015-05-07StorageMode::DiskspannedMode is effectively unusedStephan Bergmann1-4/+0
Change-Id: I977b0a51a609d3cbc30abd308715f91cad2cfdfa
2015-05-07StorageMode::CreateUnpacked is never usedStephan Bergmann1-55/+36
Change-Id: I7285c90c82b04e3ebb2db371b675689de9c183d7
2015-05-07SotStorage ctor nStorageMode param is effectively only used as bool transactedStephan Bergmann1-2/+2
Change-Id: I3458ae46c256206e31ad268f47e8b92a30f3738e
2015-05-07Remove unused SotStorage ctor nStorageMode paramStephan Bergmann1-2/+2
Change-Id: I6af399ef26d3f3ee97a49592cf97c590c0781eb0
2015-05-07Remove unused SotStorage::OpenSotStream nStorageMode paramStephan Bergmann1-5/+2
Change-Id: Ieda14d984f1614056c701a50ce637ea6fe9620f3
2015-05-07Remove unused SotStorageStream ctor nStorageMode paramStephan Bergmann1-8/+1
Change-Id: I5f114f4ca92d991d17ad871d11a78a5306191f9c
2015-05-07Unwind SotStorageRef typedefStephan Bergmann1-1/+1
Change-Id: I8d5363bb2ad813ef29b4078848914f4b0989b9f1
2015-05-07Turn StorageMode into a scoped enumStephan Bergmann1-12/+12
Change-Id: I481c153815fff793e9334153d863f26982b879cb
2015-04-24loplugin:simplifyboolStephan Bergmann1-8/+8
Change-Id: If2d2970160803bcaa1feabb8274f83bba0ba722c
2015-04-02Change INetProtocol enumerators to CamelCaseStephan Bergmann1-2/+2
...to avoid clashes with macros and poor warnings about hiding global FILE Change-Id: I444e8b958f029201b228937e088efabc4b6d3050
2015-04-02Change INetProtocol to scoped enumerationStephan Bergmann1-2/+2
...and fix o3tl::enumarray::operator [] const overload Change-Id: I749b1b9d68686b03a97074253478d9d2d9d32b0b
2015-03-28Clean up C-style casts from pointers to voidStephan Bergmann1-2/+2
Change-Id: I1d157bfc82f09f2438e59eca4fcd92931ca38723
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann1-3/+3
Change-Id: Ib6842b6215ff70a31299d1410ed66c3ea34e7c78
2015-03-18create new 'enum class' SotClipboardFormatId to unify typesNoel Grandin1-30/+31
of which there are several. There are some issues here I am unsure of - the SW and SC and CHART2 modules essentially ignore the enum values and assign their own ids Perhaps I should change them to use the common values and create new enum values where necessary? - the sc/qa/ and sq/qa/ and starmath/qa/ code was doing some dodgy stuff. I translated the code to pass down the stuff numeric values to the underlying code, but perhaps further fixing is necessary? Change-Id: Ic06d723e404481e3f1bca67c43b70321b764d923
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara1-84/+0
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin1-11/+11
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2014-09-15Clean up StorageMode parameter of SotStorage::OpenSotStorageStephan Bergmann1-3/+2
...which was only used to transport either STORAGE_TRANSACTED or sal_False (i.e., 0, meaning "not STORAGE_TRANSACTED"). Change-Id: I25a894262bbefdb6c0634309bccfb1e56dad7d88
2014-09-11create a master document template typeCaolán McNamara1-0/+1
of application/vnd.oasis.opendocument.text-master-template with suffic otm https://lists.oasis-open.org/archives/office-comment/201002/msg00042.html desktop/icons/oasis-master-document-template.icns is just a copy of desktop/icons/oasis-master-document.icns because I can't draw Change-Id: I0d18c79c4c893e97505052884ee8be97d0f117a1 Reviewed-on: https://gerrit.libreoffice.org/11350 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>