summaryrefslogtreecommitdiff
path: root/soltools
AgeCommit message (Collapse)AuthorFilesLines
2018-03-07Deduplicate includesMike Kaganski1-1/+0
Change-Id: I16a77d0701b42bcf9d751834f0eae4decedd9176 Reviewed-on: https://gerrit.libreoffice.org/50858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-25Fix typosAndrea Gelmini1-1/+1
Change-Id: Ieef0e3f21eb12cb5b72d39da4bc0a8c60dd0d5ce Reviewed-on: https://gerrit.libreoffice.org/48545 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-12tdf#114952 filep is still used in soltools/mkdepend/parse.cNoel Grandin1-5/+5
regression from commit 18f513145477d4621290253d936dad7a40ee4c05 Date: Tue Jun 20 19:54:23 2017 +0200 loplugin:unusedfields store..svl somewhat tricky to reproduce on linux, I had to do make soltools CPPFLAGS=-DDEBUG Change-Id: I4b1989efc02b9e864432b96cf4f71a29e581bcdb Reviewed-on: https://gerrit.libreoffice.org/47755 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-07loplugin:constparamsNoel Grandin2-3/+3
Change-Id: Ia322ecf8f80b28c58ec33d17ca9607401a92534b Reviewed-on: https://gerrit.libreoffice.org/45959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-24loplugin:includeform: soltools (macOS)Stephan Bergmann2-2/+2
Change-Id: I7e2a8d13e068f651bf6e8fbbb66363a4b2b5b0e7
2017-09-25Translate German comments and debug strings (leftovers)Johnny_M1-2/+2
Additionally: - A few grammatical fixes Change-Id: I15ba3809f6b4746be5a691ec2adc0ea17730fa4a Reviewed-on: https://gerrit.libreoffice.org/42690 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-09-18Use even more WIN32_LEAN_AND_MEANMike Kaganski1-0/+3
Change-Id: I538fe5b41156366e0e87b3a93e58a3947afd18f5 Reviewed-on: https://gerrit.libreoffice.org/42398 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-08-29remove some unused macro definitionsNoel Grandin1-5/+0
Change-Id: I253e5108161b932e3dc588b656e550bb9dc022b0 Reviewed-on: https://gerrit.libreoffice.org/41672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-21Make cpp cope with long source linesStephan Bergmann1-1/+1
under --with-lang=ALL it had started to crash during e.g. > LD_LIBRARY_PATH=${LD_LIBRARY_PATH:+$LD_LIBRARY_PATH:}".../instdir/program:.../instdir/program" .../workdir/LinkTarget/Executable/cpp -+ -P -DWITH_POSTGRESQL_SDBC -DWITH_FIREBIRD_SDBC -DWITHOUT_EXTENSION_MEDIAWIKI -DWITHOUT_SCRIPTING_BEANSHELL -DWITHOUT_SCRIPTING_JAVASCRIPT -DWITH_HELPPACK_INTEGRATION -DWITH_EXTENSION_INTEGRATION -DENABLE_EXTENSION_UPDATE -DX86_64 -DLINUX -D_PTHREADS -DUNIX -DUNX -DCOMID=gcc3 -D_gcc3 -DWITH_LPSOLVER -I.../scp2/inc -I.../workdir -I.../config_host -I.../workdir/CustomTarget/scp2/macros -I.../workdir/ScpTemplateTarget/scp2/source/templates .../scp2/source/calc/file_calc.scp > .../workdir/ScpPreprocessTarget/scp2/source/calc/file_calc.pre because of > Syscall param read(buf) points to unaddressable byte(s) > at 0x4F31A80: __read_nocancel (syscall-template.S:84) > by 0x404F98: fillbuf (_lex.c:631) > by 0x404CCF: gettokens (_lex.c:479) > by 0x400F0A: process (_cpp.c:77) > by 0x400E80: main (_cpp.c:60) > Address 0x5278494 is 0 bytes after a block of size 32,772 alloc'd > at 0x4C2DB9D: malloc (vg_replace_malloc.c:299) > by 0x402034: domalloc (_cpp.c:321) > by 0x40554F: setsource (_lex.c:679) > by 0x403E38: doinclude (_include.c:130) > by 0x401F9D: control (_cpp.c:297) > by 0x401002: process (_cpp.c:101) > by 0x400E80: main (_cpp.c:60) There appears to be no other check that fillbuf doesn't overflow the Source's input buffer, other than gettokens checking that the buffer isn't more than three quarters full ("if (ip >= s->inb + (3 * INS / 4)) ..."). That smells like cpp assumes input lines to be shorter than some maximum number of characters (like the C99 standard setting a minimum limit of "4095 characters in logical source lines"), and > #define README_TXT_ALL_LANG(key, name, ext) \ > key (af) = READMETXTFILENAME(name,_af,ext); \ > Name (am) = CONFIGLANGFILENAME(name,am,ext); \ > Name (ar) = CONFIGLANGFILENAME(name,ar,ext); \ [...] > Name (zh-CN) = CONFIGLANGFILENAME(name,zh-CN,ext); \ > Name (zh-TW) = CONFIGLANGFILENAME(name,zh-TW,ext); \ > key (zu) = READMETXTFILENAME(name,_zu,ext) in workdir/CustomTarget/scp2/macros/langmacros.inc (which appears to be the culprit here) exceeding that limit under --with-lang=ALL. So just bump the input buffer size. Change-Id: I5d863050fb772dc7e691a604009ff8702dc718e3
2017-08-14new loplugin:droplongNoel Grandin2-4/+4
The types 'long' and 'unsigned long' are different sizes on different platforms, making them wholy unsuitable for portable code. And when I mean different sizes, I mean 64bit Linux and 64bit Windows have different bit sizes. Change-Id: Id4d8cd709bf71a3f85ed6515fae2b0a21ae8c25d Reviewed-on: https://gerrit.libreoffice.org/41130 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-10tdf#39468: Translate some german commentsChristian Barth1-1/+2
Change-Id: Ie9062738de26b44394d4c91b31fab99a7777813f Signed-off-by: Christian Barth <Christian.Barth@zoho.com> Reviewed-on: https://gerrit.libreoffice.org/40994 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-07-21loplugin:constparams in soltools and variousNoel Grandin12-38/+38
Change-Id: I5e8e4a9a31aa7c3ff54cc7ce137d08770ea297e1 Reviewed-on: https://gerrit.libreoffice.org/40279 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06Translate German comments/debug strings (leftovers in dirs sdext to soltools)Johnny_M1-5/+4
Translates leftovers found using a custom regex and manually checking the rest of the affected file. Additionally: - Translation of someone's attempts at Spanish in the .java file Change-Id: Ie3a761bc1a8e302247d5dd6e93a6bc4cb3e85a9f Reviewed-on: https://gerrit.libreoffice.org/39609 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-07-03loplugin:unusedfields in slideshow..svtoolsNoel Grandin7-11/+7
Change-Id: I74d5a4b8cfc4b18267f99648a3112b163c91fd8c Reviewed-on: https://gerrit.libreoffice.org/39474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-21loplugin:unusedfields store..svlNoel Grandin5-27/+11
Change-Id: I6070a683e5128271b84a10caccb548d07c950927 Reviewed-on: https://gerrit.libreoffice.org/39021 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-23Remove unused #include <ctype.h>Stephan Bergmann3-1/+4
Change-Id: I8bf3e30687e20151a9e1936e69362abfe9b3a99d
2017-03-22Fix passing plain char into ctype.h is* functionsStephan Bergmann4-11/+11
Change-Id: I4de56462e1fe5bba3035fec691feda91be88b434
2017-03-22Prevent calls to rtl/character.hxx functions with (signed) char argumentsStephan Bergmann1-2/+10
...that would implicitly be sign extended (for plain char only if it is signed), so non-ASCII char values would trigger the isUnicodeCodePoint assert. Change-Id: Iaf8024ad509e64525558e882fe3fd078cfb4ea91 Reviewed-on: https://gerrit.libreoffice.org/35523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-19fix typo/grammar: "the the" --> thedennisroczek1-1/+1
* also removing pointless ASCII art (tdf#62475) * truncate ending whitespace in Doxyfile Change-Id: I59b012f41ac0d170216229da85a49aa41689dee5 Reviewed-on: https://gerrit.libreoffice.org/35151 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-06drop various _MSC_VER < 1900 conditionalsCaolán McNamara1-1/+1
Change-Id: I68d93b260db1f542bb3b44858b61b2d30ae93530 Reviewed-on: https://gerrit.libreoffice.org/34856 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-26-Werror=implicit-fallthrough= (GCC 7)Stephan Bergmann2-1/+3
Change-Id: I2e9ab956fc1e59d09b7409333f18230e34b6a9b7
2017-01-09loplugin:externvarStephan Bergmann10-23/+31
Change-Id: I304144c0ae6b51656ad326a77e9402cc34d5aa18
2016-06-23tdf#99589 - tolower / toupper - dangerous to Turks ...Gökhan Gurbetoğlu1-2/+3
Change-Id: I8b0fe9354232a7b60f3605fa6f90f6741f7bf683 Reviewed-on: https://gerrit.libreoffice.org/26537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-10Drop redundant parenthesis.Pedro Giffuni1-4/+4
Found with coccinelle: http://coccinelle.lip6.fr/ Currently only applied to C code. (cherry picked from commit aaf15142bcbc44f0e06a3357d2b21ecf9c673d21) Change-Id: I7d43b024752ebd47e84e2e51028f8fd132410800
2016-03-10Avoid reserved identifierStephan Bergmann1-4/+4
Change-Id: I3df7e42b69e3900eae8d10d28a97d776fabd9f4b
2016-03-10Avoid reserved identifiersStephan Bergmann1-14/+14
Change-Id: Ifa0efa673cd60eb7bd668b72b4550da6025ffd1e
2016-03-04-Werror,-WundefStephan Bergmann1-1/+1
For MSVC/clang-cl: "__STDC__: Indicates conformance with the ANSI/ISO C99 tandard. Defined as the integer literal constant 1 only if the /Za compiler option is given and you are not compiling C++ code; otherwise is undefined." (<https://msdn.microsoft.com/en-us/library/b0084kay.aspx>) Presumably fine to just replace #if with #ifdef here (as is used in all the other cases surrounding it), and not care whether it actually expands to true. Change-Id: Ie58c76d7e72321b06a11a370fd28221e85fcf871
2016-03-04-Werror,-Wunused-macrosStephan Bergmann2-6/+0
Whatever those _POSIX_ for _MSV_VER were supposed to be good for (have been in there at least ever since 4f4b74153d27a9579c49b225b2690e7f9416fe78 "Moved cpp from cpp to soltools"), but cause -Wunused-macros at least when building with clang-cl. Change-Id: I356bf663cd1e86298ba72a179f46bb9d0c10016b
2016-02-23new loplugin: commaoperatorNoel Grandin1-3/+6
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-17use consistent #define checks for the Windows platformNoel Grandin4-6/+6
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-16use consistent #define checks for the Windows platformNoel Grandin4-8/+8
stage 1 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro Change-Id: Iece73abdee530937e0737190b1aa97a46cd3075f Reviewed-on: https://gerrit.libreoffice.org/22390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-26-Werror,-Wunused-parameter (clang-cl)Stephan Bergmann1-0/+2
Change-Id: I1ac58714e04b995ef5229888f0c427104c001318
2016-01-10Fix typosAndrea Gelmini2-2/+2
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-11-23loplugin:unusedfields in soltools/Noel Grandin1-1/+0
Change-Id: I895a487b4c7be27fe81a2c4c122adb2aba37c638
2015-11-10loplugin:nullptr (automatic rewrite; Mac-specific code)Stephan Bergmann1-2/+2
Change-Id: Ib52f7fb846886dd970ddd51475f890cd81c8f2b5
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann4-8/+8
Change-Id: I3ae78d781e686bfe9b0513183da7fc8edd81024b
2015-10-02loplugin:unusedmethodsNoel Grandin1-1/+0
Change-Id: Ie1603adf3908fd0668bcbe8f75c6bafa0d0bfd6c Reviewed-on: https://gerrit.libreoffice.org/19072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-30Fix typosAndrea Gelmini2-9/+7
Change-Id: I89ff6d31662824d83961d6457b82db8d8031168c Reviewed-on: https://gerrit.libreoffice.org/18977 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-07-04Fix typosAndrea Gelmini3-3/+3
Change-Id: Ic6415423f46aaee7ba90239a617c318cf92ae222 Reviewed-on: https://gerrit.libreoffice.org/16711 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-16-fsanitize=nonnull-attributeStephan Bergmann1-1/+2
Change-Id: Id214fb1f0decd4d39684a846c06ff97d8baa209d
2015-04-02loplugin:staticmethodsNoel Grandin1-3/+3
Change-Id: I1f6c6d13697aa397067478d6b07429120106e6bd
2015-03-02V804: Decreased performanceCaolán McNamara1-1/+2
Change-Id: I6430442cc407e02810d849cf60833abe7c7d2830
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin4-32/+32
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-01-08brute-force find-and-remove of unused #define constants.Noel Grandin1-1/+0
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2014-12-09warning C4267: conversion from 'size_t' to 'int' (MSVC 64-bit)Stephan Bergmann1-1/+1
Change-Id: Ife7d223f5e751e246c537561d3ce24395b4c9f3b
2014-12-09warning C4267: conversion from 'size_t' to 'int' (MSVC 64-bit)Stephan Bergmann3-8/+8
Change-Id: I2fa40ebe467a65b0d6023883a14c79ff4303bb2f
2014-11-06coverity#1000834 Use of untrusted string valueCaolán McNamara1-0/+1
and coverity#706196 Use of untrusted string value coverity#1244947 Use of untrusted string value Change-Id: I5083aba2eff9e852a24513db431585922302b279
2014-10-28coverity#982185 silence Unchecked return value from libraryCaolán McNamara1-2/+2
and coverity#982184 Unchecked return value from library Change-Id: I4b4ba39abc4c008b68cfc1498ee56ac9c4934c98
2014-10-04coverity#706158 Copy into fixed size bufferNorbert Thiebaud1-5/+24
Change-Id: I5d540e6e3a21b0563febb70696882439a10b9b86
2014-10-02coverity#1233618 Overlapping buffer in memory copyCaolán McNamara1-1/+1
Change-Id: I062dd96bfc4abf2bdaec2c17d1cf57d853d655d8
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 17:38:01 +0000