summaryrefslogtreecommitdiff
path: root/soltools
AgeCommit message (Collapse)AuthorFilesLines
2016-04-10Drop redundant parenthesis.Pedro Giffuni1-4/+4
Found with coccinelle: http://coccinelle.lip6.fr/ Currently only applied to C code. (cherry picked from commit aaf15142bcbc44f0e06a3357d2b21ecf9c673d21) Change-Id: I7d43b024752ebd47e84e2e51028f8fd132410800
2016-03-10Avoid reserved identifierStephan Bergmann1-4/+4
Change-Id: I3df7e42b69e3900eae8d10d28a97d776fabd9f4b
2016-03-10Avoid reserved identifiersStephan Bergmann1-14/+14
Change-Id: Ifa0efa673cd60eb7bd668b72b4550da6025ffd1e
2016-03-04-Werror,-WundefStephan Bergmann1-1/+1
For MSVC/clang-cl: "__STDC__: Indicates conformance with the ANSI/ISO C99 tandard. Defined as the integer literal constant 1 only if the /Za compiler option is given and you are not compiling C++ code; otherwise is undefined." (<https://msdn.microsoft.com/en-us/library/b0084kay.aspx>) Presumably fine to just replace #if with #ifdef here (as is used in all the other cases surrounding it), and not care whether it actually expands to true. Change-Id: Ie58c76d7e72321b06a11a370fd28221e85fcf871
2016-03-04-Werror,-Wunused-macrosStephan Bergmann2-6/+0
Whatever those _POSIX_ for _MSV_VER were supposed to be good for (have been in there at least ever since 4f4b74153d27a9579c49b225b2690e7f9416fe78 "Moved cpp from cpp to soltools"), but cause -Wunused-macros at least when building with clang-cl. Change-Id: I356bf663cd1e86298ba72a179f46bb9d0c10016b
2016-02-23new loplugin: commaoperatorNoel Grandin1-3/+6
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-17use consistent #define checks for the Windows platformNoel Grandin4-6/+6
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-16use consistent #define checks for the Windows platformNoel Grandin4-8/+8
stage 1 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro Change-Id: Iece73abdee530937e0737190b1aa97a46cd3075f Reviewed-on: https://gerrit.libreoffice.org/22390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-26-Werror,-Wunused-parameter (clang-cl)Stephan Bergmann1-0/+2
Change-Id: I1ac58714e04b995ef5229888f0c427104c001318
2016-01-10Fix typosAndrea Gelmini2-2/+2
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-11-23loplugin:unusedfields in soltools/Noel Grandin1-1/+0
Change-Id: I895a487b4c7be27fe81a2c4c122adb2aba37c638
2015-11-10loplugin:nullptr (automatic rewrite; Mac-specific code)Stephan Bergmann1-2/+2
Change-Id: Ib52f7fb846886dd970ddd51475f890cd81c8f2b5
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann4-8/+8
Change-Id: I3ae78d781e686bfe9b0513183da7fc8edd81024b
2015-10-02loplugin:unusedmethodsNoel Grandin1-1/+0
Change-Id: Ie1603adf3908fd0668bcbe8f75c6bafa0d0bfd6c Reviewed-on: https://gerrit.libreoffice.org/19072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-30Fix typosAndrea Gelmini2-9/+7
Change-Id: I89ff6d31662824d83961d6457b82db8d8031168c Reviewed-on: https://gerrit.libreoffice.org/18977 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-07-04Fix typosAndrea Gelmini3-3/+3
Change-Id: Ic6415423f46aaee7ba90239a617c318cf92ae222 Reviewed-on: https://gerrit.libreoffice.org/16711 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-16-fsanitize=nonnull-attributeStephan Bergmann1-1/+2
Change-Id: Id214fb1f0decd4d39684a846c06ff97d8baa209d
2015-04-02loplugin:staticmethodsNoel Grandin1-3/+3
Change-Id: I1f6c6d13697aa397067478d6b07429120106e6bd
2015-03-02V804: Decreased performanceCaolán McNamara1-1/+2
Change-Id: I6430442cc407e02810d849cf60833abe7c7d2830
2015-02-23remove unnecessary parenthesis in return statementsNoel Grandin4-32/+32
found with $ git grep -lP 'return\s*\(\s*\w+\s*\)\s*;' Change-Id: Ic51606877a9edcadeb647c5bf17bc928b69ab60e
2015-01-08brute-force find-and-remove of unused #define constants.Noel Grandin1-1/+0
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
2014-12-09warning C4267: conversion from 'size_t' to 'int' (MSVC 64-bit)Stephan Bergmann1-1/+1
Change-Id: Ife7d223f5e751e246c537561d3ce24395b4c9f3b
2014-12-09warning C4267: conversion from 'size_t' to 'int' (MSVC 64-bit)Stephan Bergmann3-8/+8
Change-Id: I2fa40ebe467a65b0d6023883a14c79ff4303bb2f
2014-11-06coverity#1000834 Use of untrusted string valueCaolán McNamara1-0/+1
and coverity#706196 Use of untrusted string value coverity#1244947 Use of untrusted string value Change-Id: I5083aba2eff9e852a24513db431585922302b279
2014-10-28coverity#982185 silence Unchecked return value from libraryCaolán McNamara1-2/+2
and coverity#982184 Unchecked return value from library Change-Id: I4b4ba39abc4c008b68cfc1498ee56ac9c4934c98
2014-10-04coverity#706158 Copy into fixed size bufferNorbert Thiebaud1-5/+24
Change-Id: I5d540e6e3a21b0563febb70696882439a10b9b86
2014-10-02coverity#1233618 Overlapping buffer in memory copyCaolán McNamara1-1/+1
Change-Id: I062dd96bfc4abf2bdaec2c17d1cf57d853d655d8
2014-09-04coverity#1019334 Explicit null dereferencedCaolán McNamara1-74/+5
Change-Id: I22b85cbfda1c1bd705b35095e03cfae4071d2fb7
2014-06-24mkdepend: cleanup indentation and function declarationsNoel Grandin8-238/+186
to make it easier to read Change-Id: Iff0fe055c12358edc1be335ec83d0855cc32f03c Reviewed-on: https://gerrit.libreoffice.org/9877 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-24remove use of register keyword in C filesNoel Grandin8-86/+86
C compilers have been ignoring it for the last decade Change-Id: I42918263121dd189bab9d27077798b779b9e8da1 Reviewed-on: https://gerrit.libreoffice.org/9873 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-17-Wstrict-prototypesStephan Bergmann8-76/+25
...no reason to not have it enabled for URE C include files and what little real C code is still left. (But note that Clang ignores that warning.) Change-Id: Ia6940f9f940a0c226e9b724331d65c9862ce32e6
2014-05-30coverity#705235 Missing break in switchCaolán McNamara1-0/+1
Change-Id: I19e8e6aa08dc879f273f2a0177b40435c0ac553d
2014-05-30coverity#705236 Missing break in switchCaolán McNamara1-0/+1
Change-Id: I8065789618f806d01cdb69a18502dfafd962b9f3
2014-05-30coverity#705237 Missing break in switchCaolán McNamara1-0/+1
Change-Id: I1f8c9aa6c7b4403346ee43501a3555abbccf1cfb
2014-05-27Remove unnecessary semicolonsPeter Senna Tschudin1-3/+3
A simplified version of the semantic match that finds this problem is follows: (http://coccinelle.lip6.fr/) // <smpl> @r1@ statement S; position p,p1; @@ S@p1;@p @script:python r2@ p << r1.p; p1 << r1.p1; @@ if p[0].line != p1[0].line_end: cocci.include_match(False) @@ position r1.p; @@ -;@p // </smpl> Change-Id: Ib9708d37fbb4c6060f88d5dae3814a2d37b2091e Reviewed-on: https://gerrit.libreoffice.org/9493 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-24coverity#982647 Missing break in switchCaolán McNamara1-0/+1
Change-Id: Ifa318214079eeb2f903b3e0c4a27c1a807787fd4
2014-05-22Fix some memory leak in soltools/cpp toolStephan Bergmann2-0/+2
...though many more remain, as the design appears to be let heap grow until exit. Change-Id: I3e5cc95a0896c8add33a767209ab0ff60d6a4b52
2014-05-15Resolves fdo#70681: fixincludeguards.pl: all that's leftThomas Arnhold2-4/+4
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5 Reviewed-on: https://gerrit.libreoffice.org/9360 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-04-10Clean up function declarationStephan Bergmann3-3/+32
Change-Id: I92c54f61fe8608d788cc236956f4a5a58e20a7df
2014-04-04Move prototype to includeStephan Bergmann2-2/+2
Change-Id: I90c093c704609429f9997f3ffed6a9a79c8956a6
2014-03-31Typo #elsif -> #elifStephan Bergmann1-6/+6
Change-Id: I95d4dc2a3364172e8917d0a029564e9114943148
2013-11-17WaE: 'PATH_MAX' : macro redefinitionTor Lillqvist2-2/+6
Change-Id: I153e34d24493bbbebf37422fb6382969153506a8
2013-11-16Fix for VS 2013 compilationJesús Corrius2-2/+2
I don´t know why it doesn´t work anymore, but the fix is trivial may be related of using the Windows 8.0 SDK. Change-Id: Ia09109b53d4f022a732ea781c98ddd4eb0c721d9
2013-08-30WaE: size_t/unsigned int: possible loss of dataTor Lillqvist1-3/+3
With MSVC, the third parameter to read() is unsigned int. Change-Id: I607089fb2a9e6bf794293187be48e910ac40158f
2013-08-22left shift of 1 by 31 places cannot be represented in type 'int'Stephan Bergmann1-2/+2
Clang -fsanitize=undefined Change-Id: I2b3f1bd28e098d5eb57892d2c7438c18c5c3b357
2013-08-21We don't seem to actually need glibc getoptTor Lillqvist2-9/+3
Change-Id: I1f221533f5ea684d113bdc45c04bf84405140f9f Reviewed-on: https://gerrit.libreoffice.org/5539 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-07-14Mark as constTakeshi Abe1-1/+1
Change-Id: I0bf93f1293fb08b8b558fcac0cb496ed99ad13d9
2013-05-10soltools: remove Package_inc and empty unistd.h nonsenseMichael Stahl6-31/+2
Change-Id: Ic05de69951b28b9cc8d62f0a534b507c424e6b25
2013-04-24error: too many arguments in call to 'pr_dummy' [-Werror]Stephan Bergmann1-1/+1
Change-Id: Ib03b6d3af9909c971245314bbde2085d8c3c73b2
2013-04-24gbuild: get rid of processdeps.awkMichael Stahl3-4/+43
The only thing that processdeps.awk does that is actually useful is to be able to set the target name freely, but that is only important for the default resource file which was just renamed. Instead hack makedepend to provide the required functionality directly: - write dummy rules for included files so builds don't break on rename/removal - format deps one per line like concat-deps expects - concat-deps expects standard POSIX line ends, so open in binary mode (also disable that awful backup copying nonsense) Though in retrospect it would perhaps be a better investment of time to try to replace makedepend... Change-Id: I54fafdcdcf1a52692e62b8f1f4b96fb9a93d4421