summaryrefslogtreecommitdiff
path: root/solenv
AgeCommit message (Collapse)AuthorFilesLines
2017-11-08Suppress loplugin:unnecessaryoverride...Stephan Bergmann1-0/+1
...when a class derives from multiple (non-virtual) instances of one base class, and the override disambiguates which of those instances' member to call. That was the case with SwXTextDocument::queryAdapter (sw/source/uibase/uno/unotxdoc.cxx), where SwXTextDocument derives from cppu::OWeakObject through both SwXTextDocumentBaseClass and SfxBaseModel, but calling queryAdapter through a pointer to SwXTextDocumentBaseClass apparently needs to call OWeakObject::queryAdapter on the second, SfxBaseModel-inherited OWeakObject base instance, or else CppunitTest_sw_macros_test fails. Who knows what other instances of similar non-unnecessary overrides have been removed with the help of broken loplugin:unnecessaryoverride, for which there were no tests that started to fail... Turns out .clang-format lacked "ReflowComments: false" to not break the special "// expected-error {{...}}" etc. comments in compilerplugins/clang/test/. Also, use a better location to report loplugin:unnecessaryoverride, to keep clang-format and loplugin:unnecessaryoverride from fighting over how to split lines and where to put the comment in compilerplugins/clang/test/unnecessaryoverride.cxx. Change-Id: I3b24df24369db12f8ec1080d6c9f7b70ff561a16 Reviewed-on: https://gerrit.libreoffice.org/44418 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-07Why was this left out of unittest-failed-MACOSX.shStephan Bergmann1-0/+4
Change-Id: If32981329e79745d5497c3f63bfd227dc75f2ab3
2017-11-07Augment LibreOffice.natvisMike Kaganski1-3/+12
Change-Id: Id9c3e270db2ff8e36d18efe3221b8f1c01a2fcc1 Reviewed-on: https://gerrit.libreoffice.org/44419 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-07Adapt clang-format blacklist to recent renamesMiklos Vajna1-6/+6
Change-Id: I5e2e431900af9ea7de7dd9395af038ba2f8f7e0c
2017-11-07tdf#113550 RTF import: fix incorrect text indentMiklos Vajna1-1/+1
Left indent was set to non-zero in the style, but direct formatting set it back to zero. Teach deduplication to remove the NS_ooxml::LN_CT_PPrBase_ind SPRM itself in case the last attribute was removed. Change-Id: I01b202f0241b02816b2b392326737b1150caffc2 Reviewed-on: https://gerrit.libreoffice.org/44385 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-06QT5 rename from KF5Jan-Marek Glogowski1-1/+1
Move out of unx, as this will eventually compile on other OS platforms. At least currently it doesn't contain platform dependant code. Change-Id: Iea0bebf574201881ea158381fe7ba8af2a9a6488
2017-11-06KF5 seperate Qt5 detection from KF5Jan-Marek Glogowski1-0/+1
Splits the configure checks into a Qt5 and KF5 specific part. Change-Id: I0a616ba031e1f7fd0385219ac48179adb4bdaf14
2017-11-06Adapt flatpak-manifest.in to recent mdds updateStephan Bergmann1-3/+3
(666fd212e19af06c9fddb4a3c4a381847a0de402 "Update mdds to 1.3.0.") Change-Id: Ie1ffb199e7960e735584412b064cb0b1dcc0e3dd
2017-11-03-I$(dir $(3)) in gb_CObject__command_pattern is no longer neededStephan Bergmann1-2/+0
...in com_MSC_class.mk now, similar to ecbaf980625a9e7b06abe91c7c70e78f6ad469a7 for com_GCC_class.mk. Three libraries built from external sources (for Windows only) needed adjustment. Change-Id: Id8976a30b80efff6119afb18ccaf6811fe27d2f8 Reviewed-on: https://gerrit.libreoffice.org/44270 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-03Enforce coding style with clang-format for new codeMiklos Vajna1-0/+12
- The actual blacklist has to be generated with solenv/clang-format/generate-style-blacklist.sh in a separate commit. - .clang-format is from <https://lists.freedesktop.org/archives/libreoffice/2014-August/062802.html>, except: - the commented out lines are removed - Standard is Cpp11 instead of Cpp03 - explicitly avoid sorting includes (requested during ESC meeting 2017-10-11) - no indentation inside namespaces (lots of existing code in sc wants this) - The git hooks prints a diff when the style is violated, along with a command to fix up the violation automatically. It also enforces style only in new files and ignores all files listed in the blacklist. - To avoid introducing one more hard-to-setup build dependency for new developers, help them two ways: - if clang-format is not installed, provide pre-built binaries for Linux/Windows/macOS - download/install of these binaries are printed as cmdline instructions, similar to how we have our own 'make' on Windows - As per ESC call 2017-11-02, currently don't do any checks if clang-format is not installed (as a first step). Change-Id: Iaa139c396337e8734aa1853305d808438260c41a Reviewed-on: https://gerrit.libreoffice.org/43736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-11-03solenv: add list of existing C++ files for clang-format blacklist purposesMiklos Vajna1-0/+19928
Generated with solenv/clang-format/generate-style-blacklist.sh from <https://gerrit.libreoffice.org/#/c/43736/>. Change-Id: I9ac621494450c42ef83e5cb7c1956124d17a8de6
2017-11-01-I$(dir $(3)) in gb_CObject__command_pattern is no longer neededStephan Bergmann1-1/+0
...at least in com_GCC_class.mk (com_MSC_class.mk will be addressed in a follow- up commit), after the recent loplugin:includeform clean-up. Two static libraries built from external sources needed adjustment, two compilerplugin tests needed adjustment (which wasn't found by loplugin:includeform, by design), and one more adjustment in sal/textenc/generate/. Change-Id: Idad5ae355a02ae130369a9a45b5f5925ab48ffef Reviewed-on: https://gerrit.libreoffice.org/44174 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-01gbuild: ExternalProject: improve NMAKE handlingMichael Stahl2-3/+10
- move actual variables into com_MSC_class.mk - use export ... && to set the variables, so they affect all subsequent commands, not just the first one - clear MAKE as well, as that is apparently used by nmake, but can only point to GNU make - set CC, because nmake apparently can interpret C:/Progra~1/.../cl.exe etc. etc. as a "C:" command with some additional arguments which only changes the current directory, without even invoking the shell, which tends to cause profanities to be uttered for extended periods of time Change-Id: Ia7b1e6a70d6ac116d4ef0312d2aa1a4747fb8cbf Reviewed-on: https://gerrit.libreoffice.org/44159 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-10-30related: tdf#103884 remove gltf/collada featureThorsten Behrens1-18/+0
Change-Id: Icd26ad96c0337844ef1463dabfbe791caa00dd2d Reviewed-on: https://gerrit.libreoffice.org/43972 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-28Work around "xargs: environment is too large for exec" errors on WindowsStephan Bergmann1-1/+1
...when e.g. doing 'make sal.clean' Change-Id: I63c13dd010cf8d24f9548cf2fe089067381a4efe Reviewed-on: https://gerrit.libreoffice.org/43948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-25new loplugin:dodgyswitchNoel Grandin1-0/+1
and fix bug in ScriptDocument::getTitle which has been there since commit e304ba66f4aba5cc55612508b5738a1ed26a7904 Date: Thu Mar 15 14:59:30 2007 +0000 INTEGRATION: CWS basmgr02 (1.1.2); FILE ADDED plugin is off by default since it uses expensive parentStmt() calls Change-Id: Id0f16baec48e0381e0083594d7e59b58b023da2f Reviewed-on: https://gerrit.libreoffice.org/43750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-25res files and .ui translations are goneDavid Tardon1-13/+0
Change-Id: I3d468ac495c37f8b155f14943bd0a0ac10bd9d06
2017-10-24allow to override ENABLE_STRIP in the installerDavid Tardon1-1/+1
... because we set ENABLE_STRIP in instsetoo_native/CustomTarget_install.mk . Change-Id: I4eaf66c53a0ec680688bf819b3a396865e7a3e33
2017-10-23chmod 0755 -> 0644 for some source filesStephan Bergmann1-0/+0
Change-Id: Ibe5b5e03374419c2c23cd6559ab213d2dc2fcc66
2017-10-23Fix prev. commitStephan Bergmann1-2/+2
Change-Id: I1cb5947952afce330075b97f4106c59e14fbbb14
2017-10-23Adapt solenv/flatpak-manifest.in to recent download.lst changesStephan Bergmann1-6/+6
Change-Id: Ia9d9bae46e19a93b791f94847fa986bee2779712
2017-10-21Avoid loplugin:faileddyncast for "unnecessary", up-casting dynamic_castStephan Bergmann1-0/+1
Change-Id: Iecb943db0aff7ffc21cc2f6adb625be369255b32 Reviewed-on: https://gerrit.libreoffice.org/43606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-20solenv/flatpak-manifest.in: incorporate upstream sandboxing improvementsStephan Bergmann1-3/+2
...done by Bartłomiej Piotrowski <b@bpiotrowski.pl>, <https://github.com/flathub/flathub/pull/127/commits/83a660a7c2876cfa53b86a3a5164908d4490a5f7> "Remove access to the system and session buses" and <https://github.com/flathub/flathub/pull/127/commits/e8481f172e03542e5be0bde537f62999db7277fe> "Own correct D-Bus name on the session bus". Change-Id: I3d58833e0cee64b1c936f76df90a892bc6ce70d4
2017-10-20Adapt solenv/flatpak-manifest.in to recent download.lst changesStephan Bergmann1-9/+9
Change-Id: I02db3b076e8b4387192da1d0de321cca86fc7159
2017-10-19Let's have this additional info also for WIN buildsTamás Zolnai1-0/+4
Change-Id: Ie641f7005980585501f2de1ed83f1cd27549b2bb Reviewed-on: https://gerrit.libreoffice.org/43536 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-10-16added -C switch to native-code.pyjan Iversen1-0/+5
Android is using this script as well, so the iOS change needs to be hidden behind a flag Change-Id: Ica9064278f0b64ad3f078c7951eef15e39f2b6da
2017-10-16iOS, change prelink lib to pure C.jan Iversen1-2/+1
Removed object C and replaced with C to make lib pure. Change-Id: Ie0f49f7e2f4577195dadfa0fdec70212af7c698a
2017-10-13When the unit test fails, mention how to run just that exact test.Jan Holesovsky1-0/+5
Idea that appeared during the Stephan's talk - thanks! :-) Change-Id: Icc0b8454fde8a28f87236425d9df213959d5349c Reviewed-on: https://gerrit.libreoffice.org/43368 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-10-11There appears to be no need for -I. in SOLARINCStephan Bergmann3-4/+4
See the mail sub-thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-October/078609.html> "Re: C[++]: Normalizing include syntax ("" vs <>)". Change-Id: Ibb636be643789d455e771fcd54913dd3cdd03815 Reviewed-on: https://gerrit.libreoffice.org/43284 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-06gbuild: more verbose forwarding of LinkTarget functionsMichael Stahl5-249/+251
The forwarding of LinkTarget subclass functions to LinkTarget functions is currently done in a very elegant way that only requires listing the bare function names once, but the downside is that the subclass functions aren't defined in a way that "git grep" or "ctags" can find, so replace that with more verbose copy-paste definitions. Change-Id: I4bd7f1b1bc0904ae345958e39403ab508db584a1 Reviewed-on: https://gerrit.libreoffice.org/43196 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-10-06Improve performance of loplugin:commaoperatorStephan Bergmann1-0/+1
...by avoiding calls to parentStmt, thereby also improving the precision of exactly which comma operators to ignore (which turned up a handful more finds). Also added tests. Change-Id: Ie74f824fd7f54131aab09b59086452fb4f3ff827 Reviewed-on: https://gerrit.libreoffice.org/43181 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-06iOS, third party library updatejan Iversen1-2/+2
added arm64 to config.sub removed coinmp from compilation Change-Id: Ib0a4d8fc7cae399183116e928485869a08e7b1af
2017-10-04simplify updating of config.* in bundled projectsDavid Tardon3-0/+3336
Change-Id: I2028bb9664caf9b9c09d22cc766f88094c92b95f Reviewed-on: https://gerrit.libreoffice.org/42940 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2017-10-03new loplugin:blockblockNoel Grandin1-0/+1
Change-Id: I7b68b70fa4c7234e8882f7627026959a596968fd Reviewed-on: https://gerrit.libreoffice.org/43025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-02solenv: support gb_UITest_DEBUGRUN for ui testsMiklos Vajna1-1/+8
This is similar to gb_JunitTest_DEBUGRUN, i.e. allows running soffice in gdb, and then connecting to that soffice from the test, instead of starting an own one. Change-Id: I023d6b0ede146837666c946cb865feb9046e5a94 Reviewed-on: https://gerrit.libreoffice.org/42756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-01Drop unused manifest file from solenv/incMike Kaganski1-11/+0
Change-Id: Id2c12db1a4bcddcc3f749fad8abfcd60a43db088 Reviewed-on: https://gerrit.libreoffice.org/42986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-30Fix typosAndrea Gelmini1-1/+1
Change-Id: Ic09de64e5672d66b7436a6525344f845550523f9 Reviewed-on: https://gerrit.libreoffice.org/42982 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-30solenv: move DeclareDPIAware.manifest to gbuild directoryMichael Stahl2-1/+1
Change-Id: If09ece21c9dd69111990e1cef2508149fff7e8a6 Reviewed-on: https://gerrit.libreoffice.org/42969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-30Support loplugin in clang-clStephan Bergmann2-4/+28
This works at least with a recent Clang trunk (towards Clang 6.0). In order for the plugin.dll to find the LLVM/Clang symbols, it needs to be loaded into clang.exe not clang-cl.exe, so set CC/CXX to 'clang.exe --driver-mode=cl ...'. Buidling the plugin requires some linker flags that must go at the very end of the COMPILER_PLUGINS_CXX command line, after a /link switch, so introduce another COMPILER_PLUGINS_CXX_LINKFLAGS variable for that. Also, clang.lib is not installed as part of LLVM's 'cmake --build ... --target install' step, so is not available under CLANGDIR and needs to be taken from the build tree instead, so introduce another CLANGLIBDIR variable for that. autogen.input settings that work for me on Windows 8.1 with Microsoft Visual Studio 14.0 are: > CLANGDIR=C:/llvm/inst > CLANGLIBDIR=C:/llvm/build/lib > COMPILER_PLUGINS_CXX=C:/PROGRA~2/MICROS~3.0/VC/bin/amd64/cl.exe /IC:\PROGRA~2\MICROS~3.0\VC\INCLUDE /IC:\PROGRA~2\MICROS~3.0\VC\ATLMFC\INCLUDE /IC:\PROGRA~2\WI3CF2~1\10\include\100102~1.0\ucrt /IC:\PROGRA~2\WI3CF2~1\NETFXSDK\46D346~1.1\include\um /IC:\PROGRA~2\WI3CF2~1\8.1\include\shared /IC:\PROGRA~2\WI3CF2~1\8.1\include\um /IC:\PROGRA~2\WI3CF2~1\8.1\include\winrt > COMPILER_PLUGINS_CXX_LINKFLAGS=/LIBPATH:C:/PROGRA~2/MICROS~3.0/VC/LIB/amd64 /LIBPATH:C:/PROGRA~2/MICROS~3.0/VC/ATLMFC/LIB/amd64 /LIBPATH:C:/PROGRA~2/WI3CF2~1/10/lib/100102~1.0/ucrt/x64 /LIBPATH:C:/PROGRA~2/WI3CF2~1/NETFXSDK/46D346~1.1/lib/um/x64 /LIBPATH:C:/PROGRA~2/WI3CF2~1/8.1/lib/winv6.3/um/x64 (The last two are "C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/ amd64/cl.exe" and translations of %INCLUDE% and %LIB% as set in the "VS2015 x64 Native Tools Command Prompt" shell. AC_CHECK_HEADER(clang/AST/RecursiveASTVisitor.h, ...) in configure.ac wouldn't like CXX to start with INCLUDE=... LIB=... environment variable settings, so it wouldn't work to instead pass %INCLUDE% and %LIB% to cl.exe that way. See <https://wiki.documentfoundation.org/Development/clang-cl> for general information about building with clang-cl on Windows.) There's still some room for improvement marked "TODO". (And some of the unused* plugins, which are not run by default anyway, use Unix-style functionality, so have been disabled for now.) Change-Id: I6c28bdeb801af39ce2bae03111f455e2338d66c9 Reviewed-on: https://gerrit.libreoffice.org/42931 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-30Add compatibility information to binary manifests on WindowsMike Kaganski2-2/+17
Without that, Windows (since 8.1) may apply compatibility mode (at least its version API really works differently: see https://blogs.msdn.microsoft.com/cjacks/2014/06/23/why-windows-8-1-sometimes-tells-you-it-is-windows-8-0). Change-Id: I99f0c81aac669f21c737753bc806565c794281f2 Reviewed-on: https://gerrit.libreoffice.org/42934 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-30allow linking mergedlib on win by removing duplicate libs from commandlineChristian Lohmaier1-3/+5
adding advapi 62 times, icuuc 24 times and libxml2 18 times (and others multiple times as well) is too much for cygwin to handle and breaks the build when trying to link mergedlo.dll with the not-very telling "/usr/bin/sh: -c: line 1: syntax error: unexpected end of file" (especially since the latter are added with $W/UnpackedTarball/whatever) uses the sideeffect of make's sort to remove the duplicates Change-Id: I9e92aafa0df9518520793a5827fb6cc157538f4b Reviewed-on: https://gerrit.libreoffice.org/42953 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-29gdb pretty-printers: fix StringPrinterHelper for gdb 8.0Michael Stahl2-5/+5
Latest gdb release "lazy_string" validates the array size: Traceback (most recent call last): File "/work/lo/master/solenv/gdb/libreoffice/util/string.py", line 29, in to_string return self.make_string(data, self.encoding, len) File "/work/lo/master/solenv/gdb/libreoffice/util/string.py", line 66, in make_string return data.lazy_string(encoding, length) gdb.error: Length is larger than array size. rtl_uString has "sal_Unicode buffer[1];", which is a lie as the real size is the same as "length". Taking the address of "buffer" appears to avoid the exception. Change-Id: I85710b1adfae584ba09c8d517e9b49b290e79d8a
2017-09-29tdf#106894: Rewrite packimages.pl in PythonJens Carl1-550/+0
Remove replaced packimages.pl Change-Id: I1267f06d0476f010e7ab86878c10d5c9b0892d0b Reviewed-on: https://gerrit.libreoffice.org/42924 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-09-28Python 2.6 compatibility for pack_images.pySamuel Mehrbrodt1-1/+2
Change-Id: I61b315bc644763749acf82d2dd7e4a3140d8f8b1 Reviewed-on: https://gerrit.libreoffice.org/42911 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-09-28Fix typosAndrea Gelmini1-2/+2
Change-Id: I22b1c5575dcd38b9cfac2068ba3960026e44ad1e Reviewed-on: https://gerrit.libreoffice.org/42888 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-28tdf#106894: Rewrite packimages.pl in Python (pack_images.py)Jens Carl1-0/+590
Change-Id: I2e9054775941b38392ba3ee38575891b5339249e Reviewed-on: https://gerrit.libreoffice.org/42790 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-26Revert "tdf#106894 Rewrite packimages.pl in Python (pack_images.py)"Samuel Mehrbrodt2-590/+550
This broke the build: https://ci.libreoffice.org/job/lo_tb_master_win/14994/console This reverts commit 423ee1020afe1bca896f2ecfc67ffbd49db5081c. Change-Id: I05e6fd68f2bbec189236cbe265f6510731327997 Reviewed-on: https://gerrit.libreoffice.org/42778 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-26tdf#106894 Rewrite packimages.pl in Python (pack_images.py)Jens Carl2-550/+590
Change-Id: Id627d9295edc77e561f15e0886fdcf9fb64fe68d Reviewed-on: https://gerrit.libreoffice.org/41667 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-25Fix typosAndrea Gelmini1-2/+2
Change-Id: I879a52820d78d9151ef64dd21612379f617f66e2 Reviewed-on: https://gerrit.libreoffice.org/42726 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-23new loplugin unnecessarycatchthrowNoel Grandin1-0/+1
Change-Id: Iabab71ee076227bc38447ec109afaea1e53a86a6 Reviewed-on: https://gerrit.libreoffice.org/42643 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>