summaryrefslogtreecommitdiff
path: root/slideshow
AgeCommit message (Collapse)AuthorFilesLines
2021-03-26loplugin:flattenNoel1-28/+28
Change-Id: Ib7a895fba66f8dc9b6501e61631c02694053b7fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113157 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-03-24Using .md extension/Markdown syntax for modules READMEHossein1-0/+0
Renaming all README files for all top level modules to README.md, applying no content change at this stage to be able to track history of the files. These files should be edited to use correct Markdown syntax later. Change-Id: I542fa3f3d32072156f16eaad2211a397cc212665 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112977 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-03-21update pchesCaolán McNamara1-4/+4
Change-Id: I60e61133c305673bb305e41957f5414820c7c358 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112790 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-13update pchesJulien Nabet1-2/+4
Change-Id: Id6dfae9fb97fbe3fc89b9f2e083d7a3d5c1d36d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112411 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-03-11Work around MSVC 2019 16.9.0 warning C4103 compiler bugStephan Bergmann1-2/+2
With that compiler version (and --with-latest-c++), the build now started to fail for me with > [build CXX] slideshow/source/engine/opengl/Operation.cxx > C:\PROGRA~2\MIB055~1\2019\COMMUN~1\VC\Tools\MSVC\1428~1.299\Include\memory(14): error C2220: the following warning is treated as an error > C:\PROGRA~2\MIB055~1\2019\COMMUN~1\VC\Tools\MSVC\1428~1.299\Include\memory(14): warning C4103: alignment changed after including header, may be due to missing #pragma pack(pop) > C:\lo\core\slideshow\source\engine\opengl\Operation.hxx(34): warning C4103: alignment changed after including header, may be due to missing #pragma pack(pop) > C:/lo/core/slideshow/source/engine/opengl/Operation.cxx(36): warning C4103: alignment changed after including header, may be due to missing #pragma pack(pop) Mike had experienced the same (though without --with-latest-c++, but due to us now always using /permissive-) as explained in the post-merge comments starting at <https://gerrit.libreoffice.org/c/core/+/108961/4# message-cc2a1e2ebaeb96cbacd7d13d57ffc701f2ed4608> "Use MSVC's /permissive- to make it more standards conforming", linking to <https://developercommunity.visualstudio.com/t/ warning-c4103-in-visual-studio-166-update/1057589> "Warning C4103 in Visual Studio 16.6 Update". At least for my --with-latest-c++ aka /std:c++latest case, I have reduced the issue to a test.cc of > #include <cmath> > template<typename> void f(int[1]) {} > #include <exception> failing with > ********************************************************************** > ** Visual Studio 2019 Developer Command Prompt v16.9.0 > ** Copyright (c) 2021 Microsoft Corporation > ********************************************************************** > [vcvarsall.bat] Environment initialized for: 'x64' > > C:\Program Files (x86)\Microsoft Visual Studio\2019\Community>cd \lo\core > > C:\test>cl /std:c++latest /c test.cc > Microsoft (R) C/C++ Optimizing Compiler Version 19.28.29910 for x64 > Copyright (C) Microsoft Corporation. All rights reserved. > > /std:c++latest is provided as a preview of language features from the latest C++ > > working draft, and we're eager to hear about bugs and suggestions for improvemen > ts. > However, note that these features are provided as-is without support, and subjec > t > to changes or removal as the working draft evolves. See > https://go.microsoft.com/fwlink/?linkid=2045807 for details. > > test.cc > test.cc(3): warning C4103: alignment changed after including header, may be due > to missing #pragma pack(pop) which looks clearly like a compiler bug. As it happens, reordering the includes here makes the issue disappear at least for me. Change-Id: Ib3d0756b38da4f24e62cafa900b44c8ec8e842b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112317 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-03-09Make sal/config.h the first in pchMike Kaganski1-5/+3
By convention, it should be the first include in C/CXX files; so use of pch should not break that. Change-Id: Ic329c5f39e8f48ad1778724368e262e48972342b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112123 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-03-06update pchesJulien Nabet1-3/+4
I just used ./bin/update_pch.sh Change-Id: I06a7f36eb4c511b8d6c6477fd87e57f0d9702457 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112097 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-02-23loplugin:refcounting check for managing OWeakObject with raw pointerNoel1-4/+3
Change-Id: I7471725f1e658940b5e6993361c327be6ccf0d31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111064 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-16loplugin:referencecasting in slideshow..starmathNoel2-7/+7
Change-Id: Id9dc0ac27897c8a3650424db65d3a05e2fe418f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110986 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-08update pchesCaolán McNamara1-1/+5
Change-Id: Icf55ddda055d11b649e7607c2cdd8b6d6ddfefbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110483 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-04use more getSdrObjectFromXShapeNoel2-4/+2
Change-Id: Ia237643ab040425f231f781c86e7e060f0b53717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110400 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-27rename Toolkit::Gtk3 to Toolkit::Gtk because Gtk2 support is goneCaolán McNamara1-1/+1
so the need to distinguish no longer exists Change-Id: I4c11ddffbfa77f04497c454358c1c707ecf1d162 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109942 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-27tdf#139609 avoid fetching unnecessary xid under gtk3Caolán McNamara1-2/+7
because of the side effects using a bare GtkGrid as m_pSocket in vcl/unx/gtk3/gtk3gtkobject.cxx is perhaps a poor choice, getting its xid causes poor side effects wrt events belonging to its child widgets getting delivered to the SalFrame widget, so duplicate scrolling after showing a opengl slide and/or showing a video and lots of flickering we're (generally at least) not using the xid under gtk3 so don't set it unless it's explicitly asked for. Happily the gtk Player::createPlayerWindow doesn't use its arg[0] xid in any case, so don't bother setting it for that backend. Change-Id: I1c59a607a332635091782c3b49de10647558f301 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109941 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-13transparency->alpha in GraphicAttrNoel1-1/+1
Change-Id: I1fe9311871724ff8b7b8960f5dba6e890198565c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109211 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-03tdf#136278 Follow-up Check when the eventqueue needs to be emptied.Gülşah Köse2-8/+16
Follow up commit a63caf49958b40e33e0d7aaedbe6424f78ecdc46 Change-Id: I90b94f6aee1e1fe62f61ca20a75fd59e2a12d5da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108559 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-12-26tdf#134133 Check when the eventqueue needs to be emptied.Gülşah Köse3-0/+24
To fix tdf#131254, forceEmpty call removed without a control. Bug was related advance time setting. Now we control if slide has advance time setting. Change-Id: Ie83f4d7ff3e4bd0a744ca205173d747204918b39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108282 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-12-09remove isVCLOpenGLEnabled() settings, add DisableOpenGL optionLuboš Luňák1-0/+2
The VCL OpenGL backend code has been removed, so the settings for it no longer make sense. But there's still the code for detecting if OpenGL is broken, and that one makes sense to keep. It turns out other OpenGL code (such as slideshows) doesn't even use that, so turn this into a new DisableOpenGL option, make OpenGL-related failsafe code set and use that, and OpenGL code should use OpenGLHelper::supportsOpenGL() to make sure OpenGL use is not blocked. Change-Id: Iec83f204e89bfb0b6eea13be77da8f0f4727a074 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107398 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-12-04update pchesCaolán McNamara1-3/+7
Change-Id: I3e22c2000da03f6f3345353846213203993aa865 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107192 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-01tdf#42949 Fix new IWYU warnings in directories s*Gabor Kelemen11-8/+12
Except recently checked sc, sd, svx, sw Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ice1b86628e4f22a39f307b9c5fa567b6ab9d5acb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106917 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-01OSL_FAIL.*exception -> TOOLS_WARN_EXCEPTIONNoel1-2/+2
Change-Id: I6800e23ead2767d245d5da71d2d40e0f8a6d7e1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106859 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-30loplugin:stringviewparam include comparisons with string literalsNoel2-9/+9
Change-Id: I8ba1214500dddaf413c506a4b82f43d63cda804b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-19tdf#123936 Formatting files in module slideshow with clang-formatPhilipp Hofer12-91/+72
Change-Id: I108be5e01ed319f42912a6762ebceb97795113ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105708 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Jenkins
2020-11-17Remove unused ViewMediaShape::implInitializePlayerWindow rMimeType parameterStephan Bergmann2-5/+3
unused since 08a43cc97ccf88faa9d3a04afc3aacd2c885a2d1 "related: tdf#103884 remove gltf/collada feature" Change-Id: Ieed4a2dcd2f465de2356e640383bac2cd45b83d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106017 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-17loplugin:stringviewparam check methods tooNoel2-2/+2
not just functions Change-Id: Icca295dd159002b428b73f2c95d40725434f04d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105789 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-13Fix (some of) fallouts from tools::Long change to 64 bit on _WIN64Mike Kaganski1-8/+8
Change-Id: I297d43c594c5d8c3378e8b7f29ad798e89e4ebaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105776 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-11-10new loplugin:reducevarscopeNoel Grandin1-1/+1
Change-Id: Iefe922c2e0d605114d54673d63eccc5e4abd545d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102143 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-22long->tools::Long in slideshow..starmathNoel1-8/+9
Change-Id: I18f5b7c5da513d386f8ac848835b0410ebc7d95b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104629 Reviewed-by: Dante DM <dante19031999@gmail.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-21new tools::Degree10 strong typedefNoel Grandin1-1/+1
partly to flush some use of "long" out the codebase, but also to make it obvious which units are being used for angle values. Change-Id: I1dc22494ca42c4677a63f685d5903f2b89886dc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104548 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-17fix build with box2d 2.4.0Rene Engelhard1-1/+2
Change-Id: I60f25f04e2bfcdabf832f42b44ba3d945f4ec169 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104456 Tested-by: Jenkins Tested-by: René Engelhard <rene@debian.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-16try to make available all slide images using threadsLuboš Luňák1-0/+20
Graphic::makeAvailable() is not thread-safe, but the jpeg loader is capable of that, and the graphic can be loaded using the stream data (which is what ultimately makeAvailable() will do anyway). This loads all images faster using threads instead of them being loaded one by one on-demand. Change-Id: Ifc39a2757834a9fb0dbafa61f13f5454e69af330 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104082 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-06loplugin:const* make some params and methods constNoel2-10/+10
Change-Id: I97c5bbb929a2a4a029af4e6cb0fd571bbc2b698b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104030 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-05try not to hog the CPU during slideshow animationsLuboš Luňák1-2/+11
Try to sleep for most of the busy-waiting loop. Seeing this CPU usage is annoying when profiling. Change-Id: Ia01b547b28a22ffcb0e841ea582c93891cf1c5c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103960 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-09-01Fix typosAndrea Gelmini2-6/+6
Change-Id: Ieff77be89ee8505b8241234f6dbb7507256dbc4a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101757 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-08-31tdf#136301: fix parallel physics animations over-stepping during lock transferSarper Akdemir2-2/+22
introducing mbAlreadyStepped flag to make physics animation effects aware that the lock was just obtained from another physics animation which already stepped the time interval meant to be stepped through. Change-Id: Id7c01c96e302d7da7aae785f56c09a9ddfe4bdf1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101665 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-08-31document physics animations and related codeSarper Akdemir4-49/+251
Change-Id: I1369588dd757d5fedcd7e91eabe0020e5cf60c56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101492 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-08-29Fix typosAndrea Gelmini1-1/+1
Change-Id: I6517f3b68389c0f3581cc750c61b8e59d075d35e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101633 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2020-08-28tdf#136152: make physics animation effects handle animations with jumpy startsSarper Akdemir3-10/+45
fixes the bug where an animation effect doesn't start on it's original location and collides with everything as if it was moving from the original location to wherever the animation effect starts in a single step. Change-Id: Icd2919bcad665f8a1839a57642694d98ff73afca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101425 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-08-27remove some unused includes and update pchesCaolán McNamara1-1/+44
Change-Id: I786548bef39fa711aabcff32b592b3fdc4a6f9fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101486 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-27Fix typosAndrea Gelmini3-3/+3
Change-Id: Ieebf8bc3051d1f6b99cf72629aa411e27de21640 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101403 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-26[API CHANGE] Drop OSL_THIS_FUNC, directly use C++11 __func__Stephan Bergmann2-4/+4
It had been documented as "the macro OSL_THIS_FUNC is intended to be an office internal macro for now", so take the liberty of removing it, even if technically that can be considered an incompatible API change. Change-Id: I7580a932e1da54845934378a650e894f3f3a9062 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101406 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-26tdf#136097: make physics animation effects handle skips and rewindsSarper Akdemir3-124/+83
Making box2d world only stay populated when there's an animation effect going on. This makes it possible to get rid of big chunk of sequential update implementation. Change-Id: Iaf50d4871b2355035495618354f0ae09abe94164 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101304 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-08-25-Werror=maybe-uninitializedNoel Grandin1-12/+4
which only shows up in an optimised build, using gcc Change-Id: I16015c7d139680aba11bf183c3e2bceb79c9ecba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101330 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-22fix group shape crash for physics animationsSarper Akdemir3-4/+29
Group shapes are now considered as foreground objects. Physics animations now do not create individual bodies for shapes that are part of a group but instead create one body that represent all of them. Change-Id: I27819c853af75aff93636c99f216a67ef18791d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101174 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-08-22add bounciness velocity and density options to physics animationsSarper Akdemir6-12/+115
Adding new xml options to specify the starting velocity, bounciness, and density of the rigid body that physics animation control. Change-Id: Ifaba785e82c8ee17be00711a3e7a75257e7704ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101141 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-08-21make physics animations handle sequential animations correctlySarper Akdemir3-43/+175
fixes a bug where if there is a sequence of animations between two physics animations that change the position, rotation or visibility of a shape - changes are not picked up by the latter physics animation. Change-Id: Ie8bb8b32588f4c7bf16317b5229adc5b0334d192 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100715 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Jenkins
2020-08-21make physics animation effects always processed lastSarper Akdemir6-4/+48
Makes it possible to add activities that will be processed last in the queue. Makes physics animation effects queued this way. And fixes the bug that makes physics animation effects appear out of sync for a frame with the shapes that other in parallel animation effects control. Change-Id: I92d436aced6ef3ee2c8b0bf0167c1f7e642ba3b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100713 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Jenkins
2020-08-21box2dtools renaming some for claritySarper Akdemir3-25/+26
Change-Id: Idd872213ee3140e82fbd6e8e8bd1ebff78dfdc18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101132 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-08-21Fix typo in codeAndrea Gelmini1-2/+2
Change-Id: I65d54b3822177916850d296dcff1eb9baaebc964 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101110 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-20add support for complex shapes in physics animation effectsSarper Akdemir2-18/+198
Makes it possible to represent complex shapes of LibreOffice in physics animation effects by closely approximating their geometry. Therefore enables more convincing animation effects. Change-Id: I807bbde92c143b8c96792b3d8bf9603a31216486 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100432 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-08-17fix box2dtools build error for non debug buildsSarper Akdemir3-23/+21
Removed the asserts and moved the functions out of the box2DWorld class. Change-Id: Ifa58bceb2c64c1012e5d0e65bc12646312ab1c16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100856 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>