summaryrefslogtreecommitdiff
path: root/slideshow
AgeCommit message (Collapse)AuthorFilesLines
2021-01-04tdf#136278 Follow-up Check when the eventqueue needs to be emptied.Gülşah Köse2-8/+16
Follow up commit a63caf49958b40e33e0d7aaedbe6424f78ecdc46 Change-Id: I90b94f6aee1e1fe62f61ca20a75fd59e2a12d5da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108559 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit b83c16834792874524019495662b2f23a066611c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108585 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2020-12-28tdf#134133 Check when the eventqueue needs to be emptied.Gülşah Köse3-0/+25
To fix tdf#131254, forceEmpty call removed without a control. Bug was related advance time setting. Now we control if slide has advance time setting. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108282 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit a63caf49958b40e33e0d7aaedbe6424f78ecdc46) Change-Id: Ie83f4d7ff3e4bd0a744ca205173d747204918b39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108335 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-03-30tdf#131254 Follow-up Prevent extra eventqueue empty call.Gülşah Köse1-1/+0
When two advance timing set slides in a row, there is another extra forceEmpty call that disables timing setting. Follow up commit 80f386f787ad59936ead2022e6d932a6d441c6e9 Change-Id: I8e70ebf57328b51eab2baca9728a0f8e0561120c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91367 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 14a0727889699128f02ac0a79bdce0103c89bc01) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91304
2020-03-29tdf#131254 Prevent extra eventqueue empty call.Gülşah Köse1-1/+1
That call disables advance timing setting when we back to previous slide. Its comment line says "Process initial events and skip any animations that are started when the slide is shown" but it can still skip any animations. It seems that is an unnneeded call here. Change-Id: Iec23409da8285f5b7a8bff3d9c4f507a997ae885 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90913 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit 80f386f787ad59936ead2022e6d932a6d441c6e9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91118 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-02opengl slide transitions not working with glm >= GLM 0.9.9.0Caolán McNamara1-0/+1
tracked it down to... Removed default initialization, use GLM_FORCE_CTOR_INIT to restore the old behavior so adding in GLM_FORCE_CTOR_INIT to get them working again Change-Id: I1c6e7d8eb748fce40f0c518ff708708e5fb1e3d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87790 Tested-by: Jenkins Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2020-01-26tdf#126459: Consider translated origin of the view also on resizeKatarina Behrens1-2/+7
use-case is the presenter console on 2nd screen, media shape must be placed relative to the window w/ slide preview, not relative to the main window Change-Id: I120f86e399563d2aafc31d88d0a7f9d357f4840c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87135 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit d4561921dde7d350b3b4d5f793871bea8ba4546d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87258 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-12-19tdf#125949 Check hardware acceleration on slideshow.Gülşah Köse2-1/+10
Follow up commit for 8eb2d2972583b909a249f5b0f22a9b1fbf533d24 Allows animation if hardware acceleration disabled. Change-Id: I7997936435134e36e2bf3d3d54ff1bf157cb205c Reviewed-on: https://gerrit.libreoffice.org/85380 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit 3e88fc6b0eef06e1e12fcfe765e3092c6c06ce5c) Reviewed-on: https://gerrit.libreoffice.org/85431
2019-12-17tdf#125949 Allow the slide to continue with freezing animation.Gülşah Köse2-2/+59
Entrance (Zoom in, Spiral in, Sviwel, Stretchy) animations with shapes freezes the presentation when OpenGL is enabled. As a workaround, avoid playing these animations. Change-Id: I054d87c4d3774339a9fe6fba42dea20bccd31bb1 Reviewed-on: https://gerrit.libreoffice.org/85201 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit 8eb2d2972583b909a249f5b0f22a9b1fbf533d24) Reviewed-on: https://gerrit.libreoffice.org/85252
2019-11-12use std::move when popping stuff off stacksNoel Grandin2-5/+5
Change-Id: I6ba0ee8afee1a9579045643cd0118cf19599d5b9 Reviewed-on: https://gerrit.libreoffice.org/82497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29remove unnecessary includesCaolán McNamara1-1/+0
Change-Id: Ia4a622b34ff3f71963cff7a1aa8658a4df12f04f Reviewed-on: https://gerrit.libreoffice.org/81676 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-19loplugin:virtualdead unused params in OGLTransitionImplNoel Grandin2-9/+9
rename finish to cleanup to avoid conflict with already existing finish method Change-Id: I1036eea7e50b20c3c17d769c4094c640939d552d Reviewed-on: https://gerrit.libreoffice.org/81072 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-19loplugin:virtualdead unused param in Animation::prefetchNoel Grandin7-24/+13
Change-Id: I7eaf01548567ce560b0e32f222880d21b966c78d Reviewed-on: https://gerrit.libreoffice.org/81071 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-19loplugin:virtualdead unused params in ShapeListenerEventHandlerNoel Grandin6-28/+15
Change-Id: Ied95fd01912737ba1ae73fb1fea6ddd57eb8a14d Reviewed-on: https://gerrit.libreoffice.org/81070 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-18make bin/update_pch.s always include code in trivial #if'sLuboš Luňák1-1/+64
E.g. #ifdef LIBO_INTERNAL_ONLY is always true for code that builds with our PCHs. Change-Id: I3cf311ea3621b909105754cfea2cb0116b8b67f5 Reviewed-on: https://gerrit.libreoffice.org/80961 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-15new loplugin:bufferaddNoel Grandin1-5/+3
look for OUStringBuffer append sequences that can be turned into creating an OUString with + operations Change-Id: Ica840dc096000307b4a105fb4d9ec7588a15ade6 Reviewed-on: https://gerrit.libreoffice.org/80809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-14Related: tdf#124729 check for GL_EXT_texture_filter_anisotropic supportCaolán McNamara1-8/+14
Change-Id: I7cc7225c02e1c6688df22b237af59425fb64b79c Reviewed-on: https://gerrit.libreoffice.org/80760 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-28loplugin:constmethod in sdext..starmathNoel Grandin6-8/+8
Change-Id: Ib1b60382c9ec62f35f0f232c3f2c2d5664ea669e Reviewed-on: https://gerrit.libreoffice.org/79779 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-27loplugin:virtualdead in slideshowNoel Grandin3-8/+0
Change-Id: Ie158b76e6d552b1189173e30fbea5a43a774180b Reviewed-on: https://gerrit.libreoffice.org/79640 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-23do not require $(SRCDIR) in every gb_Library_set_precompiled_headerLuboš Luňák1-1/+1
Change-Id: I7b3a22584bb2e4d501f509ffcd80929feed23a4c Reviewed-on: https://gerrit.libreoffice.org/79360 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-10Fix typosAndrea Gelmini1-1/+1
Change-Id: I22eef797ee934fa003a513a56145e1af9c5ad94e Reviewed-on: https://gerrit.libreoffice.org/78801 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-10Fix typosAndrea Gelmini1-1/+1
Change-Id: I86f744d5b0d5d8d56c40db2ff17fefbfa3cb4907 Reviewed-on: https://gerrit.libreoffice.org/78800 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-10Fix typosAndrea Gelmini2-2/+2
Change-Id: I79f87f033eeb67d1750bb595d311d74ef3db6ce9 Reviewed-on: https://gerrit.libreoffice.org/78795 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-09-02tdf#127258: Fix ViewEventHandlerWeakPtrWrapperStephan Bergmann1-8/+69
...which had been introduced with 042e30a3dc057aef4a02d95960e4dd4fb8d083ae "Avoid adding a function template declaration to namespace std" but without taking the ListenerOperations<std::weak_ptr<ListenerTargetT>> partial specialization (in slideshow/source/inc/listenercontainer.hxx) into account, so that commit had made some confused changes to the mpImpl->maViewHandlers.applyAll calls (that can now be reverted). Change-Id: Iaaafc560dfd34940f1708027808ab4f9b8db7764 Reviewed-on: https://gerrit.libreoffice.org/78405 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-01Fix '..'Andrea Gelmini1-1/+1
To complete this: https://gerrit.libreoffice.org/#/c/78312/ This is a massive replace for lines ending with ".." instead of "..." It passed "make check" on Linux. Change-Id: I07fa7b2e30ba9ea17a1f9a5e21c57216ba958efe Reviewed-on: https://gerrit.libreoffice.org/78356 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-08-28Avoid adding a function declaration to namespace stdStephan Bergmann1-4/+4
Change-Id: Id6839850f249f2065de05a0fd929e68ca1003ec6 Reviewed-on: https://gerrit.libreoffice.org/78213 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-28Avoid adding a function template declaration to namespace stdStephan Bergmann1-16/+21
Change-Id: I1368276c859d3c81f4ebfbeca47bb99e781f2fed Reviewed-on: https://gerrit.libreoffice.org/78214 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-27tdf#74045 Make ImageMaps in slideshow clickableSamuel Mehrbrodt5-7/+56
Change-Id: I151983ce34a58c0f0d4b1e912f43525de4c0ad28 Reviewed-on: https://gerrit.libreoffice.org/78157 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-21loplugin:constvars, look for loop vars that can be constNoel Grandin1-1/+1
Change-Id: I67ee714739800f3718f9d3facf57474cd564d855 Reviewed-on: https://gerrit.libreoffice.org/77415 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-16use more TOOLS_WARN_EXCEPTIONNoel Grandin15-18/+18
Change-Id: Ic21ea11ff106e0732bb8fa600ef39a549d7bda86 Reviewed-on: https://gerrit.libreoffice.org/77569 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-15loplugin:sequenceloop in shell..sotNoel Grandin2-2/+2
Change-Id: I40e2a1be0ce7df627d3820192d24821ddd7c3e2f Reviewed-on: https://gerrit.libreoffice.org/77527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-12Fix typosAndrea Gelmini1-1/+1
Change-Id: Ic431ef6c3555f02fbc204a5b0af5f9bfe62f4a30 Reviewed-on: https://gerrit.libreoffice.org/77286 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-02Fix typosAndrea Gelmini9-9/+9
Change-Id: Ic7b6014e09e3ee1a1b4917008a267b8fa2dbc1f5 Reviewed-on: https://gerrit.libreoffice.org/76814 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-22Simplify Sequence iterations in shell..svgioArkadiy Illarionov5-76/+50
Use range-based loops, STL and comphelper functions Change-Id: I612d36abcc09a91c60f7212de6747a1a1bdcfc69 Reviewed-on: https://gerrit.libreoffice.org/76056 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-07-21loplugin:referencecasting in slideshow..svtoolsNoel Grandin6-20/+10
Change-Id: Id0f0332d5d66c0bce309643bf42059b9bdc7d448 Reviewed-on: https://gerrit.libreoffice.org/75997 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-15drop unbuilt demoshowCaolán McNamara4-595/+0
Change-Id: I1fbee5ff3eab94c492909fe7deaf990f9556a692 Reviewed-on: https://gerrit.libreoffice.org/74852 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-12Fix typosAndrea Gelmini1-1/+1
Change-Id: I20fe5f960c1df94c0b53e7edf33194e60f69bc74 Reviewed-on: https://gerrit.libreoffice.org/75472 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-25improve loplugin:simplifyconstructNoel Grandin2-5/+4
Change-Id: If863d28c6db470faa0d22273020888d4219e069e Reviewed-on: https://gerrit.libreoffice.org/74559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-17loplugin:logexceptionnicely in shell..sotNoel Grandin9-18/+20
Change-Id: I2ae0c0ac06f32ef91951aa4f7c98b5706178f841 Reviewed-on: https://gerrit.libreoffice.org/74115 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-14loplugin:unusedfields improvementsNoel Grandin2-3/+0
tighten up the only calling write-only methods part of the analysis Change-Id: I5bc6fdf0ce51940653317e8a48c5241705c90d4c Reviewed-on: https://gerrit.libreoffice.org/74022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-22New loplugin:dataStephan Bergmann1-1/+1
...following up on 1453c2c8f13bac64ecd1981af7cebf1c421808ac "prefer vector::data to &vector[0]" Change-Id: I7c113747d92d144a521d49b89384dd8bf1215c01 Reviewed-on: https://gerrit.libreoffice.org/72765 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-13fix wrong SET/QUERY flags passed to uno::ReferenceNoel Grandin3-4/+4
By creating deleted methods for the wrong calls. Avoids the compiler needing to construct a temporary Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a Reviewed-on: https://gerrit.libreoffice.org/72103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-10an uno -> a unoCaolán McNamara1-1/+1
Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d Reviewed-on: https://gerrit.libreoffice.org/72105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-09regenerate PCH headers for the 4 new levelsLuboš Luňák1-70/+14
Plus some build fixes triggered by this. Change-Id: I59b21def706598ceffd45ae5b1f0262ec9c1ad50 Reviewed-on: https://gerrit.libreoffice.org/71581 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-08improve tools::Rectangle->basegfx::B2?Rectangle conversionNoel Grandin1-4/+4
Improve the conversion method to do something reasonable with empty Rectangle. Use the conversion method in more places. Change-Id: I48c13f3d6dae71f39f03f7939101e545c8125503 Reviewed-on: https://gerrit.libreoffice.org/71853 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-04-28prefix member variables of AnimationBitmapTomaž Vajngerl1-17/+17
Change-Id: Ic84773399c95d61f843e4388fe01d00cd4facc5a Reviewed-on: https://gerrit.libreoffice.org/71425 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-28rename animate.hxx to animate/Animation.hxx, more changes followTomaž Vajngerl2-2/+2
This is the first step of refactoring Animation where it is needed to separate AnimationBitmap(s) from the Animation class, which is also responsible for displaying of animation. General idea is to make Graphic work only with AnimationBitmaps, which can be freely be swapped out and in, make copies - all transparantly from the actually displaying them and possibly it will also remove the need to copy the animation objects. Change-Id: If5d55ac1a5b26c3880d4f7602be57742b086f9da Reviewed-on: https://gerrit.libreoffice.org/71406 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-17tdf#124756 slideshow: avoid mbPaintDisabled for media windowsMiklos Vajna1-1/+0
Commit 3e0092031b73bad107e3122d5d4be2f5bd487744 (tdf#112318 sd opengl: fix lack of initial animation, 2019-04-05) enabled processing of idle events between two updates of the slideshow to help OpenGL, which uncovered a problem with media shapes. On one hand, slideshow::internal::ViewMediaShape::implInitializePlayerWindow() calls EnablePaint(false) on the media window. OTOH, vcl::Window::ImplCallPaint() handles mbPaintDisabled by invalidating the relevant area of the window, which causes a paint<->invalidate loop. Fix the problem by nominally still enabling paints on the media window: nothing will change in practice (since the actual media overlay will be on top of it), but this way the loop goes away. mbPaintDisabled is handled like this since the initial import, the media window flag was added much later, so it makes more sense to adapt the later. Change-Id: Ib89b68d93aa9d09dbcad33eb6e75a8a25ef1b752 Reviewed-on: https://gerrit.libreoffice.org/70869 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-04-16loplugin:sequentialassign in sfx2..solenvNoel Grandin2-8/+3
Change-Id: I57e11d45aad48713b7c6802e2b6976fd916fc6ba Reviewed-on: https://gerrit.libreoffice.org/70717 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-15improve loplugin simplifyconstructNoel Grandin2-2/+2
to find stuff like OUString s = OUString("xxx") Change-Id: Ie7ed074c1ae012734c67a2a89c564c1900a4ab04 Reviewed-on: https://gerrit.libreoffice.org/70697 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-31tdf#73092 remove remaining shape of the repeating animation.Mark Hung5-4/+37
It is neccessary to set a drawshape to invisible (i.e. remove the effect ) before the drawshape rewind, otherwise it remains at the original place. The timenode container will ask its child to remove the effect after all the child finished, before it start to repeat or it deactivate. Change-Id: Iaef1a8269b61afa0c37b03655e2ea169f1d3c453 Reviewed-on: https://gerrit.libreoffice.org/69543 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>