summaryrefslogtreecommitdiff
path: root/slideshow
AgeCommit message (Collapse)AuthorFilesLines
2017-02-06Add missing #includesStephan Bergmann2-0/+4
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-03new loplugin:unusedenumconstantsNoel Grandin1-1/+2
These are the simple removals, where it is obviously safe, the more complex ones will come in separate commits Change-Id: I7211945a6a5576354b60d9c709940ce9b674f308 Reviewed-on: https://gerrit.libreoffice.org/33828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin2-2/+2
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann5-112/+65
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25loplugin: unnecessary destructor sfx2..storeNoel Grandin4-11/+0
Change-Id: Idbf2585e48cd89a43ab68c5c8819880d20461ccf Reviewed-on: https://gerrit.libreoffice.org/33514 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski1-1/+1
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-17remove SunStudio hacksMichael Stahl1-14/+0
There is no "SOLARIS compiler". Change-Id: Idcfaee36307b1a4112f7fd6702c5f0e528f812c8
2017-01-17replace #ifdef SOLARIS with #ifdef __sunMichael Stahl1-1/+1
Check for a macro that is defined by the compiler, we don't really need one defined by the build system. Change-Id: Iccb8e3198396881395c97a6b81690ebe64b7e9d2
2017-01-12silence coverity#1371305 Missing move assignment operatorCaolán McNamara1-20/+19
Change-Id: I761e07d1583262d83074addbff4ca67b01640387
2016-12-15no point in having both SAL_WARN and OSL_FAIL for the same thingNoel Grandin1-4/+0
Change-Id: I1beafff257e968a62184f8b1d8cf2a3a24e7c945 Reviewed-on: https://gerrit.libreoffice.org/32039 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-15teach sallogareas plugin to catch inconsistenciesNoel Grandin2-2/+2
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a Reviewed-on: https://gerrit.libreoffice.org/32004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13post glew->epoxy, we don't need to link to win openg32 and mac OpenGLCaolán McNamara1-18/+0
Change-Id: Iadc373961dcca788b1174ee71cb386979ce064ed Reviewed-on: https://gerrit.libreoffice.org/31954 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-13gtk3: implement opengl support for slideshowCaolán McNamara3-43/+46
all of them work, except "Fall" doesn't look right, but it has the exact same problem under gtk2/gen to. Change-Id: I73cb9c0fb8211f727198be78d90d4f80a4f8c7c8 Reviewed-on: https://gerrit.libreoffice.org/31214 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-13change from glew to epoxyCaolán McNamara5-13/+3
because that works under wayland out of the box and gtk3 uses it already Change-Id: Iefaac31e325534a81a5389f752804af917c1baef Reviewed-on: https://gerrit.libreoffice.org/31213 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-11OSL_TRACE -> SAL in sfx2..svxNoel Grandin11-77/+55
Change-Id: I78cf8058a5682baa3d7b00a25feeb2d28fb3e66e Reviewed-on: https://gerrit.libreoffice.org/31799 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin2-2/+2
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05getVerticesSize got renamed to getVerticesByteSizeCaolán McNamara1-1/+1
Change-Id: I7eff6eeb92aede6beb4412aa3e574ae75d651d8b
2016-12-05rework diamond transition to use only opengl coreCaolán McNamara1-8/+18
cause that's all we've got in gtk3 Change-Id: I6a47e344ccd39ba63e7a51ae18f89bb05bb642c4 Reviewed-on: https://gerrit.libreoffice.org/31496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-05loplugin:unnecessaryoverride (dtors) in slideshowStephan Bergmann2-8/+2
Change-Id: I5c4bc26bc51347e453ce69913edc52cf1f1aa821
2016-12-02warning C4018: '<' : signed/unsigned mismatchStephan Bergmann1-1/+1
Change-Id: I5e6a6debf01886c283f5a2d6b9cacc00a44f7134
2016-12-02get vertices count without jumping through hoopsDavid Tardon2-2/+8
Change-Id: I0cab6b2f9fffc8cf9fc5059b8dc48fa9407e42b5
2016-12-02rename to avoid further misunderstandingsDavid Tardon2-3/+3
Change-Id: Ibcfae1b3ec118d74921312a80eb56c97c623f4a9
2016-12-02coverity#1371200 Missing move assignment operatorCaolán McNamara4-49/+48
adjust things to not need one Change-Id: I1079f50d8813f86c4828be602687b4cbffe61415
2016-11-30glDrawArrays takes num of indices, not size of storageCaolán McNamara1-1/+1
this stops the strange missing corner seen during the diamond transition Change-Id: If806a0a3303eb38644bb6d3a479cadbd5fe9ca25
2016-11-21Delete the "Any-to-Any" template specializations for LIBO_INTERNAL_ONLYStephan Bergmann1-1/+1
i.e., css::uno::Any function template specializations Any::has<Any>() const Any::get(Any const &) const operator >>=(Any const &, Any &) operator <<=(Any &, Any const &) that don't make much sense (the first is always true, the rest can be replaced with operator =, which additionally supports move semantics). For 3rd-party compatibility, do this only for LIBO_INTERNAL_ONLY, however. However, some generic template code did benefit from operator >>= working also for Any, so make up for that with a new (LIBO_INTERNAL_ONLY, given that operator >>= still covers if fine for !LIBO_INTERNAL_ONLY) fromAny, complementing the existing toAny. Change-Id: I8b1b5f803f0b909808159916366d53c948206a88 Reviewed-on: https://gerrit.libreoffice.org/30022 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-17loplugin:unusedfieldsNoel Grandin1-22/+0
Change-Id: Id2dbbf384637223db3d334d95332251832918003 Reviewed-on: https://gerrit.libreoffice.org/30927 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07loplugin:unnecessaryvirtual in sfx2..svtoolsNoel Grandin4-22/+8
Change-Id: Ib34e14806f7cc9a97ecfd68687ab17ee5c1f022b Reviewed-on: https://gerrit.libreoffice.org/30652 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-06tdf#103696 ensure glm always uses radiansDavid Tardon1-0/+4
This is set just locally for OGLTrans, because I have no idea what the other places that use glm expect... Change-Id: I83675ef2463ab945cb3d6885f803dcbae60a5558
2016-10-31fix doc comment to match codeDavid Tardon1-2/+2
This has been wrong since the initial commit... Change-Id: I271375ba10c37aa9b198476955d66af9fc019e27
2016-10-31convert angle from degrees to radians for glmDavid Tardon1-3/+5
This makes simple (i.e., not implemented as a shader) OpenGL transitions work correctly again. Change-Id: I773f686089bce3611940743b1a7f5046093886e8
2016-10-27loplugin:expandablemethods in slideshowNoel Grandin2-26/+4
Change-Id: I3a7207e0566bc4b871b364da3180ce67e1099de8
2016-10-25rename dir to follow suitDavid Tardon7-4/+4
Change-Id: I894e6a089e99ed6cec3a970ffa0cce9cbd9a9e1a
2016-10-25remove unnecessary dir and name prefixDavid Tardon6-7/+7
Change-Id: I57b8d8b187fe7b8a99f2f90d696cd8c97b8a07b6
2016-10-25merge duplicate source file listsDavid Tardon1-17/+8
Change-Id: I55c746c92a6803a67e7129c43d2acd94aa7cbf8e
2016-10-24loplugin:countusersofdefaultparams in sd..slideshowNoel Grandin2-2/+2
Change-Id: Iaf10935d8f231676333018a5954d97defe35acf6
2016-10-20loplugin:expandablemethodds in sfx2..starmathNoel Grandin5-22/+5
Change-Id: Ia4c411f5a9a68c2f344188ce6b6bc1815c89f993 Reviewed-on: https://gerrit.libreoffice.org/30055 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05InfoFont/Color is not used by vcl nowCaolán McNamara1-1/+1
anywhere anyone wanted to Get[Font|Color] give it the Label ones instead. why this is exposed through uno is bewildering, stubbed those out for the moment Change-Id: I7a31d027287436be1c075c76a370047efd010bf3
2016-10-05convert MapUnit to scoped enumNoel Grandin1-2/+2
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann1-2/+2
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-09-22loplugin:unusedmethods in sc..vclNoel Grandin1-4/+0
Change-Id: I70fcf95dfd3db05b4fd6e5cee37866f673d3afa8 Reviewed-on: https://gerrit.libreoffice.org/29183 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl5-34/+34
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann13-20/+20
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-05convert RasterOp to scoped enumNoel Grandin1-1/+1
Change-Id: I136423c105316c9b5b18e64d04a248fd7ac5590b
2016-08-31slideshow: stop whining about PresenterCanvas' lack of XUpdatableMichael Stahl1-3/+6
Change-Id: I1e447f5eccb41325d96e9c4cb1598a05e702badc
2016-08-29loplugin:countusersofdefaultparamsNoel Grandin1-1/+1
Change-Id: I26f46ddac3d7d810ebfa1c3e7f1a77427369828e Reviewed-on: https://gerrit.libreoffice.org/28451 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-05loplugin:countusersofdefaultparams in sfx2..svgioNoel Grandin3-8/+7
Change-Id: Ia01f3a9aa21c88df5fe5242ad4a3c0acbe68fda0 Reviewed-on: https://gerrit.libreoffice.org/27903 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-03Reduce ENABLE_OPENGL / ENABLE_HEADLESS confusionTor Lillqvist2-2/+2
ENABLE_OPENGL means whether to enable the OpenGL slideshow transition code. It does not mean whether to enable use of OpenGL in general. So rename it to ENABLE_OPENGL_TRANSITIONS while at it. ENABLE_HEADLESS means whether to disable use of X11 and OpenGL on X11 (and Wayland) platforms, I think, meaning Linux and maybe Solaris and the BSDs. Maybe it should be renamed to DISABLE_X11_AND_OPENGL. Change-Id: Ibb30f51646b1bcc477fe691a3fa38c7a1e3944ae
2016-08-01loplugin:countusersofdefaultparams in shell..starmathNoel Grandin9-16/+16
Change-Id: I553d1b031b8d261a1caa8b77a8d687af21a6f8d6 Reviewed-on: https://gerrit.libreoffice.org/27672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-27improve passstuffbyref return analysisNoel Grandin4-4/+4
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-19tdf#97195 make diamond transition work againDavid Tardon2-1/+57
Change-Id: I28236dd0c7dbd4e1798055229b2db2d0101a493e