summaryrefslogtreecommitdiff
path: root/slideshow
AgeCommit message (Collapse)AuthorFilesLines
2015-10-11tdf#93243 slideshow: replace boost::bindDaniel Robertson7-96/+52
Replace boost::bind with C++11 lambdas Change-Id: I13c500d085e6b8e80b2c067139db4ed0fffb2c71 Reviewed-on: https://gerrit.libreoffice.org/19299 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-11Replace simple while loops with range-based forDaniel Robertson10-195/+94
Replace simple while loops with range-based for-loops when apropriate. There should be no side effects due to this change. Change-Id: I0c39d4c10c991354248e864a09333144974c953c Reviewed-on: https://gerrit.libreoffice.org/19281 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-09slideshow: replace for_each with range-based forDaniel Robertson11-174/+82
Replace ::std::for_each for a more readable range-based for loop in cases in which the function object to be applied by for_each is more readable as the body of a for loop. Change-Id: I5798293cdd0d784cc4c95c67e3fc6a0b930db8bb Reviewed-on: https://gerrit.libreoffice.org/19261 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-08tdf#94222: Revert "slideshow: replace for_each with range-based loop"Jan Holesovsky13-147/+316
This reverts commit ead5bc3cfb07a4e96e367e7904dc674ee5f5ccd6. Change-Id: Icc2778cf904a71c4deaff4575d0de231acfc1335
2015-10-02loplugin:unusedmethodsNoel Grandin6-35/+2
Change-Id: Ie1603adf3908fd0668bcbe8f75c6bafa0d0bfd6c Reviewed-on: https://gerrit.libreoffice.org/19072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-30Fix typosAndrea Gelmini5-6/+6
Change-Id: I89ff6d31662824d83961d6457b82db8d8031168c Reviewed-on: https://gerrit.libreoffice.org/18977 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-29Renamed wrongly prefixed boolean variablesStefan Heinemann2-14/+14
Fixed tdf#94269 Change-Id: I63109cc4e095bad680d7637a065080ea368860ae Reviewed-on: https://gerrit.libreoffice.org/18851 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-21Properly #if these debug hooksfeature/chained-text-boxesStephan Bergmann1-0/+4
...moved here with 6fbab2ce87372bd98275d8239cd782d0ca6375e8 "loplugin:unreffun"; this file still indirectly includes boost/scoped_ptr.hpp via. boost/spirit Change-Id: Ib2f251420950395f58415c1f7c944b7e8fd61476
2015-09-21loplugin:unreffunStephan Bergmann2-8/+15
Change-Id: I526b9e1cff25a30c3f6b935c1a11ef571f7a12ea
2015-09-21boost->stdCaolán McNamara7-11/+7
Change-Id: I787ff19fd41d5ecee56efa1aa7ee539f46650703 Reviewed-on: https://gerrit.libreoffice.org/18703 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-16slideshow: fix mysterious crash with the gtk3 vclplugMichael Stahl1-2/+28
For some reason with gtk3 events are handled a bit differently, and in particular after the PresenterSlideShowView::Resize() sets the mbIsForcedPaintPending = true, with gtk2 we get a notifySlideAnimationsEnded event and then a notifyViewChanged event that calls PresenterSlideShowView::clear() to reset the flag, but with gtk3 the flag isn't reset and then PresenterSlideShowView::ForceRepaint() destroys the SlideView, while there are still events in the EventQueue with pointers to it. Since i'm evidently too dumb to tell what of this event handling is working correctly and what is buggy, avoid the crash by checking that the SlideView is still alive in the event handlers. Change-Id: Ib88e61536c21e9787cef8a436341bfbd89914f4b
2015-09-16tdf#94006 - need an explicit dispose for slideshow's GLContext.Michael Meeks1-0/+2
Fixes crasher exiting slideshow. Change-Id: I14b6a2c1abc946f590bf91cab19099753172fd95
2015-09-14boost->stdCaolán McNamara19-58/+58
Change-Id: I3fd9e1599c5ad812879a58cf1dabbcd393105e1c Reviewed-on: https://gerrit.libreoffice.org/18564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-13cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: I39194062ba68c4cb1ccc9b93c629f005ccd02497
2015-09-11tdf#94031 - slideshow: bind correct GL context for prepareEnvironmentLubosz Sarnecki1-0/+1
Change-Id: Ib139e81f770531f7d808764dd3a77c7ac8d6fa3c
2015-09-08OpenGL: use CHECK_GL_ERROR() only when a context is bound.Michael Meeks1-1/+1
Change-Id: I2cdc14defe5c4bd95776206df65fd57589d40429
2015-09-08OpenGL: use CHECK_GL_ERROR() only when a context is bound.Michael Meeks1-1/+2
Removes a large number of spurious GL errors left & right. Change-Id: I0b5639478812982b39d3b88be2600dad5d3f1fd0
2015-09-08tdf#94006 - fix OpenGLContext mis-use in several places.Michael Meeks1-4/+4
gltf rendering, OpenGL canvas, GL transitions & GL capable (charts) Avoid GLX operations on un-initialized contexts. Change-Id: I7f523640f66ab656896181e5c865879234f6640e
2015-09-07slideshow: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe11-27/+21
with the variadic variants. Change-Id: I3160235d0e6253626a8facbfed33e3c252505cbf Reviewed-on: https://gerrit.libreoffice.org/18336 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-29o3tl/cow_wrapper: remove boost dependencyDaniel Robertson3-0/+3
Remove boost dependencies from ::o3tl::cow_wrapper, and add the necessary includes to files including checked_delete and noncopyable that do not already include the necessary files. Change-Id: Iedae4232002792724226829a5d5cf9d16ffd0686 Reviewed-on: https://gerrit.libreoffice.org/18125 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-24slideshow: replace for_each with range-based loopDaniel Robertson13-315/+146
Replace ::std::for_each for a more readable range-based for loop in cases in which the function object to be applied by for_each is more readable as the body of a for loop. Change-Id: Ib0b488b36ed58c65c56357e04391b85096d043aa Reviewed-on: https://gerrit.libreoffice.org/17930 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-20loplugin: defaultparamsNoel Grandin4-5/+5
Change-Id: Ibf0ea539d2a95073a12f84964759d9c7a94baa7b
2015-08-17slideshow: replace for_each with range-based forDaniel Robertson9-243/+135
Replace ::std::for_each for a more readable range-based for loop in cases in which the function object to be applied by for_each is more readable as the body of a for loop. In addition, replace while loops with range-based for loops when possible and complex implementations of boost::bind with lambda expressions. Change-Id: I6adfb18197bd1b8627719adfca2e4c36d58a0e05 Reviewed-on: https://gerrit.libreoffice.org/17786 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-12Range-based for-loops.Jan Holesovsky1-17/+8
Change-Id: I6fb0d182dfccb3af42f0bbc60969c72df09b6ce6
2015-08-11slideshow: prefer value_type over manual type generationThorsten Behrens7-16/+14
Change-Id: I3e088a10e7bc0da73e4fa20db15e71581661fe4b Reviewed-on: https://gerrit.libreoffice.org/17641 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-11loplugin:unreffunStephan Bergmann1-0/+1
Change-Id: I130b4f1eca4cf07f17aac995c4a44a8fdf51a4df
2015-08-11loplugin:cstylecastNoel Grandin2-5/+5
Change-Id: Ie44d7b031b16647457cf08dc944526c720360f9d
2015-08-11-Werror,-Winconsistent-missing-overrideNoel Grandin9-10/+10
Change-Id: I3597b5d5cd54e6ff5398bdb5075b9fa03f9b5819
2015-08-11stop inclduing canvas/verbosetraces.hxx and canvas/debug.hxxNorbert Thiebaud99-216/+25
also clean-up and 'standardize' the include sections of canvas' source code Change-Id: Ib437a41ea41ae2ea6528f755ae5b2828775aaf73 Reviewed-on: https://gerrit.libreoffice.org/17633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-11slideshow: stop (mis)-using VERBOSENorbert Thiebaud14-68/+49
converted the use of internal 'verbose' level tracing to SAL_INFO/SAL_WARN Change-Id: Iab89d9b5c75fe476c6516718f1cee3d01d196858 Reviewed-on: https://gerrit.libreoffice.org/17632 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-08Explicit capture annotationsStephan Bergmann1-1/+1
Change-Id: I7be1a36196a07a80a7b7173c3869621f5d707204
2015-08-08tdf#92459 replace deprecated o3tl featuresDaniel Robertson10-96/+49
Replace deprecated features from the o3tl including select1st and select2nd with lambda expressions. Change-Id: I0cb1aedc3e193c52d25e2837a47d9d90c898079e Reviewed-on: https://gerrit.libreoffice.org/17459 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-07cppcheck:noExplicitConstructorNoel Grandin26-36/+36
Change-Id: I2717d3d120df8af5b7e9af8d147a57b9f5b5ecbe
2015-08-03slideshow: dumb this down to hopefully make non-GCC compilers happyMichael Stahl1-3/+18
Change-Id: If08a4f0c177abf38a381dcb9ba73a09265b2bcb5
2015-08-03slideshow: convert generateEvent args from boost::bindMichael Stahl1-2/+4
Change-Id: I85d240989e41a45b62a4631bb847daccd1919f34
2015-08-03slideshow: try to fix libc++/MSVC build by replacing boost::bindMichael Stahl13-69/+44
Change-Id: I6418119f9d3e70ea89f7c8a094bbde42eeadec8c
2015-08-03slideshow: replace boost::function with std::functionMichael Stahl6-21/+22
Change-Id: Ibcb0f40d327e3086b6493cf2052caf135aa89e10
2015-07-17loplugin:unusedmethods slideshowNoel Grandin19-178/+0
Change-Id: I66b6cddb638a9fc1228d3ea9df5d112300a00eb3 Reviewed-on: https://gerrit.libreoffice.org/17128 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-10do not include boost/utility.hppMichael Stahl11-11/+11
It just includes a bunch of other boost headers; mostly we need boost/noncopyable.hpp so include that directly. This eliminates 831 MB(!) of boost/preprocessor/seq/fold_left.hpp completely, which is the 2nd biggest header after ustring.hxx. Change-Id: I3df55770adcb46e56f389af828e8ba80da2dc1f2
2015-07-08Fix typosAndrea Gelmini2-2/+2
Change-Id: I020c7ce4d9aa93cb0292378a410cdb9f7788e920 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-07-04Fix typosAndrea Gelmini1-1/+1
Change-Id: Ic6415423f46aaee7ba90239a617c318cf92ae222 Reviewed-on: https://gerrit.libreoffice.org/16711 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-23Revert "Typo: iff->if"Julien Nabet2-3/+3
This reverts commit cf92da3d6e1de14756efe3f1ee79f393a2f3787d. iff can mean "if and only if" so not a typo
2015-06-23Typo: iff->ifJulien Nabet2-3/+3
Change-Id: I3fc60856b5a56e71d70b55c89323be074bdec3b3
2015-06-18slideshow: [loplugin:unreffun]Michael Stahl1-8/+0
Change-Id: I112e85d999a160b9b6393e924e981231d17f439d
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe2-3/+2
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-16Fix typosAndrea Gelmini1-1/+1
Change-Id: Icfb885b72d51edc886851cf503c56fa12b8f559f Reviewed-on: https://gerrit.libreoffice.org/16309 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini1-2/+2
Change-Id: I528752dfabeb31d14c350f79819b521537ab9b56 Reviewed-on: https://gerrit.libreoffice.org/16300 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-16Fix typosAndrea Gelmini2-2/+2
Change-Id: I28cfc629dc3d6ef54128615452667ccce86c1072 Reviewed-on: https://gerrit.libreoffice.org/16297 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15cppcheck:unreadVariableNoel Grandin1-2/+1
Change-Id: I03981ceba67280e8ed98a9add7f24b3bd958d522
2015-06-15inline COMPHELPER_SERVICEDECL_ macroNoel Grandin2-2/+12
it was not adding any value Change-Id: I6a911aac81e883f9155ed0cf24bfb7904efb3f92
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-23 00:58:50 +0000