summaryrefslogtreecommitdiff
path: root/slideshow
AgeCommit message (Collapse)AuthorFilesLines
2015-09-16tdf#94006 - need an explicit dispose for slideshow's GLContext.Michael Meeks1-0/+2
Fixes crasher exiting slideshow. Change-Id: I14b6a2c1abc946f590bf91cab19099753172fd95 Reviewed-on: https://gerrit.libreoffice.org/18609 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2015-09-11tdf#94031 - slideshow: bind correct GL context for prepareEnvironmentLubosz Sarnecki1-0/+1
Change-Id: Ib139e81f770531f7d808764dd3a77c7ac8d6fa3c Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2015-09-09OpenGL: use CHECK_GL_ERROR() only when a context is bound.Michael Meeks1-2/+3
Removes a large number of spurious GL errors left & right. Change-Id: I0b5639478812982b39d3b88be2600dad5d3f1fd0 Reviewed-on: https://gerrit.libreoffice.org/18422 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-09-08tdf#94006 - re-factor and fix OpenGLContext mis-use.Michael Meeks1-4/+4
Squashes two related patches from master: Don't use rtl::Reference for the global / list state, so the ref-count reflects the number of real users. Hold a reference during ~OpenGLContext. Fix mis-use in: gltf rendering, OpenGL canvas, GL transitions & GL capable (charts) Avoid GLX operations on un-initialized contexts. Signed-off-by: Miklos Vajna <vmiklos@collabora.co.uk> Conflicts: vcl/source/opengl/OpenGLContext.cxx vcl/workben/vcldemo.cxx canvas/source/opengl/ogl_spritedevicehelper.hxx Change-Id: I7ea29b544d53bb80b25fa6663d39f345bf8f4e64
2015-06-13tdf#91960 presentation causes Impress crashNoel Grandin2-10/+12
The SystenChildWindow in question is owned by ViewMediaShape Fixed ViewMediaShape to dispose the vcl objects it creates correctly. Also fix another crash in MediaWindowImpl child window correctly disposing its children. Change-Id: If4aebcb6e5824266c154416f7246d73c6cb3509c Reviewed-on: https://gerrit.libreoffice.org/16230 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-05-15convert META_*_ACTION constants to scoped enumNoel Grandin3-14/+15
Change-Id: I8ecfbfecd765a35fafcbcc5452b0d04a89be2459
2015-05-13slideshow: simplify code by replacing std::find_if by std::any_of/std::none_ofTakeshi Abe8-48/+28
Change-Id: Ib8eec5074e82127e11f4fba2c0b143ab8cef3bcc Reviewed-on: https://gerrit.libreoffice.org/15714 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-05-05loplugin:staticmethodsNoel Grandin7-15/+15
Change-Id: I4d19f868a618cb135aa7a949222972dc35b47d2a
2015-05-05loplugin:staticmethodsNoel Grandin1-1/+1
Change-Id: I384a5e60f4b7b2f479c89ef97630519059ab720f
2015-04-30Get rid of the initial :: for the vcl namespaceTor Lillqvist2-3/+3
We used it all over the place without leading :: already anyway, even in many files in include. So let's be consistent. In the majority of cases, prefer the easier-on-the-eyes choice, not the "safe" one. In those files in include where *all* existing uses of ::vcl:: indeed used the :: prefix, there let's keep it for consistency. Change-Id: If99cb41d3bf290d38c601d91125c3c8d935e61d0
2015-04-28Merge remote-tracking branch 'origin/feature/vclptr'Michael Meeks4-46/+47
Resolve several thousand lines of conflicts. Conflicts: accessibility/source/extended/accessiblelistbox.cxx accessibility/source/standard/vclxaccessiblecombobox.cxx accessibility/source/standard/vclxaccessibledropdowncombobox.cxx accessibility/source/standard/vclxaccessibledropdownlistbox.cxx accessibility/source/standard/vclxaccessiblelistbox.cxx accessibility/source/standard/vclxaccessibletextfield.cxx basctl/source/basicide/basidesh.cxx cui/source/inc/chardlg.hxx cui/source/tabpages/tpbitmap.cxx dbaccess/source/ui/dlg/UserAdmin.cxx dbaccess/source/ui/querydesign/ConnectionLineAccess.cxx extensions/source/propctrlr/propertyeditor.hxx extensions/source/scanner/sanedlg.cxx filter/source/pdf/impdialog.cxx include/sfx2/mgetempl.hxx include/sfx2/sidebar/SidebarToolBox.hxx include/sfx2/viewsh.hxx include/svtools/brwbox.hxx include/svtools/filectrl.hxx include/svtools/scrwin.hxx include/svx/dlgctrl.hxx include/svx/sidebar/Popup.hxx include/svx/sidebar/PopupContainer.hxx include/svx/sidebar/PopupControl.hxx include/svx/sidebar/SidebarDialControl.hxx include/svx/sidebar/ValueSetWithTextControl.hxx sc/source/ui/condformat/condformatdlgentry.cxx sc/source/ui/navipi/navipi.cxx sc/source/ui/sidebar/CellBorderStyleControl.hxx sd/source/ui/animations/CustomAnimationDialog.cxx sd/source/ui/inc/DrawViewShell.hxx sd/source/ui/inc/Ruler.hxx sd/source/ui/inc/SlideSorter.hxx sd/source/ui/inc/ViewTabBar.hxx sd/source/ui/inc/Window.hxx sd/source/ui/inc/morphdlg.hxx sd/source/ui/inc/sdpreslt.hxx sd/source/ui/sidebar/CurrentMasterPagesSelector.hxx sd/source/ui/sidebar/LayoutMenu.hxx sd/source/ui/sidebar/MasterPagesSelector.hxx sd/source/ui/sidebar/NavigatorWrapper.hxx sd/source/ui/sidebar/PanelBase.hxx sd/source/ui/sidebar/RecentMasterPagesSelector.cxx sd/source/ui/sidebar/RecentMasterPagesSelector.hxx sd/source/ui/slideshow/showwindow.hxx sd/source/ui/slidesorter/view/SlsInsertAnimator.cxx sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx sd/source/ui/view/ViewShellBase.cxx sd/source/ui/view/drviewsa.cxx sfx2/source/appl/fileobj.hxx sfx2/source/appl/opengrf.cxx sfx2/source/control/thumbnailviewacc.hxx sfx2/source/dialog/securitypage.cxx sfx2/source/dialog/templdlg.cxx sfx2/source/doc/docinsert.cxx sfx2/source/doc/guisaveas.cxx sfx2/source/inc/alienwarn.hxx sfx2/source/sidebar/Deck.cxx sfx2/source/sidebar/Deck.hxx sfx2/source/sidebar/DeckTitleBar.cxx sfx2/source/sidebar/DeckTitleBar.hxx sfx2/source/sidebar/MenuButton.cxx sfx2/source/sidebar/MenuButton.hxx sfx2/source/sidebar/Panel.cxx sfx2/source/sidebar/Panel.hxx sfx2/source/sidebar/PanelTitleBar.hxx sfx2/source/sidebar/SidebarDockingWindow.hxx sfx2/source/sidebar/SidebarToolBox.cxx sfx2/source/sidebar/TabBar.hxx sfx2/source/sidebar/TabItem.cxx sfx2/source/sidebar/TabItem.hxx sfx2/source/sidebar/TitleBar.hxx sfx2/source/toolbox/imgmgr.cxx starmath/inc/edit.hxx starmath/inc/smmod.hxx starmath/qa/cppunit/test_starmath.cxx starmath/source/edit.cxx starmath/source/smmod.cxx svtools/source/brwbox/brwbox1.cxx svtools/source/brwbox/datwin.hxx svtools/source/contnr/fileview.cxx svtools/source/contnr/simptabl.cxx svtools/source/control/filectrl.cxx svtools/source/control/valueimp.hxx svx/inc/GalleryControl.hxx svx/source/dialog/dlgctrl.cxx svx/source/dialog/swframeexample.cxx svx/source/fmcomp/fmgridif.cxx svx/source/gallery2/GalleryControl.cxx svx/source/sidebar/EmptyPanel.hxx svx/source/sidebar/area/AreaPropertyPanel.hxx svx/source/sidebar/area/AreaTransparencyGradientControl.hxx svx/source/sidebar/graphic/GraphicPropertyPanel.hxx svx/source/sidebar/insert/InsertPropertyPanel.cxx svx/source/sidebar/insert/InsertPropertyPanel.hxx svx/source/sidebar/line/LinePropertyPanel.hxx svx/source/sidebar/line/LineWidthControl.cxx svx/source/sidebar/line/LineWidthControl.hxx svx/source/sidebar/line/LineWidthValueSet.hxx svx/source/sidebar/paragraph/ParaPropertyPanel.hxx svx/source/sidebar/possize/SidebarDialControl.cxx svx/source/sidebar/text/TextCharacterSpacingPopup.hxx svx/source/sidebar/text/TextPropertyPanel.hxx svx/source/sidebar/tools/PopupContainer.cxx svx/source/sidebar/tools/PopupControl.cxx svx/source/sidebar/tools/ValueSetWithTextControl.cxx svx/source/svdraw/svdfmtf.hxx svx/source/svdraw/svdibrow.cxx svx/source/tbxctrls/colrctrl.cxx svx/source/tbxctrls/tbcontrl.cxx sw/source/ui/dbui/mmaddressblockpage.cxx sw/source/ui/dialog/uiregionsw.cxx sw/source/ui/index/cnttab.cxx sw/source/uibase/inc/drpcps.hxx sw/source/uibase/sidebar/PageColumnControl.hxx sw/source/uibase/sidebar/PageMarginControl.hxx sw/source/uibase/sidebar/PageOrientationControl.hxx sw/source/uibase/sidebar/PagePropertyPanel.hxx sw/source/uibase/sidebar/PageSizeControl.hxx sw/source/uibase/uiview/view2.cxx sw/source/uibase/utlui/navipi.cxx vcl/inc/svdata.hxx vcl/source/control/combobox.cxx vcl/source/control/lstbox.cxx vcl/source/window/dockwin.cxx vcl/source/window/winproc.cxx Change-Id: I056cf3026ff17d65cca0b6e6588bda4a88fa8d95
2015-04-27More loplugin:simplifyboolStephan Bergmann2-4/+4
Change-Id: I5426400b0831a353336451409103ebeb01dcd946
2015-04-24loplugin:simplifyboolStephan Bergmann2-3/+2
Change-Id: I427b32e79696bbdc521b78f4b4c1e6f4fce119a7
2015-04-18fix higher debug levelsCaolán McNamara1-2/+1
Change-Id: I78a2b74a4e80018a8093457cb15a93d49c0ff8f3
2015-04-16slideshow: convert new to ::Create to get initial ref-counting right.Michael Meeks1-3/+3
Change-Id: I513dacfa0dd2e902437578611b6d39575f2e7314
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin11-61/+61
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-04-13loplugin:staticmethodsNoel Grandin9-18/+16
Change-Id: I33a8ca28b0c3bf1c31758d93238e74927bebde9c
2015-04-10Automated conversion of VclPtr construction to use Instance template.Michael Meeks2-4/+4
Change-Id: I8be9141b9653e73ebd23a5a3d810f240c376f97e
2015-04-10Fix OutputDevice members / stack allocation: slideshow, starmath, sd, sc.Michael Meeks2-41/+41
Change-Id: I6d6d41b8a6501ce7d35c78e5b730ea45143d6b73
2015-04-10vclwidget: convert lots more sites to use VclPtrNoel Grandin1-2/+3
seems there was a lot of shared_ptr usage floating around... Change-Id: Icd05243170eb8493709275fc36bf986fc194b781
2015-04-05WaE: Unreferenced function definitionTor Lillqvist1-20/+0
Change-Id: I3190e994b7b63b258436ef5d35542722fa91fa46
2015-04-04callcatcher: update unusedcodeCaolán McNamara2-22/+0
mostly changed due to loplugin:constantfunction Change-Id: Ib677c78db256f8032a99b3f02a3e363fee68ebcc
2015-04-02fix higher debug level buildCaolán McNamara2-4/+4
Change-Id: I23324d03f3388642e964c13d8a5c32311f97ef08
2015-03-24loplugin:constantfunction: variousNoel Grandin5-27/+0
Change-Id: I6eddda9f4b31c7ce413c328b6a857a81bd222eed
2015-03-13tdf#43157: Fix format string violations in OSL_TRACE etc.Stephan Bergmann1-2/+4
...for a 32-bit build, similar to what ee11e221d2108212619e1bbe7f029e7d9afdba32 "tdf#43157: Fix format string violations in OSL_TRACE etc." did for a 64-bit build Change-Id: I05dd79ede3e66cb9ab7a33792319eb34b34c82dd
2015-03-13tdf#43157: Fix format string violations in OSL_TRACE etc.Stephan Bergmann2-14/+18
...in preparation of enabling the __attribute__((format(...))) in sal_detail_logFormat (include/sal/detail/log.h) Change-Id: I8a859199fa11ca0f9f4f4b4b23a8ebddec955a86
2015-03-09V801: Decreased performanceCaolán McNamara1-1/+1
Change-Id: I9e9a00acf9503980f0c6c7cd0a20378e5ca7390d
2015-03-05V801: Decreased performanceCaolán McNamara1-2/+2
Change-Id: I5e7b5327b542f610efb0960b8bcfad10e04025b5
2015-03-04V813: Decreased performanceCaolán McNamara1-5/+5
Change-Id: Ica2563d9e8da15e19eb38246d4de54a1fcb75655
2015-03-02Remove references to unused GLUStephan Bergmann1-1/+0
(after removing the one remaining use of gluErrorString in a SAL_WARN call) Change-Id: Ib94e346d73e508e69c07deafdc690e3ae0e23d4e
2015-03-02Replace uses of deprecated gluBuild2DMipmapsStephan Bergmann1-11/+27
...with glGenerateMipmap (since OpenGL 3.0) or GL_GENERATE_MIPMAP (since OpenGL 1.4). Appears to make slide transitions not worse on Linux and Mac OS X, while actually improving them on Windows (where the transitions were rendered in just white w/o textures), at least on the specific machines I tested on. Change-Id: I1e4c115223521acd3f254bdbf0330a7830160a9c
2015-02-28TyposJulien Nabet1-1/+1
Change-Id: I5e938a0b53ea7a1b020bc73634bff70913f3ebc3
2015-02-28Typo: skiped->skippedJulien Nabet1-1/+1
Change-Id: I88c53ade0101cfd7735a45b2038879bd027b0314
2015-02-12Turn all-static TransitionFactory class into namespaceStephan Bergmann5-56/+76
Change-Id: I0187cf4c1b31c5a8c930804c7d3f36c79142af3a
2015-02-07loplugin:deletedspecialStephan Bergmann6-69/+32
Change-Id: I78acc6b7c56e79e2e4cc071efe95bfee94d73b7a
2015-01-29callcatcher: large newly detected unused methods post de-virtualizationCaolán McNamara2-8/+0
i.e lots now able to be detected after... commit b44cbb26efe1d0b0950b1e1613e131b506dc3876 Author: Noel Grandin <noel@peralex.com> Date: Tue Jan 20 12:38:10 2015 +0200 new loplugin: change virtual methods to non-virtual Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
2015-01-26new loplugin: change virtual methods to non-virtualNoel Grandin7-61/+5
Where we can prove that the virtual method is never overriden. In the case of pure-virtual methods, we remove the method entirely. Sometimes this leads to entire methods and fields being eliminated. Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
2015-01-20Some more loplugin:cstylecast: slideshowStephan Bergmann1-1/+1
Change-Id: I5cba157aa69b979a1e821f267f0560dd16533677
2015-01-07fdo#84938: convert STREAM_ #defines to 'enum class'Noel Grandin1-1/+1
Change-Id: Ibbf14c7e9a5c1883c1311d4c86f948f74f8e473e
2015-01-06boost::math::nextafter->std::nextafterCaolán McNamara1-2/+1
Change-Id: I868b3fcf367e61c40e77e64bcc153b2a2feefa0b
2015-01-04boost::unordered_map->std::unordered_mapCaolán McNamara4-10/+9
Change-Id: I82f668ef72e916d2ff11df5cda2a02653999f66f
2014-12-18slideshow: Use appropriate OUString functions on string constantsStephan Bergmann1-1/+1
Change-Id: I5498af3577591fa035319b72324cf70c536f8559
2014-12-08coverity#1257110 Big parameter passed by valueCaolán McNamara1-1/+2
and coverity#1186125 Big parameter passed by value Change-Id: I6cb6863645647edf4fba114059195582679c30c4
2014-12-05Slightly less verbose adaptation to boost-1.56.0Thorsten Behrens5-12/+6
This fixes up 45dfbdca6a9afba1a6aef21623ec025ded635a4d Change-Id: I754fec5c94d51cbae69ad1155f57b0bb53788ba5
2014-11-26Silence Mac OS X 10.9/10.10 deprecations for nowStephan Bergmann1-0/+4
Change-Id: Ie63ed8f6f66a7641ad872f93d76efb962333cec9
2014-11-25-Werror,-WuninitializedStephan Bergmann1-3/+1
(in DummyRenderer ctor: base class 'comphelper::OBaseMutex' is uninitialized when used here to access 'comphelper::OBaseMutex::m_aMutex') Change-Id: I5b151176c676a58593933b3f2e33a3e2dfdcc630
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl4-1/+7
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini2-2/+2
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-10constify slideshow.Michael Meeks1-3/+3
Change-Id: I548f527be4be76a2bda43dcb5ee14e4f50f3b409
2014-11-10merge vcllo and vclopenglloMarkus Mohrhard2-2/+0
Change-Id: I419ca67dc1f87dd9ac751aa5a094fecf58136edb