summaryrefslogtreecommitdiff
path: root/slideshow
AgeCommit message (Collapse)AuthorFilesLines
2017-04-28clang-tidy readability-simplify-boolean-exprNoel Grandin1-7/+1
Change-Id: Iea7ab64683f0b29794d50d774cc482b54a00e70a Reviewed-on: https://gerrit.libreoffice.org/36450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25errinf.hxx moved out of tools and into vcl moduleChris Sherlock1-1/+1
ErrorInfo has a hard depency on VCL, yet is in the tools package. It is more appropriate to have it reside in the VCL module. Change-Id: Ica54a46c3a7f86cf0331ed7245234bea69c05650 Reviewed-on: https://gerrit.libreoffice.org/36839 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky4-4/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-20loplugin:unusedmethodsNoel Grandin1-1/+0
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672 Reviewed-on: https://gerrit.libreoffice.org/36718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-16logging the simple message is sufficientCaolán McNamara7-14/+14
Change-Id: I50050001f080f668bded036372feeb271da4a7c6
2017-04-12no need to use OUStringToOString in SAL_INFONoel Grandin1-8/+3
Change-Id: I707e0d72aba89b7e644def6f4c251e14f6599ad2 Reviewed-on: https://gerrit.libreoffice.org/36451 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-06Improved loplugin:redundantcast, static_cast on arithmetic types: slideshowStephan Bergmann1-4/+4
Change-Id: I5f2031068ef0ab8e777fddfa90e7a15836938b48
2017-04-03use actual UNO enums in reportdesign..svtoolsNoel Grandin1-1/+1
Change-Id: Idcd916382b87f8542dc6b5cdcb5ecb01d6947203 Reviewed-on: https://gerrit.libreoffice.org/36043 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna3-8/+8
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-26Fix typosAndrea Gelmini6-7/+7
Change-Id: I5518e764fd8349c476e79bb888e93a1dab01ed1d Reviewed-on: https://gerrit.libreoffice.org/35644 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-23convert UpdateFlags to scoped enumNoel Grandin4-39/+44
Change-Id: I73121e85a927bae3f042a2bbc0283a28067b891f Reviewed-on: https://gerrit.libreoffice.org/35553 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-09some OSL_FAIL to SAL_WARNCaolán McNamara7-38/+15
Change-Id: I5101e42b7a34cca9055fc805d9a392ba4f920a3d
2017-03-08show the last gif frame when the animation endsCaolán McNamara1-3/+6
Change-Id: I240d0a46cff905edababbd13fe7e58c9e4d0f0db
2017-03-08loplugin:loopvartoosmallStephan Bergmann1-2/+1
Change-Id: Ib8737f1690c738016fcdc1f365b744fcb567ce57
2017-03-03Remove redundant 'inline' keywordStephan Bergmann1-1/+1
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-28new loplugin unoanyNoel Grandin2-7/+7
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89 Reviewed-on: https://gerrit.libreoffice.org/34714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21loplugin:subtlezeroinit: slideshowStephan Bergmann1-1/+1
Change-Id: I1280b51f42c21d15c76ea54a11c7a5a72930d566
2017-02-15convert AttributeType to scoped enumNoel Grandin3-200/+181
and drop unused CHAR_ROTATION enumerator Change-Id: I9ca50aef41fa736c7f34c210844fb54f60f5bca8
2017-02-15convert DocTreeNode::NodeType to scoped enumNoel Grandin7-51/+31
and drop unused enumerators Change-Id: I0b9220cc2a70847ee43b63accec5bede3dbb99fa
2017-02-15drop CycleMode enumNoel Grandin7-67/+14
since we only ever used the CYCLE_LOOP enumerator Change-Id: I181be1e1bba7f72f64420ab22e119d2bffad2d37
2017-02-15convert ReverseMethod to scoped enumNoel Grandin3-201/+183
and drop unused enumerators REVERSEMETHOD_INVERT_SWEEP REVERSEMETHOD_SUBTRACT_POLYGON Change-Id: I11b52d4b32e5f766dfa3bcd69b9c636f4106b7b4
2017-02-14BOOST_SPIRIT_SINGLE_GRAMMAR_INSTANCE has been defined forever in these filesTor Lillqvist1-10/+1
Change-Id: I0afa1b404192f44540aa318e748452e0328fac6b
2017-02-06Add missing #includesStephan Bergmann2-0/+4
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-03new loplugin:unusedenumconstantsNoel Grandin1-1/+2
These are the simple removals, where it is obviously safe, the more complex ones will come in separate commits Change-Id: I7211945a6a5576354b60d9c709940ce9b674f308 Reviewed-on: https://gerrit.libreoffice.org/33828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin2-2/+2
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann5-112/+65
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25loplugin: unnecessary destructor sfx2..storeNoel Grandin4-11/+0
Change-Id: Idbf2585e48cd89a43ab68c5c8819880d20461ccf Reviewed-on: https://gerrit.libreoffice.org/33514 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski1-1/+1
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-17remove SunStudio hacksMichael Stahl1-14/+0
There is no "SOLARIS compiler". Change-Id: Idcfaee36307b1a4112f7fd6702c5f0e528f812c8
2017-01-17replace #ifdef SOLARIS with #ifdef __sunMichael Stahl1-1/+1
Check for a macro that is defined by the compiler, we don't really need one defined by the build system. Change-Id: Iccb8e3198396881395c97a6b81690ebe64b7e9d2
2017-01-12silence coverity#1371305 Missing move assignment operatorCaolán McNamara1-20/+19
Change-Id: I761e07d1583262d83074addbff4ca67b01640387
2016-12-15no point in having both SAL_WARN and OSL_FAIL for the same thingNoel Grandin1-4/+0
Change-Id: I1beafff257e968a62184f8b1d8cf2a3a24e7c945 Reviewed-on: https://gerrit.libreoffice.org/32039 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-15teach sallogareas plugin to catch inconsistenciesNoel Grandin2-2/+2
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a Reviewed-on: https://gerrit.libreoffice.org/32004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13post glew->epoxy, we don't need to link to win openg32 and mac OpenGLCaolán McNamara1-18/+0
Change-Id: Iadc373961dcca788b1174ee71cb386979ce064ed Reviewed-on: https://gerrit.libreoffice.org/31954 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-13gtk3: implement opengl support for slideshowCaolán McNamara3-43/+46
all of them work, except "Fall" doesn't look right, but it has the exact same problem under gtk2/gen to. Change-Id: I73cb9c0fb8211f727198be78d90d4f80a4f8c7c8 Reviewed-on: https://gerrit.libreoffice.org/31214 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-13change from glew to epoxyCaolán McNamara5-13/+3
because that works under wayland out of the box and gtk3 uses it already Change-Id: Iefaac31e325534a81a5389f752804af917c1baef Reviewed-on: https://gerrit.libreoffice.org/31213 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-11OSL_TRACE -> SAL in sfx2..svxNoel Grandin11-77/+55
Change-Id: I78cf8058a5682baa3d7b00a25feeb2d28fb3e66e Reviewed-on: https://gerrit.libreoffice.org/31799 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin2-2/+2
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05getVerticesSize got renamed to getVerticesByteSizeCaolán McNamara1-1/+1
Change-Id: I7eff6eeb92aede6beb4412aa3e574ae75d651d8b
2016-12-05rework diamond transition to use only opengl coreCaolán McNamara1-8/+18
cause that's all we've got in gtk3 Change-Id: I6a47e344ccd39ba63e7a51ae18f89bb05bb642c4 Reviewed-on: https://gerrit.libreoffice.org/31496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-05loplugin:unnecessaryoverride (dtors) in slideshowStephan Bergmann2-8/+2
Change-Id: I5c4bc26bc51347e453ce69913edc52cf1f1aa821
2016-12-02warning C4018: '<' : signed/unsigned mismatchStephan Bergmann1-1/+1
Change-Id: I5e6a6debf01886c283f5a2d6b9cacc00a44f7134
2016-12-02get vertices count without jumping through hoopsDavid Tardon2-2/+8
Change-Id: I0cab6b2f9fffc8cf9fc5059b8dc48fa9407e42b5
2016-12-02rename to avoid further misunderstandingsDavid Tardon2-3/+3
Change-Id: Ibcfae1b3ec118d74921312a80eb56c97c623f4a9
2016-12-02coverity#1371200 Missing move assignment operatorCaolán McNamara4-49/+48
adjust things to not need one Change-Id: I1079f50d8813f86c4828be602687b4cbffe61415
2016-11-30glDrawArrays takes num of indices, not size of storageCaolán McNamara1-1/+1
this stops the strange missing corner seen during the diamond transition Change-Id: If806a0a3303eb38644bb6d3a479cadbd5fe9ca25
2016-11-21Delete the "Any-to-Any" template specializations for LIBO_INTERNAL_ONLYStephan Bergmann1-1/+1
i.e., css::uno::Any function template specializations Any::has<Any>() const Any::get(Any const &) const operator >>=(Any const &, Any &) operator <<=(Any &, Any const &) that don't make much sense (the first is always true, the rest can be replaced with operator =, which additionally supports move semantics). For 3rd-party compatibility, do this only for LIBO_INTERNAL_ONLY, however. However, some generic template code did benefit from operator >>= working also for Any, so make up for that with a new (LIBO_INTERNAL_ONLY, given that operator >>= still covers if fine for !LIBO_INTERNAL_ONLY) fromAny, complementing the existing toAny. Change-Id: I8b1b5f803f0b909808159916366d53c948206a88 Reviewed-on: https://gerrit.libreoffice.org/30022 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-17loplugin:unusedfieldsNoel Grandin1-22/+0
Change-Id: Id2dbbf384637223db3d334d95332251832918003 Reviewed-on: https://gerrit.libreoffice.org/30927 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07loplugin:unnecessaryvirtual in sfx2..svtoolsNoel Grandin4-22/+8
Change-Id: Ib34e14806f7cc9a97ecfd68687ab17ee5c1f022b Reviewed-on: https://gerrit.libreoffice.org/30652 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-06tdf#103696 ensure glm always uses radiansDavid Tardon1-0/+4
This is set just locally for OGLTrans, because I have no idea what the other places that use glm expect... Change-Id: I83675ef2463ab945cb3d6885f803dcbae60a5558