summaryrefslogtreecommitdiff
path: root/slideshow
AgeCommit message (Collapse)AuthorFilesLines
2016-10-05convert MapUnit to scoped enumNoel Grandin1-2/+2
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann1-2/+2
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-09-22loplugin:unusedmethods in sc..vclNoel Grandin1-4/+0
Change-Id: I70fcf95dfd3db05b4fd6e5cee37866f673d3afa8 Reviewed-on: https://gerrit.libreoffice.org/29183 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl5-34/+34
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann13-20/+20
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-05convert RasterOp to scoped enumNoel Grandin1-1/+1
Change-Id: I136423c105316c9b5b18e64d04a248fd7ac5590b
2016-08-31slideshow: stop whining about PresenterCanvas' lack of XUpdatableMichael Stahl1-3/+6
Change-Id: I1e447f5eccb41325d96e9c4cb1598a05e702badc
2016-08-29loplugin:countusersofdefaultparamsNoel Grandin1-1/+1
Change-Id: I26f46ddac3d7d810ebfa1c3e7f1a77427369828e Reviewed-on: https://gerrit.libreoffice.org/28451 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-05loplugin:countusersofdefaultparams in sfx2..svgioNoel Grandin3-8/+7
Change-Id: Ia01f3a9aa21c88df5fe5242ad4a3c0acbe68fda0 Reviewed-on: https://gerrit.libreoffice.org/27903 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-03Reduce ENABLE_OPENGL / ENABLE_HEADLESS confusionTor Lillqvist2-2/+2
ENABLE_OPENGL means whether to enable the OpenGL slideshow transition code. It does not mean whether to enable use of OpenGL in general. So rename it to ENABLE_OPENGL_TRANSITIONS while at it. ENABLE_HEADLESS means whether to disable use of X11 and OpenGL on X11 (and Wayland) platforms, I think, meaning Linux and maybe Solaris and the BSDs. Maybe it should be renamed to DISABLE_X11_AND_OPENGL. Change-Id: Ibb30f51646b1bcc477fe691a3fa38c7a1e3944ae
2016-08-01loplugin:countusersofdefaultparams in shell..starmathNoel Grandin9-16/+16
Change-Id: I553d1b031b8d261a1caa8b77a8d687af21a6f8d6 Reviewed-on: https://gerrit.libreoffice.org/27672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-27improve passstuffbyref return analysisNoel Grandin4-4/+4
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-19tdf#97195 make diamond transition work againDavid Tardon2-1/+57
Change-Id: I28236dd0c7dbd4e1798055229b2db2d0101a493e
2016-07-11loplugin:staticmethodsStephan Bergmann1-15/+13
Change-Id: If898ac15d958d4f0a5bcf0062a8d9869ef5e84e5
2016-07-11tdf#97195 fix crash in diamond shape transitionDavid Tardon2-17/+25
The setScene() function was a hack from the beginning--it was only introduced to avoid the need to override displaySlides_() in DiamondTransition. And it worked until someone started to make false assumptions about the scene, like that it is unchanging or that both slides have the same (non-zero) number of elements... Change-Id: I401cccc4dfbcba0a5f5544d3aac94d1cae027c99
2016-07-07loplugin:passstuffbyref also for {css::uno,rtl}::ReferenceStephan Bergmann1-1/+1
Change-Id: Iaeeb594821f8b2875ca08afdf62d442d33e186ba
2016-07-05Clarify calculation precedence tdf#39440Muhammet Kara1-1/+1
Use parentheses to clarify the code. Change-Id: I864dc6dacadb5b9ba9dca8e0abd9fa4e6db1eddc Reviewed-on: https://gerrit.libreoffice.org/25677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-04comphelper::OBaseMutex -> cppu::BaseMutexNoel Grandin1-3/+3
convert usage of deprecated class, and remove the old class Change-Id: I19fb9271090d19e5531622b58492e1a848d306e2 Reviewed-on: https://gerrit.libreoffice.org/26843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-28loplugin:singlevalfields in variousNoel Grandin1-12/+0
Change-Id: Ia0d8f463a4dba9ec63aa0159441e3e607dd3bf5e Reviewed-on: https://gerrit.libreoffice.org/26738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-10Slideshow: Add 'Oval' Shape Transition variantMayank Gupta3-9/+22
Committer's note: There is no Oval or Ellipse transition in MSO formats, so fallback to circle on export to those. Change-Id: Ibc3d617d3bb94bdd0702bb4d60ce5fbe2eea8e24 Reviewed-on: https://gerrit.libreoffice.org/23661 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-09Revert "Slideshow: Add 'Oval' Shape Transition variant"jan iversen3-22/+9
The patch caused problems with the export filter tests, to check that you need to add --with-export-validation to your autopen.input see https://cgit.freedesktop.org/libreoffice/contrib/dev-tools/tree/export-validation for more info on how to set it up This reverts commit 248c5ea771255b54e64394458a321ccf829bbd02. Change-Id: Ib3b8fa7bf80630feeca1f24dfb1ceb5a945d7162 Reviewed-on: https://gerrit.libreoffice.org/26114 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-09Slideshow: Add 'Oval' Shape Transition variantMayank Gupta3-9/+22
Change-Id: Ibc3d617d3bb94bdd0702bb4d60ce5fbe2eea8e24 Reviewed-on: https://gerrit.libreoffice.org/23661 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-09tdf#94698 cleanup Makefiles. Get rid of udkapi and offapiGleb Mishchenko1-4/+1
This patch changes occurences in makefiles from $(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \ udkapi \ offapi \ )) to $(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config)) (corrected instead of abandon, jani) Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e Reviewed-on: https://gerrit.libreoffice.org/23426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-08tdf#96099 Remove various smart pointer typedefsMark Page7-71/+69
Change-Id: I76843139e43ca1c158a977e24d210d5af93e4d0f Reviewed-on: https://gerrit.libreoffice.org/26014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08initialize the counterDavid Tardon1-0/+3
Change-Id: I55c2a95a860dc814569b00c2edc9e135feb95bcd
2016-06-02loplugin:unusedfieldsNoel Grandin3-24/+0
Change-Id: Ieed5f4d9411478d2568b8e5f4bbe0782bd1d309d Reviewed-on: https://gerrit.libreoffice.org/25724 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-01Can use boost::make_optionalStephan Bergmann2-5/+3
...reportedly available since Boost 1.34, and configure.ac checks for at least Boost 1.47. Change-Id: I07952de220f1eee5f91ad83a1965420eb6b09ada
2016-05-30Remove CycleMode enumNoel Grandin1-26/+2
to never takes any value other than NORMAL Change-Id: I9558ee8864537c695ce1172a0cfad421d5f591ee Reviewed-on: https://gerrit.libreoffice.org/25587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-27Convert GRAPHIC to scoped enumNoel Grandin2-3/+3
Change-Id: I1fd09a729cbda00f99841532e0dd3fa66bce7bea Reviewed-on: https://gerrit.libreoffice.org/25534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-25slideshow: appease MSVC 2013 with the std::chrono typesMichael Stahl1-5/+5
Change-Id: I00ecc510192e71b12f746f876d564ac9b7c3a6c5
2016-05-25slideshow: replace boost::posix_time with C++11 std::chronoMichael Stahl1-24/+22
Change-Id: Ied221b25f1bbe486cac6bb88bbc752a3c19c33ce
2016-05-25Convert Disposal to scoped enumNoel Grandin1-10/+3
and drop unused FULL value Change-Id: I3b9c26cb164785ef86f1a8d57cce962b015c85d6 Reviewed-on: https://gerrit.libreoffice.org/25432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-21GLX_EXT_texture_from_pixmap path cannot be called...Caolán McNamara1-199/+9
slideshow mbHasTFPVisual is always false since commit eccaf91ec9c50d42ce98c90abe2c129bedbbc60e Date: Mon May 19 19:21:29 2014 +0200 use VCL's OpenGLContext for 3D transitions Change-Id: I510518461eb8bc9669d0de2679c34c473f66b175 and GLWindow fbc has always been null since that incarnation of opengl started, so even if mbHasTFPVisual was true it would crash. OpenGLHelper::GetPixmapFBConfig is *almost* the same as the old removed code for setting fbc, but if I use that then for me the transitions still don't work at all. Examining further shows GetPixmapFBConfig lacks the test for GLX_BIND_TO_MIPMAP_TEXTURE_EXT that the old code had. If I add than, then it "works", but examining *that*, reveals it only works because GLX_BIND_TO_MIPMAP_TEXTURE_EXT is unsupported on my rig, so the GLX_EXT_texture_from_pixmap code still doesn't get executed. I apparently can't test the original working configuration, and I'm not particularly interested in getting X working and I just wanted to make sure I didn't break that case, so... this removes the uncallable since 2014 code entirely rather than try to fix it. I suspect this may leave the cairo-canvas CanvasBitmap::getFastPropertyValue "1" branch now also dead Change-Id: I6727576056533fa54a4f82378954fb53891f5873
2016-05-21Split OpenGLContext up into SalInstance specific classesCaolán McNamara2-22/+8
which, at least theoretically, allows there to be vclplug specific ones. i.e. a gtk3 specific one which doesn't assume gtk3 is running under X Change-Id: I6c007a87abbd3049b6fffc70d349e3b7ac445eec
2016-05-19loplugin:unusedmethods in slideshow to svtoolsNoel Grandin2-15/+0
Change-Id: Icf0056e13c88d7d347e668adaeddd4ed72af85cf Reviewed-on: https://gerrit.libreoffice.org/25141 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18clang-tidy modernize-make-sharedNoel Grandin6-16/+15
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-13slideshow: replace boost::mem_fn with std::mem_fnMichael Stahl7-29/+27
Change-Id: I0b02b2b13cacac48d94e541671a446368f5e527f Reviewed-on: https://gerrit.libreoffice.org/24885 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-13slideshow: tweak BaseContainerNode::forEachChildNodeMichael Stahl1-1/+1
Mac OS X clang/libc++ refuse to invoke a "const" std::mem_fn object. And you thought that MSVC was the only one with a deficient stdlib. Change-Id: Ib7a659adbd270a20b9fdcd661df1bd78d40768ca Reviewed-on: https://gerrit.libreoffice.org/24901 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-13convert EXCEPTION_ to scoped enumNoel Grandin1-5/+4
- simplify VCLExceptionSignal_impl - drop "minor" part of error code, nobody passes it in, and nobody checks it - rename Display to UserInterface, to prevent -Werror=shadow Change-Id: I503fd8a50ded30d59c30fb388796f6b1a0c058de Reviewed-on: https://gerrit.libreoffice.org/24892 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11slideshow: tweak ListenerOperations<std::weak_ptr<ListenerTargetT>>Michael Stahl1-1/+1
Pretty sure FuncT(...value_type) is wrong since value_type is std::weak_ptr which does not implicitly convert to a callable pointer; this caused build failure on Mac OS X with clang/libc++. Change-Id: Id9de4a7825347a84cce2aab5367a457a003bb352
2016-05-11slideshow: replace boost::mem_fn with C++11 lambdasMichael Stahl1-4/+12
A bit more verbose but we have less than 10 mem_fn now so better elimintate them all so hopefully we can get rid of the corresponding boost warning patches. Change-Id: I79e2f9994841125916d92bdce9973d956f2a68ce
2016-05-11clang-tidy modernize-loop-convert in scripting to svtoolsNoel Grandin2-4/+4
Change-Id: I98229d14109cf243839d632feabde1391ea9bad5 Reviewed-on: https://gerrit.libreoffice.org/24847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann6-22/+13
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-06basegfx,oox,slideshow: replace boost::next/prior with std::next/prevMichael Stahl1-2/+2
Change-Id: I38fde54d0fdbb9c61e3df004242a70e14429f52f
2016-05-06teach passstuffbyref plugin to check for..Noel Grandin3-7/+7
unnecessarily passing primitives by const ref. Suggested by Tor Lillqvist Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6 Reviewed-on: https://gerrit.libreoffice.org/24672 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-04use Any constructor instead of temporariesNoel Grandin1-7/+3
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-05-01Fix typosAndrea Gelmini1-1/+1
Change-Id: Ifb7c33d6052efe5ea8a1e0e10b3178073cd29ca0 Reviewed-on: https://gerrit.libreoffice.org/24536 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin2-5/+5
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-21new plugin stylepoliceNoel Grandin1-4/+4
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann2-8/+8
Change-Id: Ic748f5d0df9622aae0faa600fe13f82103bbf4bf
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-17 02:06:23 +0000