summaryrefslogtreecommitdiff
path: root/shell
AgeCommit message (Collapse)AuthorFilesLines
2020-08-04Improved loplugin:staticanonymous -> redundantstatic redux, clang-clStephan Bergmann1-1/+1
Change-Id: Ie6dc22edbcfdf05ab8d7d668cb7cc33b5b747995 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100100 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-07-23shell/wininet: create instances with uno constructorsNoel Grandin5-100/+14
See tdf#74608 for motivation. Change-Id: I6612d0e45b50f3b02396734b2a20a2c17e18e052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99137 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-21shell/simplemail: create instances with uno constructorsNoel Grandin4-90/+16
See tdf#74608 for motivation. Change-Id: I944cbd7bc38f9dc1811756d3db4522047aaf34e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99135 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-21shell/syssh: create instances with uno constructorsNoel Grandin4-74/+9
See tdf#74608 for motivation. Change-Id: I0c46ef0e9be472b8fccc34376e9f1c23b0c07cb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99130 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-20compact namespace declNoel Grandin1-10/+1
used git grep -lw namespace | xargs perl -i -p0e 's/(\w+)\s*.\{.\s*namespace\s*(\w+)/\1::\2/smg;' to do the initial replace, then compiled and fixed. Change-Id: If69904d75940c851aeffab0e78c4ba02cc968d44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-17shell/sessioninstall: create instances with uno constructorsNoel Grandin5-40/+33
See tdf#74608 for motivation. Change-Id: I1878cf052b3f250927d5bb72ddd523af28cf9337 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98917 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-16shell/desktop: create instances with uno constructorsNoel Grandin2-30/+12
See tdf#74608 for motivation. Change-Id: Id59a5182a94f642811063a1e29730aa6c7a01f5d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98879 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-16shell/kf5: create instances with uno constructorsNoel Grandin2-30/+9
See tdf#74608 for motivation. Change-Id: I45cf95f39f5d3bcab23000422b1348c72782acc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98880 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-15shell/locale: create instances with uno constructorsNoel Grandin5-99/+14
See tdf#74608 for motivation. Change-Id: Id13b26fb6f518e0586bb01c0c897c039fd3bd887 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98683 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-15shell/syssh: create instances with uno constructorsNoel Grandin4-78/+12
See tdf#74608 for motivation. Change-Id: I94d0d68133877ab68e67607715afe78313bf1faf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98681 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-14shell/cmdmail: create instances with uno constructorsNoel Grandin4-81/+11
See tdf#74608 for motivation. Change-Id: Ifeece1a72c594348f52e3edbee503a16a99619e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98682 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-14shell/macbe1: create instances with uno constructorsNoel Grandin5-104/+13
See tdf#74608 for motivation. Change-Id: Ifdb4adc5073b728cbad4da5b261aa7475e9997e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98680 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-10replace usage of blacklist with excludelist for IWYUThorsten Behrens1-1/+1
Background and motivation: https://tools.ietf.org/html/draft-knodel-terminology-02 Change-Id: I2f22d455d2a936a85750eaab1fda215ebb6d9d48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98182 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-10replace usage of blacklist with denylistThorsten Behrens1-2/+2
.. and a few cases of instead doing blacklist->excludelist where that made more sense. Background and motivation: https://tools.ietf.org/html/draft-knodel-terminology-02 [API CHANGE] officecfg::Office::Canvas::DeviceBlacklist -> DeviceDenylist [API CHANGE] officecfg::Office::Canvas::BlacklistCurrentDevice -> DenylistCurrentDevice [API CHANGE] officecfg::Office::Common::Misc::OpenCLBlackList -> OpenCLDenyList Change-Id: Ia35e25496bf0cc0692d5de4cb66bfc232d3a869e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98180 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-02Upcoming improved loplugin:staticanonymous -> redundantstatic: shellStephan Bergmann3-3/+3
Change-Id: Ieb0abded6050cdb8a179ea1558bd17fa14ebb64b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97665 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-10tdf#42949 Fix IWYU warnings in shell/Gabor Kelemen18-47/+36
Except for MAC/WIN specific parts (i.e. most of it) Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia14fb27c047e0e69f81386212aa25344f1297e05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95663 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-07Use o3tl::safeCoInitializeEx/safeCoUninitializeReinit (shell/SysShExec)Julien Nabet2-3/+11
Change-Id: Ice97c2db27085fefed098ee01f3aaeb55fc90cca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95643 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-06-05Upcoming loplugin:elidestringvar: shellStephan Bergmann1-2/+1
Change-Id: I4459f995f7515beeb2e4d2446cfe4cdcfb1a07ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95548 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-26Fix loplugin:simplifypointertobool for libstdc++ std::shared_ptrStephan Bergmann1-1/+1
...where the get member function is defined on a std::__shared_ptr base class, so loplugin:simplifypointertobool used to miss those until now. (While e.g. using libc++ on macOS found those cases.) 366d08f2f6d4de922f6099c62bb81b49d89e0a68 "new loplugin:simplifypointertobool" was mistaken in breaking isSmartPointerType(const clang::Type* t) out of isSmartPointerType(const Expr* e); c874294ad9fb178df47c66875bfbdec466e39763 "Fix detection of std::unique_ptr/shared_ptr in loplugin:redundantpointerops" had introduced that indivisible two-step algorithm on purpose. The amount of additional hits (on Linux) apparently asked for turning loplugin:simplifypointertobool into a rewriting plugin. Which in turn showed that the naive adivce to just "drop the get()" is not sufficient in places that are not contextually converted to bool, as those places need to be wrapped in a bool(...) functional cast now. If the expression was already wrapped in parentheses, those could be reused as part of the functional cast, but implementing that showed that such cases are not yet found at all by the existing loplugin:simplifypointertobool. Lets leave that TODO for another commit. Besides the changes to compilerplugins/ itself, this change has been generated fully automatically with the rewriting plugin on Linux. Change-Id: I83107d6f634fc9ac232986f49044d7017df83e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94888 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-05-22Prefer CoInitializeEx instead of CoInitializeJulien Nabet1-1/+1
As https://docs.microsoft.com/fr-fr/windows/win32/api/objbase/nf-objbase-coinitialize?redirectedfrom=MSDN advised. Moreover, it'll make concurrency model explicit Change-Id: I247a49248bf45beb64a7985a7c0d078ee48efe2d Change-Id: I6e755fd516d9fb2dd2a9df0c66d9afd6070447ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94669 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-21use for-range on Sequence in sfx2..swNoel Grandin1-6/+6
Change-Id: I09806869f2fdbae61f4c5d5c9db6859202bb63b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94609 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-10compact namespace in sal..svgioNoel Grandin1-2/+2
Change-Id: I7e70614ea5a1cb1a1dc0ef8e9fb6fd48e85c3562 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93904 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-25Remove unused using declarations in oox...xmlsecurityGabor Kelemen1-2/+0
Found by: run-clang-tidy-10 -checks=-*,misc-unused-using-decls Change-Id: I3e95791e223ef01e140a6217e29a9efae428a784 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90876 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-20Fix passing RT_RCDATA into FindResourceWStephan Bergmann1-1/+1
RT_RCDATA is defined as MAKEINTRESOURCE(10) in WinUser.h, and MAKEINTRESOURCE is defined as MAKEINTRESOURCEA in WinUser.h absent a definition of UNICODE. 649854544e28f388774492f27eb1b75485202148 "WinAPI: Fix some leftovers having UNICODE-define-dependency" had changed this > - HRSRC hrc = FindResourceW(g_hModule, L"#2000", RT_RCDATA); > + HRSRC hrc = FindResourceW(g_hModule, L"#2000", MAKEINTRESOURCEW(RT_RCDATA)); before 558956dc811a1f0f07411e348f7081a467bbc3b5 "Drop UNICODE/_UNICODE defines" dropped defining UNICODE. But that change was technically wrong, as now flagged by LLVM 10 trunk clang-cl: > C:/lo-clang/core/shell/source/win32/shlxthandler/thumbviewer/thumbviewer.cxx(50,56): error: cast to smaller integer type 'unsigned short' from 'char *' [-Werror,-Wpointer-to-int-cast] > HRSRC hrc = FindResourceW(g_hModule, L"#2000", MAKEINTRESOURCEW(RT_RCDATA)); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > C:/PROGRA~2/WI3CF2~1/10/Include/10.0.18362.0/um\winuser.h(236,51): note: expanded from macro 'MAKEINTRESOURCEW' > #define MAKEINTRESOURCEW(i) ((LPWSTR)((ULONG_PTR)((WORD)(i)))) > ^~~~~~~~~ There appears to be no explicit define for MAKEINTRESOURCEW(10), and the fix presented here seems like a cleaner way than replacing the use of RC_RCDATA with MAKEINTRESOURCEW(10). Change-Id: I36f60a8647ac264085656fc9ec3b129c2d81f480 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90799 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-03-12Revert "loplugin:constfields in shell"Noel Grandin3-4/+4
This reverts commit ec7e3609917092ee00667c78ff40cd4c2f0adec1. Change-Id: I11aa028f6562f97b0d251d6b326e9aecb45d03de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90415 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-16GBUILD_TRACE, support for finding out where the build time is spentLuboš Luňák2-0/+4
See instructions in solenv/gbuild/Trace.mk . This generates a file than can be viewed e.g. in the Chromium tracing view. Change-Id: I5f90647c58ca729375525b6daed2d4918adc8188 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88754 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-03loplugin:stringadd (clang-cl)Stephan Bergmann1-2/+2
Change-Id: Id5babe1e16c8f8a8c72077fc95508a567138766a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87889 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03loplugin:unsignedcompare (clang-cl)Stephan Bergmann1-3/+5
Change-Id: I69cc1b352221ca053ccd0c5b78e926480a8c9ccd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87884 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-31clang-tidy modernize-concat-nested-namespaceNoel Grandin1-2/+2
Change-Id: Iab35a8b85b3ba1df791c774f40b037f9420a071a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-28tdf#88205: - Adapt uses of css::uno::Sequence to use initializer_list ctoriakarsu1-3/+1
Change-Id: If0fe2feb6b6b4aa595f69c1a1448a809438ec077 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87508 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-28Simplify the codeMike Kaganski1-34/+13
Unify Windows header usage (wrap into prewin/postwin, remove redundant); replace "using" with explicit namespace usage; drop some indirection. Change-Id: Ia635e732de7165b161935c05d54d0490464248b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87571 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-28tdf#130216: normalize paths with .. segmentsMike Kaganski1-11/+23
... which obviously are rejected by SHGetFileInfoW and SHParseDisplayName that it calls internally. Change-Id: I2f5f3c675ea6aa1c2d92eef30be4399a8d600255 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87565 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-17Clean up computation of preprocessed_command passed to ShellExecuteExWStephan Bergmann1-92/+1
* In the URIS_ONLY case (which is intended to open documents etc.), set preprocessed_command to the filesystem pathname the first time that is computed (and which will no longer fail for file URLs with fragment since 14b36a16b225bf7c988f118d499a7287c47cd83e "Remove a fragment from a file URL early on"). * In the !URIS_ONLY case (which is intended to run other programs), we will generally be called with aCommand already being a filesystem pathname. But even if it should be a file URL, it appears to be OK to pass that as-is to ShellExecuteExW: At least on Windows 8, passing "file:///C:/Windows/System32/notepad.exe" does start it. * The code for <https://bz.apache.org/ooo/show_bug.cgi?id=4789> "Hyperlinks doesnt works" should no longer be relevant: In the URIS_ONLY case, any fragment (called a "jump mark" in that code) has already been removed from the incoming URL now. In the !URIS_ONLY case, we should generally not be called with a URL with a fragment, but even if we are, it should be OK to pass that as-is to ShellExecuteExW and let it handle that (see above). * Similarly, the code for <https://bugs.documentfoundation.org/show_bug.cgi?id=54204> "Hyperlinks between documents not works if link contains anchor at the end" is no longer relevant for the same reason. Change-Id: Ia6ec80a30f6d0603bccc87b9d6dd93ca6a84c370 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86975 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-15Remove a fragment from a file URL early onStephan Bergmann1-2/+4
...as ShellExecuteExW would ignore it anyway Change-Id: I969db094bb7d2ea230ac8c36eb23d71a90fbe466 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86868 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-11loplugin:finalclasses in starmathNoel Grandin1-1/+1
Change-Id: I65ac9a8767c298c50606a3b269a227dd1513a112 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86550 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-22sal_Char->char in sfx2..slideshowNoel Grandin9-10/+10
Change-Id: I59667664fc097989e0a78d8876f2be8353911236 Reviewed-on: https://gerrit.libreoffice.org/85701 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-12-10loplugin:unusedmember (clang-cl)Stephan Bergmann1-22/+10
PROPERTYMAP members pszXPathParent and pszValueNodeName were unused ever since 85e0cc246d4350122b17fbe2bfd15635a190ad77 "dv17: #i70994#: Use property handler instead of column info for Windows Vista" introduced the code. (And removing them allowed to simplify the code further in the obvious way.) Change-Id: Ie1247cbee31a172a15fd57c4b752d74711b1d3a1 Reviewed-on: https://gerrit.libreoffice.org/84860 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-06loplugin:external (macOS)Stephan Bergmann1-4/+3
* OldEntry in fpicker/source/aqua/resourceprovider.mm was apparently unused ever since it got introduced with 00657aef09d854c74fb426a935a3e8b1fc390bb0 "migrate to boost::gettext" * impl_throwError is used from multiple TU, connectivity/source/drivers/macab/MacabStatement.cxx just missed the relevant #include Change-Id: Iba131da57aa20085bb1c634ba9a3a59566070abd Reviewed-on: https://gerrit.libreoffice.org/84653 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-05loplugin:external (clang-cl)Stephan Bergmann4-7/+12
...plus loplugin:consttobool and loplugin:fakebool fallout Change-Id: Ie3d8121815c080b13bea6d9deca1eb138ca56138 Reviewed-on: https://gerrit.libreoffice.org/84515 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-12-03remove some useless comment linesNoel Grandin5-5/+0
which merely announce that the next declaration is a class Change-Id: Ifdb1398bcd99816b13e0b3769b46d0562bfbc1dc Reviewed-on: https://gerrit.libreoffice.org/84229 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-26loplugin:consttobool (clang-cl)Stephan Bergmann2-12/+12
Change-Id: I81fea38cd737a8be74e6ece333ca37cc434a1c33 Reviewed-on: https://gerrit.libreoffice.org/83765 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-19loplugin:fakebool (clang-cl)Stephan Bergmann6-7/+7
...plus follow-up loplugin:implicitboolconversion and loplugin:redundantcast Change-Id: I9fc9c5cb46fbb50da87ff80af64cb0dfda3e5f90 Reviewed-on: https://gerrit.libreoffice.org/83207 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-19loplugin:indentation (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I9da73ceef20a0b2535694438a3a6b20876dccd0f Reviewed-on: https://gerrit.libreoffice.org/83208 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-15tdf#128538: Open filesystem directories in Finder after allStephan Bergmann1-3/+10
Where option "-R" means, according to the open(1) man page: "Reveals the file(s) in the Finder instead of opening them." This appears to always reveal in Finder, even for *.app "application directories", so should not affect CVE-2019-9847.) Change-Id: I775db7bf71c09adc6570931a977b82dfee8dc95a Reviewed-on: https://gerrit.libreoffice.org/82749 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-12tdf#54204 File URLs with fragment need toIUri conversionTünde Tóth1-0/+5
Non-ASCII file links didn't work when the link contains anchor at the end. Note: The "correct" way to convert from a LO-internal to -external file URL would be the translateToExternal method of the css.uri.ExternalUriReferenceTranslator UNO service. But that translates the URL to be interpreted according to the current Windows code page (i.e., osl_getThreadTextEncoding), so only supports characters covered by that code page, and given that the result is passed into a Windows wchar_t API, ToIUri nicely avoids such potential conversion failure. Change-Id: I1a5b07366b0fea3da2fbe11a9378aacd765b5e04 Reviewed-on: https://gerrit.libreoffice.org/82219 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-23loplugin:stringadd (clang-cl)Stephan Bergmann1-2/+2
Change-Id: I324496ff7c61d87a83b6b378810aa5c78cd7dba3 Reviewed-on: https://gerrit.libreoffice.org/81405 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-17Remove some memset callsMike Kaganski4-6/+3
Replace them with default initialization or calloc Change-Id: I747f53c2ced2d0473fd5a5ede4f8520a0633dcc1 Reviewed-on: https://gerrit.libreoffice.org/80805 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-14loplugin:stringadd look for unnecessary temporariesNoel Grandin1-1/+1
which defeat the *StringConcat optimisation. Also make StringConcat conversions treat a nullptr as an empty string, to match the O*String(char*) constructors. Change-Id: If45f5b4b6a535c97bfeeacd9ec472a7603a52e5b Reviewed-on: https://gerrit.libreoffice.org/80724 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-02-Werror,-Wmicrosoft-exception-spec (clang-cl)Stephan Bergmann4-16/+16
No idea why that started to show up now, but C:/Program Files (x86)/Windows Kits/10/Include/10.0.17763.0/um/combaseapi.h contains > #define STDMETHOD(method) virtual COM_DECLSPEC_NOTHROW HRESULT STDMETHODCALLTYPE method while C:/Program Files (x86)/Windows Kits/10/Include/10.0.17763.0/um/winnt.h contains > #define STDMETHODIMP HRESULT STDMETHODCALLTYPE which caused failures like > [build CXX] embedserv/source/inprocserv/dllentry.cxx > embedserv/source/inprocserv/dllentry.cxx(261,40): error: 'QueryInterface' is missing exception specification '__attribute__((nothrow))' [-Werror,-Wmicrosoft-exception-spec] > STDMETHODIMP InprocEmbedProvider_Impl::QueryInterface( REFIID riid, void ** ppv ) > ^ > embedserv/source/inprocserv/dllentry.cxx(143,15): note: previous declaration is here > STDMETHOD(QueryInterface)(REFIID riid, void ** ppvObj) override; > ^ Change-Id: I0fe3554c2da4089bf0f883e1132d6f2ee95ae2c3 Reviewed-on: https://gerrit.libreoffice.org/79970 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01-Werror,-Wswitch (clang-cl)Stephan Bergmann1-0/+2
Change-Id: I3d40104d6822ebb80ebec44b36bcdfa5c7e953ed Reviewed-on: https://gerrit.libreoffice.org/79960 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 20:01:39 +0000