summaryrefslogtreecommitdiff
path: root/shell
AgeCommit message (Collapse)AuthorFilesLines
2018-03-12tdf#116074: Don't block on sending email interactivelyMike Kaganski5-21/+259
When sending e-mail using a MAPI mail client that doesn't return from MAPISendMail until message compose dialog is closed (like MS Outlook), waiting for the senddoc process blocks UI, which is unexpected and prevents users from copying stuff from documents to the mail body. Waiting for senddoc process completion is used for two things: 1. To serialize sending multiple mails (e.g., using mailmerge); 2. To show error in case when it failed. This patch allows to avoid blocking the UI in case when compose UI is requested - i.e., user interaction with the mail client is expected, and serialization is not required. In this case, the senddoc process will show the error message itself -> no need for main application to wait for its return. The error message now includes actual error code. To avoid cases when closing main program would remove temporary attachment files before they were used by mail client, they are copied to base temporary directory (instead of default session temporary directory that gets deleted upon program shutdown). senddoc cleans up its temporaries itself. The temporary attachment files are copied to files with ASCII-only filenames, and their original filenames are passed to mail clients using MAPI. This allows to avoid cases when the filenames contain characters outside of current Windows codepage, thus receiving wrong filename and erroring out from the send. Includes commit 01c71fba5f525b035f8a723215669d499bc27a3f. Change-Id: I4a517bd7a797e76e4c0b7ea48bb1a7b652741a81 Reviewed-on: https://gerrit.libreoffice.org/50826 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/50911 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-05-18tdf#107587 Opening Hyperlink opens Browser in Background.Thomas Beck1-0/+22
Added neccessary WinAPI calls to bring called window into the Foreground. Change-Id: I080968f655e2230d1a514b3ef91bf916d904d844 Reviewed-on: https://gerrit.libreoffice.org/37196 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit ad711bc6e2cc35c2ed114fff15008d5bbcfcf21c) Reviewed-on: https://gerrit.libreoffice.org/37266 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 45b2e11a6756ed322cda932142c31366fc2b6da6)
2017-04-13tdf#103058: fix build failed because of missing headerMike Kaganski1-0/+2
Change-Id: I8cb7a94baad753f5cab07a085ae567d2c65ef5e1 Reviewed-on: https://gerrit.libreoffice.org/36502 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-04-11tdf#103058: use RegQueryValueEx instead of RegGetValueMike Kaganski1-1/+21
because the latter is unsupported on WinXP Change-Id: Ie922271ab837637d77f3d76c5144d10a7f5a5f0d Reviewed-on: https://gerrit.libreoffice.org/36416 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit aa4e06c67dbe414ae26b757d6968eb27b5ebeb99) Reviewed-on: https://gerrit.libreoffice.org/36419 Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-04-11tdf#103058: allow optional registration for MS ProgIDsMike Kaganski7-162/+249
To allow in-place replacement of OWSSUPP.dll, we need to be able to handle the same ProgIDs that it handles, namely: SharePoint.OpenDocuments and its versions. This allows to use the SharePoint integration capabilities of LO without the need to reconfigure SharePoint server's DOCICON.xml (the system would start the component with same name as MS Office uses). But this cannot be the default mode, since if MS Office is installed on the same system, we would hijack the registration, that could be undesirable. So, this commit adds an option to use regsvr32 [/u] /i:Substitute_OWSSUPP path o\spsupp.dll to also [un]register SharePoint.OpenDocuments in addition to normal LOSPSupport.OpenDocuments. Reviewed-on: https://gerrit.libreoffice.org/36389 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (Cherry-picked from commit 88829fd914105a0837ee41d3f00f9178228c19cf) Change-Id: Icc284f9aa8f97ecf04594dd55b99bc1e3d20740d Reviewed-on: https://gerrit.libreoffice.org/36411 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-03-29tdf#103058: Implement OpenDocuments ActiveX controlMike Kaganski18-1/+1514
Change-Id: I97489090476cd884a122a4b36d3ac62ca86fd886 Reviewed-on: https://gerrit.libreoffice.org/29608 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2016-11-01style fixes for cppcheck noExplicitConstructorJochen Nitschke1-1/+1
Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34 Reviewed-on: https://gerrit.libreoffice.org/30460 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-11-01loplugin:oncevar in sd..svgioNoel Grandin1-3/+2
Change-Id: I58565460fcc3279c9771c6e1272d0af540b2c87c Reviewed-on: https://gerrit.libreoffice.org/30459 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-15clang-cl loplugin: shellStephan Bergmann52-454/+442
Change-Id: I98d2e5154270b795cdd11653ecfff2abd8dda294 Reviewed-on: https://gerrit.libreoffice.org/29851 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-09-23TDE fix some clang plugin based warningsJan-Marek Glogowski1-6/+5
Change-Id: I3b44038e8a889e4c13126fd8d721e53e71ea9ec6
2016-09-15loplugin:singlevalfields in sc..vclNoel Grandin1-3/+1
Change-Id: I68752a3daf5ddd8581c07759b8be2c1dabbb9258
2016-09-14loplugin:overrideStephan Bergmann1-1/+1
Change-Id: I7b746d652887d61e6a8a63b5b3ba37e0a158817e
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann4-4/+4
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13add xdg-email as the default email routeCaolán McNamara1-2/+8
because xdg-email is apparently the only route that knows how to support adding an attachment to thunderbird Change-Id: Ife1b56ccfe2434eb31ad67bef00f55197e96151e
2016-09-12Bin some noise comments and superfluous vertical whitespaceTor Lillqvist11-140/+29
Change-Id: I3c19457bb29cd1392f14598fc8798aed4b1a1a7f
2016-09-09loplugin:constantparam in sfx2Noel Grandin5-14/+11
Change-Id: If5d401001abb7bf3fc642d47f537b57836e6d9c5 Reviewed-on: https://gerrit.libreoffice.org/28772 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-25new loplugin: countusersofdefaultparamsNoel Grandin2-2/+2
Change-Id: I79e2c690f3e664c14af12cf763dd5a8ac20d6b04 Reviewed-on: https://gerrit.libreoffice.org/28353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-23Revert "Remove WorkPathVariable support from KDE backends"Stephan Bergmann4-4/+26
This reverts commit 8da1d7869a2bdbe006265f584e0d9af5046ef723. plus: Revert "Revert "KDE: don't throw on TemplatePathVariable"" This reverts commit 72812a380c0d9587670bae1d1efa8700c874634e. I had misread the code and thought that handling of those two properties in shell/source/backends/desktopbe/desktopbackend.cxx would hide handling them in the specific KDE backends, but that is not actually the case. Change-Id: I32fae5ba34cc934ceca2f574d50fc327b506b001
2016-08-22Remove WorkPathVariable support from KDE backendsStephan Bergmann4-24/+2
...now that b5c05876f73c31270bc374e4f481ef1d09a42e5f "Related: rhbz#1065807 recover using xdg templates and documents settings" handles WorkPathVariable in the generic shell/source/backends/desktopbe/desktopbackend.cxx code. Change-Id: I3920cdb3f54688462813d212569c9b33a1371333
2016-08-22Revert "KDE: don't throw on TemplatePathVariable"Stephan Bergmann2-2/+2
This reverts commit e44a7eefb7f632977b4c8c91ad14244372c6e04d, which is no longer necessary now that b5c05876f73c31270bc374e4f481ef1d09a42e5f "Related: rhbz#1065807 recover using xdg templates and documents settings" handles TemplatePathVariable in the generic shell/source/backends/desktopbe/desktopbackend.cxx code.
2016-08-22tdf#101661: Report XDG_{DOCUMENTS,TEMPLATES}_DIR only when it existsStephan Bergmann1-6/+10
...as had been done in the GConf-based backend prior to 3cf557c12d27f1b2250e69a543136da098112d80 "drop gconf integration as per ESC decision". Change-Id: I56f256aaec542e0a62fc30a37d5c982e93e77812
2016-08-16new loplugin to check for static OUStringsNoel Grandin1-3/+3
that are better declared as OUStringLiteral Change-Id: Ifb5d9a12bb31a68641940bec16971a8181a46567 Reviewed-on: https://gerrit.libreoffice.org/27377 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-11loplugin:constantparamNoel Grandin1-3/+2
Change-Id: Ia06b9b189033b9409d7a59a211866f66a0614886 Reviewed-on: https://gerrit.libreoffice.org/28016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-01loplugin:countusersofdefaultparams in shell..starmathNoel Grandin1-2/+2
Change-Id: I553d1b031b8d261a1caa8b77a8d687af21a6f8d6 Reviewed-on: https://gerrit.libreoffice.org/27672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-22shell: loplugin:nullptr / staticanonymous / stringconstantMichael Stahl1-3/+7
Change-Id: I67458301fb13601c5bf8d83c689fd861694ee460
2016-07-22Related: rhbz#1065807 recover using xdg templates and documents settingsCaolán McNamara1-2/+117
Change-Id: If2c594174a6fa8c524d9664c9f197cb7c6d4641d
2016-07-22There is no css.configuration.backend.GconfBackendCaolán McNamara1-5/+1
since commit 3cf557c12d27f1b2250e69a543136da098112d80 Author: Bjoern Michaelsen <bjoern.michaelsen@canonical.com> Date: Fri Oct 16 12:15:55 2015 +0100 drop gconf integration as per ESC decision Conflicts: shell/source/backends/gconfbe/gconfbackend.cxx Change-Id: If8e9b273e410250b45d3f645f6a31c1e80f02c6c
2016-07-05Workaround to call /app/bin/xdg-open when run under flatpakStephan Bergmann1-2/+6
LibreOffice wants to open URLs by calling /usr/bin/xdg-open, which the flatpak org.gnome.Platform runtime does not provide. However, <https://github.com/flatpak/xdg-desktop-portal> will provide a Desktop portal through which an application can make an OpenURI request. So the idea is to include a fake xdg-open application in the LO flatpak, that will use gdbus to call that portal. However, I see no way to make the LO flatpak provide that as /usr/bin/xdg-open, so instead provide it as /app/bin/xdg-open and hack LO to use that path when run under flatpak (where the LIBO_FLATPAK environment variable is already used for the OfficeIPCThread). Change-Id: I63bc0bfb937ef767958ba4d34b0c3653e38ec868
2016-06-22Work towards tdf#72606 EasyHack _tstring/TCHAR eliminationskswales12-69/+69
shell module largely already compiled UNICODE: A/W clarity Verified by installing release build and trying property sheets etc. Change-Id: I4965cdadbce635d86da1996c3c1bbd37a981ffde Reviewed-on: https://gerrit.libreoffice.org/26556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-11clang-tidy modernize-loop-convert in scripting to svtoolsNoel Grandin1-3/+3
Change-Id: I98229d14109cf243839d632feabde1391ea9bad5 Reviewed-on: https://gerrit.libreoffice.org/24847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann1-8/+8
Change-Id: I97f0ed6c3f4fa36523b6ecc05ab8b4e79a3a3c91
2016-04-19WIP tdf#89609 Ignore subsecond precision in iso8601Muhammet Kara2-1/+11
Explorer shell extension fails to convert date into locale specific string if it has sub-second precision. Change-Id: I11bd38fc2876aa1f8235dbfb8c7850ff22ac2a8b Reviewed-on: https://gerrit.libreoffice.org/24220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke6-11/+0
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-13tdf#94306 replace boost::noncopyable in sfx2 to sotJochen Nitschke4-11/+13
Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes. Add missing default ctors. Make some overloaded ctors explicit, seems cppcheck doesn't flag: T(const template<X>& rx). Change-Id: I63c5a3ac84a33ea6d49868e2d9aa281ada79958e Reviewed-on: https://gerrit.libreoffice.org/24050 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-07Drop pointless "internal" directory level for already internal include filesTor Lillqvist49-108/+108
Change-Id: I1ece44616704483cd4d9d2b6204329414f82a98c
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke2-2/+0
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-01tdf#97966 Drop 'static' keywordsWastack1-1/+1
Including no keywords from extern "C" blocks Change-Id: I87f2ed75888b51ec9e0cb75566bf7c2351b479b4 Reviewed-on: https://gerrit.libreoffice.org/23675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin5-10/+10
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-11tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar1-3/+3
I replaced OSL_DEBUG_LEVEL > 2 conditionals with OSL_DEBUG_LEVEL > 0 conditionals Change-Id: Ibfb3a4e00da7ef6a213dcd4659c7963935cfad1f Reviewed-on: https://gerrit.libreoffice.org/23081 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-08tdf#97703 Removed empty setUp/tearDown methodsChirag Manwani1-2/+0
Change-Id: Ia62de30ae94bdae87cd5109c44eab40af4d020e5 Reviewed-on: https://gerrit.libreoffice.org/22985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-07tdf#96099 Reduce number of trivial typedefsChirag Manwani1-5/+3
Change-Id: I39e9fcfdf2203239ac56d1c8195ca7ac07054817 Reviewed-on: https://gerrit.libreoffice.org/22898 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-02shell, scp2: clean up empty script packagesMichael Stahl4-39/+0
Change-Id: I93abddac491578d470f85bf3e814a0d7a91f0351
2016-03-02Just use xdg-openBryan Quigley7-197/+2
Remove kde4/tde/open-url.sh and have LO just use xdg-open. It's available on TDE builds as well as any recent KDE. We recently did this just for gnome-open-url and have had no reported issues. Change-Id: I4e1ee6caef368051af92023fa382b6fed9d9397e Reviewed-on: https://gerrit.libreoffice.org/21173 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2016-03-01loplugin:unuseddefaultparam in shellNoel Grandin2-3/+3
Change-Id: Ib14fd4f7f0a23f83801f448aa2c22e550057ec71
2016-02-17Typo: namesapce(s)->namespace(s)Julien Nabet1-1/+1
Change-Id: Ic7c14c2e39a5ade1f5622a8350f9197d84cf9cc8
2016-02-17use consistent #define checks for the Windows platformNoel Grandin2-8/+8
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-16use consistent #define checks for the Windows platformNoel Grandin1-4/+0
stage 1 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro Change-Id: Iece73abdee530937e0737190b1aa97a46cd3075f Reviewed-on: https://gerrit.libreoffice.org/22390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-09Remove excess newlinesChris Sherlock34-129/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-05Fix typosAndrea Gelmini2-2/+2
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-19-Werror=terminate (GCC 6)Stephan Bergmann1-3/+5
...when throwing an exception from implicitly noexcept ~GErrorWrapper. So make ~GErrorWrapper noexcept(false) and see that no code executed while a GErrorWrapper instance is active on the stack would throw an exception. But the design of GErrorWrapper, to throw an exception from a dtor, is very brittle and should be fixed. Change-Id: Ib04ff2b0497c160dc7ee44c3354fa9619285ec88
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-20 02:25:36 +0000