summaryrefslogtreecommitdiff
path: root/sfx2
AgeCommit message (Collapse)AuthorFilesLines
2020-06-18distinguish active dnd-operation case from simple query caseCaolán McNamara1-2/+2
Change-Id: I1d8e95e46b45c71c0c83316ab4f19ba85eddcf75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96598 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-17notebookbar: send uno items state updateSzymon Kłos1-0/+27
Change-Id: I56b9c64f11631bd28520b9294aef7d6db8da5733 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93700 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96525 Tested-by: Jenkins
2020-06-16vcl: namespace PDFWriterImpl consistentlyMiklos Vajna1-0/+2
We had a mix of 'using namespace vcl;' and 'namespace vcl {', standardize on the later. Change-Id: I088bb0e0c03f712242427bf6a0b31dd17755b9dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96475 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-16sfx2: add uitest for pdf signingMiklos Vajna4-0/+56
Fails with 058caeef45f9abf12e4e243aafbbb1c2ebcbc057 (tdf#130354 sfx2: make PDF signing UI work again, 2020-06-02) reverted. Change-Id: I4f4ffaeed4b93c033bc2fdaa76ff817d172c8853 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96469 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-15sd signature line: create signature with pre-selected cert, if availableMiklos Vajna2-30/+52
This makes the "finish signing" button do what it says. The signature line shape is not yet in the output, though. Change-Id: I096210fe505b4c9eafb56eae6c4706e454bac45c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96317 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-15Add an option to send email encrypted PDF files via mailmerge.Gülşah Köse1-0/+28
Change-Id: I002e054b685bd3367c4183014adc1dbd0843a365 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96303 Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Tested-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-06-13tdf#133928 Help need javascript enabled in browserOlivier Hallot1-5/+9
Warn user that javascript must be enabled to display Help pages Change-Id: I3c2fd6bea68346584faef2a0f8d4e383ffcf1bc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96237 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-11sd signature line: inform infobar if a cert is already selectedMiklos Vajna1-29/+79
In case a pdf is opened for signing, the infobar has a button to start the signing. If a signature line is already inserted and the user picked a certificate, then let's call the infobar button's action "finish signing", since the signature list and the certificate chooser won't appear in this case. (The actual behavior when you click on the button is still unchanged, though.) Change-Id: I50ee2455c91cdee26612a6b8239dbb6772401877 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96060 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-09notebookbar: simplify custom widgetsSzymon Kłos2-10/+108
Change-Id: I0176a9852a0f405fba7b6308e28abf2ca0ae280e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95900 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-06-09tdf#128502: Try to support multiple documents in LibreOfficeKit-using processTor Lillqvist4-17/+82
The LibreOfficeKit-specific code typically has assumed that all the "views" (SfxViewShell instances) are for the same document, because all LibreOfficeKit-based application processes (including the "kit" processes in Online and the iOS app) so far have only had one document open at a time. It is now possible to pass several document file names on the command line to gtktiledviewer and that is an easy way to demonstrate how badly it still works even with this patch. Introduce a unique numeric document id that is increased in the LibLODocument_Impl constructor. Add APIs to access that. When iterating over views, try to skip views that are not of the document visible in the "current" view, if we know what the "current" view is. Also add a couple of FIXMEs at places where it is a bit unclear (to me) whether it is correct to iterate over all views, or whether only views for the "current" document are what we would want. Change-Id: Id5ebb92a115723cdeb23907163d5b5f282016252 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95353 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-06-09remove the fake SvxScriptErrorDialog codeNoel Grandin1-3/+1
which just forwards to an async real dialog. Change-Id: I61936c4d105b9829042817e6a3cf5e60c451fb6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95830 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-06ofz#23131 use TOOLS_WARN_EXCEPTIONCaolán McNamara1-1/+1
Change-Id: I23f8cbe083c4490f9f582ab27317698964c4f5ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95656 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-05sd signature line: limit this to PDF signing for nowMiklos Vajna2-19/+14
The intent is to use this to add a visible signature to an existing PDF, disable the command in sd/ for other cases that would not work at the moment, anyway. Change-Id: I78aa68d91126a9981c1240c7dd257d793e7eaba8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95604 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-05have just one way to set expander imageCaolán McNamara3-4/+9
Change-Id: Ic07709a864620c6146616c8e0a1417343c0937de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95590 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-05Upcoming loplugin:elidestringvar: sfx2Stephan Bergmann9-23/+11
Change-Id: I58b77dd04fb0de28fcbf34a22ed73fe248f0c6b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95547 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-04Revert "Resolves tdf#127401 - Chinese locale pointing to wrong hub forward ↵Heiko Tietze1-4/+1
address" This reverts commit 2788cc07e9d0d078b53a7280d524175c03c51e12. Reason for revert: <INSERT REASONING HERE> Change-Id: I47277e7344d5533cc09a3fd6637a0780b36fe739 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95427 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-06-04Resolves tdf#127401 - Chinese locale pointing to wrong hub forward addressHeiko Tietze1-1/+4
zh is replaced by zh-cn for donation and whatsnew commands Change-Id: Ibd56e94983882bd9090d176cb42ae0a7a1f88065 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95450 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-06-04loplugin:simplifypointertobool improve (2)Noel Grandin2-2/+2
to look for the x.get() == null pattern, which can be simplified to !x Change-Id: I0eddf93257ab53ab31949961d7c33ac2dd7288ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95400 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-04Use lokCallbackTypeToString to show value symbolicallyTor Lillqvist1-1/+1
Change-Id: Idb685e2807cc62bbaca117f5cf85fdda622caae8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95467 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-06-03Resolves tdf#130936 - Proper Icon Size for MIME type Icon in Start CenterHeiko Tietze2-8/+9
Icons are now in 48px Change-Id: I484458adf047999bc2ea0cbf16e7ff3fff131eec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95028 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-06-03loplugin:simplifypointertobool improveNoel Grandin2-3/+3
to look for the x.get() != null pattern, which can be simplified to x I'll do the x.get() == nullptr pattern in a separate patch, to reduce the chances of a mistake Change-Id: I45e0d178e75359857cdf50d712039cb526016555 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95354 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-02tdf#130354 sfx2: make PDF signing UI work againMiklos Vajna1-0/+4
Regression from commit 9112c18524c9f5e67d6cbb282586a439e3020cdb (Don't create unnecessary tempfiles for opened doc, 2019-10-18), restore the temporary file creation for the PDF case, as it's needed for PDF signing to work. Change-Id: I945f04f6ab90d0e04fb14a7634ec877fb0af1a0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95367 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-02inline some use-once typedefsNoel Grandin2-10/+7
Change-Id: I335e0c5cf7944efa487e4535a9e6a5baab2f36dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95140 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-30loplugin:simplifybool extend to expression like !(a < b || c > d)Noel Grandin4-5/+5
mostly to catch stuff from the flatten work, but I think this looks good in general Change-Id: I7be5b7bcf1f3d9f980c748ba20793965cef957e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92493 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-28loplugin:sequenceloop (macOS)Stephan Bergmann1-1/+1
Change-Id: Ie1f5c925a058ef79df3f5183051c87fa8d342fb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95063 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-27Related: tdf#133385 set cursor in row on right clickCaolán McNamara1-0/+1
if the target row is not already selected Change-Id: I7cb39118f4a695546d8d2251390d6d3279e82bc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94947 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-26Fix loplugin:simplifypointertobool for libstdc++ std::shared_ptrStephan Bergmann3-7/+7
...where the get member function is defined on a std::__shared_ptr base class, so loplugin:simplifypointertobool used to miss those until now. (While e.g. using libc++ on macOS found those cases.) 366d08f2f6d4de922f6099c62bb81b49d89e0a68 "new loplugin:simplifypointertobool" was mistaken in breaking isSmartPointerType(const clang::Type* t) out of isSmartPointerType(const Expr* e); c874294ad9fb178df47c66875bfbdec466e39763 "Fix detection of std::unique_ptr/shared_ptr in loplugin:redundantpointerops" had introduced that indivisible two-step algorithm on purpose. The amount of additional hits (on Linux) apparently asked for turning loplugin:simplifypointertobool into a rewriting plugin. Which in turn showed that the naive adivce to just "drop the get()" is not sufficient in places that are not contextually converted to bool, as those places need to be wrapped in a bool(...) functional cast now. If the expression was already wrapped in parentheses, those could be reused as part of the functional cast, but implementing that showed that such cases are not yet found at all by the existing loplugin:simplifypointertobool. Lets leave that TODO for another commit. Besides the changes to compilerplugins/ itself, this change has been generated fully automatically with the rewriting plugin on Linux. Change-Id: I83107d6f634fc9ac232986f49044d7017df83e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94888 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-05-26make highlight of get_dest_row_at_pos optionalCaolán McNamara1-1/+1
Change-Id: I280e1a49e938f45402f373896669fd6f7e8a66fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94876 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-26tdf#133094 NotebookbarToolBox is not in the sidebarCaolán McNamara6-16/+22
though it is inheriting from SidebarToolBox and we're distinguish the sidebar case from the non-sidebar case wrt certain color toolbuttons Change-Id: Ieffe45adfab95d426bb36296ee3428b6bd3dbd3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94806 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-25[MS-OFFCRYPTO] convert oox implementation into UNO serviceVasily Melenchuk1-1/+2
To permit pluggable crypto services, abstract existing implementation behind an XPackageEncryption API. Previous code already had two halfway-polymorphic classes (agile and standard 2007 engine), so we're not adding much additional layers. As MS crypto always uses OLE storage to wrap content into one single file, current implementation passes all substorage names down into XPackageEncryption APi, so different downstream implementations (e.g. for MS RMS, or Azure AIP) are possible. Because OleStorage classes are internal to LibO core, access is provided via XInput/XOutput stream API function. Change-Id: Icc32a4e0ce215090c3b739f1dcaa0654b36b7f08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84436 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-05-25sfx2 UNO API: XModel2::setArgs() now also supports "EncryptionData"Vasily Melenchuk1-0/+5
XModel2::setArgs() only permits hand-picked set of media descriptor parameters. Add one more in preparation to API-based MS crypto rework. Change-Id: I179a1cfc2cdd7b04becba0d7dfe9740d920ae4ee Reviewed-on: https://gerrit.libreoffice.org/80432 Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Tested-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84434 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-05-22Resolves: tdf#133183 select style under mouse on right click context menuCaolán McNamara2-4/+30
Change-Id: I4317f6702b7a0e172d059fe83614aab94845b201 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94690 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22Resolves: tdf#133180 use full width of canvas for preview renderCaolán McNamara1-3/+4
Change-Id: I1fa3f0fd8505712155c72c25b67da1ab6d4753e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94660 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22move InterimItemWindow to vclCaolán McNamara4-5/+5
Change-Id: If0a4a14708810c44d087b51961f2ecb3fda4df23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94649 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-21drop some unnecessary includesCaolán McNamara1-3/+0
Change-Id: Idf507ea5a9790bf54ef98ed4f0cc89e2c01cc8eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94606 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-21use for-range on Sequence in sfx2..swNoel Grandin1-6/+6
Change-Id: I09806869f2fdbae61f4c5d5c9db6859202bb63b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94609 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-18Create weld::Builder implementation for JSDialogSzymon Kłos1-1/+6
and use for WordCountDialog on mobile Change-Id: I12c3455ff9b16c30918067f9282b72f49141a308 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94041 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94055 Tested-by: Jenkins
2020-05-18officecfg,unotools,cui: add ODF 1.2 Extended / ODF 1.3 versionsMichael Stahl1-1/+1
... to configuration and UI. The new default is ODF 1.3 Extended, which is now ODFVER_LATEST and stored as value "3" in configuration. Adapt a few places related to DocumentDigitalSignatures etc. to new default. Change-Id: I420da4f7787cc864c6bd88470d61b146b9399aa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93177 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-16loplugin:unusedmethodsNoel Grandin3-72/+0
Change-Id: I52187eccf6170f64d38c673a86dc80818813efa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94328 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-15LOK: sending status of paragraph outline buttonsPranam Lashkari1-1/+5
status of: OutlineRight, OutlineLeft, OutlineDown, OutlineUp Change-Id: I28dd805e1a620831c4092523969e1c4825b568f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94216 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-15comphelper,sfx2,dbaccess: add ODFVER_013_TEXT constantMichael Stahl2-4/+11
This is used for Version of package in API. Change-Id: I23d162c4dfff2f56c541a7c6c2e21c87ed7d8213 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93087 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-15use more try_emplaceNoel Grandin1-4/+2
specifically looking for the pattern if (map.find(...) == map.end() map[...] = value Change-Id: I99f20d73f6e71a10726c9d39d8644c2e51120091 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94151 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-14loplugin:unusedfieldsNoel Grandin2-5/+1
Change-Id: I0ec89b56b339f26bb236887c904e6b5d14ceecea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94136 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-13Fix translation domains in .ui filesGabor Kelemen4-4/+4
Found with bin/ui-checkdomain.sh Change-Id: I2a3ec2593b9ce0a19efced9020b95dff796e4702 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94153 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2020-05-12weld help browserCaolán McNamara10-1548/+1530
Change-Id: Ibd8dcc10c4403731953e2e46db4ae8f89ebc7e4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93216 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-12always use the LinkManager's persist as the known refererCaolán McNamara1-2/+6
Change-Id: Ibb1bd9138993adbd8391b524c0cd654ba523cad2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94006 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-11de-duplicate cut and paste functionCaolán McNamara2-41/+15
Change-Id: I9569a10562e50ab5660a5638c518680c58fc97dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93961 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-10new loplugin:simplifypointertoboolNoel Grandin4-5/+5
Change-Id: Iff68e8f379614a6ab6a6e0d1bad18e70bc76d76a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-10compact namespace in sfx2Noel Grandin25-51/+45
Change-Id: I70e1002fc09f5a8d0352cdb0c120fe5ed79cf3e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93874 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-10lok: set device form factor of the client on view creationMarco Cecchetti6-5/+28
This patch allows the lok core to know about the device form facor of the client requesting the creation of new view, immediately instead of a later time. When a new view is needed a "DeviceFormFactor" parameter is forwarded to lo_documentLoadWithOptions and doc_createViewWithOptions from the client. This parameter can have one of the following values: 'desktop', 'tablet','mobile' and it is used to set a global variable accessible by SfxLokHelper::setDeviceFormFactor and SfxLokHelper::getDeviceFormFactor. This global variable is retrived in the SfxViewShell constructor for setting SfxViewShell::maLOKDeviceFormFactor attribute. In SfxViewShell we have the following 3 methods: - bool isLOKDesktop() - bool isLOKTablet() - bool isLOKMobilePhone() which replace the following boolean functions: - comphelper::LibreOfficeKit::isTablet - comphelper::LibreOfficeKit::::isMobilePhone Change-Id: I9b36f354278df8c216fcb90f6a9da8256ec9c1e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93340 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-01 09:59:32 +0000